From: Arnon Warshavsky <arnon@qwilt.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
wenzhuo.lu@intel.com, declan.doherty@intel.com,
jerin.jacob@caviumnetworks.com,
Bruce Richardson <bruce.richardson@intel.com>,
ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [PATCH v3 01/13] crypto: replace rte_panic instances in crypto driver
Date: Mon, 16 Apr 2018 17:24:56 +0300 [thread overview]
Message-ID: <CAKy9EB3-UB1O38=Bq7YixwpjrNG+-_ah5bX-cwBMBKOB9zgTwg@mail.gmail.com> (raw)
In-Reply-To: <20180416114912.GB25243@hmswarspite.think-freely.org>
This function is only called from locations that return a -errno code, not
just
> -1.
>
> Neil
Hi Neil
Looking up the references I see that some of the places looking at this
return value from the probe function
simply return their own -1 , and some return different enums relevant for
their context.
As they all look at !=0 or < 0 , but not all propagate the value they got
I used an explicit -1.
Do you have a specific enum in mind I should replace it with?
/Arnon
next prev parent reply other threads:[~2018-04-16 14:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 18:30 [PATCH v3 00/13] eal: replace calls to rte_panic and refrain from new instances Arnon Warshavsky
2018-04-13 18:30 ` [PATCH v3 01/13] crypto: replace rte_panic instances in crypto driver Arnon Warshavsky
2018-04-16 11:49 ` Neil Horman
2018-04-16 14:24 ` Arnon Warshavsky [this message]
2018-04-13 18:30 ` [PATCH v3 02/13] bond: replace rte_panic instances in bonding driver Arnon Warshavsky
2018-04-13 18:30 ` [PATCH v3 03/13] e1000: replace rte_panic instances in e1000 driver Arnon Warshavsky
2018-04-16 15:34 ` Stephen Hemminger
2018-04-16 16:19 ` Arnon Warshavsky
2018-04-13 18:30 ` [PATCH v3 04/13] ixgbe: replace rte_panic instances in ixgbe driver Arnon Warshavsky
2018-04-13 18:30 ` [PATCH v3 05/13] eal: replace rte_panic instances in eventdev Arnon Warshavsky
2018-04-13 18:30 ` [PATCH v3 06/13] kni: replace rte_panic instances in kni Arnon Warshavsky
2018-04-13 18:30 ` [PATCH v3 07/13] eal: replace rte_panic instances in rte_malloc Arnon Warshavsky
2018-04-13 18:30 ` [PATCH v3 08/13] eal: replace rte_panic instances in hugepage_info Arnon Warshavsky
2018-04-16 11:30 ` Burakov, Anatoly
2018-04-16 14:45 ` Arnon Warshavsky
2018-04-13 18:30 ` [PATCH v3 09/13] eal: replace rte_panic instances in common_memzone Arnon Warshavsky
2018-04-13 18:30 ` [PATCH v3 10/13] eal: replace rte_panic instances in interrupts thread Arnon Warshavsky
2018-04-13 18:30 ` [PATCH v3 11/13] eal: replace rte_panic instances in ethdev Arnon Warshavsky
2018-04-13 18:30 ` [PATCH v3 12/13] eal: replace rte_panic instances in init sequence Arnon Warshavsky
2018-04-13 18:30 ` [PATCH v3 13/13] devtools: prevent new instances of rte_panic and rte_exit Arnon Warshavsky
2018-04-16 11:22 ` [PATCH v3 00/13] eal: replace calls to rte_panic and refrain from new instances Burakov, Anatoly
2018-04-16 13:43 ` Arnon Warshavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKy9EB3-UB1O38=Bq7YixwpjrNG+-_ah5bX-cwBMBKOB9zgTwg@mail.gmail.com' \
--to=arnon@qwilt.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nhorman@tuxdriver.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.