All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Shilovsky <piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: David Disseldorp <ddiss-l3A5Bk7waGM@public.gmane.org>,
	"linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: smb3 mount fix for Macs
Date: Thu, 4 May 2017 11:43:39 -0700	[thread overview]
Message-ID: <CAKywueR3XgeCHRu_a6CJ9gk33CveMjSLivkRXAjuwOZP4O4FSw@mail.gmail.com> (raw)
In-Reply-To: <CAH2r5mvt2MKaeMC7zJ+xX5jXpEMGWP6ja4F-BmwPq8q=TdNGOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

2017-05-04 3:30 GMT-07:00 Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
> On Thu, May 4, 2017 at 5:24 AM, David Disseldorp <ddiss-l3A5Bk7waGM@public.gmane.org> wrote:
>> On Wed, 3 May 2017 21:25:50 -0500, Steve French wrote:
>>
>>> Minor update and added cc:stable
>>>
>>> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=7db0a6efdc3e990cdfd4b24820d010e9eb7890ad
>>
>> The relaxed validate negotiate rsplen check looks okay, but I think the
>> reduced MaxOutputResponse change should probably be split out into a
>> separate commit, as it affects all other ioctls.
>
> That is a good thing in a way - because we don't want any ioctls to
> send more than maxbufsize until we can handle this.
>

I agree that we need to split the patch into two because it is
targeted to stable. SMB2_ioctl() and smb3_validate_negotiate() were
introduced in different times, so the single patch won't be applied
properly on some stable kernel versions.

--
Best regards,
Pavel Shilovsky

      parent reply	other threads:[~2017-05-04 18:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04  2:23 smb3 mount fix for Macs Steve French
     [not found] ` <CAH2r5mtm7mJn7V5qiP6Xz3PW-+d_j02idQcsZkgfS3Gqw4=92g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-04  2:25   ` Steve French
     [not found]     ` <CAH2r5mtrghs-cnnxDvwtSzz5orUxNU-xpwFxJ0GVCr2BCeDOWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-04 10:24       ` David Disseldorp
     [not found]         ` <20170504122447.03f54767-l3A5Bk7waGM@public.gmane.org>
2017-05-04 10:30           ` Steve French
     [not found]             ` <CAH2r5mvt2MKaeMC7zJ+xX5jXpEMGWP6ja4F-BmwPq8q=TdNGOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-04 18:43               ` Pavel Shilovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKywueR3XgeCHRu_a6CJ9gk33CveMjSLivkRXAjuwOZP4O4FSw@mail.gmail.com \
    --to=piastryyy-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=ddiss-l3A5Bk7waGM@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.