From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37319C282D8 for ; Fri, 1 Feb 2019 20:17:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01D4820844 for ; Fri, 1 Feb 2019 20:17:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TkbexwMs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728622AbfBAURf (ORCPT ); Fri, 1 Feb 2019 15:17:35 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:43145 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728326AbfBAURf (ORCPT ); Fri, 1 Feb 2019 15:17:35 -0500 Received: by mail-lj1-f193.google.com with SMTP id q2-v6so6845994lji.10 for ; Fri, 01 Feb 2019 12:17:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wQDGtS1oqMKjUsn03QZvGn8vEYqQPfx7L5QGCQRzAQ0=; b=TkbexwMsCSyh8/fJEMPQ0OHDxvQypy5Aju3/8+DeRQa/Yy2nNDuoLi1RpiuyRZan1I mJpNnc74MdBAgWfuxuxo/2DJJcgDbogn04l/MlnbCqmH+u1GuarA66RPIUWqndO75r4U e+Fnd14t0+kjkP5EW959H/KxFVJYEEMCHb5Tf2mvnlaXhRnRc+Y+Mrh5G/5+DaHZZsDI ooBT63Yp1Vf/GrPlEr7bI8n3FxWUA6aSv/2Id5pFr/7JedVdOhixRxmx+vY5KWBpGD7P pcjM1t0yfGteXOZwgO0cumGuIoVaNDsW8NrFsFagdQJN9XP4ny9rJmis76tg9Q299c7R akQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wQDGtS1oqMKjUsn03QZvGn8vEYqQPfx7L5QGCQRzAQ0=; b=nc7AU438zclkHqdwz9qlEylD+hw9LM6zpb06i/vCrwv4Y2FDcQyTTzGfDxSrbwxpEI uhJ24yTTXtWjEfxykHU9Ua4cw74N6jyJ8+NvJana5Xg62/M3ej6dY7mz96te7fXW767U hYtyO48m6v77t90Q5RGm0KYmT0xaUC12aNAz0n6bvvs5vQpJumqeUXb/IEWJi63k+I3H L2y5+kHw9lB70wGJAB1CefkBkhMWKagPfXx8JUXdz5Z/vdVVi30KyQWd4x8C8D68KWhO Y9Ckzu0TNESBQ0hMN7MC4cFhnI9WrNqancmaiVTbmrJN0ZSozq6AWVUKNGWSPdZN5Fun mzBA== X-Gm-Message-State: AJcUuke3lU6V3OCtS5JTmzabc4w7tPwsngidEmurIpPdJZagfypK60cH riMPMbo+B8HXsHMWo25YyYnMLcuqNpgDRLS2ZQ== X-Google-Smtp-Source: ALg8bN6NdIuZl3FtGF5G6Riy9irxF8iV6Nebgl1teJufm0a9SjbFpRrcNMDjm3OZB6bgR3By9OuPOHkmuxs825AMK3s= X-Received: by 2002:a2e:9107:: with SMTP id m7-v6mr33210636ljg.23.1549052253129; Fri, 01 Feb 2019 12:17:33 -0800 (PST) MIME-Version: 1.0 References: <1548893250-48583-1-git-send-email-pshilov@microsoft.com> <20190131071600.GB4500@kroah.com> <20190201141149.GU3973@sasha-vm> In-Reply-To: <20190201141149.GU3973@sasha-vm> From: Pavel Shilovsky Date: Fri, 1 Feb 2019 12:17:21 -0800 Message-ID: Subject: Re: [PATCH] cifs: Always resolve hostname before reconnecting To: Sasha Levin Cc: Greg KH , Stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org =D0=BF=D1=82, 1 =D1=84=D0=B5=D0=B2=D1=80. 2019 =D0=B3. =D0=B2 06:11, Sasha = Levin : > > On Thu, Jan 31, 2019 at 10:37:54AM -0800, Pavel Shilovsky wrote: > >=D1=81=D1=80, 30 =D1=8F=D0=BD=D0=B2. 2019 =D0=B3. =D0=B2 23:16, Greg KH = : > >> > >> On Wed, Jan 30, 2019 at 04:07:30PM -0800, Pavel Shilovsky wrote: > >> > Commit 28eb24ff75c5 ("cifs: Always resolve hostname before reconnect= ing"). > >> > > >> > In case a hostname resolves to a different IP address (e.g. long > >> > running mounts), make sure to resolve it every time prior to calling > >> > generic_ip_connect() in reconnect. > >> > > >> > This patch needs user space changes of cifs.upcall that set a timeou= t > >> > value for the "dns_resolver" key. > >> > > >> > Suggested-by: Steve French > >> > Signed-off-by: Paulo Alcantara > >> > Signed-off-by: Steve French > >> > Signed-off-by: Pavel Shilovsky > >> > --- > >> > fs/cifs/connect.c | 53 ++++++++++++++++++++++++++++++++++++++++++++= +++++++++ > >> > 1 file changed, 53 insertions(+) > >> > >> What stable kernel(s) is this to be applied to? > >>\ > > > >All stable kernels that are under active maintenance may have the fix > >if it applies clearly. Please let me know if it doesn't. > > So this wasn't actually tested against any of the stable kernels? Why > not? Microsoft has a solid testsuite for it. This was successfully tested on v4.4.y kernel. -- Best regards, Pavel Shilovsky