From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87027C47082 for ; Thu, 27 May 2021 02:00:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63EE361358 for ; Thu, 27 May 2021 02:00:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233387AbhE0CC2 (ORCPT ); Wed, 26 May 2021 22:02:28 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:47225 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229799AbhE0CCU (ORCPT ); Wed, 26 May 2021 22:02:20 -0400 Received: from mail-wm1-f71.google.com ([209.85.128.71]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lm5KI-00008x-Ud for linux-kernel@vger.kernel.org; Thu, 27 May 2021 02:00:46 +0000 Received: by mail-wm1-f71.google.com with SMTP id b67-20020a1ce4460000b029017517d833b9so1341973wmh.0 for ; Wed, 26 May 2021 19:00:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eO/Q7/DwdHgvkIjY5sWiF4+6czPdEPcOWJ8cjVak3Sg=; b=k/0hSS3LfpqJZvDyc5p6/kWG+v2wxkLL1mJQxvP07iaMw2pXJW09iD/+eDGTaFJ3Dm Smq8JnEttp3cQYyZ3LBIA4dfdhfrkLhVEvoEb/E39+A+hUxD5I5cOJd/mauS+df2K5mF sYNfBMgYIDdT0XTJPBM15Xr14smjA7rSeliKHfPQoId97yK7sh4L1j8BH64TEhiYDUzr vAiR39YU+w8b+yRtu5okBgyM4D1ZZjNS258GG07bW5iycpeUYTTEKzx2qcvNJ9/jUk0K ZK/ppLLy8y8FXAhXTLOOXBHnNTKjVctqNJ6/ir6VES+lvD8L/eCdARVuKJxUmtLhzrqH vqTQ== X-Gm-Message-State: AOAM532E1726JR47LulnTx8scOMef2ZubPVT/7tYne5dlfGFb0NxndEz p56Gl4ovLjXE+jPdwM690VcMtZxgMoiC2ukopuiD5MQwVxsBsnhjZxg8oAfQR6BM1VWiVtTDzyq 3pbMDgUojSZooQ2nHni04tuK5gLl8ASqgiYSMw4yNWpt9FJGtacFd5L5c6w== X-Received: by 2002:a05:600c:35c3:: with SMTP id r3mr1054043wmq.23.1622080846091; Wed, 26 May 2021 19:00:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEvsKjX5vb6v9LJQTnIbKsJVPCMP26VU/hVaoqYsv3G8T765p39uC6V4zYsYwNTnZ7ewtnItkx8x5xAUazLDc= X-Received: by 2002:a05:600c:35c3:: with SMTP id r3mr1054034wmq.23.1622080845788; Wed, 26 May 2021 19:00:45 -0700 (PDT) MIME-Version: 1.0 References: <20210519170357.58410-1-jeremy.szu@canonical.com> In-Reply-To: <20210519170357.58410-1-jeremy.szu@canonical.com> From: Jeremy Szu Date: Thu, 27 May 2021 10:00:34 +0800 Message-ID: Subject: Re: [PATCH 1/4] ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 To: tiwai@suse.com Cc: Jaroslav Kysela , Kailang Yang , Jian-Hong Pan , Hui Wang , Huacai Chen , PeiSen Hou , "moderated list:SOUND" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Takashi, Would you please help to review these quirks? Many thanks. On Thu, May 20, 2021 at 1:04 AM Jeremy Szu wrote: > > The HP EliteBook 855 G8 Notebook PC is using ALC285 codec which needs > ALC285_FIXUP_HP_MUTE_LED fixup to make it works. After applying the > fixup, the mute/micmute LEDs work good. > > Signed-off-by: Jeremy Szu > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 552e2cb73291..9d68f591c6bf 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -8291,6 +8291,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > + SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED), > SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), > SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC), > SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300), > -- > 2.31.1 > -- Sincerely, Jeremy Su From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF7F3C47082 for ; Thu, 27 May 2021 02:02:16 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27897613C1 for ; Thu, 27 May 2021 02:02:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27897613C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CF6CB1704; Thu, 27 May 2021 04:01:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CF6CB1704 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1622080932; bh=zZtbcaLYQh3e9AXPt6H86r3iJV5qIHyybnOkJo+pHRo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ikLRsaYHCLro9VKdcxJxJC70MbDEdxFM1DmNoDfhcyK/xgaX+Po7e/P6kEA3ZPxct mKA/+v5ZHezQSbOrz4nX/WXoI6xjunVdVLPagglK3UKnqUwNSoOXFl+FS/wOpGDwU8 J9j2LfjkhJvU4Om3rZROS9gl2q6rqSyHj8Ee4uRA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 69E1EF80116; Thu, 27 May 2021 04:01:22 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 453C2F8012E; Thu, 27 May 2021 04:01:18 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2D688F800EA for ; Thu, 27 May 2021 04:01:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2D688F800EA Received: from mail-wr1-f72.google.com ([209.85.221.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lm5KI-00008d-F5 for alsa-devel@alsa-project.org; Thu, 27 May 2021 02:00:46 +0000 Received: by mail-wr1-f72.google.com with SMTP id c13-20020a5d6ccd0000b029010ec741b84bso1114157wrc.23 for ; Wed, 26 May 2021 19:00:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eO/Q7/DwdHgvkIjY5sWiF4+6czPdEPcOWJ8cjVak3Sg=; b=DwXayyk7oRMd3tAMDFIM9Y4kJGI2uNoF/zus8OTq5U68LRAyEePxc6kIZH723fVbfi 9Yfmo48euPPJ3x2kg7cRWc7PtuyXlYFbbL6MlSMTsxHItfeHG/k3fcF+2OkQHAIva4KJ VYjJpzAcctdtQ0ksXGuB+jO0BqbnP65uwbFBGKalI3VdVmEWu/iLXMzpuk4GqXIylYRg I9NecxmYq+0mv0f21CoY8hVAXc1QBaN0Khwy1e1XuECSw+NozfttpA9ePq9ZZpQkekbi CodNHfjnBzx7Pe4NAexBl72xBuLqTXQr9kc/BnWK/vYAJSudut8ceihbmPwklZz1yark ArWA== X-Gm-Message-State: AOAM5303M6MeEvvf+XJNrMZqLUTeSv08KfxbZqZIyZL2AAFT0xFvwVl/ cb0mYsHbTyw2tU2vZxUsa4L8fLI7s5btKkHogESBtZPODloKHFJgGidtMeyb80XNrZz/MfO9gTS blf/koFmlE9h2zAYdF4BOCo4fD2RXfcU6/fBFuOps+lDQj4NluLbw+etI X-Received: by 2002:a05:600c:35c3:: with SMTP id r3mr1054045wmq.23.1622080846092; Wed, 26 May 2021 19:00:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEvsKjX5vb6v9LJQTnIbKsJVPCMP26VU/hVaoqYsv3G8T765p39uC6V4zYsYwNTnZ7ewtnItkx8x5xAUazLDc= X-Received: by 2002:a05:600c:35c3:: with SMTP id r3mr1054034wmq.23.1622080845788; Wed, 26 May 2021 19:00:45 -0700 (PDT) MIME-Version: 1.0 References: <20210519170357.58410-1-jeremy.szu@canonical.com> In-Reply-To: <20210519170357.58410-1-jeremy.szu@canonical.com> From: Jeremy Szu Date: Thu, 27 May 2021 10:00:34 +0800 Message-ID: Subject: Re: [PATCH 1/4] ALSA: hda/realtek: fix mute/micmute LEDs for HP 855 G8 To: tiwai@suse.com Content-Type: text/plain; charset="UTF-8" Cc: "moderated list:SOUND" , Kailang Yang , open list , Huacai Chen , Jian-Hong Pan , Hui Wang , PeiSen Hou X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Takashi, Would you please help to review these quirks? Many thanks. On Thu, May 20, 2021 at 1:04 AM Jeremy Szu wrote: > > The HP EliteBook 855 G8 Notebook PC is using ALC285 codec which needs > ALC285_FIXUP_HP_MUTE_LED fixup to make it works. After applying the > fixup, the mute/micmute LEDs work good. > > Signed-off-by: Jeremy Szu > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 552e2cb73291..9d68f591c6bf 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -8291,6 +8291,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > + SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED), > SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), > SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC), > SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300), > -- > 2.31.1 > -- Sincerely, Jeremy Su