From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755154AbbGVBi1 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jul 2015 21:38:27 -0400
Received: from mail-la0-f45.google.com ([209.85.215.45]:34286 "EHLO
	mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753982AbbGVBiZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jul 2015 21:38:25 -0400
MIME-Version: 1.0
In-Reply-To: <55AE0995.2010209@dev.mellanox.co.il>
References: <1437437534-17931-1-git-send-email-sbaugh@catern.com> <55AE0995.2010209@dev.mellanox.co.il>
From: Roland Dreier <roland@purestorage.com>
Date: Tue, 21 Jul 2015 18:38:04 -0700
Message-ID: <CAL1RGDWAVnwD0bwdFyaUNofjMC6MWREn4pK_3Qu6ZV1rXzL9-w@mail.gmail.com>
Subject: Re: [PATCH] target/iscsi: fix digest computation for chained SGs
To: Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Spencer Baugh <sbaugh@catern.com>,
        "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
        Sagi Grimberg <sagig@mellanox.com>, Christoph Hellwig <hch@lst.de>,
        Bart Van Assche <bart.vanassche@sandisk.com>,
        Andy Grover <agrover@redhat.com>,
        Christophe Vu-Brugier <cvubrugier@fastmail.fm>,
        "open list:TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
        "open list:TARGET SUBSYSTEM" <target-devel@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Joern Engel <joern@purestorage.com>,
        Alexei Potashnik <alexei@purestorage.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 21, 2015 at 1:57 AM, Sagi Grimberg <sagig@dev.mellanox.co.il> wrote:
> How were you able to get a chained SG list in the target code?

Local hack.  So this bug can't be hit in current mainline code, but
patch improves the code and removes a hidden booby-trap, so I think it
makes sense to apply.