From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: [PATCH libibverbs V3 2/3] Use neighbour lookup for RoCE UD QPs Eth L2 resolution Date: Fri, 9 May 2014 07:03:02 -0700 Message-ID: References: <20140508201549.GA32622@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20140508201549.GA32622-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Or Gerlitz , Or Gerlitz , linux-rdma , Matan Barak , Yishai Hadas , Doug Ledford , "Hefty, Sean" , Liran Liss List-Id: linux-rdma@vger.kernel.org On Thu, May 8, 2014 at 1:15 PM, Jason Gunthorpe wrote: > From now on I think every proposed API/ABI change should be in an > isolated patch from anything else, it should be accompanied by other > patches showing the implementation, and the ABI patch specifically > should earn a public Reviewed-By from at least two of people who > designed this monster: Sean, Liran and myself. > > Roland? That would be extremely helpful to me and I support that rule 100%. > .. and you should start by correcting the flow steering changes, they > are not up to the standard and haven't earned the above reviews. Do we have a way of fixing things without breaking ABI, or at least making the ABI break painless? - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html