From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51481C43603 for ; Mon, 9 Dec 2019 18:18:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B75C2080D for ; Mon, 9 Dec 2019 18:18:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XL8FnAMK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B75C2080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieNbm-0007qA-Ki for qemu-devel@archiver.kernel.org; Mon, 09 Dec 2019 13:18:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34286) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieNZv-0006BF-V3 for qemu-devel@nongnu.org; Mon, 09 Dec 2019 13:16:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieNZu-0006vz-Hx for qemu-devel@nongnu.org; Mon, 09 Dec 2019 13:16:15 -0500 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]:35156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieNZu-0006vQ-9f for qemu-devel@nongnu.org; Mon, 09 Dec 2019 13:16:14 -0500 Received: by mail-ot1-x341.google.com with SMTP id o9so13053790ote.2 for ; Mon, 09 Dec 2019 10:16:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CB1KjF3ZOT0dJgFx5/rOjrc7b02VK8tpDKAvB4NS60E=; b=XL8FnAMKMZwOwQm9O83ZMGUERbua4XP7KpF7b68IPgy4PpOcor39bmaEPr54JdXsXW eiuuWSKkacCjhcJ2eYKR5EqAhTmFEa4KMq28GwRq6k6ZNq8LsozGlSsULwGBzYr+nHhK UPOTE8N8GYg4BLosaTZxuUREb/G7Pl1DWYRHp6TOz+lnrgoYwZunSlLUtGsAIvIa9uTK SP+MaBOWlCdbf/7ZLRcbt/O5x0zLsg4LoFWpAJC34D2LTlgvRIPrZ/kmUfDm3UTf7Lup uQiXkNG2CVmC9Hyw2MLqenbTAUEJfPp+md/PZ5hF/vpRZ73HKHbANxO2Wb1DYoIPScAB KEtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CB1KjF3ZOT0dJgFx5/rOjrc7b02VK8tpDKAvB4NS60E=; b=J8Or8U6N/q2XztH/735mL7c/UVLC2nseuX4q2boRXs4oIWsd5F0TcFwVEvdppcoxZw 2Zl7ibMHLPLjYRSSbHVWXmTJfd4nbEbmjBwKLMVqoxUIMWaCYY8/Uek68jst3Mkiu/RE tO5DNixC/3aEAXXuQ9wpM5ucnWwZFl88Zod0slnmJo7mn7L51BogsGVXgWRoELoo1nTQ P45W65Yppt7X/LEYEDp7Nl9ltJtwYQzg1NtL5vRUqtQnlilqHTaAg06jHcuPXZ139NJ4 oNhQ6BHbGg5qs7DYy+bAOMyo1scUKuf6WVSVNABZvL43r1uWCa/p6RpzNq+j14Lk8+IQ klyg== X-Gm-Message-State: APjAAAXZRVlUDx9GFRucSdhy59IYENiXFrzNpSeIIy9LqTORClIacK8/ tmCTDDG6FBVU17fq5w63Z2aye3JgQ85nVrkJfL4= X-Google-Smtp-Source: APXvYqw2tu35+4zamET+3exp6Iq6vHplTOu+7ufm0JC4Dhn/QR5O5NEBVOCvqGiCze0F3dUJwWuRAjtmdmI6ppXzAFQ= X-Received: by 2002:a9d:7305:: with SMTP id e5mr21692006otk.64.1575915373490; Mon, 09 Dec 2019 10:16:13 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a9d:d21:0:0:0:0:0 with HTTP; Mon, 9 Dec 2019 10:16:13 -0800 (PST) In-Reply-To: <20191208183922.13757-18-mrolnik@gmail.com> References: <20191208183922.13757-1-mrolnik@gmail.com> <20191208183922.13757-18-mrolnik@gmail.com> From: Aleksandar Markovic Date: Mon, 9 Dec 2019 19:16:13 +0100 Message-ID: Subject: Re: [PATCH v38 17/22] target/avr: Register AVR support with the rest of QEMU To: Michael Rolnik Content-Type: multipart/alternative; boundary="00000000000008754d05994964d0" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "thuth@redhat.com" , "me@xcancerberox.com.ar" , "richard.henderson@linaro.org" , "qemu-devel@nongnu.org" , "dovgaluk@ispras.ru" , "imammedo@redhat.com" , "philmd@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000008754d05994964d0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sunday, December 8, 2019, Michael Rolnik wrote: > Add AVR related definitions into QEMU > > Signed-off-by: Michael Rolnik > Tested-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Aleksandar Markovic > --- > qapi/machine.json | 3 ++- > include/disas/dis-asm.h | 6 ++++++ > include/sysemu/arch_init.h | 1 + > arch_init.c | 2 ++ > 4 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/qapi/machine.json b/qapi/machine.json > index ca26779f1a..8c6df54921 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -21,11 +21,12 @@ > # is true even for "qemu-system-x86_64". > # > # ppcemb: dropped in 3.1 > +# avr: since 5.0 > # > # Since: 3.0 > ## > { 'enum' : 'SysEmuTarget', > - 'data' : [ 'aarch64', 'alpha', 'arm', 'cris', 'hppa', 'i386', 'lm32', > + 'data' : [ 'aarch64', 'alpha', 'arm', 'avr', 'cris', 'hppa', 'i386', > 'lm32', 'm68k', 'microblaze', 'microblazeel', 'mips', 'mips64', > 'mips64el', 'mipsel', 'moxie', 'nios2', 'or1k', 'ppc', > 'ppc64', 'riscv32', 'riscv64', 's390x', 'sh4', > diff --git a/include/disas/dis-asm.h b/include/disas/dis-asm.h > index e9c7dd8eb4..8bedce17ac 100644 > --- a/include/disas/dis-asm.h > +++ b/include/disas/dis-asm.h > @@ -211,6 +211,12 @@ enum bfd_architecture > #define bfd_mach_m32r 0 /* backwards compatibility */ > bfd_arch_mn10200, /* Matsushita MN10200 */ > bfd_arch_mn10300, /* Matsushita MN10300 */ > + bfd_arch_avr, /* Atmel AVR microcontrollers. */ > +#define bfd_mach_avr1 1 > +#define bfd_mach_avr2 2 > +#define bfd_mach_avr3 3 > +#define bfd_mach_avr4 4 > +#define bfd_mach_avr5 5 Incomplete list. I already explained why in reply to v37. > bfd_arch_cris, /* Axis CRIS */ > #define bfd_mach_cris_v0_v10 255 > #define bfd_mach_cris_v32 32 > diff --git a/include/sysemu/arch_init.h b/include/sysemu/arch_init.h > index 62c6fe4cf1..893df26ce2 100644 > --- a/include/sysemu/arch_init.h > +++ b/include/sysemu/arch_init.h > @@ -24,6 +24,7 @@ enum { > QEMU_ARCH_NIOS2 =3D (1 << 17), > QEMU_ARCH_HPPA =3D (1 << 18), > QEMU_ARCH_RISCV =3D (1 << 19), > + QEMU_ARCH_AVR =3D (1 << 20), > }; > > extern const uint32_t arch_type; > diff --git a/arch_init.c b/arch_init.c > index 705d0b94ad..6a741165b2 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -89,6 +89,8 @@ int graphic_depth =3D 32; > #define QEMU_ARCH QEMU_ARCH_UNICORE32 > #elif defined(TARGET_XTENSA) > #define QEMU_ARCH QEMU_ARCH_XTENSA > +#elif defined(TARGET_AVR) > +#define QEMU_ARCH QEMU_ARCH_AVR > #endif > > const uint32_t arch_type =3D QEMU_ARCH; > -- > 2.17.2 (Apple Git-113) > > --00000000000008754d05994964d0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sunday, December 8, 2019, Michael Rolnik <mrolnik@gmail.com> wrote:
Add AVR related definitions into QEMU

Signed-off-by: Michael Rolnik <mrol= nik@gmail.com>
Tested-by: Philippe Mathieu-Daud=C3=A9 <philmd@redhat.com>
Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
---
=C2=A0qapi/machine.json=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 3 ++-
=C2=A0include/disas/dis-asm.h=C2=A0 =C2=A0 | 6 ++++++
=C2=A0include/sysemu/arch_init.h | 1 +
=C2=A0arch_init.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | = 2 ++
=C2=A04 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/qapi/machine.json b/qapi/machine.json
index ca26779f1a..8c6df54921 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -21,11 +21,12 @@
=C2=A0#=C2=A0 =C2=A0 =C2=A0 =C2=A0 is true even for "qemu-system-x86_6= 4".
=C2=A0#
=C2=A0# ppcemb: dropped in 3.1
+# avr: since 5.0
=C2=A0#
=C2=A0# Since: 3.0
=C2=A0##
=C2=A0{ 'enum' : 'SysEmuTarget',
-=C2=A0 'data' : [ 'aarch64', 'alpha', 'arm'= ;, 'cris', 'hppa', 'i386', 'lm32',
+=C2=A0 'data' : [ 'aarch64', 'alpha', 'arm'= ;, 'avr', 'cris', 'hppa', 'i386', 'lm32= ',
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'm68k', 'micro= blaze', 'microblazeel', 'mips', 'mips64',
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'mips64el', 'm= ipsel', 'moxie', 'nios2', 'or1k', 'ppc'= ,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'ppc64', 'risc= v32', 'riscv64', 's390x', 'sh4',
diff --git a/include/disas/dis-asm.h b/include/disas/dis-asm.h
index e9c7dd8eb4..8bedce17ac 100644
--- a/include/disas/dis-asm.h
+++ b/include/disas/dis-asm.h
@@ -211,6 +211,12 @@ enum bfd_architecture
=C2=A0#define bfd_mach_m32r=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0=C2=A0 /* ba= ckwards compatibility */
=C2=A0 =C2=A0bfd_arch_mn10200,=C2=A0 =C2=A0 /* Matsushita MN10200 */
=C2=A0 =C2=A0bfd_arch_mn10300,=C2=A0 =C2=A0 /* Matsushita MN10300 */
+=C2=A0 bfd_arch_avr,=C2=A0 =C2=A0 =C2=A0 =C2=A0/* Atmel AVR microcontrolle= rs.=C2=A0 */
+#define bfd_mach_avr1=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1
+#define bfd_mach_avr2=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 2
+#define bfd_mach_avr3=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 3
+#define bfd_mach_avr4=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 4
+#define bfd_mach_avr5=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 5

Incomplete list. I already explained why in reply to v37.

=C2=A0
=C2=A0 =C2=A0bfd_arch_cris,=C2=A0 =C2=A0 =C2=A0 =C2=A0/* Axis CRIS */
=C2=A0#define bfd_mach_cris_v0_v10=C2=A0 =C2=A0255
=C2=A0#define bfd_mach_cris_v32=C2=A0 =C2=A0 =C2=A0 32
diff --git a/include/sysemu/arch_init.h b/include/sysemu/arch_init.h
index 62c6fe4cf1..893df26ce2 100644
--- a/include/sysemu/arch_init.h
+++ b/include/sysemu/arch_init.h
@@ -24,6 +24,7 @@ enum {
=C2=A0 =C2=A0 =C2=A0QEMU_ARCH_NIOS2 =3D (1 << 17),
=C2=A0 =C2=A0 =C2=A0QEMU_ARCH_HPPA =3D (1 << 18),
=C2=A0 =C2=A0 =C2=A0QEMU_ARCH_RISCV =3D (1 << 19),
+=C2=A0 =C2=A0 QEMU_ARCH_AVR =3D (1 << 20),
=C2=A0};

=C2=A0extern const uint32_t arch_type;
diff --git a/arch_init.c b/arch_init.c
index 705d0b94ad..6a741165b2 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -89,6 +89,8 @@ int graphic_depth =3D 32;
=C2=A0#define QEMU_ARCH QEMU_ARCH_UNICORE32
=C2=A0#elif defined(TARGET_XTENSA)
=C2=A0#define QEMU_ARCH QEMU_ARCH_XTENSA
+#elif defined(TARGET_AVR)
+#define QEMU_ARCH QEMU_ARCH_AVR
=C2=A0#endif

=C2=A0const uint32_t arch_type =3D QEMU_ARCH;
--
2.17.2 (Apple Git-113)

--00000000000008754d05994964d0--