From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E127C432C3 for ; Mon, 25 Nov 2019 14:47:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1508C2068F for ; Mon, 25 Nov 2019 14:47:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="enVEjOSv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1508C2068F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZFdt-0000cF-Sc for qemu-devel@archiver.kernel.org; Mon, 25 Nov 2019 09:47:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53750) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZFcT-00009o-It for qemu-devel@nongnu.org; Mon, 25 Nov 2019 09:45:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZFcQ-0001Nm-Bx for qemu-devel@nongnu.org; Mon, 25 Nov 2019 09:45:41 -0500 Received: from mail-oi1-x22a.google.com ([2607:f8b0:4864:20::22a]:38878) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZFcQ-0001Nc-64 for qemu-devel@nongnu.org; Mon, 25 Nov 2019 09:45:38 -0500 Received: by mail-oi1-x22a.google.com with SMTP id a14so13298709oid.5 for ; Mon, 25 Nov 2019 06:45:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=artqHuiH4PqGUk36wHCRDIwkCmyejoDw6Ie1Ey1mQto=; b=enVEjOSvXWy2rRF/KZPYMSP/DkP8W1oQIk0hnktI4SSMv0pLN7TGfW4ovNv1VOW8YR vG6Dxz6lq09EIwuYGoaelcfcoiIssgufSfJluBETYzhfPPVJ8lk/uRq7ER3gVCglQpKJ og0bvroQqrdeZ6GxmtGznKeT/HsodVS6wMrYsO+v7+rveiE2uziqsTkMELp5XiUiXz97 O2J+yjWxexR+I3vrglHFMg0Ni0r616ojwZt6HmFaWjHffp6Q4umU+lCIrTSOntdIlW8N Cm7/XmrElY9meYe8WXy8OfLftRX6P86u+GYD/5vE2PZ0LEUfrN7nXKIPCc8Y1cnIJmVa gMng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=artqHuiH4PqGUk36wHCRDIwkCmyejoDw6Ie1Ey1mQto=; b=MIF1nvjKXwfHubx6FoiXQRAZb99ZiD0/LhUrvbFZWfAjGcDiYe5xnHbpqPg3nrWGFQ VeCxGnVcnBh8Fr9zZdo96bJCOCGYSF0lT0Cx90dkksqLnnHjEXJWHwfl8mGrljqaB/m1 3v4Eopc6v76Y5zJe8T+um02cUm0MhU+TgR5eVYawc/6/CZQq+wdlsatSfhNs8q29T88s Z2T2+XCHC0YJiWhoo8nby7YvWjjnWJrhq1VBUNQlGIJlAbORqlXKyOHV2elsfpYYMMHj mNgXbTQqybFjPAHEUP38XAEMncT/BnDT1X1PxLgooki+NtcehKV9AOyWmrDuihgBPFSj 5yIA== X-Gm-Message-State: APjAAAUVBY4utcdWB2ttFqwg/M9IR5KQnredx+OZIsKHfuI+xwlvkNLY 7MNXcVXpN6WLDPPVaKbF5sniF4N8k8nuVezA7Ybqkg== X-Google-Smtp-Source: APXvYqy8UsdQlaUDfoBEQkW/J2B1M39kkMSy8vpC8J9HGwSV3oObRMQz9XTV146szQrSlDq/itQfsEcDfUxOcw9kCH4= X-Received: by 2002:aca:670b:: with SMTP id z11mr22146172oix.79.1574693136324; Mon, 25 Nov 2019 06:45:36 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:6830:1391:0:0:0:0 with HTTP; Mon, 25 Nov 2019 06:45:35 -0800 (PST) In-Reply-To: <20191125104103.28962-1-philmd@redhat.com> References: <20191125104103.28962-1-philmd@redhat.com> From: Aleksandar Markovic Date: Mon, 25 Nov 2019 15:45:35 +0100 Message-ID: Subject: Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="000000000000055d8e05982cd176" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::22a X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "libvir-list@redhat.com" , "qemu-devel@nongnu.org" , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Aleksandar Markovic , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000055d8e05982cd176 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Monday, November 25, 2019, Philippe Mathieu-Daud=C3=A9 wrote: > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > logical change was in 2005 (9542611a6). After we can count 164 > maintenance commits (QEMU API changes) with the exception of > 1 fix in 2015 (memory leak, commit 3ad9fd5a). > > Please don't start any deprecation process. This requires certain consultation within my company. Rest assured that everyone's opinion will be taken into account while doing consiltation. Aleksandar This machine was introduced as a proof of concept to run a MIPS > CPU. 2 years later, the Malta machine was add (commit 5856de80) > modeling a real platform. > > Note also this machine has no specification except 5 lines in > the header of this file: > > * emulates a simple machine with ISA-like bus. > * ISA IO space mapped to the 0x14000000 (PHYS) and > * ISA memory at the 0x10000000 (PHYS, 16Mb in size). > * All peripherial devices are attached to this "bus" with > * the standard PC ISA addresses. > > It is time to deprecate this obsolete machine. Users are > recommended to use the Malta board, which hardware is well > documented. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > qemu-deprecated.texi | 5 +++++ > hw/mips/mips_r4k.c | 1 + > MAINTAINERS | 2 +- > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > index 4b4b7425ac..05265b43c8 100644 > --- a/qemu-deprecated.texi > +++ b/qemu-deprecated.texi > @@ -266,6 +266,11 @@ The 'scsi-disk' device is deprecated. Users should > use 'scsi-hd' or > > @section System emulator machines > > +@subsection mips r4k platform (since 4.2) > + > +This machine type is very old and unmaintained. Users should use the > 'malta' > +machine type instead. > + > @subsection pc-0.12, pc-0.13, pc-0.14 and pc-0.15 (since 4.0) > > These machine types are very old and likely can not be used for live > migration > diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c > index 70024235ae..0b79ad26cb 100644 > --- a/hw/mips/mips_r4k.c > +++ b/hw/mips/mips_r4k.c > @@ -294,6 +294,7 @@ void mips_r4k_init(MachineState *machine) > > static void mips_machine_init(MachineClass *mc) > { > + mc->deprecation_reason =3D "use malta machine type instead"; > mc->desc =3D "mips r4k platform"; > mc->init =3D mips_r4k_init; > mc->block_default_type =3D IF_IDE; > diff --git a/MAINTAINERS b/MAINTAINERS > index 5e5e3e52d6..3b3a88e264 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -972,7 +972,7 @@ F: hw/net/mipsnet.c > R4000 > M: Aurelien Jarno > R: Aleksandar Rikalo > -S: Maintained > +S: Obsolete > F: hw/mips/mips_r4k.c > > Fulong 2E > -- > 2.21.0 > > > --000000000000055d8e05982cd176 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Monday, November 25, 2019, Philippe Mathieu-Daud=C3=A9 <philmd@redhat.com> wrote:
The r4k machine was introduced in 2005 (6af0bf9c7) = and its last
logical change was in 2005 (9542611a6). After we can count 164
maintenance commits (QEMU API changes) with the exception of
1 fix in 2015 (memory leak, commit 3ad9fd5a).


Please don't start any deprecation= process. This requires certain consultation within my company. Rest assure= d that everyone's opinion will be taken into account while doing consil= tation.

Aleksandar

This machine was introduced as a proof of concept to run a MIPS
CPU. 2 years later, the Malta machine was add (commit 5856de80)
modeling a real platform.

Note also this machine has no specification except 5 lines in
the header of this file:

=C2=A0* emulates a simple machine with ISA-like bus.
=C2=A0* ISA IO space mapped to the 0x14000000 (PHYS) and
=C2=A0* ISA memory at the 0x10000000 (PHYS, 16Mb in size).
=C2=A0* All peripherial devices are attached to this "bus" with =C2=A0* the standard PC ISA addresses.

It is time to deprecate this obsolete machine. Users are
recommended to use the Malta board, which hardware is well
documented.

Signed-off-by: Philippe Mathieu-Daud=C3=A9 <philmd@redhat.com>
---
=C2=A0qemu-deprecated.texi | 5 +++++
=C2=A0hw/mips/mips_r4k.c=C2=A0 =C2=A0| 1 +
=C2=A0MAINTAINERS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-
=C2=A03 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 4b4b7425ac..05265b43c8 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -266,6 +266,11 @@ The 'scsi-disk' device is deprecated. Users sh= ould use 'scsi-hd' or

=C2=A0@section System emulator machines

+@subsection mips r4k platform (since 4.2)
+
+This machine type is very old and unmaintained. Users should use the '= malta'
+machine type instead.
+
=C2=A0@subsection pc-0.12, pc-0.13, pc-0.14 and pc-0.15 (since 4.0)

=C2=A0These machine types are very old and likely can not be used for live = migration
diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c
index 70024235ae..0b79ad26cb 100644
--- a/hw/mips/mips_r4k.c
+++ b/hw/mips/mips_r4k.c
@@ -294,6 +294,7 @@ void mips_r4k_init(MachineState *machine)

=C2=A0static void mips_machine_init(MachineClass *mc)
=C2=A0{
+=C2=A0 =C2=A0 mc->deprecation_reason =3D "use malta machine type i= nstead";
=C2=A0 =C2=A0 =C2=A0mc->desc =3D "mips r4k platform";
=C2=A0 =C2=A0 =C2=A0mc->init =3D mips_r4k_init;
=C2=A0 =C2=A0 =C2=A0mc->block_default_type =3D IF_IDE;
diff --git a/MAINTAINERS b/MAINTAINERS
index 5e5e3e52d6..3b3a88e264 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -972,7 +972,7 @@ F: hw/net/mipsnet.c
=C2=A0R4000
=C2=A0M: Aurelien Jarno <aurelie= n@aurel32.net>
=C2=A0R: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
-S: Maintained
+S: Obsolete
=C2=A0F: hw/mips/mips_r4k.c

=C2=A0Fulong 2E
--
2.21.0


--000000000000055d8e05982cd176--