From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F61FC282DD for ; Fri, 10 Jan 2020 19:57:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C137A206ED for ; Fri, 10 Jan 2020 19:57:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h8+KDmP1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C137A206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iq0P3-0001Qh-TD for qemu-devel@archiver.kernel.org; Fri, 10 Jan 2020 14:57:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46349) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iq0OP-0000Zt-Bd for qemu-devel@nongnu.org; Fri, 10 Jan 2020 14:56:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iq0OO-0006Vk-8g for qemu-devel@nongnu.org; Fri, 10 Jan 2020 14:56:25 -0500 Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]:42785) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iq0OO-0006Rt-25 for qemu-devel@nongnu.org; Fri, 10 Jan 2020 14:56:24 -0500 Received: by mail-ot1-x32d.google.com with SMTP id 66so3105966otd.9 for ; Fri, 10 Jan 2020 11:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a+E//MlcJw7X7i6kiN0VA1+qmTJPw7LyaSR1hwCzQQw=; b=h8+KDmP1F6EUZiQYF8wJtE3+MUF3gQLn5coMPlxbqk4//u42htUtrG4GSXQqdrzdUd lbUjLvCLXZB0roX42sY3a8mPDngRYO+rTZXtnlCH0eoUa8iYfxoG9wn28rdm0O1s+GSa uqROzVDVBImOAVPMUDj9RqhwiFjy0BnO9ZP91n8LpZX0xJXYNEaBsu2yv0lDrmzNYPAp hq+8AfPt9G6FWs1oSiOxS8X5acU9B01iC+lIDCBwCeLcPtTSyV7+xzx/4xCwKkOYU7ZN tclvXUMC4hNyEvUNm3st3PwSGPU1KOsDbXjX4+Lsg28DytK0dEm7N9Gl0vLyyAvJFoh5 yGRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a+E//MlcJw7X7i6kiN0VA1+qmTJPw7LyaSR1hwCzQQw=; b=PR3tZlkJiSryygY6kFhnL5HMMBt6T/G4Yo4IEItbrTfmeRmpqsRUTBHG7mHfdV+OE7 /1IAAG9GECmDP4REjKTJg4d/he3sxoGBRTF0TmOYRjh7fv4iVTDCpjHPvNqXvVh2oLXX a+Z7NRMKGR6YdICQFBhaMTbvnJc/Fb+Iy+EMPqWbEnPNOoxeu4bvtKDq3uCXXlygW6iT lhFkd+SiI8e+LTolGVfSUe/C4r0K2p2DJP8cHraARH8+8skdlhE8rBT2zefN7e29shvW KX25QXyuVAu2NikV0bg3DhggMWmbfcREkdgvYsW2Pe4UVbLECx57GVUIOmuFQ1HTttVF vjQw== X-Gm-Message-State: APjAAAWwk0jORNhfUR6tERbVPK2Sz5XegApsgZ5qh0lhRKWOV3D8z9N/ emUzc2Q/OymcVdG1woRzFLvIGX3dHaEGT87JfGk= X-Google-Smtp-Source: APXvYqyIFyVIMf+RuS0fsMqMcwRa/NBpPdpscwIg1yGEFG5YBP5QVBasBq4XJVz07iRY0Fvd9EUIk/8QN0V1u3P+fXA= X-Received: by 2002:a9d:7305:: with SMTP id e5mr3814333otk.64.1578686183433; Fri, 10 Jan 2020 11:56:23 -0800 (PST) MIME-Version: 1.0 References: <20190319144013.26584-1-pbonzini@redhat.com> <87imwe847x.fsf_-_@dusky.pond.sub.org> <9b92b3c4-c5d5-9a51-7b96-50dcf113ee5a@redhat.com> <20200106064526.zh6rt4wbibfjrscu@sirius.home.kraxel.org> In-Reply-To: From: Aleksandar Markovic Date: Fri, 10 Jan 2020 20:56:00 +0100 Message-ID: Subject: Re: [Qemu-devel] What should a virtual board emulate? To: Gerd Hoffmann Content-Type: multipart/alternative; boundary="0000000000002ceac2059bce857c" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32d X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Markus Armbruster , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , qemu-devel@nongnu.org, Aleksandar Markovic , Paolo Bonzini , Aleksandar Rikalo , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000002ceac2059bce857c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 8:42 PM Pet, 10.01.2020. Aleksandar Markovic =D1=98=D0=B5 =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BE/=D0=BB=D0=B0: > > 7:45 AM Pon, 06.01.2020. Gerd Hoffmann =D1=98=D0=B5 = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BE/=D0=BB=D0=B0: > > > > Hi, > > > > > 78c37d88f1b8b0b3ebcc632c458f0c3779fe2951 is the first bad commit > > > commit 78c37d88f1b8b0b3ebcc632c458f0c3779fe2951 > > > Author: Paolo Bonzini > > > Date: Tue Mar 19 15:37:19 2019 +0100 > > > > > > mips-fulong2e: obey -vga none > > > > > > Do not create an ATI VGA if "-vga none" was passed on the command line. > > > > > 1/ the Radeon chip is soldered on the motherboard, > > > > > > 2/ the default BIOS expects the Radeon chip to be > > > unconditionally present, > > > > > > I insist this patch is incorrect for the particular case of the Fuloong2e > > > board. I plan to revert it when I post the test. > > > > Yep. IMHO devices which you can't unplug on the physical board should > > be present even with "qemu -nodefaults". > > > > I have to agree with Philippe's approach. That is not to say that Zoltan's efforts are not appreciated. I meant to say also Paolo's. But, I didn't mean to fingerpoint. It is quite normal that from time to time, a well-intended change may actually produce unexpected breaking. All is well, no bad feelings at all. Yours, Aleksandar Just that the patch in question that broke Foolong scenario didn't fit quite well, however some other its reincarnation may have better destiny. > > Sincerely, > Aleksandar > > > cheers, > > Gerd > > > > --0000000000002ceac2059bce857c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

8:42 PM Pet, 10.01.2020. Aleksandar Markovic <aleksandar.m.mail@gmail.com> =D1= =98=D0=B5 =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BE/=D0=BB=D0=B0:
>
> 7:45 AM Pon, 06.01.2020. Gerd Hoffmann <kraxel@redhat.com> =D1=98=D0=B5 =D0=BD=D0=B0=D0=BF=D0=B8= =D1=81=D0=B0=D0=BE/=D0=BB=D0=B0:
> >
> > =C2=A0 Hi,
> >
> > > 78c37d88f1b8b0b3ebcc632c458f0c3779fe2951 is the first bad co= mmit
> > > commit 78c37d88f1b8b0b3ebcc632c458f0c3779fe2951
> > > Author: Paolo Bonzini <pbonzini@redhat.com>
> > > Date:=C2=A0 =C2=A0Tue Mar 19 15:37:19 2019 +0100
> > >
> > >=C2=A0 =C2=A0 =C2=A0mips-fulong2e: obey -vga none
> > >
> > >=C2=A0 =C2=A0 =C2=A0Do not create an ATI VGA if "-vga no= ne" was passed on the command line.
> >
> > > 1/ the Radeon chip is soldered on the motherboard,
> > >
> > > 2/ the default BIOS expects the Radeon chip to be
> > >=C2=A0 =C2=A0 unconditionally present,
> > >
> > > I insist this patch is incorrect for the particular case of = the Fuloong2e
> > > board. I plan to revert it when I post the test.
> >
> > Yep.=C2=A0 IMHO devices which you can't unplug on the physica= l board should
> > be present even with "qemu -nodefaults".
> >
>
> I have to agree with Philippe's approach. That is not to say that = Zoltan's efforts are not appreciated.

I meant to say also Paolo's. But, I didn't mean to f= ingerpoint. It is quite normal that from time to time, a well-intended chan= ge may actually produce unexpected breaking. All is well, no bad feelings a= t all.

Yours,
Aleksandar

Just that the patch in question that broke Foolong scenario= didn't fit quite well, however some other its reincarnation may have b= etter destiny.
>
> Sincerely,
> Aleksandar
>
> > cheers,
> > =C2=A0 Gerd
> >
> >

--0000000000002ceac2059bce857c--