Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

[Aleksandar Markovic <aleksandar.m.mail@gmail.com>]

On May 29, 2019 5:09 PM, "Markus Armbruster" <armbru@redhat.com> wrote:
>
> When scripts/get_maintainer.pl reports something like
>
>     John Doe <jdoe@example.org> (maintainer:Overall)
>
> the user is left to wonder *which* of our three "Overall" sections
> applies.  We have three, one each under "Guest CPU cores (TCG)",
> "Guest CPU Cores (KVM)", and "Overall usermode emulation".
>
> Rename sections under
>
> * "Guest CPU cores (TCG)" from "FOO" to "FOO CPU cores (TCG)"
>
> * "Guest CPU Cores (KVM)" from "FOO" to "FOO CPU cores (KVM)"
>
> * "Guest CPU Cores (Xen)" from "FOO" to "FOO CPU cores (Xen)"
>

In its essence definitely not a bad idea, but I must admit I tend to agree
with Philippe the new titles sound confusing, odd, artificial. Perhaps the
better alternative could be:

“FOO TCG guest”
“FOO KVM guest”
“FOO Xen guest”

> * "Architecture support" from "FOO" to "FOO general architecture
>   support"
>

Here we have a kind of strange situation with S390 architecture - it is the
only one present in this way in MAINTAINERS. Othrr than that, your new
wording looks fine to me.

> * "Tiny Code Generator (TCG)" from "FOO target" to "FOO TCG target"
>

I think this one you got it right.

Yours,
Aleksandar

>
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  MAINTAINERS | 78 ++++++++++++++++++++++++++---------------------------
>  1 file changed, 39 insertions(+), 39 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index edc260e503..196282d165 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -83,7 +83,7 @@ T: git https://github.com/vivier/qemu.git
trivial-patches
>
>  Architecture support
>  --------------------
> -S390
> +S390 general architecture support
>  M: Cornelia Huck <cohuck@redhat.com>
>  S: Supported
>  F: default-configs/s390x-softmmu.mak
> @@ -108,7 +108,7 @@ L: qemu-s390x@nongnu.org
>
>  Guest CPU cores (TCG):
>  ----------------------
> -Overall
> +Overall CPU cores (TCG)
>  M: Richard Henderson <rth@twiddle.net>
>  R: Paolo Bonzini <pbonzini@redhat.com>
>  S: Maintained
> @@ -133,14 +133,14 @@ F: fpu/
>  F: include/fpu/
>  F: tests/fp/
>
> -Alpha
> +Alpha CPU cores (TCG)
>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: target/alpha/
>  F: tests/tcg/alpha/
>  F: disas/alpha.c
>
> -ARM
> +ARM CPU cores (TCG)
>  M: Peter Maydell <peter.maydell@linaro.org>
>  L: qemu-arm@nongnu.org
>  S: Maintained
> @@ -161,7 +161,7 @@ S: Maintained
>  F: hw/arm/smmu*
>  F: include/hw/arm/smmu*
>
> -CRIS
> +CRIS CPU cores (TCG)
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  S: Maintained
>  F: target/cris/
> @@ -170,14 +170,14 @@ F: include/hw/cris/
>  F: tests/tcg/cris/
>  F: disas/cris.c
>
> -HPPA (PA-RISC)
> +HPPA (PA-RISC) CPU cores (TCG)
>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: target/hppa/
>  F: hw/hppa/
>  F: disas/hppa.c
>
> -LM32
> +LM32 CPU cores (TCG)
>  M: Michael Walle <michael@walle.cc>
>  S: Maintained
>  F: target/lm32/
> @@ -190,20 +190,20 @@ F: include/hw/char/lm32_juart.h
>  F: include/hw/lm32/
>  F: tests/tcg/lm32/
>
> -M68K
> +M68K CPU cores (TCG)
>  M: Laurent Vivier <laurent@vivier.eu>
>  S: Maintained
>  F: target/m68k/
>  F: disas/m68k.c
>
> -MicroBlaze
> +MicroBlaze CPU cores (TCG)
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  S: Maintained
>  F: target/microblaze/
>  F: hw/microblaze/
>  F: disas/microblaze.c
>
> -MIPS
> +MIPS CPU cores (TCG)
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  M: Aleksandar Markovic <amarkovic@wavecomp.com>
>  R: Aleksandar Rikalo <arikalo@wavecomp.com>
> @@ -224,7 +224,7 @@ F: include/hw/timer/mips_gictimer.h
>  F: tests/tcg/mips/
>  K: ^Subject:.*(?i)mips
>
> -Moxie
> +Moxie CPU cores (TCG)
>  M: Anthony Green <green@moxielogic.com>
>  S: Maintained
>  F: target/moxie/
> @@ -232,7 +232,7 @@ F: disas/moxie.c
>  F: hw/moxie/
>  F: default-configs/moxie-softmmu.mak
>
> -NiosII
> +NiosII CPU cores (TCG)
>  M: Chris Wulff <crwulff@gmail.com>
>  M: Marek Vasut <marex@denx.de>
>  S: Maintained
> @@ -242,14 +242,14 @@ F: hw/intc/nios2_iic.c
>  F: disas/nios2.c
>  F: default-configs/nios2-softmmu.mak
>
> -OpenRISC
> +OpenRISC CPU cores (TCG)
>  M: Stafford Horne <shorne@gmail.com>
>  S: Odd Fixes
>  F: target/openrisc/
>  F: hw/openrisc/
>  F: tests/tcg/openrisc/
>
> -PowerPC
> +PowerPC CPU cores (TCG)
>  M: David Gibson <david@gibson.dropbear.id.au>
>  L: qemu-ppc@nongnu.org
>  S: Maintained
> @@ -258,7 +258,7 @@ F: hw/ppc/
>  F: include/hw/ppc/
>  F: disas/ppc.c
>
> -RISC-V
> +RISC-V CPU cores (TCG)
>  M: Palmer Dabbelt <palmer@sifive.com>
>  M: Alistair Francis <Alistair.Francis@wdc.com>
>  M: Sagar Karandikar <sagark@eecs.berkeley.edu>
> @@ -271,7 +271,7 @@ F: include/hw/riscv/
>  F: linux-user/host/riscv32/
>  F: linux-user/host/riscv64/
>
> -S390
> +S390 CPU cores (TCG)
>  M: Richard Henderson <rth@twiddle.net>
>  M: David Hildenbrand <david@redhat.com>
>  S: Maintained
> @@ -281,7 +281,7 @@ F: disas/s390.c
>  F: tests/tcg/s390x/
>  L: qemu-s390x@nongnu.org
>
> -SH4
> +SH4 CPU cores (TCG)
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  S: Odd Fixes
>  F: target/sh4/
> @@ -289,7 +289,7 @@ F: hw/sh4/
>  F: disas/sh4.c
>  F: include/hw/sh4/
>
> -SPARC
> +SPARC CPU cores (TCG)
>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>  M: Artyom Tarasenko <atar4qemu@gmail.com>
>  S: Maintained
> @@ -299,14 +299,14 @@ F: hw/sparc64/
>  F: include/hw/sparc/sparc64.h
>  F: disas/sparc.c
>
> -UniCore32
> +UniCore32 CPU cores (TCG)
>  M: Guan Xuetao <gxt@mprc.pku.edu.cn>
>  S: Maintained
>  F: target/unicore32/
>  F: hw/unicore32/
>  F: include/hw/unicore32/
>
> -X86
> +X86 CPU cores (TCG)
>  M: Paolo Bonzini <pbonzini@redhat.com>
>  M: Richard Henderson <rth@twiddle.net>
>  M: Eduardo Habkost <ehabkost@redhat.com>
> @@ -319,7 +319,7 @@ F: disas/i386.c
>  F: docs/qemu-cpu-models.texi
>  T: git https://github.com/ehabkost/qemu.git x86-next
>
> -Xtensa
> +Xtensa CPU cores (TCG)
>  M: Max Filippov <jcmvbkbc@gmail.com>
>  W: http://wiki.osll.ru/doku.php?id=etc:users:jcmvbkbc:qemu-target-xtensa
>  S: Maintained
> @@ -330,7 +330,7 @@ F: disas/xtensa.c
>  F: include/hw/xtensa/xtensa-isa.h
>  F: default-configs/xtensa*.mak
>
> -TriCore
> +TriCore CPU cores (TCG)
>  M: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>  S: Maintained
>  F: target/tricore/
> @@ -345,7 +345,7 @@ F: tests/tcg/multiarch/
>  Guest CPU Cores (KVM):
>  ----------------------
>
> -Overall
> +Overall CPU cores (KVM)
>  M: Paolo Bonzini <pbonzini@redhat.com>
>  L: kvm@vger.kernel.org
>  S: Supported
> @@ -356,24 +356,24 @@ F: include/hw/kvm/
>  F: include/sysemu/kvm*.h
>  F: scripts/kvm/kvm_flightrecorder
>
> -ARM
> +ARM CPU cores (KVM)
>  M: Peter Maydell <peter.maydell@linaro.org>
>  L: qemu-arm@nongnu.org
>  S: Maintained
>  F: target/arm/kvm.c
>
> -MIPS
> +MIPS CPU cores (KVM)
>  M: James Hogan <jhogan@kernel.org>
>  R: Aleksandar Rikalo <arikalo@wavecomp.com>
>  S: Maintained
>  F: target/mips/kvm.c
>
> -PPC
> +PPC CPU cores (KVM)
>  M: David Gibson <david@gibson.dropbear.id.au>
>  S: Maintained
>  F: target/ppc/kvm.c
>
> -S390
> +S390 CPU cores (KVM)
>  M: Halil Pasic <pasic@linux.ibm.com>
>  M: Cornelia Huck <cohuck@redhat.com>
>  M: Christian Borntraeger <borntraeger@de.ibm.com>
> @@ -392,7 +392,7 @@ T: git https://github.com/cohuck/qemu.git s390-next
>  T: git https://github.com/borntraeger/qemu.git s390-next
>  L: qemu-s390x@nongnu.org
>
> -X86
> +X86 CPU cores (KVM)
>  M: Paolo Bonzini <pbonzini@redhat.com>
>  M: Marcelo Tosatti <mtosatti@redhat.com>
>  L: kvm@vger.kernel.org
> @@ -403,7 +403,7 @@ F: scripts/kvm/vmxcap
>  Guest CPU Cores (Xen):
>  ----------------------
>
> -X86
> +X86 CPU cores (Xen)
>  M: Stefano Stabellini <sstabellini@kernel.org>
>  M: Anthony Perard <anthony.perard@citrix.com>
>  M: Paul Durrant <paul.durrant@citrix.com>
> @@ -2256,7 +2256,7 @@ F: tests/uefi-test-tools/
>
>  Usermode Emulation
>  ------------------
> -Overall
> +Overall usermode emulation
>  M: Riku Voipio <riku.voipio@iki.fi>
>  S: Maintained
>  F: thunk.c
> @@ -2282,7 +2282,7 @@ M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: tcg/
>
> -AArch64 target
> +AArch64 TCG target
>  M: Claudio Fontana <claudio.fontana@huawei.com>
>  M: Claudio Fontana <claudio.fontana@gmail.com>
>  S: Maintained
> @@ -2291,33 +2291,33 @@ F: tcg/aarch64/
>  F: disas/arm-a64.cc
>  F: disas/libvixl/
>
> -ARM target
> +ARM TCG target
>  M: Andrzej Zaborowski <balrogg@gmail.com>
>  S: Maintained
>  L: qemu-arm@nongnu.org
>  F: tcg/arm/
>  F: disas/arm.c
>
> -i386 target
> +i386 TCG target
>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: tcg/i386/
>  F: disas/i386.c
>
> -MIPS target
> +MIPS TCG target
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  R: Aleksandar Rikalo <arikalo@wavecomp.com>
>  S: Maintained
>  F: tcg/mips/
>  F: disas/mips.c
>
> -PPC
> +PPC TCG target
>  M: Richard Henderson <rth@twiddle.net>
>  S: Odd Fixes
>  F: tcg/ppc/
>  F: disas/ppc.c
>
> -RISC-V
> +RISC-V TCG target
>  M: Palmer Dabbelt <palmer@sifive.com>
>  M: Alistair Francis <Alistair.Francis@wdc.com>
>  L: qemu-riscv@nongnu.org
> @@ -2325,19 +2325,19 @@ S: Maintained
>  F: tcg/riscv/
>  F: disas/riscv.c
>
> -S390 target
> +S390 TCG target
>  M: Richard Henderson <rth@twiddle.net>
>  S: Maintained
>  F: tcg/s390/
>  F: disas/s390.c
>  L: qemu-s390x@nongnu.org
>
> -SPARC target
> +SPARC TCG target
>  S: Odd Fixes
>  F: tcg/sparc/
>  F: disas/sparc.c
>
> -TCI target
> +TCI TCG target
>  M: Stefan Weil <sw@weilnetz.de>
>  S: Maintained
>  F: tcg/tci/
> --
> 2.17.2
>
>