From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Bresticker Subject: Re: [PATCH 4/4] ARM: tegra: fix Venice2 VQMMC regulators Date: Wed, 16 Apr 2014 13:24:25 -0700 Message-ID: References: <1397526163-20126-1-git-send-email-abrestic@chromium.org> <1397526163-20126-5-git-send-email-abrestic@chromium.org> <534EAD91.90704@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <534EAD91.90704-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Thierry Reding , Chris Ball , Ulf Hansson , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Wed, Apr 16, 2014 at 9:19 AM, Stephen Warren wrote: > On 04/15/2014 06:29 PM, Andrew Bresticker wrote: >>> sdhci@0,700b0600 { >>> status = "okay"; >>> bus-width = <8>; >>> + vqmmc-supply = <&vddio_1v8>; >> >> It turns out this bit isn't needed as the initialization failures are >> instead due to +3V3_RUN toggling, which Stephen has fixed: >> http://patchwork.ozlabs.org/patch/339386/ > > Indeed, if I apply patches 1, 2, and 4 from this series, revert the hunk > above, apply my Venice2 regulator patch, and finally apply your AS3722 > regulator GPIO patch, then everything works fine for me:-) Great, I'll fix up and resend without patch 3 as it looks like that will need some more work. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756204AbaDPUYa (ORCPT ); Wed, 16 Apr 2014 16:24:30 -0400 Received: from mail-ve0-f174.google.com ([209.85.128.174]:39375 "EHLO mail-ve0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753917AbaDPUY0 (ORCPT ); Wed, 16 Apr 2014 16:24:26 -0400 MIME-Version: 1.0 In-Reply-To: <534EAD91.90704@wwwdotorg.org> References: <1397526163-20126-1-git-send-email-abrestic@chromium.org> <1397526163-20126-5-git-send-email-abrestic@chromium.org> <534EAD91.90704@wwwdotorg.org> Date: Wed, 16 Apr 2014 13:24:25 -0700 X-Google-Sender-Auth: akJMw8qJ12puDj0SfdoZWzaRzCQ Message-ID: Subject: Re: [PATCH 4/4] ARM: tegra: fix Venice2 VQMMC regulators From: Andrew Bresticker To: Stephen Warren Cc: Thierry Reding , Chris Ball , Ulf Hansson , "linux-mmc@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 16, 2014 at 9:19 AM, Stephen Warren wrote: > On 04/15/2014 06:29 PM, Andrew Bresticker wrote: >>> sdhci@0,700b0600 { >>> status = "okay"; >>> bus-width = <8>; >>> + vqmmc-supply = <&vddio_1v8>; >> >> It turns out this bit isn't needed as the initialization failures are >> instead due to +3V3_RUN toggling, which Stephen has fixed: >> http://patchwork.ozlabs.org/patch/339386/ > > Indeed, if I apply patches 1, 2, and 4 from this series, revert the hunk > above, apply my Venice2 regulator patch, and finally apply your AS3722 > regulator GPIO patch, then everything works fine for me:-) Great, I'll fix up and resend without patch 3 as it looks like that will need some more work. From mboxrd@z Thu Jan 1 00:00:00 1970 From: abrestic@chromium.org (Andrew Bresticker) Date: Wed, 16 Apr 2014 13:24:25 -0700 Subject: [PATCH 4/4] ARM: tegra: fix Venice2 VQMMC regulators In-Reply-To: <534EAD91.90704@wwwdotorg.org> References: <1397526163-20126-1-git-send-email-abrestic@chromium.org> <1397526163-20126-5-git-send-email-abrestic@chromium.org> <534EAD91.90704@wwwdotorg.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Apr 16, 2014 at 9:19 AM, Stephen Warren wrote: > On 04/15/2014 06:29 PM, Andrew Bresticker wrote: >>> sdhci at 0,700b0600 { >>> status = "okay"; >>> bus-width = <8>; >>> + vqmmc-supply = <&vddio_1v8>; >> >> It turns out this bit isn't needed as the initialization failures are >> instead due to +3V3_RUN toggling, which Stephen has fixed: >> http://patchwork.ozlabs.org/patch/339386/ > > Indeed, if I apply patches 1, 2, and 4 from this series, revert the hunk > above, apply my Venice2 regulator patch, and finally apply your AS3722 > regulator GPIO patch, then everything works fine for me:-) Great, I'll fix up and resend without patch 3 as it looks like that will need some more work.