From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D68DC433F5 for ; Wed, 8 Dec 2021 17:19:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 269FA804C8; Wed, 8 Dec 2021 18:19:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SfwWCRrm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1EAEE801E7; Wed, 8 Dec 2021 18:19:12 +0100 (CET) Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BC976801E7 for ; Wed, 8 Dec 2021 18:19:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=javad321javad@gmail.com Received: by mail-il1-x131.google.com with SMTP id j7so2777004ilk.13 for ; Wed, 08 Dec 2021 09:19:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LhM1tTzn/EQqKlyMSm3nwHTaDFdTu7ajI18UpXKTEwM=; b=SfwWCRrm4Mo0bL6Cd1zBVHT5dhvDcuE0OxBUSOb/n22nKwSNO+wyPitHPepkWhLDik AZuT6ZDPoXSgs6Z6L+8xCqdl7CukDsTH086j/DexaV4pn3ryf1ZHuseQcMRvHIYta+6P uyzY8vu2paJQoGdQgqWEcVB87l7Vg2why+ufYMAhmz4AW/u4/Ua6BEbrFTaFtztcWgsn PPDBuboTTeZnLezY18R6qQyYJZ8kM3mMxUxVL+U0fuJ/vOA7oJfZ/UJ9PWabmRX4T3/K MvMlxWUP4sqyUYYfgXc720SJDyYSeumEQB0SKsLJU3p3RDdY5kudvg/R37930DaQIBFp hxOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LhM1tTzn/EQqKlyMSm3nwHTaDFdTu7ajI18UpXKTEwM=; b=a7yXlBxNiQ76SQ0uskOT5DMWZmeoQCrJgDG8/qcGGNYLVqB6sLGzKk6KBIDxEE9q6o oGC9I3PHAALYVIYIA99V0VPRWBz8V/BjPRwMy9SDlMzPhKCNqFIK55LsqX4BD9SNtuZO BxRydrMr8cuXCZIp+yAlrDnE8LucfWYVjOLUH5iatc5k/IoTVUf5vbttZesyKKYUf657 oz4ZDHGZng8NL+M9eC0irIvsILXgOs/rPsAv6ENwmMPBjhzF+35WZJz3DtQhZ7sSvHSP 9ya4unv2bX2fV7XXPguuIDS3Jbh02djFUu2tLLiXc9VbkgSoiwXOGN40ZSBF7A2SfhFc viFg== X-Gm-Message-State: AOAM531UK9+TMSjY8VY5N4RNuAJ+U6VN/jcpe8MjGpNbI7vC5gNPuJC6 Cpqwb4hdTULl2JK0CF2Gh6ZyShVDq8EcDC94AxU= X-Google-Smtp-Source: ABdhPJyNsV9cmrpEMe9FkMKYa+5xLcaFYpzHsErncG+9QtCHPfiddqRFk5zhNKzW3hgcp8m7aNdVPjDE6HFGwoSiywU= X-Received: by 2002:a92:c244:: with SMTP id k4mr7602319ilo.169.1638983945787; Wed, 08 Dec 2021 09:19:05 -0800 (PST) MIME-Version: 1.0 References: <20211208142238.127247-1-javad321javad@gmail.com> <20211208143456.53b9e996@donnerap.cambridge.arm.com> <20211208170328.7e7c4e29@donnerap.cambridge.arm.com> In-Reply-To: <20211208170328.7e7c4e29@donnerap.cambridge.arm.com> From: Javad Rahimi Date: Wed, 8 Dec 2021 20:48:54 +0330 Message-ID: Subject: Re: [PATCH v2] Cubieboard2:SUN7I:Add LED BOOT support To: Andre Przywara Cc: hdegoede@redhat.com, Jagan Teki , u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Dec 8, 2021 at 8:33 PM Andre Przywara wrote: > > On Wed, 8 Dec 2021 19:14:22 +0330 > Javad Rahimi wrote: > > > On Wed, Dec 8, 2021 at 6:05 PM Andre Przywara wrote: > > > > > > On Wed, 8 Dec 2021 15:25:54 +0100 > > > Frank Wunderlich wrote: > > > > > > Hi, > > > > > > > you should add maintainer email for your patch > > > > > > > > $ scripts/get_maintainer.pl board/sunxi/board.c > > > > Jagan Teki (maintainer:ARM SUNXI) > > > > Andre Przywara (maintainer:ARM SUNXI) > > > > u-boot@lists.denx.de (open list) > > > > > > Thanks Frank! > > > > > > > > Gesendet: Mittwoch, 08. Dezember 2021 um 15:22 Uhr > > > > > Von: "Javad Rahimi" > > > > > An: u-boot@lists.denx.de > > > > > Cc: "Javad Rahimi" > > > > > Betreff: [PATCH v2] Cubieboard2:SUN7I:Add LED BOOT support > > > > > > > > > > This feature makes it possible to assign one of > > > > > LED1(PH20) and LED2(PH21) to BOOT process LED. > > > > > User should activates the "Enable status LED API" in > > > > > "Device Drivers -> LED Support" > > > > > > Please have a look at the current pinephone_defconfig, because that uses > > > the boot LED already in a much easier fashion: > > > https://source.denx.de/u-boot/u-boot/-/commit/0534153fd1 > > > > > > Cheers, > > > Andre > > > > > Hi Andre, > > Thanks for your comments. I studied the pinephone_defconfig. > > By default, when activating the same options on Cubieboard2_defconfig > > it shows linker error for `__led_init` and `__led_set`. > > In other words, they are not defined. So, in this patch, I added the > > implementation for these functions for this board. > > Did you add the: > CONFIG_SPL_DRIVERS_MISC=y > line as well? And re-ran make Cubieboard2_defconfig? > Because that seemed to work for me. > > Cheers, > Andre > > When I add CONFIG_SPL_DRIVERS_MISC=y By flashing SD card and turning on the board, It freezes in this step: ``` U-Boot SPL 2022.01-rc3-00025-gf570594bc9-dirty (Dec 08 2021 - 20:36:51 +0330) ``` ----------------------------------------- The customized defconfig file for Cubieboard: ``` CONFIG_ARM=y CONFIG_ARCH_SUNXI=y CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-cubieboard2" CONFIG_SPL_DRIVERS_MISC=y CONFIG_SPL=y CONFIG_MACH_SUN7I=y CONFIG_DRAM_CLK=480 CONFIG_MMC0_CD_PIN="PH1" CONFIG_SATAPWR="PB8" CONFIG_AHCI=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL_I2C=y CONFIG_SCSI_AHCI=y CONFIG_SYS_I2C_MVTWSI=y CONFIG_SYS_I2C_SLAVE=0x7f CONFIG_SYS_I2C_SPEED=400000 CONFIG_PHY_REALTEK=y CONFIG_ETH_DESIGNWARE=y CONFIG_MII=y CONFIG_SUN7I_GMAC=y CONFIG_SCSI=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_OHCI_HCD=y CONFIG_LED_STATUS=y CONFIG_LED_STATUS_GPIO=y CONFIG_LED_STATUS0=y CONFIG_LED_STATUS_BIT=114 CONFIG_LED_STATUS_STATE=2 ``` Best Regards, Javad > > > > > > > > > > Signed-off-by: Javad Rahimi > > > > > --- > > > > > This is my first contributation in open source world. > > > > > I'm sorry if I have mistakes in my commits and versioning. > > > > > I do my best to learn fast. > > > > > > > > > > Changes in v2: > > > > > - Missed braces added > > > > > - Unnecessary debug removed > > > > > - Some typo fixed > > > > > > > > > > board/sunxi/board.c | 49 +++++++++++++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 49 insertions(+) > > > > > > > > > > diff --git a/board/sunxi/board.c b/board/sunxi/board.c > > > > > index 4f5747c34a..5e2f6ae902 100644 > > > > > --- a/board/sunxi/board.c > > > > > +++ b/board/sunxi/board.c > > > > > @@ -1002,3 +1002,52 @@ int board_fit_config_name_match(const char *name) > > > > > return ret; > > > > > } > > > > > #endif > > > > > + > > > > > +#if defined(CONFIG_LED_STATUS) && defined(CONFIG_LED_STATUS_BOOT) && defined(CONFIG_LED_STATUS_BOARD_SPECIFIC) > > > > > + > > > > > +#define CUBIE2_LED_BOOT_GPIO "PH20" > > > > > +static int gpio_boot_led; > > > > > + > > > > > +void __led_init(led_id_t mask, int state) > > > > > +{ > > > > > + int ret; > > > > > + > > > > > + if (mask != CONFIG_LED_STATUS_BOOT) > > > > > + return; > > > > > + > > > > > + ret = gpio_lookup_name(CUBIE2_LED_BOOT_GPIO, NULL, NULL, &gpio_boot_led); > > > > > + > > > > > + if (ret) > > > > > + return; > > > > > + > > > > > + ret = gpio_request(gpio_boot_led, "boot_led"); > > > > > + if (ret == -1) { > > > > > + debug("[gpio_request] Error:%d\n", ret); > > > > > + return; > > > > > + } > > > > > + > > > > > + ret = gpio_direction_output(gpio_boot_led, 1); > > > > > + if (ret == -1) { > > > > > + debug("[gpio_direction_output] Error:%d\n", ret); > > > > > + return; > > > > > + } > > > > > + __led_set(mask, state); > > > > > +} > > > > > + > > > > > +void __led_set(led_id_t mask, int state) > > > > > +{ > > > > > + if (mask != CONFIG_LED_STATUS_BOOT) > > > > > + return; > > > > > + > > > > > + gpio_set_value(gpio_boot_led, state); > > > > > +} > > > > > + > > > > > +void __led_toggle(led_id_t mask) > > > > > +{ > > > > > + if (mask != CONFIG_LED_STATUS_BOOT) > > > > > + return; > > > > > + > > > > > + gpio_set_value(gpio_boot_led, !gpio_get_value(gpio_boot_led)); > > > > > +} > > > > > + > > > > > +#endif > > > > > -- > > > > > 2.25.1 > > > > > > > > > > > > > >