All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vaibhav Nagarnaik <vnagarnaik@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Michael Rubin <mrubin@google.com>,
	David Sharp <dhsharp@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] trace-cmd: Add parse error checking target
Date: Fri, 29 Jul 2011 12:07:38 -0700	[thread overview]
Message-ID: <CAL26m8JXQxWf-Pj1_KuW=ORUoL9yzEdtgXnQfe7dw0cqPUSURw@mail.gmail.com> (raw)
In-Reply-To: <1311962000.21143.69.camel@gandalf.stny.rr.com>

On Fri, Jul 29, 2011 at 10:53 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri, 2011-07-29 at 10:41 -0700, Vaibhav Nagarnaik wrote:
>
>> Thanks Steve. I will send the man page patch.
>
> BTW, I played with this and I have a few issues. I'll still accept the
> patch as it's not that big of a deal. But here's some improvements that
> can be made.
>
>
> It should load in the plugins. As the plugins can process failed events
> well. If you don't want the plugins than you can just do what we do with
> report, add a -N to prevent plugins from being loaded.

Thanks for the suggestion, I didn't know about plugins adding parsing
capability. I will add loading the available plugins for this option.

> It should also read a trace.dat file if one is provided on the command
> line. If you don't add a file then it will use the local events of the
> system, if possible.

Our intention with this patch was to reuse the format string parsing
functionality in trace-cmd to look for any errors in new trace events
added by various kernel developers. So this was targeted to test for
event format errors and report them during a new kernel release.

A trace.dat file has already recorded all the data from the machine and
when 'report' is used on it, the format string errors will be reported
regardless. I don't see how using 'check-events' on a trace.dat file
would be useful. Thoughts?


Vaibhav Nagarnaik

  reply	other threads:[~2011-07-29 19:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-16  3:00 [PATCH 1/4] trace-cmd: Add parse error checking target Vaibhav Nagarnaik
2011-07-16  3:00 ` [PATCH 2/4] trace-cmd: Handle invalid opcode parsing gracefully Vaibhav Nagarnaik
2011-07-25 14:03   ` Steven Rostedt
2012-05-21  9:39   ` [tip:perf/core] parse-events: " tip-bot for Vaibhav Nagarnaik
2011-07-16  3:00 ` [PATCH 3/4] trace-cmd: Handle opcode parsing error Vaibhav Nagarnaik
2011-07-25 14:01   ` Steven Rostedt
2011-07-25 18:06     ` Vaibhav Nagarnaik
2011-07-25 18:40   ` Vaibhav Nagarnaik
2012-05-21  9:39     ` [tip:perf/core] parse-events: " tip-bot for Vaibhav Nagarnaik
2011-07-16  3:00 ` [PATCH 4/4] trace-cmd: Support '+' opcode in print format Vaibhav Nagarnaik
2011-07-25 14:02   ` Steven Rostedt
2012-05-21  9:41   ` [tip:perf/core] parse-events: " tip-bot for Vaibhav Nagarnaik
2011-07-25 13:32 ` [PATCH 1/4] trace-cmd: Add parse error checking target Steven Rostedt
2011-07-25 18:06   ` Vaibhav Nagarnaik
2011-07-25 18:39 ` [PATCH v2 " Vaibhav Nagarnaik
2011-07-29 14:19   ` Steven Rostedt
2011-07-29 17:41     ` Vaibhav Nagarnaik
2011-07-29 17:53       ` Steven Rostedt
2011-07-29 19:07         ` Vaibhav Nagarnaik [this message]
2011-07-30  1:33           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL26m8JXQxWf-Pj1_KuW=ORUoL9yzEdtgXnQfe7dw0cqPUSURw@mail.gmail.com' \
    --to=vnagarnaik@google.com \
    --cc=dhsharp@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mrubin@google.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.