From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751830AbcGRFwk (ORCPT ); Mon, 18 Jul 2016 01:52:40 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:36761 "EHLO mail-io0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbcGRFwi (ORCPT ); Mon, 18 Jul 2016 01:52:38 -0400 MIME-Version: 1.0 From: Yendapally Reddy Dhananjaya Reddy Date: Mon, 18 Jul 2016 11:22:36 +0530 Message-ID: Subject: Re: [patch] phy: phy-brcm-sata: fix a loop timeout To: Dan Carpenter Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 2:07 PM, Dan Carpenter wrote: > Since this loop is a post op then it means we end with "try == -1" but > afterward we test for if it's zero. Fix this by changing to a pre-op so > we end on zero. Thanks Dan. That should be pre-op. Thnaks Dhananjay > > Fixes: 024812889ad1 ('phy: Add SATA3 PHY support for Broadcom NSP SoC') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c > index 18d6626..c86456f 100644 > --- a/drivers/phy/phy-brcm-sata.c > +++ b/drivers/phy/phy-brcm-sata.c > @@ -329,7 +329,7 @@ static int brcm_nsp_sata_init(struct brcm_sata_port *port) > > /* Wait for pll_seq_done bit */ > try = 50; > - while (try--) { > + while (--try) { > val = brcm_sata_phy_rd(base, BLOCK0_REG_BANK, > BLOCK0_XGXSSTATUS); > if (val & BLOCK0_XGXSSTATUS_PLL_LOCK) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yendapally Reddy Dhananjaya Reddy Date: Mon, 18 Jul 2016 05:52:42 +0000 Subject: Re: [patch] phy: phy-brcm-sata: fix a loop timeout Message-Id: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Tue, Jun 21, 2016 at 2:07 PM, Dan Carpenter wrote: > Since this loop is a post op then it means we end with "try = -1" but > afterward we test for if it's zero. Fix this by changing to a pre-op so > we end on zero. Thanks Dan. That should be pre-op. Thnaks Dhananjay > > Fixes: 024812889ad1 ('phy: Add SATA3 PHY support for Broadcom NSP SoC') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c > index 18d6626..c86456f 100644 > --- a/drivers/phy/phy-brcm-sata.c > +++ b/drivers/phy/phy-brcm-sata.c > @@ -329,7 +329,7 @@ static int brcm_nsp_sata_init(struct brcm_sata_port *port) > > /* Wait for pll_seq_done bit */ > try = 50; > - while (try--) { > + while (--try) { > val = brcm_sata_phy_rd(base, BLOCK0_REG_BANK, > BLOCK0_XGXSSTATUS); > if (val & BLOCK0_XGXSSTATUS_PLL_LOCK)