Re: [PATCH] kern/efi: Adding efi-watchdog command

[Erwan Velu <erwanaliasr1@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]

[...]
The ext_cmd change is cool except the linker isn't happy as it cannot find
the associated symbols.
I asked a question on the IRC channel on this point.
I'm not familiar with the dependencies definition in this project, where
should I work to get ext_cmd being linked with kern/efi ?
I tried inside grub-core/Makefile.core.def without much luck for now. I
even wonder if we can linked modules with kern.
If you can point me in the right direction for this. I checked some other
commits around ext_cmd but none changes the makefiles.

I also forgot to mention, your review was high quality for a newcomer. You
point to the sample commits and that's very useful to see the expectations.
Thanks for that.


>
> > [...]
> > > Here you should add Signed-off-by of original author.
> >
> > Yeah, I was wondering that but the only email I have was from his
> previous
> > company.
> >
> > I have no idea what email I should use so its useful.
>
> I thought you know where he works. So, maybe you will be able to find
> his current email address too. If you find it please ask him which
> address should be used in this patch. If you are not able to get his
> current email address please use one from original patch.
>
> I just have his linked profile but locked as I'm not premium.
I'll use the one I found.

[-- Attachment #2: Type: text/html, Size: 1702 bytes --]