From: Filipe David Manana <fdmanana@gmail.com>
To: "dsterba@suse.cz" <dsterba@suse.cz>,
Filipe David Borba Manana <fdmanana@gmail.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v4] Btrfs: optimize key searches in btrfs_search_slot
Date: Fri, 30 Aug 2013 15:47:21 +0100 [thread overview]
Message-ID: <CAL3q7H4s4OrCkgws8Q4qZXezk-_WGGucc3C84Ud3Xy5d0zFgKQ@mail.gmail.com> (raw)
In-Reply-To: <20130830141435.GK23113@twin.jikos.cz>
On Fri, Aug 30, 2013 at 3:14 PM, David Sterba <dsterba@suse.cz> wrote:
> On Thu, Aug 29, 2013 at 08:21:51PM +0100, Filipe David Borba Manana wrote:
>> Count: 5013
>> Range: 25.000 - 497.000; Mean: 82.767; Median: 64.000; Stddev: 49.972
>> Percentiles: 90th: 141.000; 95th: 182.000; 99th: 287.000
>> 25.000 - 33.930: 211 ######
>> 33.930 - 45.927: 277 ########
>> 45.927 - 62.045: 1834 #####################################################
>> 62.045 - 83.699: 1203 ###################################
>> 83.699 - 112.789: 609 ##################
>> 112.789 - 151.872: 450 #############
>> 151.872 - 204.377: 246 #######
>> 204.377 - 274.917: 124 ####
>> 274.917 - 369.684: 48 #
>> 369.684 - 497.000: 11 |
>>
>> Approach proposed by this patch:
>>
>> Count: 5013
>> Range: 10.000 - 8303.000; Mean: 28.505; Median: 18.000; Stddev: 119.147
>> Percentiles: 90th: 49.000; 95th: 74.000; 99th: 115.000
>> 10.000 - 20.339: 3160 #####################################################
>> 20.339 - 40.397: 1131 ###################
>> 40.397 - 79.308: 507 #########
>> 79.308 - 154.794: 199 ###
>> 154.794 - 301.232: 14 |
>> 301.232 - 585.313: 1 |
>> 585.313 - 8303.000: 1 |
>
> The statistics do not change from patch to patch+1 but you're doing
> changes that may affect performance, can you please update them as well?
Sure.
They're actually better now :)
Patch following with updated histograms.
>
> thanks,
> david
--
Filipe David Manana,
"Reasonable men adapt themselves to the world.
Unreasonable men adapt the world to themselves.
That's why all progress depends on unreasonable men."
next prev parent reply other threads:[~2013-08-30 14:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 12:44 [PATCH] Btrfs: optimize key searches in btrfs_search_slot Filipe David Borba Manana
2013-08-29 13:42 ` [PATCH v2] " Filipe David Borba Manana
2013-08-29 13:49 ` [PATCH] " Josef Bacik
2013-08-29 13:53 ` Filipe David Manana
2013-08-29 13:59 ` [PATCH v3] " Filipe David Borba Manana
2013-08-29 18:08 ` Zach Brown
2013-08-29 18:35 ` Josef Bacik
2013-08-29 19:00 ` Zach Brown
2013-08-29 18:41 ` Filipe David Manana
2013-08-29 19:02 ` Zach Brown
2013-08-29 19:21 ` [PATCH v4] " Filipe David Borba Manana
2013-08-30 14:14 ` David Sterba
2013-08-30 14:47 ` Filipe David Manana [this message]
2013-08-30 14:59 ` David Sterba
2013-08-30 15:10 ` Filipe David Manana
2013-08-30 14:46 ` [PATCH v5] " Filipe David Borba Manana
2013-08-31 11:08 ` Miao Xie
2013-08-31 12:54 ` [PATCH v6] " Filipe David Borba Manana
2013-09-01 7:21 ` Miao Xie
2013-09-01 10:32 ` Filipe David Manana
2013-09-01 10:39 ` [PATCH v7] " Filipe David Borba Manana
2013-09-02 13:39 ` David Sterba
2013-09-02 14:40 ` Filipe David Manana
2013-09-02 14:52 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL3q7H4s4OrCkgws8Q4qZXezk-_WGGucc3C84Ud3Xy5d0zFgKQ@mail.gmail.com \
--to=fdmanana@gmail.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.