From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f181.google.com ([209.85.213.181]:38861 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbbCZRZU (ORCPT ); Thu, 26 Mar 2015 13:25:20 -0400 Received: by igbqf9 with SMTP id qf9so59667099igb.1 for ; Thu, 26 Mar 2015 10:25:19 -0700 (PDT) MIME-Version: 1.0 Reply-To: fdmanana@gmail.com In-Reply-To: <55143DD7.2020608@redhat.com> References: <55137BE2.80603@redhat.com> <5514137E.6080804@redhat.com> <1427381284.28930.5@mail.thefacebook.com> <55143DD7.2020608@redhat.com> Date: Thu, 26 Mar 2015 17:25:19 +0000 Message-ID: Subject: Re: I think "btrfs: fix leak of path in btrfs_find_item" broke stable trees ... From: Filipe David Manana To: Eric Sandeen Cc: Chris Mason , linux-btrfs Content-Type: text/plain; charset=UTF-8 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, Mar 26, 2015 at 5:11 PM, Eric Sandeen wrote: > On 3/26/15 9:48 AM, Chris Mason wrote: >> On Thu, Mar 26, 2015 at 10:11 AM, Eric Sandeen wrote: > > ... > >>>>> 9c4f61f btrfs: simplify insert_orphan_item >>>>> >>>>> made the whole path alloc/free go away. >>> >>> so I think there's no need for my patch; may as well just send the above to stable >>> and fix it that way, as long as 9c4f61f is deemed safe & correct, I think. >> >> Nice catch, thanks Eric. 9c4f61f looks fine for stable to me, but >> since he's already testing on stable, I talked Eric into giving it a >> pass through xfstests before I send it up. >> >> -chris > > ./check -g auto on 3.19-stable-ish seems fine-ish. Certainly no worse w/ the patch added :) > > Failures: btrfs/010 btrfs/017 btrfs/078 generic/015 generic/039 generic/040 generic/041 generic/065 generic/066 generic/071 generic/204 > Failed 11 of 202 tests Just curious, how did btrfs/078 fail? It isn't supposed to fail on 3.19.x nor 3.18.x. > > I'd say ship it! > > -Eric > -- Filipe David Manana, "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themselves. That's why all progress depends on unreasonable men."