All of lore.kernel.org
 help / color / mirror / Atom feed
From: Filipe Manana <fdmanana@kernel.org>
To: Zorro Lang <zlang@redhat.com>
Cc: Su Yue <glass.su@suse.com>,
	fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
	 l@damenly.org
Subject: Re: [PATCH] btrfs/172,206: call _log_writes_cleanup in _cleanup
Date: Fri, 1 Mar 2024 14:55:26 +0000	[thread overview]
Message-ID: <CAL3q7H53QTzMVdJwEJBOyoB3fBem-2zi3FH411JugRDkq9Bqvg@mail.gmail.com> (raw)
In-Reply-To: <20240301134914.dgcv4vh2jbx2egfp@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>

On Fri, Mar 1, 2024 at 1:49 PM Zorro Lang <zlang@redhat.com> wrote:
>
> On Thu, Feb 15, 2024 at 10:02:36PM +0800, Su Yue wrote:
> > From: Su Yue <glass.su@suse.com>
> >
> > Because block group tree requires require no-holes feature,
> > _log_writes_mkfs "-O ^no-holes" fails when "-O block-group-tree" is
> > given in MKFS_OPTION.
> > Without explicit _log_writes_cleanup, the two tests fail with
> > logwrites-test device left. And all next tests will fail due to
> > SCRATCH DEVICE EBUSY.
> >
> > Fix it by overriding _cleanup to call _log_writes_cleanup.
> >
> > Signed-off-by: Su Yue <glass.su@suse.com>
> > ---
> >  tests/btrfs/172 | 6 ++++++
> >  tests/btrfs/206 | 6 ++++++
> >  2 files changed, 12 insertions(+)
> >
> > diff --git a/tests/btrfs/172 b/tests/btrfs/172
> > index f5acc6982cd7..fceff56c9d37 100755
> > --- a/tests/btrfs/172
> > +++ b/tests/btrfs/172
> > @@ -13,6 +13,12 @@
> >  . ./common/preamble
> >  _begin_fstest auto quick log replay recoveryloop
> >
> > +# Override the default cleanup function.
> > +_cleanup()
> > +{
> > +     _log_writes_cleanup &> /dev/null
>
> This _cleanup will override the default one, so better to copy the
> default cleanup in this function,
>
>   cd /
>   rm -r -f $tmp.*

Zorro,

You had already replied to v2 of this patch with exactly the same comments:

https://lore.kernel.org/fstests/20240225162212.qcidpyb2bhdburl6@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com/

It's trivial to do those changes.
Do you expect Su to send yet another version just for that, or could
you amend the patch?

Can you please be more clear in future replies about that, i.e. if you
expect the author to send a new version or if you'll amend the patch
for trivial changes?

Speaking for myself, I very often get confused with your replies, and
I feel that some patches often get stalled for that reason.
Usually with Eryu or Dave that didn't happen, the course of action was clear.

Thanks.

>
> You can refer to btrfs/196 or generic/482 etc.
>
> > +}
> > +
> >  # Import common functions.
> >  . ./common/filter
> >  . ./common/dmlogwrites
> > diff --git a/tests/btrfs/206 b/tests/btrfs/206
> > index f6571649076f..e05adf75b67e 100755
> > --- a/tests/btrfs/206
> > +++ b/tests/btrfs/206
> > @@ -14,6 +14,12 @@
> >  . ./common/preamble
> >  _begin_fstest auto quick log replay recoveryloop punch prealloc
> >
> > +# Override the default cleanup function.
> > +_cleanup()
> > +{
> > +     _log_writes_cleanup &> /dev/null
>
>
> Same as above.
>
> Thanks,
> Zorro
>
> > +}
> > +
> >  # Import common functions.
> >  . ./common/filter
> >  . ./common/dmlogwrites
> > --
> > 2.43.0
> >
> >
>
>

  reply	other threads:[~2024-03-01 14:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 14:02 [PATCH] btrfs/172,206: call _log_writes_cleanup in _cleanup Su Yue
2024-02-15 15:58 ` Filipe Manana
2024-02-15 23:10 ` Qu Wenruo
2024-03-01 13:49 ` Zorro Lang
2024-03-01 14:55   ` Filipe Manana [this message]
2024-03-02  7:03     ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL3q7H53QTzMVdJwEJBOyoB3fBem-2zi3FH411JugRDkq9Bqvg@mail.gmail.com \
    --to=fdmanana@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=glass.su@suse.com \
    --cc=l@damenly.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.