All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fsstress: improve error message on check_cwd() error
@ 2021-09-21 17:50 Luis Chamberlain
  2021-09-22 10:15 ` Filipe Manana
  0 siblings, 1 reply; 10+ messages in thread
From: Luis Chamberlain @ 2021-09-21 17:50 UTC (permalink / raw)
  To: fstests; +Cc: Luis Chamberlain, Anthony Iliopoulos

I ran into an error with generic/083 with xfs due to check_cwd() but
why it failed is not clear because there are two types of
failures:

  o stat64() failed (likely -ENOMEM is my guess)
  o the inode actually changed

Thow a bone out to developers so that in case en error does happen
they know which rabbit hole to go down on.

Cc: Anthony Iliopoulos <ailiopoulos@suse.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 ltp/fsstress.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index b4ddf5e2..d2f09901 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -9,6 +9,7 @@
 #include <sys/uio.h>
 #include <stddef.h>
 #include <stdbool.h>
+#include <string.h>
 #include "global.h"
 
 #ifdef HAVE_BTRFSUTIL_H
@@ -943,9 +944,21 @@ check_cwd(void)
 {
 #ifdef DEBUG
 	struct stat64	statbuf;
+	int ret;
+
+	ret = stat64(".", &statbuf);
+	if (ret !=0) {
+		fprintf(stderr, "fsstress: check_cwd stat64 failed with: %d (%s)\n",
+			ret, strerror(ret));
+		goto out;
+	}
 
-	if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
+	if (statbuf.st_ino == top_ino)
 		return;
+
+	fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%ld) != top_ino (%ld)\n",
+		(long)statbuf.st_ino, (long)top_ino);
+out:
 	assert(chdir(homedir) == 0);
 	fprintf(stderr, "fsstress: check_cwd failure\n");
 	abort();
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] fsstress: improve error message on check_cwd() error
  2021-09-21 17:50 [PATCH] fsstress: improve error message on check_cwd() error Luis Chamberlain
@ 2021-09-22 10:15 ` Filipe Manana
  2021-09-22 20:07   ` Luis Chamberlain
  0 siblings, 1 reply; 10+ messages in thread
From: Filipe Manana @ 2021-09-22 10:15 UTC (permalink / raw)
  To: Luis Chamberlain; +Cc: fstests, Anthony Iliopoulos

On Tue, Sep 21, 2021 at 6:51 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> I ran into an error with generic/083 with xfs due to check_cwd() but
> why it failed is not clear because there are two types of
> failures:
>
>   o stat64() failed (likely -ENOMEM is my guess)
>   o the inode actually changed
>
> Thow a bone out to developers so that in case en error does happen
> they know which rabbit hole to go down on.
>
> Cc: Anthony Iliopoulos <ailiopoulos@suse.de>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  ltp/fsstress.c | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> index b4ddf5e2..d2f09901 100644
> --- a/ltp/fsstress.c
> +++ b/ltp/fsstress.c
> @@ -9,6 +9,7 @@
>  #include <sys/uio.h>
>  #include <stddef.h>
>  #include <stdbool.h>
> +#include <string.h>
>  #include "global.h"
>
>  #ifdef HAVE_BTRFSUTIL_H
> @@ -943,9 +944,21 @@ check_cwd(void)
>  {
>  #ifdef DEBUG
>         struct stat64   statbuf;
> +       int ret;
> +
> +       ret = stat64(".", &statbuf);
> +       if (ret !=0) {
> +               fprintf(stderr, "fsstress: check_cwd stat64 failed with: %d (%s)\n",
> +                       ret, strerror(ret));

The error is not in 'ret' but instead in 'errno', so it should print
errno and strerror(errno).

> +               goto out;
> +       }
>
> -       if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
> +       if (statbuf.st_ino == top_ino)
>                 return;
> +
> +       fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%ld) != top_ino (%ld)\n",
> +               (long)statbuf.st_ino, (long)top_ino);

ino_t is guaranteed to be an unsigned integer, and can be either 64 or
32 bits wide [1].
Casting to unsigned 64 bits would be better imo.

Thanks.

https://www.gnu.org/software/libc/manual/html_node/Attribute-Meanings.html

> +out:
>         assert(chdir(homedir) == 0);
>         fprintf(stderr, "fsstress: check_cwd failure\n");
>         abort();
> --
> 2.30.2
>


-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] fsstress: improve error message on check_cwd() error
  2021-09-22 10:15 ` Filipe Manana
@ 2021-09-22 20:07   ` Luis Chamberlain
  2021-09-23 12:37     ` Filipe Manana
  0 siblings, 1 reply; 10+ messages in thread
From: Luis Chamberlain @ 2021-09-22 20:07 UTC (permalink / raw)
  To: Filipe Manana; +Cc: fstests, Anthony Iliopoulos

On Wed, Sep 22, 2021 at 11:15:08AM +0100, Filipe Manana wrote:
> On Tue, Sep 21, 2021 at 6:51 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
> >
> > I ran into an error with generic/083 with xfs due to check_cwd() but
> > why it failed is not clear because there are two types of
> > failures:
> >
> >   o stat64() failed (likely -ENOMEM is my guess)
> >   o the inode actually changed
> >
> > Thow a bone out to developers so that in case en error does happen
> > they know which rabbit hole to go down on.
> >
> > Cc: Anthony Iliopoulos <ailiopoulos@suse.de>
> > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> > ---
> >  ltp/fsstress.c | 15 ++++++++++++++-
> >  1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> > index b4ddf5e2..d2f09901 100644
> > --- a/ltp/fsstress.c
> > +++ b/ltp/fsstress.c
> > @@ -9,6 +9,7 @@
> >  #include <sys/uio.h>
> >  #include <stddef.h>
> >  #include <stdbool.h>
> > +#include <string.h>
> >  #include "global.h"
> >
> >  #ifdef HAVE_BTRFSUTIL_H
> > @@ -943,9 +944,21 @@ check_cwd(void)
> >  {
> >  #ifdef DEBUG
> >         struct stat64   statbuf;
> > +       int ret;
> > +
> > +       ret = stat64(".", &statbuf);
> > +       if (ret !=0) {
> > +               fprintf(stderr, "fsstress: check_cwd stat64 failed with: %d (%s)\n",
> > +                       ret, strerror(ret));
> 
> The error is not in 'ret' but instead in 'errno', so it should print
> errno and strerror(errno).

Good call will fix.

> > +               goto out;
> > +       }
> >
> > -       if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
> > +       if (statbuf.st_ino == top_ino)
> >                 return;
> > +
> > +       fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%ld) != top_ino (%ld)\n",
> > +               (long)statbuf.st_ino, (long)top_ino);
> 
> ino_t is guaranteed to be an unsigned integer, and can be either 64 or
> 32 bits wide [1].
> Casting to unsigned 64 bits would be better imo.

There are other similar mi-uses in the code, should I fix those to
then?

  Luis
 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] fsstress: improve error message on check_cwd() error
  2021-09-22 20:07   ` Luis Chamberlain
@ 2021-09-23 12:37     ` Filipe Manana
  2021-11-01 15:50       ` Luis Chamberlain
  0 siblings, 1 reply; 10+ messages in thread
From: Filipe Manana @ 2021-09-23 12:37 UTC (permalink / raw)
  To: Luis Chamberlain; +Cc: fstests, Anthony Iliopoulos

On Wed, Sep 22, 2021 at 9:07 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> On Wed, Sep 22, 2021 at 11:15:08AM +0100, Filipe Manana wrote:
> > On Tue, Sep 21, 2021 at 6:51 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
> > >
> > > I ran into an error with generic/083 with xfs due to check_cwd() but
> > > why it failed is not clear because there are two types of
> > > failures:
> > >
> > >   o stat64() failed (likely -ENOMEM is my guess)
> > >   o the inode actually changed
> > >
> > > Thow a bone out to developers so that in case en error does happen
> > > they know which rabbit hole to go down on.
> > >
> > > Cc: Anthony Iliopoulos <ailiopoulos@suse.de>
> > > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> > > ---
> > >  ltp/fsstress.c | 15 ++++++++++++++-
> > >  1 file changed, 14 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> > > index b4ddf5e2..d2f09901 100644
> > > --- a/ltp/fsstress.c
> > > +++ b/ltp/fsstress.c
> > > @@ -9,6 +9,7 @@
> > >  #include <sys/uio.h>
> > >  #include <stddef.h>
> > >  #include <stdbool.h>
> > > +#include <string.h>
> > >  #include "global.h"
> > >
> > >  #ifdef HAVE_BTRFSUTIL_H
> > > @@ -943,9 +944,21 @@ check_cwd(void)
> > >  {
> > >  #ifdef DEBUG
> > >         struct stat64   statbuf;
> > > +       int ret;
> > > +
> > > +       ret = stat64(".", &statbuf);
> > > +       if (ret !=0) {
> > > +               fprintf(stderr, "fsstress: check_cwd stat64 failed with: %d (%s)\n",
> > > +                       ret, strerror(ret));
> >
> > The error is not in 'ret' but instead in 'errno', so it should print
> > errno and strerror(errno).
>
> Good call will fix.
>
> > > +               goto out;
> > > +       }
> > >
> > > -       if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
> > > +       if (statbuf.st_ino == top_ino)
> > >                 return;
> > > +
> > > +       fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%ld) != top_ino (%ld)\n",
> > > +               (long)statbuf.st_ino, (long)top_ino);
> >
> > ino_t is guaranteed to be an unsigned integer, and can be either 64 or
> > 32 bits wide [1].
> > Casting to unsigned 64 bits would be better imo.
>
> There are other similar mi-uses in the code, should I fix those to
> then?

If you want to, as a separate patch.
Noticing now that since the code is using struct stat64, using %llu
for the printfs without any casts should be fine [1].

Thanks.

[1] https://www.mkssoftware.com/docs/man5/struct_stat.5.asp

>
>   Luis
>


-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] fsstress: improve error message on check_cwd() error
  2021-09-23 12:37     ` Filipe Manana
@ 2021-11-01 15:50       ` Luis Chamberlain
  0 siblings, 0 replies; 10+ messages in thread
From: Luis Chamberlain @ 2021-11-01 15:50 UTC (permalink / raw)
  To: Filipe Manana; +Cc: fstests, Anthony Iliopoulos

On Thu, Sep 23, 2021 at 01:37:04PM +0100, Filipe Manana wrote:
> On Wed, Sep 22, 2021 at 9:07 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
> >
> > On Wed, Sep 22, 2021 at 11:15:08AM +0100, Filipe Manana wrote:
> > > > +       fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%ld) != top_ino (%ld)\n",
> > > > +               (long)statbuf.st_ino, (long)top_ino);
> > >
> > > ino_t is guaranteed to be an unsigned integer, and can be either 64 or
> > > 32 bits wide [1].
> > > Casting to unsigned 64 bits would be better imo.
> >
> > There are other similar mi-uses in the code, should I fix those to
> > then?
> 
> If you want to, as a separate patch.

> Since the code is using struct stat64, using %llu
> for the printfs without any casts should be fine [1].

You mean %lu because with %llu there is a warning.

  Luis

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] fsstress: improve error message on check_cwd() error
  2021-11-05 16:04     ` Luis Chamberlain
@ 2021-11-05 16:09       ` Darrick J. Wong
  0 siblings, 0 replies; 10+ messages in thread
From: Darrick J. Wong @ 2021-11-05 16:09 UTC (permalink / raw)
  To: Luis Chamberlain; +Cc: fdmanana, fstests, Anthony Iliopoulos

On Fri, Nov 05, 2021 at 09:04:21AM -0700, Luis Chamberlain wrote:
> On Wed, Nov 03, 2021 at 11:18:22AM -0700, Luis Chamberlain wrote:
> > On Wed, Nov 03, 2021 at 09:24:34AM -0700, Darrick J. Wong wrote:
> > > > -	if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
> > > > +	if (statbuf.st_ino == top_ino)
> > > >  		return;
> > > > +
> > > > +	fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%lu) != top_ino (%lu)\n",
> > > > +		statbuf.st_ino, top_ino);
> > > 
> > > This might want some explicit casting, since this can be defined as
> > > anything between unsigned long to uint64_t, at least according to the
> > > glibc headers on my system.
> > 
> > Um, Filipe had suggested something a bit different before. Can you guys
> > decide and let me know your final preference ? :)
> 
> Any final preference / recommendation?

Use %llu with explicit casts to (unsigned long long) and it should work
fine everywhere.

--D

>   Luis

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] fsstress: improve error message on check_cwd() error
  2021-11-03 18:18   ` Luis Chamberlain
@ 2021-11-05 16:04     ` Luis Chamberlain
  2021-11-05 16:09       ` Darrick J. Wong
  0 siblings, 1 reply; 10+ messages in thread
From: Luis Chamberlain @ 2021-11-05 16:04 UTC (permalink / raw)
  To: Darrick J. Wong, fdmanana; +Cc: fstests, Anthony Iliopoulos

On Wed, Nov 03, 2021 at 11:18:22AM -0700, Luis Chamberlain wrote:
> On Wed, Nov 03, 2021 at 09:24:34AM -0700, Darrick J. Wong wrote:
> > > -	if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
> > > +	if (statbuf.st_ino == top_ino)
> > >  		return;
> > > +
> > > +	fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%lu) != top_ino (%lu)\n",
> > > +		statbuf.st_ino, top_ino);
> > 
> > This might want some explicit casting, since this can be defined as
> > anything between unsigned long to uint64_t, at least according to the
> > glibc headers on my system.
> 
> Um, Filipe had suggested something a bit different before. Can you guys
> decide and let me know your final preference ? :)

Any final preference / recommendation?

  Luis

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] fsstress: improve error message on check_cwd() error
  2021-11-03 16:24 ` Darrick J. Wong
@ 2021-11-03 18:18   ` Luis Chamberlain
  2021-11-05 16:04     ` Luis Chamberlain
  0 siblings, 1 reply; 10+ messages in thread
From: Luis Chamberlain @ 2021-11-03 18:18 UTC (permalink / raw)
  To: Darrick J. Wong, fdmanana; +Cc: fstests, Anthony Iliopoulos, mcgrof

On Wed, Nov 03, 2021 at 09:24:34AM -0700, Darrick J. Wong wrote:
> On Mon, Nov 01, 2021 at 08:55:59AM -0700, Luis Chamberlain wrote:
> > I ran into an error with generic/083 with xfs due to check_cwd() but
> > why it failed is not clear because there are two types of
> > failures:
> > 
> >   o stat64() failed (likely -ENOMEM is my guess)
> >   o the inode actually changed
> > 
> > Throw a bone out to developers so that in case en error does happen
> > they know which rabbit hole to go down on.
> 
> <cough> word choice on those last three words...

Will fix thanks.

> > 
> > Cc: Anthony Iliopoulos <ailiopoulos@suse.de>
> > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> > ---
> >  ltp/fsstress.c | 15 ++++++++++++++-
> >  1 file changed, 14 insertions(+), 1 deletion(-)
> > 
> > diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> > index 90ae432e..a576afea 100644
> > --- a/ltp/fsstress.c
> > +++ b/ltp/fsstress.c
> > @@ -9,6 +9,7 @@
> >  #include <sys/uio.h>
> >  #include <stddef.h>
> >  #include <stdbool.h>
> > +#include <string.h>
> >  #include "global.h"
> >  
> >  #ifdef HAVE_BTRFSUTIL_H
> > @@ -943,9 +944,21 @@ check_cwd(void)
> >  {
> >  #ifdef DEBUG
> >  	struct stat64	statbuf;
> > +	int ret;
> > +
> > +	ret = stat64(".", &statbuf);
> > +	if (ret !=0) {
> 
> Nit: space between '!=' and '0'.

OK.

> > +		fprintf(stderr, "fsstress: check_cwd stat64 failed with: %d (%s)\n",
> > +			ret, strerror(ret));
> 
> ret is set to -1 on error, according to the manpage; to get the real
> error you'd have to call strerror(errno) as the last arg, or be lazy
> and:

I don't want to be lazy here as this is a real issue.

> 		perror("fsstress check_cwd stat64");
> 
> > +		goto out;
> > +	}
> >  
> > -	if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
> > +	if (statbuf.st_ino == top_ino)
> >  		return;
> > +
> > +	fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%lu) != top_ino (%lu)\n",
> > +		statbuf.st_ino, top_ino);
> 
> This might want some explicit casting, since this can be defined as
> anything between unsigned long to uint64_t, at least according to the
> glibc headers on my system.

Um, Filipe had suggested something a bit different before. Can you guys
decide and let me know your final preference ? :)

  Luis

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] fsstress: improve error message on check_cwd() error
  2021-11-01 15:55 Luis Chamberlain
@ 2021-11-03 16:24 ` Darrick J. Wong
  2021-11-03 18:18   ` Luis Chamberlain
  0 siblings, 1 reply; 10+ messages in thread
From: Darrick J. Wong @ 2021-11-03 16:24 UTC (permalink / raw)
  To: Luis Chamberlain; +Cc: fstests, fdmanana, Anthony Iliopoulos

On Mon, Nov 01, 2021 at 08:55:59AM -0700, Luis Chamberlain wrote:
> I ran into an error with generic/083 with xfs due to check_cwd() but
> why it failed is not clear because there are two types of
> failures:
> 
>   o stat64() failed (likely -ENOMEM is my guess)
>   o the inode actually changed
> 
> Throw a bone out to developers so that in case en error does happen
> they know which rabbit hole to go down on.

<cough> word choice on those last three words...

> 
> Cc: Anthony Iliopoulos <ailiopoulos@suse.de>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  ltp/fsstress.c | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> index 90ae432e..a576afea 100644
> --- a/ltp/fsstress.c
> +++ b/ltp/fsstress.c
> @@ -9,6 +9,7 @@
>  #include <sys/uio.h>
>  #include <stddef.h>
>  #include <stdbool.h>
> +#include <string.h>
>  #include "global.h"
>  
>  #ifdef HAVE_BTRFSUTIL_H
> @@ -943,9 +944,21 @@ check_cwd(void)
>  {
>  #ifdef DEBUG
>  	struct stat64	statbuf;
> +	int ret;
> +
> +	ret = stat64(".", &statbuf);
> +	if (ret !=0) {

Nit: space between '!=' and '0'.

> +		fprintf(stderr, "fsstress: check_cwd stat64 failed with: %d (%s)\n",
> +			ret, strerror(ret));

ret is set to -1 on error, according to the manpage; to get the real
error you'd have to call strerror(errno) as the last arg, or be lazy
and:

		perror("fsstress check_cwd stat64");

> +		goto out;
> +	}
>  
> -	if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
> +	if (statbuf.st_ino == top_ino)
>  		return;
> +
> +	fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%lu) != top_ino (%lu)\n",
> +		statbuf.st_ino, top_ino);

This might want some explicit casting, since this can be defined as
anything between unsigned long to uint64_t, at least according to the
glibc headers on my system.

--D

> +out:
>  	assert(chdir(homedir) == 0);
>  	fprintf(stderr, "fsstress: check_cwd failure\n");
>  	abort();
> -- 
> 2.33.0
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH] fsstress: improve error message on check_cwd() error
@ 2021-11-01 15:55 Luis Chamberlain
  2021-11-03 16:24 ` Darrick J. Wong
  0 siblings, 1 reply; 10+ messages in thread
From: Luis Chamberlain @ 2021-11-01 15:55 UTC (permalink / raw)
  To: fstests; +Cc: fdmanana, Luis Chamberlain, Anthony Iliopoulos

I ran into an error with generic/083 with xfs due to check_cwd() but
why it failed is not clear because there are two types of
failures:

  o stat64() failed (likely -ENOMEM is my guess)
  o the inode actually changed

Throw a bone out to developers so that in case en error does happen
they know which rabbit hole to go down on.

Cc: Anthony Iliopoulos <ailiopoulos@suse.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 ltp/fsstress.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index 90ae432e..a576afea 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -9,6 +9,7 @@
 #include <sys/uio.h>
 #include <stddef.h>
 #include <stdbool.h>
+#include <string.h>
 #include "global.h"
 
 #ifdef HAVE_BTRFSUTIL_H
@@ -943,9 +944,21 @@ check_cwd(void)
 {
 #ifdef DEBUG
 	struct stat64	statbuf;
+	int ret;
+
+	ret = stat64(".", &statbuf);
+	if (ret !=0) {
+		fprintf(stderr, "fsstress: check_cwd stat64 failed with: %d (%s)\n",
+			ret, strerror(ret));
+		goto out;
+	}
 
-	if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
+	if (statbuf.st_ino == top_ino)
 		return;
+
+	fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%lu) != top_ino (%lu)\n",
+		statbuf.st_ino, top_ino);
+out:
 	assert(chdir(homedir) == 0);
 	fprintf(stderr, "fsstress: check_cwd failure\n");
 	abort();
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-11-05 16:09 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-21 17:50 [PATCH] fsstress: improve error message on check_cwd() error Luis Chamberlain
2021-09-22 10:15 ` Filipe Manana
2021-09-22 20:07   ` Luis Chamberlain
2021-09-23 12:37     ` Filipe Manana
2021-11-01 15:50       ` Luis Chamberlain
2021-11-01 15:55 Luis Chamberlain
2021-11-03 16:24 ` Darrick J. Wong
2021-11-03 18:18   ` Luis Chamberlain
2021-11-05 16:04     ` Luis Chamberlain
2021-11-05 16:09       ` Darrick J. Wong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.