Re: [PATCH v2 3/3] mx7ulp_com: add support for SPL

[Igor Opaniuk <igor.opaniuk@foundries.io>]

Hi Fabio,

On Mon, Sep 13, 2021 at 1:03 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Oleksandr,
>
> On Sun, Sep 12, 2021 at 11:33 AM Oleksandr Suvorov
> <oleksandr.suvorov@foundries.io> wrote:
> >
> > From: Ricardo Salveti <ricardo@foundries.io>
> >
> > Add EA iMX7ULP COM board support for building SPL.
> >
> > Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
> > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> > ---
> >
> > Changes in v2:
> > - add a patch with SPL support for mx7ulp_com board.
> >
> >  arch/arm/dts/imx7ulp-com-u-boot.dtsi | 37 ++++++++++++++++++++++++++++
> >  arch/arm/dts/imx7ulp-com.dts         |  1 +
> >  arch/arm/mach-imx/mx7ulp/Kconfig     | 12 +++++++++
> >  board/ea/mx7ulp_com/mx7ulp_com.c     | 26 +++++++++++++++++++
> >  include/configs/mx7ulp_com.h         |  6 +++++
> >  5 files changed, 82 insertions(+)
> >  create mode 100644 arch/arm/dts/imx7ulp-com-u-boot.dtsi
>
> I don't see DRAM initialization in the newly added SPL code.
>
> Am I missing something?

Maybe I misunderstood your question,
but it's already in board/ea/mx7ulp_com/mx7ulp_com.c, no?

int dram_init(void)
{
        gd->ram_size = imx_ddr_size();

#ifdef CONFIG_OPTEE_TZDRAM_SIZE
       gd->ram_size -= CONFIG_OPTEE_TZDRAM_SIZE;
#endif

        return 0;
}

which is in init_sequence_f (common/board_f.c), which is supposed to be
called in spl when CONFIG_SPL=y.

Or what exactly do you mean?

Regards,
Igor

-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk
Embedded Software Engineer
T:  +380 938364067
E: igor.opaniuk@foundries.io
W: www.foundries.io