From: Feng Kan <fkan@apm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: jason <jason@lakedaemon.net>, Marc Zyngier <marc.zyngier@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
patches <patches@apm.com>, Vinayak Kale <vkale@apm.com>
Subject: Re: [PATCH V2 2/2] irqchip: gic: preserve gic V2 bypass bits in cpu ctrl register
Date: Thu, 26 Jun 2014 09:48:25 -0700 [thread overview]
Message-ID: <CAL85gmAPXDTO2x4esYNq1ZHUAwuNTtMCNtc+ODwnrNPEaDH_1w@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1406260302510.5170@nanos>
On Wed, Jun 25, 2014 at 6:05 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 25 Jun 2014, Feng Kan wrote:
>
>> This change is made to preserve the GIC v2 bypass bits in the
>> GIC_CPU_CTRL register (also known as the GICC_CTLR register in spec).
>> This code will preserve all bits configured by the bootloader regarding
>> v2 bypass group bits. In the X-Gene platform, the bypass functionality
>> is not used and bypass bits should not be changed by the kernel gic
>> code as it could lead to incorrect behavior.
>>
>> Signed-off-by: Vinayak Kale <vkale@apm.com>
>> Signed-off-by: Feng Kan <fkan@apm.com>
>
> Who wrote the patch? According to the SOB chain it's Vinayak, but your
> patch is missing the:
I wrote the patch which was based on Vinayak's original change. I can
change it to
Reviewed-by. I was trying to give him credit.
>
> From: Vinayak Kale <vkale@apm.com>
>
> before the actual changelog starts.
next prev parent reply other threads:[~2014-06-26 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 22:07 [PATCH v2 0/2] irqchip: gic: Add support for GIC v2 bypass disable Feng Kan
2014-06-25 22:07 ` [PATCH V2 1/2] irqchip: gic: replace hex numbers with defines Feng Kan
2014-06-25 22:07 ` [PATCH V2 2/2] irqchip: gic: preserve gic V2 bypass bits in cpu ctrl register Feng Kan
2014-06-26 1:05 ` Thomas Gleixner
2014-06-26 16:48 ` Feng Kan [this message]
2014-06-27 11:17 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL85gmAPXDTO2x4esYNq1ZHUAwuNTtMCNtc+ODwnrNPEaDH_1w@mail.gmail.com \
--to=fkan@apm.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=patches@apm.com \
--cc=tglx@linutronix.de \
--cc=vkale@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.