From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hoyeonjiki Kim Date: Thu, 12 Nov 2020 22:11:52 +0900 Subject: [PATCH] env: mmc: Correct partition comparison in mmc_offset_try_partition In-Reply-To: <20201112123026.458-1-jigi.kim@gmail.com> References: <20201112123026.458-1-jigi.kim@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Mis-submitted the patch without versioning... :( I'll re-submit my patch again. Sorry for interrupting you. Best Regards, Hoyeonjiki Kim On Thu, Nov 12, 2020 at 9:30 PM Hoyeonjiki Kim wrote: > > The function mmc_offset_try_partition searches MMC partition to save the > environment data by name. However, it only compares the first word-size > bytes (size of 'const char *'), which may make the function to find > unintended partition. > > Correct the function not to partially compare the partition name with > config "u-boot,mmc-env-partition". > > Fixes: c9e87ba66540 ("env: Save environment at the end of an MMC partition") > Signed-off-by: Hoyeonjiki Kim > Reviewed-by: Jaehoon Chung > --- > env/mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/env/mmc.c b/env/mmc.c > index 4e67180b23..505f7aa2b8 100644 > --- a/env/mmc.c > +++ b/env/mmc.c > @@ -42,7 +42,7 @@ static inline int mmc_offset_try_partition(const char *str, int copy, s64 *val) > if (ret < 0) > return ret; > > - if (!strncmp((const char *)info.name, str, sizeof(str))) > + if (!strcmp((const char *)info.name, str)) > break; > } > > -- > 2.25.1 >