From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED3FAC4320A for ; Thu, 5 Aug 2021 08:56:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D078D61029 for ; Thu, 5 Aug 2021 08:56:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239748AbhHEI4O (ORCPT ); Thu, 5 Aug 2021 04:56:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232651AbhHEI4N (ORCPT ); Thu, 5 Aug 2021 04:56:13 -0400 Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B08E3C061765; Thu, 5 Aug 2021 01:55:59 -0700 (PDT) Received: by mail-il1-x135.google.com with SMTP id x7so4336409ilh.10; Thu, 05 Aug 2021 01:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gzmhApPj8HKqYSRf21gqLOYpahW4Hf0SxEjn45dssUM=; b=TOTf9psJWunXK13kHgtY8TiWSVBgt5Vzq7W3W8AQ6vfyunOVZEh0Qg4+gWIaULVC0g U3YhP0DGAJBbmfrkgJEG1F3KzQp2r86sDY8FA4NRqzJFZVplKdW1VXiss+CkUgIVFlHY 1AScnG9bhXvzFieoJZX0UsqLYilrjUrI/OQe5yDln9R0bPAl+gjRmsFEH07AqF30YWzf ITB/9oa3eXMfGlktXJpWD/8UHgFfsPXBT3zWtvvJCNHBegdJVKz1bP3KPigPDera7nA5 ViBZAMJxF0nDwi4qDAhUT12fx7jCiepxmlN3eWPhh+rNERgLcXgkD/ePxOYnQOfNRHWn nplg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gzmhApPj8HKqYSRf21gqLOYpahW4Hf0SxEjn45dssUM=; b=iYQcSkEEN+wvYRGP6jF+uT8lHPQSWPRFvb9Bx21zdtX5Prbsq/A5xohDHHkbmmWidH mupVSJ2IHpgG8N81vmUF7cmTrHi9UnLMGdWpfjZ4SCwRHK6v+Cry/MD6yK8exp2KlKhK VkhcgvMwObv+Kc0YQKp08zxLnqtQsK48tzmmVKkhtg+7GJ6Q6TNb7xQu4NRKrSRtcp4x rOlK1f27Hah4YV/SeJku28CgvddveRC+1PeyFTSl6EueN9555oqePvbsFmy30jWBy9xr CdZhJu7tp/GC5Wzk2qxj70tUXBN86xXcCgbw087sxfGN2DZk6UAtjne+W+n75xxC59O5 vFQQ== X-Gm-Message-State: AOAM5300alSulMHxyOkYWkiIRUG5T9ZOecyUn90/ivmFwWLVMyYccM8k kK148kfHQcWLU4x7Jl7KnjhST7IRu+mY6TodWPtiYRwof63CfpjJ X-Google-Smtp-Source: ABdhPJwE6/hjmNRFCTdKVvlJC0gbv70mRmlYMEcT7G0uSTjPkThFyytPoqX7/kmL1I7cGXdcgbE94sArd3GVW8kQtzU= X-Received: by 2002:a05:6e02:13b3:: with SMTP id h19mr244834ilo.218.1628153759089; Thu, 05 Aug 2021 01:55:59 -0700 (PDT) MIME-Version: 1.0 References: <1627098243-2742-1-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1627098243-2742-1-git-send-email-dillon.minfei@gmail.com> From: Dillon Min Date: Thu, 5 Aug 2021 16:55:23 +0800 Message-ID: Subject: Re: [PATCH v4 0/3] Add ilitek ili9341 panel driver To: laurent.pinchart@ideasonboard.com, Thierry Reding , Sam Ravnborg , Dave Airlie , Daniel Vetter , Rob Herring , Linus Walleij , Alexandre TORGUE , Maxime Coquelin , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Peter Robinson Cc: kbuild-all@lists.01.org, linux-stm32@st-md-mailman.stormreply.com, Linux ARM , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi All Just a gentle ping, thanks. Best regards. Dillon On Sat, 24 Jul 2021 at 11:44, wrote: > > From: Dillon Min > > Since the st,sf-tc240t-9370-t dts binding already exist in stm32f429-disco.dts > but, the panel driver didn't get accepted from mainline. it's time to submit > patch fot it. > > This driver can support two different interface by different dts bindings: > - spi+dpi, use spi to configure register, dpi for graphic data. > st,sf-tc240t-9370-t > - only spi, just like tiny/ili9341.c (actually, this part is copy from tiny) > adafruit,yx240qv29 > > I was submited the first patch last year, you can find it at [1]. > this patch has one major difference from that one, which is replace the low > level communication way, from spi_sync() to mipi_dbi_{command, > command_stackbuf}() interface, referred from Linus's patch [2]. > > both the two dpi/dbi interface was tested on stm32f429-disco board, if anyone > want to verify this patch, you need apply the clk patch for this board first, > you can get it from [3]. > > [1] "drm/panel: Add ilitek ili9341 panel driver" > https://lore.kernel.org/lkml/1590378348-8115-7-git-send-email-dillon.minfei@gmail.com/ > > [2] "drm/panel: s6e63m0: Switch to DBI abstraction for SPI" > https://lore.kernel.org/dri-devel/20210611214243.669892-1-linus.walleij@linaro.org/ > > [3] > https://lore.kernel.org/lkml/1590378348-8115-6-git-send-email-dillon.minfei@gmail.com/ > > v4: > - fix m68k-allmodconfig build error which reported by lkp, thanks. > - add Copyright 2018 David Lechner . > v3 link: > https://lore.kernel.org/lkml/1627013203-23099-1-git-send-email-dillon.minfei@gmail.com/ > > v3: > - add Fixes tags. > - collect reviewed-by tags from linus and jagan. > - replace DRM_ERROR() with dev_err() or drm_err(). > - remove kernel-doc markers from struct ili9341_config{}. > - reorder include headers. > - remove the struct device *dev from struct ili9341{}. > - restructure the ili9341_probe() function, add two ili9341_{dbi,dpi)_probe() > to make it more readable according to jagan's suggestion, thanks. > > for the full drm driver exist in drm/panel need Sam and Laurent's feedback. > so, not cover this part at this time, will be update later. > > v2 link: > https://lore.kernel.org/lkml/1626853288-31223-1-git-send-email-dillon.minfei@gmail.com/ > > v2: > - replace vcc regulator to bulk regulators in driver, from linus suggestion. > - fix dtbs_check warnings on ili9341 dts binding check. > - add bulk regulation node in ilitek,ili9341.yaml. > v1 link: > https://lore.kernel.org/lkml/1626430843-23823-1-git-send-email-dillon.minfei@gmail.com/ > > Dillon Min (3): > dt-bindings: display: panel: Add ilitek ili9341 panel bindings > ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding > drm/panel: Add ilitek ili9341 panel driver > > .../bindings/display/panel/ilitek,ili9341.yaml | 78 ++ > arch/arm/boot/dts/stm32f429-disco.dts | 2 +- > drivers/gpu/drm/panel/Kconfig | 12 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 792 +++++++++++++++++++++ > 5 files changed, 884 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml > create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9341.c > > -- > 1.9.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C19C4338F for ; Thu, 5 Aug 2021 08:57:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B22560F38 for ; Thu, 5 Aug 2021 08:57:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1B22560F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vy6SbmM4tTa3yInMCcUCeohGgwqT9UciXTzBB1JlkBo=; b=M/S0GUbzg+4hs2 QdqJcD20Fbj8o1FgI++ACqlc5W1054MhmG2YcRiJrgcqVTJWq1/MGB/fvMKOBKAhQ1iuvx1UF/rP7 CvRkxAkP7MChpe31+4QXrA+8xeXoaaJikQ7cabfSQ2oLekBL5ZkqyuBS50Vv6UrRp3sHnj6a2/KO4 C7YQ39LxZn0sRpFv9ZnzOnvWcGaEBcz6QLIy7jWLgRhk2WMAqIIowIj3SSqPb/OrlVezHSU0zODvH DNhBzcNIsYiZWA8zzUulgi8jxON9qr0cGVN0/E6I3IxXWex3fxyxR0PNeo0GaLPX7vZXvOjpEgAlg fneN9N/ax/RJdW3ipakw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBZAc-008jcy-Rb; Thu, 05 Aug 2021 08:56:07 +0000 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBZAY-008jat-K1 for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 08:56:04 +0000 Received: by mail-il1-x12f.google.com with SMTP id r1so4343454iln.6 for ; Thu, 05 Aug 2021 01:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gzmhApPj8HKqYSRf21gqLOYpahW4Hf0SxEjn45dssUM=; b=TOTf9psJWunXK13kHgtY8TiWSVBgt5Vzq7W3W8AQ6vfyunOVZEh0Qg4+gWIaULVC0g U3YhP0DGAJBbmfrkgJEG1F3KzQp2r86sDY8FA4NRqzJFZVplKdW1VXiss+CkUgIVFlHY 1AScnG9bhXvzFieoJZX0UsqLYilrjUrI/OQe5yDln9R0bPAl+gjRmsFEH07AqF30YWzf ITB/9oa3eXMfGlktXJpWD/8UHgFfsPXBT3zWtvvJCNHBegdJVKz1bP3KPigPDera7nA5 ViBZAMJxF0nDwi4qDAhUT12fx7jCiepxmlN3eWPhh+rNERgLcXgkD/ePxOYnQOfNRHWn nplg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gzmhApPj8HKqYSRf21gqLOYpahW4Hf0SxEjn45dssUM=; b=Stxfh2ISF9UL0l6sZKAcPhvcOQthC19IcoDqSRNUZAlGGoGXyItWhIv+LxhGqulaCb K1ulGVilr5m7Z49ZwJy8zjadv1hXfJCiryq5k7NKgI26eCGouF9OdACyBilW310tInTV 1akDID/13LLne9+2I9AjfeicR/Qqse9BcWDqYj40PCqEUEnjI1E32fS4b7CWATRSJKRR 2iDFeZF+b9xTPR0tYgkZh5VvSNd9gEaAPFU7dSRN9k1ztbgxlZYVB0GnJj6N/fecWxlf wEkFuSned15rqkt+QtVz7GMb+cHq6CpqAaUxVzbV8xuT0erGTVH9RTZR6yULNg2ImqMl xDnQ== X-Gm-Message-State: AOAM530wHgy8JTO60BT3mA+cTDqlycYgRgCaLVpRrfcP2AOfd7gYkvFz PtgGIIUur2mNzRBNEScUxcSDZXArlzARd/75qOc= X-Google-Smtp-Source: ABdhPJwE6/hjmNRFCTdKVvlJC0gbv70mRmlYMEcT7G0uSTjPkThFyytPoqX7/kmL1I7cGXdcgbE94sArd3GVW8kQtzU= X-Received: by 2002:a05:6e02:13b3:: with SMTP id h19mr244834ilo.218.1628153759089; Thu, 05 Aug 2021 01:55:59 -0700 (PDT) MIME-Version: 1.0 References: <1627098243-2742-1-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1627098243-2742-1-git-send-email-dillon.minfei@gmail.com> From: Dillon Min Date: Thu, 5 Aug 2021 16:55:23 +0800 Message-ID: Subject: Re: [PATCH v4 0/3] Add ilitek ili9341 panel driver To: laurent.pinchart@ideasonboard.com, Thierry Reding , Sam Ravnborg , Dave Airlie , Daniel Vetter , Rob Herring , Linus Walleij , Alexandre TORGUE , Maxime Coquelin , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Peter Robinson Cc: kbuild-all@lists.01.org, linux-stm32@st-md-mailman.stormreply.com, Linux ARM , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_015602_690577_6982B90F X-CRM114-Status: GOOD ( 28.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi All Just a gentle ping, thanks. Best regards. Dillon On Sat, 24 Jul 2021 at 11:44, wrote: > > From: Dillon Min > > Since the st,sf-tc240t-9370-t dts binding already exist in stm32f429-disco.dts > but, the panel driver didn't get accepted from mainline. it's time to submit > patch fot it. > > This driver can support two different interface by different dts bindings: > - spi+dpi, use spi to configure register, dpi for graphic data. > st,sf-tc240t-9370-t > - only spi, just like tiny/ili9341.c (actually, this part is copy from tiny) > adafruit,yx240qv29 > > I was submited the first patch last year, you can find it at [1]. > this patch has one major difference from that one, which is replace the low > level communication way, from spi_sync() to mipi_dbi_{command, > command_stackbuf}() interface, referred from Linus's patch [2]. > > both the two dpi/dbi interface was tested on stm32f429-disco board, if anyone > want to verify this patch, you need apply the clk patch for this board first, > you can get it from [3]. > > [1] "drm/panel: Add ilitek ili9341 panel driver" > https://lore.kernel.org/lkml/1590378348-8115-7-git-send-email-dillon.minfei@gmail.com/ > > [2] "drm/panel: s6e63m0: Switch to DBI abstraction for SPI" > https://lore.kernel.org/dri-devel/20210611214243.669892-1-linus.walleij@linaro.org/ > > [3] > https://lore.kernel.org/lkml/1590378348-8115-6-git-send-email-dillon.minfei@gmail.com/ > > v4: > - fix m68k-allmodconfig build error which reported by lkp, thanks. > - add Copyright 2018 David Lechner . > v3 link: > https://lore.kernel.org/lkml/1627013203-23099-1-git-send-email-dillon.minfei@gmail.com/ > > v3: > - add Fixes tags. > - collect reviewed-by tags from linus and jagan. > - replace DRM_ERROR() with dev_err() or drm_err(). > - remove kernel-doc markers from struct ili9341_config{}. > - reorder include headers. > - remove the struct device *dev from struct ili9341{}. > - restructure the ili9341_probe() function, add two ili9341_{dbi,dpi)_probe() > to make it more readable according to jagan's suggestion, thanks. > > for the full drm driver exist in drm/panel need Sam and Laurent's feedback. > so, not cover this part at this time, will be update later. > > v2 link: > https://lore.kernel.org/lkml/1626853288-31223-1-git-send-email-dillon.minfei@gmail.com/ > > v2: > - replace vcc regulator to bulk regulators in driver, from linus suggestion. > - fix dtbs_check warnings on ili9341 dts binding check. > - add bulk regulation node in ilitek,ili9341.yaml. > v1 link: > https://lore.kernel.org/lkml/1626430843-23823-1-git-send-email-dillon.minfei@gmail.com/ > > Dillon Min (3): > dt-bindings: display: panel: Add ilitek ili9341 panel bindings > ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding > drm/panel: Add ilitek ili9341 panel driver > > .../bindings/display/panel/ilitek,ili9341.yaml | 78 ++ > arch/arm/boot/dts/stm32f429-disco.dts | 2 +- > drivers/gpu/drm/panel/Kconfig | 12 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 792 +++++++++++++++++++++ > 5 files changed, 884 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml > create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9341.c > > -- > 1.9.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3C8C432BE for ; Thu, 5 Aug 2021 08:56:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22CF461029 for ; Thu, 5 Aug 2021 08:56:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 22CF461029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF6D66E40A; Thu, 5 Aug 2021 08:56:00 +0000 (UTC) Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by gabe.freedesktop.org (Postfix) with ESMTPS id C00D66E40A for ; Thu, 5 Aug 2021 08:55:59 +0000 (UTC) Received: by mail-il1-x136.google.com with SMTP id j18so4337236ile.8 for ; Thu, 05 Aug 2021 01:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gzmhApPj8HKqYSRf21gqLOYpahW4Hf0SxEjn45dssUM=; b=TOTf9psJWunXK13kHgtY8TiWSVBgt5Vzq7W3W8AQ6vfyunOVZEh0Qg4+gWIaULVC0g U3YhP0DGAJBbmfrkgJEG1F3KzQp2r86sDY8FA4NRqzJFZVplKdW1VXiss+CkUgIVFlHY 1AScnG9bhXvzFieoJZX0UsqLYilrjUrI/OQe5yDln9R0bPAl+gjRmsFEH07AqF30YWzf ITB/9oa3eXMfGlktXJpWD/8UHgFfsPXBT3zWtvvJCNHBegdJVKz1bP3KPigPDera7nA5 ViBZAMJxF0nDwi4qDAhUT12fx7jCiepxmlN3eWPhh+rNERgLcXgkD/ePxOYnQOfNRHWn nplg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gzmhApPj8HKqYSRf21gqLOYpahW4Hf0SxEjn45dssUM=; b=lcvv3aW+j+L8iVAeZcpDvPCsz/BCVBIzKibrG7LGFQtiSfC/SitFDirieOso/aBfM2 k5q7dIkyTRlRmtILxQJvM+vuGPjbXr26WJ4Cf+kSH+qAwG67BvNC3R+wB0AbdEwMC9xx /G2HCwGn2YST5fi7sYr1IzGwBkSVSlOPTS3K5T85jIgCOIy06b0B2H+vaBCWm7rl55Ek WilwifRs2xOuiAKsMgj6/enWjTnTh7m3WEny3N9iqmpGroqN+IODYjiK5czkm8xZNeR0 Y/k9MxFUJX2rLK09WO7XUAKrjlNoJwW9L42q8a3jcDj/pBDhY4bf58z8eJENdCcL8NPn 2E6g== X-Gm-Message-State: AOAM531ChQthHBbhuSTVlKMmsYFMycTm6+SBsfLEQtqpSkJbv9ZKKXUn rx0s8UesvbDsKcxPhQE5u4Y9KAPdJDjETlhP3dc= X-Google-Smtp-Source: ABdhPJwE6/hjmNRFCTdKVvlJC0gbv70mRmlYMEcT7G0uSTjPkThFyytPoqX7/kmL1I7cGXdcgbE94sArd3GVW8kQtzU= X-Received: by 2002:a05:6e02:13b3:: with SMTP id h19mr244834ilo.218.1628153759089; Thu, 05 Aug 2021 01:55:59 -0700 (PDT) MIME-Version: 1.0 References: <1627098243-2742-1-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1627098243-2742-1-git-send-email-dillon.minfei@gmail.com> From: Dillon Min Date: Thu, 5 Aug 2021 16:55:23 +0800 Message-ID: Subject: Re: [PATCH v4 0/3] Add ilitek ili9341 panel driver To: laurent.pinchart@ideasonboard.com, Thierry Reding , Sam Ravnborg , Dave Airlie , Daniel Vetter , Rob Herring , Linus Walleij , Alexandre TORGUE , Maxime Coquelin , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Peter Robinson Cc: kbuild-all@lists.01.org, linux-stm32@st-md-mailman.stormreply.com, Linux ARM , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi All Just a gentle ping, thanks. Best regards. Dillon On Sat, 24 Jul 2021 at 11:44, wrote: > > From: Dillon Min > > Since the st,sf-tc240t-9370-t dts binding already exist in stm32f429-disco.dts > but, the panel driver didn't get accepted from mainline. it's time to submit > patch fot it. > > This driver can support two different interface by different dts bindings: > - spi+dpi, use spi to configure register, dpi for graphic data. > st,sf-tc240t-9370-t > - only spi, just like tiny/ili9341.c (actually, this part is copy from tiny) > adafruit,yx240qv29 > > I was submited the first patch last year, you can find it at [1]. > this patch has one major difference from that one, which is replace the low > level communication way, from spi_sync() to mipi_dbi_{command, > command_stackbuf}() interface, referred from Linus's patch [2]. > > both the two dpi/dbi interface was tested on stm32f429-disco board, if anyone > want to verify this patch, you need apply the clk patch for this board first, > you can get it from [3]. > > [1] "drm/panel: Add ilitek ili9341 panel driver" > https://lore.kernel.org/lkml/1590378348-8115-7-git-send-email-dillon.minfei@gmail.com/ > > [2] "drm/panel: s6e63m0: Switch to DBI abstraction for SPI" > https://lore.kernel.org/dri-devel/20210611214243.669892-1-linus.walleij@linaro.org/ > > [3] > https://lore.kernel.org/lkml/1590378348-8115-6-git-send-email-dillon.minfei@gmail.com/ > > v4: > - fix m68k-allmodconfig build error which reported by lkp, thanks. > - add Copyright 2018 David Lechner . > v3 link: > https://lore.kernel.org/lkml/1627013203-23099-1-git-send-email-dillon.minfei@gmail.com/ > > v3: > - add Fixes tags. > - collect reviewed-by tags from linus and jagan. > - replace DRM_ERROR() with dev_err() or drm_err(). > - remove kernel-doc markers from struct ili9341_config{}. > - reorder include headers. > - remove the struct device *dev from struct ili9341{}. > - restructure the ili9341_probe() function, add two ili9341_{dbi,dpi)_probe() > to make it more readable according to jagan's suggestion, thanks. > > for the full drm driver exist in drm/panel need Sam and Laurent's feedback. > so, not cover this part at this time, will be update later. > > v2 link: > https://lore.kernel.org/lkml/1626853288-31223-1-git-send-email-dillon.minfei@gmail.com/ > > v2: > - replace vcc regulator to bulk regulators in driver, from linus suggestion. > - fix dtbs_check warnings on ili9341 dts binding check. > - add bulk regulation node in ilitek,ili9341.yaml. > v1 link: > https://lore.kernel.org/lkml/1626430843-23823-1-git-send-email-dillon.minfei@gmail.com/ > > Dillon Min (3): > dt-bindings: display: panel: Add ilitek ili9341 panel bindings > ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding > drm/panel: Add ilitek ili9341 panel driver > > .../bindings/display/panel/ilitek,ili9341.yaml | 78 ++ > arch/arm/boot/dts/stm32f429-disco.dts | 2 +- > drivers/gpu/drm/panel/Kconfig | 12 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 792 +++++++++++++++++++++ > 5 files changed, 884 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml > create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9341.c > > -- > 1.9.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8953659096367012675==" MIME-Version: 1.0 From: Dillon Min To: kbuild-all@lists.01.org Subject: Re: [PATCH v4 0/3] Add ilitek ili9341 panel driver Date: Thu, 05 Aug 2021 16:55:23 +0800 Message-ID: In-Reply-To: <1627098243-2742-1-git-send-email-dillon.minfei@gmail.com> List-Id: --===============8953659096367012675== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi All Just a gentle ping, thanks. Best regards. Dillon On Sat, 24 Jul 2021 at 11:44, wrote: > > From: Dillon Min > > Since the st,sf-tc240t-9370-t dts binding already exist in stm32f429-disc= o.dts > but, the panel driver didn't get accepted from mainline. it's time to sub= mit > patch fot it. > > This driver can support two different interface by different dts bindings: > - spi+dpi, use spi to configure register, dpi for graphic data. > st,sf-tc240t-9370-t > - only spi, just like tiny/ili9341.c (actually, this part is copy from ti= ny) > adafruit,yx240qv29 > > I was submited the first patch last year, you can find it at [1]. > this patch has one major difference from that one, which is replace the l= ow > level communication way, from spi_sync() to mipi_dbi_{command, > command_stackbuf}() interface, referred from Linus's patch [2]. > > both the two dpi/dbi interface was tested on stm32f429-disco board, if an= yone > want to verify this patch, you need apply the clk patch for this board fi= rst, > you can get it from [3]. > > [1] "drm/panel: Add ilitek ili9341 panel driver" > https://lore.kernel.org/lkml/1590378348-8115-7-git-send-email-dillon.minf= ei(a)gmail.com/ > > [2] "drm/panel: s6e63m0: Switch to DBI abstraction for SPI" > https://lore.kernel.org/dri-devel/20210611214243.669892-1-linus.walleij(a= )linaro.org/ > > [3] > https://lore.kernel.org/lkml/1590378348-8115-6-git-send-email-dillon.minf= ei(a)gmail.com/ > > v4: > - fix m68k-allmodconfig build error which reported by lkp, thanks. > - add Copyright 2018 David Lechner . > v3 link: > https://lore.kernel.org/lkml/1627013203-23099-1-git-send-email-dillon.min= fei(a)gmail.com/ > > v3: > - add Fixes tags. > - collect reviewed-by tags from linus and jagan. > - replace DRM_ERROR() with dev_err() or drm_err(). > - remove kernel-doc markers from struct ili9341_config{}. > - reorder include headers. > - remove the struct device *dev from struct ili9341{}. > - restructure the ili9341_probe() function, add two ili9341_{dbi,dpi)_pro= be() > to make it more readable according to jagan's suggestion, thanks. > > for the full drm driver exist in drm/panel need Sam and Laurent's feedbac= k. > so, not cover this part at this time, will be update later. > > v2 link: > https://lore.kernel.org/lkml/1626853288-31223-1-git-send-email-dillon.min= fei(a)gmail.com/ > > v2: > - replace vcc regulator to bulk regulators in driver, from linus suggesti= on. > - fix dtbs_check warnings on ili9341 dts binding check. > - add bulk regulation node in ilitek,ili9341.yaml. > v1 link: > https://lore.kernel.org/lkml/1626430843-23823-1-git-send-email-dillon.min= fei(a)gmail.com/ > > Dillon Min (3): > dt-bindings: display: panel: Add ilitek ili9341 panel bindings > ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding > drm/panel: Add ilitek ili9341 panel driver > > .../bindings/display/panel/ilitek,ili9341.yaml | 78 ++ > arch/arm/boot/dts/stm32f429-disco.dts | 2 +- > drivers/gpu/drm/panel/Kconfig | 12 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 792 +++++++++++++++= ++++++ > 5 files changed, 884 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/display/panel/ilite= k,ili9341.yaml > create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9341.c > > -- > 1.9.1 > --===============8953659096367012675==--