From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 384C4C63797 for ; Thu, 22 Jul 2021 07:10:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1147A60FF4 for ; Thu, 22 Jul 2021 07:10:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231365AbhGVGaQ (ORCPT ); Thu, 22 Jul 2021 02:30:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231352AbhGVGaM (ORCPT ); Thu, 22 Jul 2021 02:30:12 -0400 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11D9EC061575; Thu, 22 Jul 2021 00:10:48 -0700 (PDT) Received: by mail-il1-x133.google.com with SMTP id o8so4497785ilf.4; Thu, 22 Jul 2021 00:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9R4GbaLb7x9qYxl2DeK7+TAwKctElQJWbiwEkX5Kzhk=; b=drEckRBoqNpLV7KnpEQDsBNrKsL1z88qdiMBOWSN+inGx/IgPK3kZh7HLjL9eQIZCf gcWfT3C1MXhCkjax7snHv0jZb9oMnWW6KhFukvrSe0qSYniu1DeGbaBadXCECKfexHJx cwbDJA8SXdVqOSmAuNuW+1QE23ZLEJcaOc8FT/JGdyOMZvXV82BH67J4Td+pquObDxAc TR6wY660uZ0NHlZZgMQKG07iOZgqu8oi/t8RKbcKnKOpeL7XaB029Hx4zZQ0+44UsYgF aUdqhrlTqEeZLrnvU87iwYWINJwFzSrAS9cyj5M1NHUvmWKZEbgB0qDSZJJYNLi6Ea09 +eBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9R4GbaLb7x9qYxl2DeK7+TAwKctElQJWbiwEkX5Kzhk=; b=WSAFQqjXAfLr6rlEkLa8fOY7hWIquQYio5VeeiK+f5Rk9PYN0mVVOlhOkAxOqS2M1p ND6cB0rKeukPZUdXKoK1+HrOiJjO8kRGsugtgy2csczEIzLloUUMLlkpxLlgwBC+TbX9 4IGTLKWEJ5CVVUT6HzmcbhGUmDAbhsHx4sClLYBPXacKjH/XGjNzFrib6oS0E51yGs76 CWiq7Jf+KuAE2TVYJA4DdlWJPuk0GfG88Csyrk7zi4+ok9SLYgFiCvYgMBDUoNffMz5o 21WeMHycsgXeHC7Que1AK/Jj0sOpBXuDrLPreJYIfYdVZf1iL8vpoZl5AbwghD5e8N0N tBnw== X-Gm-Message-State: AOAM530b35w03XK7bzYef+15O9/E7KHLPdgxZfkX8eP9JI5Z3G/BhrP1 JDsjUYDDD81ZWzNUIvKDSKwU3vAjmYhdiIPZ55k= X-Google-Smtp-Source: ABdhPJwTjhAu6xTfG+QL54ZvXhMm9gqmN62x3piyRaO10skkcefHcASreEjbQs9lCGvv4P+2iukaRJZFPQezISZZX9g= X-Received: by 2002:a92:ddcf:: with SMTP id d15mr13786756ilr.184.1626937847507; Thu, 22 Jul 2021 00:10:47 -0700 (PDT) MIME-Version: 1.0 References: <1626853288-31223-1-git-send-email-dillon.minfei@gmail.com> <1626853288-31223-4-git-send-email-dillon.minfei@gmail.com> <8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org> <1e4743b0-250f-975a-f83d-5d000c6496e3@tronnes.org> In-Reply-To: <1e4743b0-250f-975a-f83d-5d000c6496e3@tronnes.org> From: Dillon Min Date: Thu, 22 Jul 2021 15:10:11 +0800 Message-ID: Subject: Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Cc: Thierry Reding , Sam Ravnborg , Dave Airlie , Daniel Vetter , Rob Herring , Linus Walleij , Alexandre TORGUE , Maxime Coquelin , Doug Anderson , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Noralf, On Thu, 22 Jul 2021 at 15:03, Noralf Tr=C3=B8nnes wrot= e: > > > > Den 22.07.2021 04.07, skrev Dillon Min: > > Hi Noralf > > > > Thanks for your time to review my patch. > > > > On Thu, 22 Jul 2021 at 01:42, Noralf Tr=C3=B8nnes = wrote: > >> > >> > >> > >> Den 21.07.2021 09.41, skrev dillon.minfei@gmail.com: > >>> From: Dillon Min > >>> > >>> This driver combine tiny/ili9341.c mipi_dbi_interface driver > >>> with mipi_dpi_interface driver, can support ili9341 with serial > >>> mode or parallel rgb interface mode by register configuration. > >>> > >>> Cc: Linus Walleij > >>> Signed-off-by: Dillon Min > >>> --- > >> > >>> +static const struct of_device_id ili9341_of_match[] =3D { > >>> + { > >>> + .compatible =3D "st,sf-tc240t-9370-t", > >>> + .data =3D &ili9341_stm32f429_disco_data, > >>> + }, > >>> + { > >>> + /* porting from tiny/ili9341.c > >>> + * for original mipi dbi compitable > >>> + */ > >>> + .compatible =3D "adafruit,yx240qv29", > >> > >> I don't understand this, now there will be 2 drivers that support the > >> same display? > > > > There is no reason to create two drivers to support the same display. > > > > To support only-dbi and dbi+dpi panel at drm/panel or drm/tiny both > > fine with me. > > > >> > >> AFAICT drm/tiny/ili9341.c is just copied into this driver, is the plan > >> to remove the tiny/ driver? If so I couldn't see this mentioned anywhe= re. > > > > Yes, I'd like to merge the code from drm/tiny/ili9341.c to this driver > > (to make a single driver to support different bus). > > > > I have two purpose to extend the feature drm/tiny/ili9341.c > > > > - keep compatible =3D "adafruit,yx240qv29", add bus mode dts bindings (= panel_bus) > > to define the interface which host wants to use. such as > > panel_bus=3D"dbi" or "rgb" > > or "i80" for this case, i will add dpi code to drm/tiny/ili9341.c. > > > > - merge tiny/ili9341.c to this driver,remove drm/tiny/ili9341.c, add > > new dts compatible > > string to support other interfaces. just like what i'm doing now. > > > > I have no idea about your plan on drm/tiny drivers, actually some of > > these panels under > > the diny folder can support both dbi and dbi+dpi (much faster, need > > more pins). no > > doubt the requirement to support dpi is always there. > > > > What is your preference? > > > > I have no plans for tiny/, it's just a place to put tiny DRM drivers of > all sorts. Thanks for clarifying. > > Whether or not to have "full" DRM drivers in panel/ is up to Sam and > Laurent I guess, currently there's only drm_panel drivers in there. I > have no objections to doing that though. > > I just wanted to make sure we don't have 2 drivers for the same display. Sure, agree with you, sorry for not mentioning it in the cover letter. I'm waiting for Sam and Laurent's feedback, then submit v3 after that. Best regards. Dillon > > Noralf. > > > Thanks & Regards > > Dillon > > > >> > >> Noralf. > >> > >>> + .data =3D NULL, > >>> + }, > >>> +}; > >>> +MODULE_DEVICE_TABLE(of, ili9341_of_match); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F20B6C63793 for ; Thu, 22 Jul 2021 07:12:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1D0E61279 for ; Thu, 22 Jul 2021 07:12:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1D0E61279 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V0YnI1CmHSGRf5v7aigHmhWyjIVVaodH9bq/C2P09JI=; b=xFq8iypRoqu1nQ i3OVufLL9+dh1Mn+Ne9TFJkiNMZSapM13/brTo/l2RdBO7/B9+S+A8Gw9t1oDCOzsxqJok5ZWDfn4 kif5/vfSL5vrXwInvRI/yQJmmswUJ7Yh6weGqLvw2ogl02LNdHEajMevyq/FkxNiWghxL6lj1dcYG 9fzx9ufbWlowtN5DUOtAOT4K9Kg3nOew5mUo8WvhGhBFcPxtnVUnGhgWeBURDv4PWw3qWOYejov1o X/NsqMKV0hEqujKZix5NI8+DJ3UgTU2fSXJvLijBYmsyxSoXxY149MngEKuvz3Roy99jPu78/8r+m 6X022of+8k9TNkMadYTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6SrC-000TR5-AT; Thu, 22 Jul 2021 07:10:58 +0000 Received: from mail-il1-x130.google.com ([2607:f8b0:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6Sr7-000TPE-GE for linux-arm-kernel@lists.infradead.org; Thu, 22 Jul 2021 07:10:55 +0000 Received: by mail-il1-x130.google.com with SMTP id y6so4445151ilj.13 for ; Thu, 22 Jul 2021 00:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9R4GbaLb7x9qYxl2DeK7+TAwKctElQJWbiwEkX5Kzhk=; b=drEckRBoqNpLV7KnpEQDsBNrKsL1z88qdiMBOWSN+inGx/IgPK3kZh7HLjL9eQIZCf gcWfT3C1MXhCkjax7snHv0jZb9oMnWW6KhFukvrSe0qSYniu1DeGbaBadXCECKfexHJx cwbDJA8SXdVqOSmAuNuW+1QE23ZLEJcaOc8FT/JGdyOMZvXV82BH67J4Td+pquObDxAc TR6wY660uZ0NHlZZgMQKG07iOZgqu8oi/t8RKbcKnKOpeL7XaB029Hx4zZQ0+44UsYgF aUdqhrlTqEeZLrnvU87iwYWINJwFzSrAS9cyj5M1NHUvmWKZEbgB0qDSZJJYNLi6Ea09 +eBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9R4GbaLb7x9qYxl2DeK7+TAwKctElQJWbiwEkX5Kzhk=; b=OY8K0+A/48aVpBkQIlFXcri5xfyOZ9kO6GADWttHbz41zbb0Ak4Gk6k2CJCcNVeTF6 2sYYBK3Cy1WfDywZ4k4k4OcxabuKcVhxveNOZNmpOM5GDaN2p36qFVYdSKV2rXSsKQFf SMbGZDlMFq3TUiOe70/HTwpwJDhF3KaSCguDX9xur1DlLtGntu5T0u74bXEFjNEKOqXL DZCuoYXhmXd6QXMqMKW9Rx7QP4LpzNwff7GsGaE7vn8qaog0RyNSE0HTi62a27ixlcoG pipwaxkgWfTEEXtSklccBI8cpG9+InCUzOwgYj9q5VtQ5y1DqYEnKtnMX8TgFVpGOh15 ViVQ== X-Gm-Message-State: AOAM533MANm9iW76Jhs10gWF+zGwwEpSGDCAlq4lqgHgcfj3Qk1mMQP5 byRdLbleHZPuea0Z9WzSo5C1ao3y8g6TRzAmoUw= X-Google-Smtp-Source: ABdhPJwTjhAu6xTfG+QL54ZvXhMm9gqmN62x3piyRaO10skkcefHcASreEjbQs9lCGvv4P+2iukaRJZFPQezISZZX9g= X-Received: by 2002:a92:ddcf:: with SMTP id d15mr13786756ilr.184.1626937847507; Thu, 22 Jul 2021 00:10:47 -0700 (PDT) MIME-Version: 1.0 References: <1626853288-31223-1-git-send-email-dillon.minfei@gmail.com> <1626853288-31223-4-git-send-email-dillon.minfei@gmail.com> <8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org> <1e4743b0-250f-975a-f83d-5d000c6496e3@tronnes.org> In-Reply-To: <1e4743b0-250f-975a-f83d-5d000c6496e3@tronnes.org> From: Dillon Min Date: Thu, 22 Jul 2021 15:10:11 +0800 Message-ID: Subject: Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Cc: Thierry Reding , Sam Ravnborg , Dave Airlie , Daniel Vetter , Rob Herring , Linus Walleij , Alexandre TORGUE , Maxime Coquelin , Doug Anderson , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210722_001053_569557_A11852A8 X-CRM114-Status: GOOD ( 37.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTm9yYWxmLAoKT24gVGh1LCAyMiBKdWwgMjAyMSBhdCAxNTowMywgTm9yYWxmIFRyw7hubmVz IDxub3JhbGZAdHJvbm5lcy5vcmc+IHdyb3RlOgo+Cj4KPgo+IERlbiAyMi4wNy4yMDIxIDA0LjA3 LCBza3JldiBEaWxsb24gTWluOgo+ID4gSGkgTm9yYWxmCj4gPgo+ID4gVGhhbmtzIGZvciB5b3Vy IHRpbWUgdG8gcmV2aWV3IG15IHBhdGNoLgo+ID4KPiA+IE9uIFRodSwgMjIgSnVsIDIwMjEgYXQg MDE6NDIsIE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPiB3cm90ZToKPiA+Pgo+ ID4+Cj4gPj4KPiA+PiBEZW4gMjEuMDcuMjAyMSAwOS40MSwgc2tyZXYgZGlsbG9uLm1pbmZlaUBn bWFpbC5jb206Cj4gPj4+IEZyb206IERpbGxvbiBNaW4gPGRpbGxvbi5taW5mZWlAZ21haWwuY29t Pgo+ID4+Pgo+ID4+PiBUaGlzIGRyaXZlciBjb21iaW5lIHRpbnkvaWxpOTM0MS5jIG1pcGlfZGJp X2ludGVyZmFjZSBkcml2ZXIKPiA+Pj4gd2l0aCBtaXBpX2RwaV9pbnRlcmZhY2UgZHJpdmVyLCBj YW4gc3VwcG9ydCBpbGk5MzQxIHdpdGggc2VyaWFsCj4gPj4+IG1vZGUgb3IgcGFyYWxsZWwgcmdi IGludGVyZmFjZSBtb2RlIGJ5IHJlZ2lzdGVyIGNvbmZpZ3VyYXRpb24uCj4gPj4+Cj4gPj4+IENj OiBMaW51cyBXYWxsZWlqIDxsaW51cy53YWxsZWlqQGxpbmFyby5vcmc+Cj4gPj4+IFNpZ25lZC1v ZmYtYnk6IERpbGxvbiBNaW4gPGRpbGxvbi5taW5mZWlAZ21haWwuY29tPgo+ID4+PiAtLS0KPiA+ Pgo+ID4+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgaWxpOTM0MV9vZl9tYXRj aFtdID0gewo+ID4+PiArICAgICB7Cj4gPj4+ICsgICAgICAgICAgICAgLmNvbXBhdGlibGUgPSAi c3Qsc2YtdGMyNDB0LTkzNzAtdCIsCj4gPj4+ICsgICAgICAgICAgICAgLmRhdGEgPSAmaWxpOTM0 MV9zdG0zMmY0MjlfZGlzY29fZGF0YSwKPiA+Pj4gKyAgICAgfSwKPiA+Pj4gKyAgICAgewo+ID4+ PiArICAgICAgICAgICAgIC8qIHBvcnRpbmcgZnJvbSB0aW55L2lsaTkzNDEuYwo+ID4+PiArICAg ICAgICAgICAgICAqIGZvciBvcmlnaW5hbCBtaXBpIGRiaSBjb21waXRhYmxlCj4gPj4+ICsgICAg ICAgICAgICAgICovCj4gPj4+ICsgICAgICAgICAgICAgLmNvbXBhdGlibGUgPSAiYWRhZnJ1aXQs eXgyNDBxdjI5IiwKPiA+Pgo+ID4+IEkgZG9uJ3QgdW5kZXJzdGFuZCB0aGlzLCBub3cgdGhlcmUg d2lsbCBiZSAyIGRyaXZlcnMgdGhhdCBzdXBwb3J0IHRoZQo+ID4+IHNhbWUgZGlzcGxheT8KPiA+ Cj4gPiBUaGVyZSBpcyBubyByZWFzb24gdG8gY3JlYXRlIHR3byBkcml2ZXJzIHRvIHN1cHBvcnQg dGhlIHNhbWUgZGlzcGxheS4KPiA+Cj4gPiBUbyBzdXBwb3J0IG9ubHktZGJpIGFuZCBkYmkrZHBp IHBhbmVsIGF0IGRybS9wYW5lbCBvciBkcm0vdGlueSBib3RoCj4gPiBmaW5lIHdpdGggbWUuCj4g Pgo+ID4+Cj4gPj4gQUZBSUNUIGRybS90aW55L2lsaTkzNDEuYyBpcyBqdXN0IGNvcGllZCBpbnRv IHRoaXMgZHJpdmVyLCBpcyB0aGUgcGxhbgo+ID4+IHRvIHJlbW92ZSB0aGUgdGlueS8gZHJpdmVy PyBJZiBzbyBJIGNvdWxkbid0IHNlZSB0aGlzIG1lbnRpb25lZCBhbnl3aGVyZS4KPiA+Cj4gPiBZ ZXMsIEknZCBsaWtlIHRvIG1lcmdlIHRoZSBjb2RlIGZyb20gZHJtL3RpbnkvaWxpOTM0MS5jIHRv IHRoaXMgZHJpdmVyCj4gPiAodG8gbWFrZSBhIHNpbmdsZSBkcml2ZXIgdG8gc3VwcG9ydCBkaWZm ZXJlbnQgYnVzKS4KPiA+Cj4gPiBJIGhhdmUgdHdvIHB1cnBvc2UgdG8gZXh0ZW5kIHRoZSBmZWF0 dXJlIGRybS90aW55L2lsaTkzNDEuYwo+ID4KPiA+IC0ga2VlcCBjb21wYXRpYmxlID0gImFkYWZy dWl0LHl4MjQwcXYyOSIsIGFkZCBidXMgbW9kZSBkdHMgYmluZGluZ3MgKHBhbmVsX2J1cykKPiA+ ICAgdG8gZGVmaW5lIHRoZSBpbnRlcmZhY2Ugd2hpY2ggaG9zdCB3YW50cyB0byB1c2UuIHN1Y2gg YXMKPiA+IHBhbmVsX2J1cz0iZGJpIiBvciAicmdiIgo+ID4gICBvciAiaTgwIiBmb3IgdGhpcyBj YXNlLCBpIHdpbGwgYWRkIGRwaSBjb2RlIHRvIGRybS90aW55L2lsaTkzNDEuYy4KPiA+Cj4gPiAt IG1lcmdlIHRpbnkvaWxpOTM0MS5jIHRvIHRoaXMgZHJpdmVyLHJlbW92ZSBkcm0vdGlueS9pbGk5 MzQxLmMsIGFkZAo+ID4gbmV3IGR0cyBjb21wYXRpYmxlCj4gPiAgIHN0cmluZyB0byBzdXBwb3J0 IG90aGVyIGludGVyZmFjZXMuIGp1c3QgbGlrZSB3aGF0IGknbSBkb2luZyBub3cuCj4gPgo+ID4g SSBoYXZlIG5vIGlkZWEgYWJvdXQgeW91ciBwbGFuIG9uIGRybS90aW55IGRyaXZlcnMsIGFjdHVh bGx5IHNvbWUgb2YKPiA+IHRoZXNlIHBhbmVscyB1bmRlcgo+ID4gdGhlIGRpbnkgZm9sZGVyIGNh biBzdXBwb3J0IGJvdGggZGJpIGFuZCBkYmkrZHBpIChtdWNoIGZhc3RlciwgbmVlZAo+ID4gbW9y ZSBwaW5zKS4gbm8KPiA+IGRvdWJ0IHRoZSByZXF1aXJlbWVudCB0byBzdXBwb3J0IGRwaSBpcyBh bHdheXMgdGhlcmUuCj4gPgo+ID4gV2hhdCBpcyB5b3VyIHByZWZlcmVuY2U/Cj4gPgo+Cj4gSSBo YXZlIG5vIHBsYW5zIGZvciB0aW55LywgaXQncyBqdXN0IGEgcGxhY2UgdG8gcHV0IHRpbnkgRFJN IGRyaXZlcnMgb2YKPiBhbGwgc29ydHMuCgpUaGFua3MgZm9yIGNsYXJpZnlpbmcuCgo+Cj4gV2hl dGhlciBvciBub3QgdG8gaGF2ZSAiZnVsbCIgRFJNIGRyaXZlcnMgaW4gcGFuZWwvIGlzIHVwIHRv IFNhbSBhbmQKPiBMYXVyZW50IEkgZ3Vlc3MsIGN1cnJlbnRseSB0aGVyZSdzIG9ubHkgZHJtX3Bh bmVsIGRyaXZlcnMgaW4gdGhlcmUuIEkKPiBoYXZlIG5vIG9iamVjdGlvbnMgdG8gZG9pbmcgdGhh dCB0aG91Z2guCj4KPiBJIGp1c3Qgd2FudGVkIHRvIG1ha2Ugc3VyZSB3ZSBkb24ndCBoYXZlIDIg ZHJpdmVycyBmb3IgdGhlIHNhbWUgZGlzcGxheS4KClN1cmUsIGFncmVlIHdpdGggeW91LCBzb3Jy eSBmb3Igbm90IG1lbnRpb25pbmcgaXQgaW4gdGhlIGNvdmVyIGxldHRlci4KSSdtIHdhaXRpbmcg Zm9yIFNhbSBhbmQgTGF1cmVudCdzIGZlZWRiYWNrLCB0aGVuIHN1Ym1pdCB2MyBhZnRlciB0aGF0 LgoKQmVzdCByZWdhcmRzLgpEaWxsb24KCj4KPiBOb3JhbGYuCj4KPiA+IFRoYW5rcyAmIFJlZ2Fy ZHMKPiA+IERpbGxvbgo+ID4KPiA+Pgo+ID4+IE5vcmFsZi4KPiA+Pgo+ID4+PiArICAgICAgICAg ICAgIC5kYXRhID0gTlVMTCwKPiA+Pj4gKyAgICAgfSwKPiA+Pj4gK307Cj4gPj4+ICtNT0RVTEVf REVWSUNFX1RBQkxFKG9mLCBpbGk5MzQxX29mX21hdGNoKTsKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 207C0C63798 for ; Thu, 22 Jul 2021 07:10:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0A4E61279 for ; Thu, 22 Jul 2021 07:10:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0A4E61279 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EA6F6EC71; Thu, 22 Jul 2021 07:10:49 +0000 (UTC) Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1CE406EC54 for ; Thu, 22 Jul 2021 07:10:48 +0000 (UTC) Received: by mail-il1-x12f.google.com with SMTP id z1so4549310ils.0 for ; Thu, 22 Jul 2021 00:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9R4GbaLb7x9qYxl2DeK7+TAwKctElQJWbiwEkX5Kzhk=; b=drEckRBoqNpLV7KnpEQDsBNrKsL1z88qdiMBOWSN+inGx/IgPK3kZh7HLjL9eQIZCf gcWfT3C1MXhCkjax7snHv0jZb9oMnWW6KhFukvrSe0qSYniu1DeGbaBadXCECKfexHJx cwbDJA8SXdVqOSmAuNuW+1QE23ZLEJcaOc8FT/JGdyOMZvXV82BH67J4Td+pquObDxAc TR6wY660uZ0NHlZZgMQKG07iOZgqu8oi/t8RKbcKnKOpeL7XaB029Hx4zZQ0+44UsYgF aUdqhrlTqEeZLrnvU87iwYWINJwFzSrAS9cyj5M1NHUvmWKZEbgB0qDSZJJYNLi6Ea09 +eBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9R4GbaLb7x9qYxl2DeK7+TAwKctElQJWbiwEkX5Kzhk=; b=ru+tnNpR8uq4bTNtagLqA/VDNFn+hsh+37oQ2jRaYfN8gs8lG8g2WcASjXA1dvZQUW 02orzmfQUgrmIkOJQdQwoRGRMBn6M4i3jbhazv8YnmDKF4cqI5f1b9d+2dXQa9IPgGzI SJNo0O98YW0G9DcpEefhQVYeCQrh/ctObcfuCIB4Y3vaUdSbBlwmP5wQLG2mZSsN/8nK negELm0iZ5TWEnJr94jwpNFO0B4q2bjk5BEwVGnSsPK4MT83HUlsWjsXuWrl3hwotsfw 2yIznOZHLAIWXq2fkF06x5R1GigbxPqErveOKnSpsntO6ekn96ceOwbL8QTob9rym4mp JI1Q== X-Gm-Message-State: AOAM533cG2CBmbhOrefF1HwUshZNo2k+74xC3K+z9B5/77pH87Uigpnz vtfmo6d5uwsyjn6994N6el3B3NMACDgWkmR4EyU= X-Google-Smtp-Source: ABdhPJwTjhAu6xTfG+QL54ZvXhMm9gqmN62x3piyRaO10skkcefHcASreEjbQs9lCGvv4P+2iukaRJZFPQezISZZX9g= X-Received: by 2002:a92:ddcf:: with SMTP id d15mr13786756ilr.184.1626937847507; Thu, 22 Jul 2021 00:10:47 -0700 (PDT) MIME-Version: 1.0 References: <1626853288-31223-1-git-send-email-dillon.minfei@gmail.com> <1626853288-31223-4-git-send-email-dillon.minfei@gmail.com> <8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org> <1e4743b0-250f-975a-f83d-5d000c6496e3@tronnes.org> In-Reply-To: <1e4743b0-250f-975a-f83d-5d000c6496e3@tronnes.org> From: Dillon Min Date: Thu, 22 Jul 2021 15:10:11 +0800 Message-ID: Subject: Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Maxime Coquelin , Dave Airlie , Linux Kernel Mailing List , Alexandre TORGUE , "open list:DRM PANEL DRIVERS" , Doug Anderson , Rob Herring , Thierry Reding , Sam Ravnborg , linux-stm32@st-md-mailman.stormreply.com, Linux ARM Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Noralf, On Thu, 22 Jul 2021 at 15:03, Noralf Tr=C3=B8nnes wrot= e: > > > > Den 22.07.2021 04.07, skrev Dillon Min: > > Hi Noralf > > > > Thanks for your time to review my patch. > > > > On Thu, 22 Jul 2021 at 01:42, Noralf Tr=C3=B8nnes = wrote: > >> > >> > >> > >> Den 21.07.2021 09.41, skrev dillon.minfei@gmail.com: > >>> From: Dillon Min > >>> > >>> This driver combine tiny/ili9341.c mipi_dbi_interface driver > >>> with mipi_dpi_interface driver, can support ili9341 with serial > >>> mode or parallel rgb interface mode by register configuration. > >>> > >>> Cc: Linus Walleij > >>> Signed-off-by: Dillon Min > >>> --- > >> > >>> +static const struct of_device_id ili9341_of_match[] =3D { > >>> + { > >>> + .compatible =3D "st,sf-tc240t-9370-t", > >>> + .data =3D &ili9341_stm32f429_disco_data, > >>> + }, > >>> + { > >>> + /* porting from tiny/ili9341.c > >>> + * for original mipi dbi compitable > >>> + */ > >>> + .compatible =3D "adafruit,yx240qv29", > >> > >> I don't understand this, now there will be 2 drivers that support the > >> same display? > > > > There is no reason to create two drivers to support the same display. > > > > To support only-dbi and dbi+dpi panel at drm/panel or drm/tiny both > > fine with me. > > > >> > >> AFAICT drm/tiny/ili9341.c is just copied into this driver, is the plan > >> to remove the tiny/ driver? If so I couldn't see this mentioned anywhe= re. > > > > Yes, I'd like to merge the code from drm/tiny/ili9341.c to this driver > > (to make a single driver to support different bus). > > > > I have two purpose to extend the feature drm/tiny/ili9341.c > > > > - keep compatible =3D "adafruit,yx240qv29", add bus mode dts bindings (= panel_bus) > > to define the interface which host wants to use. such as > > panel_bus=3D"dbi" or "rgb" > > or "i80" for this case, i will add dpi code to drm/tiny/ili9341.c. > > > > - merge tiny/ili9341.c to this driver,remove drm/tiny/ili9341.c, add > > new dts compatible > > string to support other interfaces. just like what i'm doing now. > > > > I have no idea about your plan on drm/tiny drivers, actually some of > > these panels under > > the diny folder can support both dbi and dbi+dpi (much faster, need > > more pins). no > > doubt the requirement to support dpi is always there. > > > > What is your preference? > > > > I have no plans for tiny/, it's just a place to put tiny DRM drivers of > all sorts. Thanks for clarifying. > > Whether or not to have "full" DRM drivers in panel/ is up to Sam and > Laurent I guess, currently there's only drm_panel drivers in there. I > have no objections to doing that though. > > I just wanted to make sure we don't have 2 drivers for the same display. Sure, agree with you, sorry for not mentioning it in the cover letter. I'm waiting for Sam and Laurent's feedback, then submit v3 after that. Best regards. Dillon > > Noralf. > > > Thanks & Regards > > Dillon > > > >> > >> Noralf. > >> > >>> + .data =3D NULL, > >>> + }, > >>> +}; > >>> +MODULE_DEVICE_TABLE(of, ili9341_of_match);