From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E4F1C433E0 for ; Thu, 14 May 2020 13:08:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73BB220728 for ; Thu, 14 May 2020 13:08:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HQy57Gtt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbgENNIX (ORCPT ); Thu, 14 May 2020 09:08:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725955AbgENNIR (ORCPT ); Thu, 14 May 2020 09:08:17 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1112C061A0C; Thu, 14 May 2020 06:08:16 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id o5so1064720iow.8; Thu, 14 May 2020 06:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TxjLQAmlgCmIbW66ttakmR+UHsu55ZGYYjiNgQ7pD60=; b=HQy57GttiwVxh24sQLfeiQngcOiErLC6lrc6A6arkVum1pGd0PXCrQaHvOCK4hPNEV b/059ZwlWVA1AS8FK1q2/gCJIeug5/mReyn6myQQGKj7Nqz7CVRv86DNFSRbqqL9jNJu tITMdAKorHxeF7YvlIBXB8sc7+tzC2Jw9Tf81bsZ6FJbcXdDfUt6nlqKXBjb5tQmn5MB gsR5CUzH/zKAUZsVkX976vv3QKAm1v8PnXFZ2eAaurKTEVbK4xwSxyYq0RD28bfWf5Cm c7yPr6SgCzeFtV1ZHtYdDrrDUR4DC+KkcElHzh4hDhUaeG4VHhyQV+JNQPmJwrKZiy5d Dj2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TxjLQAmlgCmIbW66ttakmR+UHsu55ZGYYjiNgQ7pD60=; b=uDIITVugJ18J9MzAI1K+7uH1u3m1je5J4rJ+RkFXN/vQGs5ORJGQUAdFRVwL8CvoUo s9W/PI70ZJjjQr+sk9hHXil6NBfoDeOuhRIzULjy5811CxksvyX+qQPt1UI3UffBzwV4 JkoyDMsEIy1/isXnh9zp8w70brsnypgRgsR6tmU+hlBpeCGRGS7Cph9lmNAt6t+J3ZQJ 0BfH8CDTbQtNf6yaLQP0QJRlDC7NxkgvnL6yMlud9w/f7MQOvtukjSfz5B+lRRte3ycS WgZRFzVvlwfUSyHRGIc4RWHgBLS0WGIP8iJP3HooxRQDYXXv8XU1ea48WK86PWVCJXAq E4vQ== X-Gm-Message-State: AOAM533KS1NSUVIvgJ/r7+LxyfLkzvAIGEZ5mnRVXLJv9oYeMQapcr2P jTmstuOgHgN7+KYVy4ztAmw536EefhUULf30/n8= X-Google-Smtp-Source: ABdhPJxFXm/snfV7f+PaeEk0/JpSTrHSkPZMuSqd6hBKK/zxQapVp8rf2U8UIu+qvc9Q33J56Hi8hFlnpuvp0XR2Wlk= X-Received: by 2002:a5d:8b8e:: with SMTP id p14mr3979084iol.110.1589461696306; Thu, 14 May 2020 06:08:16 -0700 (PDT) MIME-Version: 1.0 References: <1589267017-17294-1-git-send-email-dillon.minfei@gmail.com> <1589267017-17294-4-git-send-email-dillon.minfei@gmail.com> In-Reply-To: From: dillon min Date: Thu, 14 May 2020 21:07:40 +0800 Message-ID: Subject: Re: [PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board To: Alexandre Torgue Cc: Linus Walleij , Rob Herring , Maxime Coquelin , "thierry.reding@gmail.com" , Sam Ravnborg , Dave Airlie , Daniel Vetter , Michael Turquette , Stephen Boyd , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , "linux-kernel@vger.kernel.org" , "open list:DRM PANEL DRIVERS" , linux-clk Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, On Thu, May 14, 2020 at 8:53 PM Alexandre Torgue wrote: > > > > On 5/14/20 10:24 AM, Linus Walleij wrote: > > On Tue, May 12, 2020 at 9:04 AM wrote: > > > >> From: dillon min > >> > >> Enable the ltdc & ili9341 on stm32429-disco board. > >> > >> Signed-off-by: dillon min > > > > This mostly looks good but... > > > >> +&spi5 { > >> + status = "okay"; > >> + pinctrl-0 = <&spi5_pins>; > >> + pinctrl-names = "default"; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; > >> + dmas = <&dma2 3 2 0x400 0x0>, > >> + <&dma2 4 2 0x400 0x0>; > >> + dma-names = "rx", "tx"; > > > > These DMA assignments seem to be SoC things and should > > rather be in the DTS(I) file where &spi5 is defined, right? > > stm32f429.dtsi I suppose? > > I agree with Linus, DMA have to be defined in SoC dtsi. And if a board > doesn't want to use it, we use the "delete-property". Yes, will move to Soc dtsi in next submits. i'm working on write a v4l2-m2m driver for dma2d of stm32 to support pixel conversion alpha blending between foreground and background graphics. as you know, some soc's engineer trying to add this function to drm system. do you know st's planning about soc's hardware accelerator driver on stm32mp? such as chrom-art, will add to drm subsystem via ioctl to access, or to v4l2, thanks. > > > > > It is likely the same no matter which device is using spi5. > > > > Yours, > > Linus Walleij > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 797AAC433E0 for ; Thu, 14 May 2020 13:08:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4384A206DA for ; Thu, 14 May 2020 13:08:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DIE9fhlY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HQy57Gtt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4384A206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q7HKZzJsQ9wJRl59Y2hrdL7DIUDClYi0l6kZeFWOPxk=; b=DIE9fhlYoo2NNV rjuJuJc/xgEnNrOp6/VCxlJ6GsT7M5NYnEm+6pC6h4a2adRzdLi7glLnDLH+h0pmLmhz9TD7ppYXZ f5Z3gBYhrjIWEBGrT3pbC3zTENxKTorCqmIhxgA11PORMqcemXd4nU14f5Q5J6wZyXLzs6Rv9wLu0 r5MTl7M421a5lYLicae0UnxuMsGSlNeXvwNUvQqIIottFstEROpDRPUrxghQgSHTuVrR6d5gWEeBT +uf4GCI6J3F3HPENGucQhdyKjGvmmNo3m6C0UWhVp669i7xsgXXsgqs8icQ7bVYlSVf6gBe1DSw9S evWe3cRsLLVAH2qiNcOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZDb2-0001tI-Lu; Thu, 14 May 2020 13:08:20 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZDaz-0001sy-KU for linux-arm-kernel@lists.infradead.org; Thu, 14 May 2020 13:08:18 +0000 Received: by mail-io1-xd41.google.com with SMTP id f3so2928768ioj.1 for ; Thu, 14 May 2020 06:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TxjLQAmlgCmIbW66ttakmR+UHsu55ZGYYjiNgQ7pD60=; b=HQy57GttiwVxh24sQLfeiQngcOiErLC6lrc6A6arkVum1pGd0PXCrQaHvOCK4hPNEV b/059ZwlWVA1AS8FK1q2/gCJIeug5/mReyn6myQQGKj7Nqz7CVRv86DNFSRbqqL9jNJu tITMdAKorHxeF7YvlIBXB8sc7+tzC2Jw9Tf81bsZ6FJbcXdDfUt6nlqKXBjb5tQmn5MB gsR5CUzH/zKAUZsVkX976vv3QKAm1v8PnXFZ2eAaurKTEVbK4xwSxyYq0RD28bfWf5Cm c7yPr6SgCzeFtV1ZHtYdDrrDUR4DC+KkcElHzh4hDhUaeG4VHhyQV+JNQPmJwrKZiy5d Dj2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TxjLQAmlgCmIbW66ttakmR+UHsu55ZGYYjiNgQ7pD60=; b=Aqy1S5TJMIuG/eyTpPXWwEbl4KQiB2n+vKJxfPbjHIzpl8wNdD7Wjf8ny6ShIuAJA3 vvkSTOPer8UpxVH/eLV2fr9a4VUJwmjCMsYO9oTRB5qk4l3FEivN8/LcvF0zyTvFJHjt Jc7Q9fXhrTJY8sZ4mnsJL2p4Kz5aFmSPA7my7ENhwAZqgKhHm3eYsIhBP0dZta5ANZNG QddgnzwN5l8ftj/PGGf+Kwvi9lYJng7Y9Dw2k1LEJj4dZR9KJJBFLXo07hyIbo9k30Gl EMbNiRGY7z5fJZc/Fn+WIwZM93eOHTQ4/cdvQWhD+J39Q9xXFpMawyR30N/y09F4b3Qz XmZw== X-Gm-Message-State: AOAM530QzlXYltlSt8HG0wk1dM9Iv2DGgEX3tDR8or7uokLfNvgQtLJN U1nV6w5hMPw9FzmM51T6OyQ7iEFI1E+hBr6rPiY= X-Google-Smtp-Source: ABdhPJxFXm/snfV7f+PaeEk0/JpSTrHSkPZMuSqd6hBKK/zxQapVp8rf2U8UIu+qvc9Q33J56Hi8hFlnpuvp0XR2Wlk= X-Received: by 2002:a5d:8b8e:: with SMTP id p14mr3979084iol.110.1589461696306; Thu, 14 May 2020 06:08:16 -0700 (PDT) MIME-Version: 1.0 References: <1589267017-17294-1-git-send-email-dillon.minfei@gmail.com> <1589267017-17294-4-git-send-email-dillon.minfei@gmail.com> In-Reply-To: From: dillon min Date: Thu, 14 May 2020 21:07:40 +0800 Message-ID: Subject: Re: [PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board To: Alexandre Torgue X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200514_060817_694911_82C935B9 X-CRM114-Status: GOOD ( 16.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Daniel Vetter , Dave Airlie , Linus Walleij , linux-clk , "linux-kernel@vger.kernel.org" , "open list:DRM PANEL DRIVERS" , linux-stm32@st-md-mailman.stormreply.com, Stephen Boyd , Rob Herring , "thierry.reding@gmail.com" , Maxime Coquelin , Sam Ravnborg , Michael Turquette , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexandre, On Thu, May 14, 2020 at 8:53 PM Alexandre Torgue wrote: > > > > On 5/14/20 10:24 AM, Linus Walleij wrote: > > On Tue, May 12, 2020 at 9:04 AM wrote: > > > >> From: dillon min > >> > >> Enable the ltdc & ili9341 on stm32429-disco board. > >> > >> Signed-off-by: dillon min > > > > This mostly looks good but... > > > >> +&spi5 { > >> + status = "okay"; > >> + pinctrl-0 = <&spi5_pins>; > >> + pinctrl-names = "default"; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; > >> + dmas = <&dma2 3 2 0x400 0x0>, > >> + <&dma2 4 2 0x400 0x0>; > >> + dma-names = "rx", "tx"; > > > > These DMA assignments seem to be SoC things and should > > rather be in the DTS(I) file where &spi5 is defined, right? > > stm32f429.dtsi I suppose? > > I agree with Linus, DMA have to be defined in SoC dtsi. And if a board > doesn't want to use it, we use the "delete-property". Yes, will move to Soc dtsi in next submits. i'm working on write a v4l2-m2m driver for dma2d of stm32 to support pixel conversion alpha blending between foreground and background graphics. as you know, some soc's engineer trying to add this function to drm system. do you know st's planning about soc's hardware accelerator driver on stm32mp? such as chrom-art, will add to drm subsystem via ioctl to access, or to v4l2, thanks. > > > > > It is likely the same no matter which device is using spi5. > > > > Yours, > > Linus Walleij > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AA0CC433E3 for ; Fri, 15 May 2020 06:53:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BB16206F1 for ; Fri, 15 May 2020 06:53:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HQy57Gtt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BB16206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C8566EBE4; Fri, 15 May 2020 06:53:28 +0000 (UTC) Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE6286E343 for ; Thu, 14 May 2020 13:08:16 +0000 (UTC) Received: by mail-io1-xd44.google.com with SMTP id k18so239896ion.0 for ; Thu, 14 May 2020 06:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TxjLQAmlgCmIbW66ttakmR+UHsu55ZGYYjiNgQ7pD60=; b=HQy57GttiwVxh24sQLfeiQngcOiErLC6lrc6A6arkVum1pGd0PXCrQaHvOCK4hPNEV b/059ZwlWVA1AS8FK1q2/gCJIeug5/mReyn6myQQGKj7Nqz7CVRv86DNFSRbqqL9jNJu tITMdAKorHxeF7YvlIBXB8sc7+tzC2Jw9Tf81bsZ6FJbcXdDfUt6nlqKXBjb5tQmn5MB gsR5CUzH/zKAUZsVkX976vv3QKAm1v8PnXFZ2eAaurKTEVbK4xwSxyYq0RD28bfWf5Cm c7yPr6SgCzeFtV1ZHtYdDrrDUR4DC+KkcElHzh4hDhUaeG4VHhyQV+JNQPmJwrKZiy5d Dj2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TxjLQAmlgCmIbW66ttakmR+UHsu55ZGYYjiNgQ7pD60=; b=puFCSlKJT9iEzMQRbtvKlXtAkhxKWt10JYwJ9LU4f90GRjEV3IYtuZO07uimey0lK5 x2ocmyGwY2jUfkH+s/tm9DwT1up3uc3zgWnC+crCvA06DuPHDN1BoYZZGvegj+A/ibpF 5mmenMUOZu7viztmrrfKP+gtcjzDG7UpIT9HW8yT+Fb6Hssk53lCIFS/eBFQBGMoi3LX L6q4k34bLC9j3sT210JtBtVl+teUeKpuf8UwynjRlmEHSQaNHo2AYawk2dSBEKnHlzON ZEnMj9W1uLaHEQTsjsI4m9J0L4VdK3j9Gq48t37QKGA0JEi6GyTCeNMSQfHhV459+mEs v7yg== X-Gm-Message-State: AOAM53119pSLWvnJJHtkwAu674yvjJOIMGvdFnFwxK9bJoRn5xDlQiib ETkWPIG3q1oHps5maCQiri5gdHzY3kwh2Ceftro= X-Google-Smtp-Source: ABdhPJxFXm/snfV7f+PaeEk0/JpSTrHSkPZMuSqd6hBKK/zxQapVp8rf2U8UIu+qvc9Q33J56Hi8hFlnpuvp0XR2Wlk= X-Received: by 2002:a5d:8b8e:: with SMTP id p14mr3979084iol.110.1589461696306; Thu, 14 May 2020 06:08:16 -0700 (PDT) MIME-Version: 1.0 References: <1589267017-17294-1-git-send-email-dillon.minfei@gmail.com> <1589267017-17294-4-git-send-email-dillon.minfei@gmail.com> In-Reply-To: From: dillon min Date: Thu, 14 May 2020 21:07:40 +0800 Message-ID: Subject: Re: [PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board To: Alexandre Torgue X-Mailman-Approved-At: Fri, 15 May 2020 06:52:56 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Dave Airlie , linux-clk , "linux-kernel@vger.kernel.org" , "open list:DRM PANEL DRIVERS" , linux-stm32@st-md-mailman.stormreply.com, Stephen Boyd , Rob Herring , "thierry.reding@gmail.com" , Maxime Coquelin , Sam Ravnborg , Michael Turquette , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Alexandre, On Thu, May 14, 2020 at 8:53 PM Alexandre Torgue wrote: > > > > On 5/14/20 10:24 AM, Linus Walleij wrote: > > On Tue, May 12, 2020 at 9:04 AM wrote: > > > >> From: dillon min > >> > >> Enable the ltdc & ili9341 on stm32429-disco board. > >> > >> Signed-off-by: dillon min > > > > This mostly looks good but... > > > >> +&spi5 { > >> + status = "okay"; > >> + pinctrl-0 = <&spi5_pins>; > >> + pinctrl-names = "default"; > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; > >> + dmas = <&dma2 3 2 0x400 0x0>, > >> + <&dma2 4 2 0x400 0x0>; > >> + dma-names = "rx", "tx"; > > > > These DMA assignments seem to be SoC things and should > > rather be in the DTS(I) file where &spi5 is defined, right? > > stm32f429.dtsi I suppose? > > I agree with Linus, DMA have to be defined in SoC dtsi. And if a board > doesn't want to use it, we use the "delete-property". Yes, will move to Soc dtsi in next submits. i'm working on write a v4l2-m2m driver for dma2d of stm32 to support pixel conversion alpha blending between foreground and background graphics. as you know, some soc's engineer trying to add this function to drm system. do you know st's planning about soc's hardware accelerator driver on stm32mp? such as chrom-art, will add to drm subsystem via ioctl to access, or to v4l2, thanks. > > > > > It is likely the same no matter which device is using spi5. > > > > Yours, > > Linus Walleij > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel