From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA0A7C07E9B for ; Wed, 21 Jul 2021 07:30:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 759D660FEA for ; Wed, 21 Jul 2021 07:30:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 759D660FEA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D33EC6E85A; Wed, 21 Jul 2021 07:30:01 +0000 (UTC) Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0E5836E85A for ; Wed, 21 Jul 2021 07:30:00 +0000 (UTC) Received: by mail-il1-x12c.google.com with SMTP id y6so1463945ilj.13 for ; Wed, 21 Jul 2021 00:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JJyapWso43cKxu7exR6UDB9SXEcP2zO2ejL6sTcse9U=; b=draIOqOnpPvTHBMPDajHYxnZpgi3hCpg1BxirrVgoEYxghc3TcRRz0/xxRvpShQl2y QRfeyP2nf4Yx3eBaLVfC1pihBjTXaPHGttywezWhikOFcGHneCk2GT0Nao1l9czoSKZj Aw4jTYrCrc+1hLgqrUlMyzOnkHhg3aLmqWC+1+1eu6SLQGz9CpwJq5KpSJop0o9jlK/W lDQWyc4D9GnFw3y6SHXtI08cbPppDFrCva60xhsgVAoxFK33INN2tA8MmOeBGltQzSd/ rS+sQxYdp1FjCfIOJGetNFAEA3ZuaS7tI6Du1FjFTlr2vM/geuMnMVJpSFOHeB90EWFK U32A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JJyapWso43cKxu7exR6UDB9SXEcP2zO2ejL6sTcse9U=; b=AeCjG36t/A5s7Bnr0LPHDNiX0U3sCmyulNTEzboEppDtpOFWbYek4SZKx47BRWIVIZ ZRZhdwEBNNeATsgCB8fKBNjQxUIzNoH0BGs0ZJaUzX/cRkf3gcsMO3J9AUFO6VwsoOPS J4ZWPb/bWXMssZgjwxBRGFhcpE/4oRY2TrtFDLgHofn3rJ7V6jDxRG6AlAgvbPFbu6wu BIf7gjWPZGXVDAcy8IyV2cYfACKIRVuSX2XCkSMPgY3KQzSNztSnT/Oot71X/ke5QUzg g0BqDLD2o20RzY5Doq90W0//RcXzG0cN0yBK+fz+Da4darkWQdB7OB+Btabu9IGLmkrD l6KA== X-Gm-Message-State: AOAM5325yVw9eIeS+k6RYQfUpcXJk5ZYB478SaW5OpP+x9jCmOTwPGuU 1EPhWRe+eqvMNbPpOlep00t3dudxNKBYfHrRJjQ= X-Google-Smtp-Source: ABdhPJwgZTtkv63YIk04u138pE+AS+Biq6n5UJESA7lfXXhZ+X6P39wlRoF2kGHKp3Xbkqqzt5aEcXzq2cwEpD0hdcI= X-Received: by 2002:a05:6e02:e82:: with SMTP id t2mr23356675ilj.218.1626852599569; Wed, 21 Jul 2021 00:29:59 -0700 (PDT) MIME-Version: 1.0 References: <1626430843-23823-1-git-send-email-dillon.minfei@gmail.com> <1626430843-23823-2-git-send-email-dillon.minfei@gmail.com> In-Reply-To: From: Dillon Min Date: Wed, 21 Jul 2021 15:29:23 +0800 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add ilitek ili9341 panel bindings To: Linus Walleij Content-Type: multipart/alternative; boundary="0000000000004ca0fd05c79d2384" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Dave Airlie , linux-kernel , Doug Anderson , "open list:DRM PANEL DRIVERS" , Alexandre Torgue , Rob Herring , "thierry.reding@gmail.com" , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --0000000000004ca0fd05c79d2384 Content-Type: text/plain; charset="UTF-8" Hi Linus, Thanks for your detailed reply. On Sun, 18 Jul 2021 at 08:17, Linus Walleij wrote: > Hi Dillon, > > thanks for your patch! > > On Fri, Jul 16, 2021 at 12:20 PM wrote: > > > From: Dillon Min > > > > Add documentation for "ilitek,ili9341" panel. > > > > Signed-off-by: Dillon Min > > > + dc-gpios: > > + maxItems: 1 > > + description: Display data/command selection (D/CX) > > This is a DBI feature so mention in the description that this is a > DBI panel. > Okay, I will add the DBI panel to v2. > > > + spi-3wire: true > > + > > + spi-max-frequency: > > + const: 10000000 > > + > > + port: true > > + > > +additionalProperties: false > > Please add regulator supplies for the power lines, it's fine > not to implement code handling them in the driver but they > should be in the bindings. > > For the ili9341 it should be > > vci-supply: > description: Analog voltage supply (2.5 .. 3.3V) > > vddi-supply: > description: Voltage supply for interface logic (1.65 .. 3.3 V) > > vddi-led-supply: > description: Voltage supply for the LED driver (1.65 .. 3.3 V) > > Thanks so much, I will add it to v2. > Yours, > Linus Walleij > --0000000000004ca0fd05c79d2384 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Linus,

Thanks for y= our detailed reply.

On Sun, 18 Jul 2021 at 08:17, Linus Walleij <linus.walleij@linaro.org> = wrote:
Hi Dillon= ,

thanks for your patch!

On Fri, Jul 16, 2021 at 12:20 PM <dillon.minfei@gmail.com> wrote:

> From: Dillon Min <dillon.minfei@gmail.com>
>
> Add documentation for "ilitek,ili9341" panel.
>
> Signed-off-by: Dillon Min <dillon.minfei@gmail.com>

> +=C2=A0 dc-gpios:
> +=C2=A0 =C2=A0 maxItems: 1
> +=C2=A0 =C2=A0 description: Display data/command selection (D/CX)

This is a DBI feature so mention in the description that this is a
DBI panel.

Okay, I will add the DBI pan= el to v2.
=C2=A0

> +=C2=A0 spi-3wire: true
> +
> +=C2=A0 spi-max-frequency:
> +=C2=A0 =C2=A0 const: 10000000
> +
> +=C2=A0 port: true
> +
> +additionalProperties: false

Please add regulator supplies for the power lines, it's fine
not to implement code handling them in the driver but they
should be in the bindings.

For the ili9341 it should be

=C2=A0 vci-supply:
=C2=A0 =C2=A0 description: Analog voltage supply (2.5 .. 3.3V)

=C2=A0 vddi-supply:
=C2=A0 =C2=A0 description: Voltage supply for interface logic (1.65 .. 3.3 = V)

=C2=A0 vddi-led-supply:
=C2=A0 =C2=A0 description: Voltage supply for the LED driver (1.65 .. 3.3 V= )


Thanks so much, I will add it to v2.
=C2=A0
Yours,
Linus Walleij
--0000000000004ca0fd05c79d2384--