From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C745FC6377C for ; Thu, 22 Jul 2021 02:07:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A523B611C1 for ; Thu, 22 Jul 2021 02:07:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbhGVB1V (ORCPT ); Wed, 21 Jul 2021 21:27:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbhGVB1U (ORCPT ); Wed, 21 Jul 2021 21:27:20 -0400 Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90226C061575; Wed, 21 Jul 2021 19:07:55 -0700 (PDT) Received: by mail-il1-x131.google.com with SMTP id o8so4051374ilf.4; Wed, 21 Jul 2021 19:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=90T8pVlNu5R4aARTLjIPZ2shWeZ1pN4LEYWIIMIBA/Y=; b=ZrcYlafSzxD0iNHz7hFfuRgsZhERE/FFxN0t89R6+5lbyxC7+FH5iiv/EwOH4RoWLg qvxm3vsrC/5fwcDoUGWRvEBxx+MKGXA6auS8Dr5I8xK1XsiTXuJbW7GKLUlPzTqM4W1C +2CrFCMeknsDB2dF9Ecr6TqMn14CNC88WEKDpWBUxKEp8Ikpmv9jmxS2x+fQIfTgAnlF Z91yHUNCggVbgrcsjthne/UBOvQtsFefHu7S4Vp6UhjPlx2hJH6mbx1YF4xl5AIOlIbm DoklVBDaXv1/Eqh3VxLyksW2y5dGQhnsR1DYubiaFaFPi9btcOoHAJ/xROeJC58fY/6f TCRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=90T8pVlNu5R4aARTLjIPZ2shWeZ1pN4LEYWIIMIBA/Y=; b=EqIcJjNsB/Dsk2wGvvwcJ9OypQDjxRX1uymZ8WMLzHu+fMPkzl+uh0uHJ3GiQl0x4m QfHLJztZZ4NXZMR1pA0k386bR9BKk45QGCg5vEa7Y9LnIXt47yjcqi1O70F0W4Xa+u5H Cp54b43mG9QadieN3PbMV06yf4f//++9+OfhRv9ADLRFxFMTHrV0lf9eSycSLyegJna6 DmGojpFS4vPjfp46hcCxfkDXRcieErB0iMn2pDv+EugcRp0Zf8nR2mv+qa5houEoTGxA CPdsRQnEQJFcQYJ0209Jo4b8bMbzGBOmCw8perIJMQCkQ+oZT9Do6Z5i94jvVZq/d5eL YQyw== X-Gm-Message-State: AOAM531T1DEjyTGzSub2P1i6tGnriIANU+gLgdlJcJqigoMxihHS3XkB s6K1kbjozbyhndedYvpEXTemLEB26WsgBn/NuNA= X-Google-Smtp-Source: ABdhPJxgBytAWSHe5ssnHfJDN1qf7Ebn8LuKIIxs/cyJ1/sfTsYmEVV6WZ09Y2ktwylhbMFQIAmIrxrDCnDM1ssJyPA= X-Received: by 2002:a92:c5c5:: with SMTP id s5mr24509368ilt.271.1626919674933; Wed, 21 Jul 2021 19:07:54 -0700 (PDT) MIME-Version: 1.0 References: <1626853288-31223-1-git-send-email-dillon.minfei@gmail.com> <1626853288-31223-4-git-send-email-dillon.minfei@gmail.com> <8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org> In-Reply-To: <8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org> From: Dillon Min Date: Thu, 22 Jul 2021 10:07:18 +0800 Message-ID: Subject: Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Cc: Thierry Reding , Sam Ravnborg , Dave Airlie , Daniel Vetter , Rob Herring , Linus Walleij , Alexandre TORGUE , Maxime Coquelin , Doug Anderson , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Noralf Thanks for your time to review my patch. On Thu, 22 Jul 2021 at 01:42, Noralf Tr=C3=B8nnes wrot= e: > > > > Den 21.07.2021 09.41, skrev dillon.minfei@gmail.com: > > From: Dillon Min > > > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > > with mipi_dpi_interface driver, can support ili9341 with serial > > mode or parallel rgb interface mode by register configuration. > > > > Cc: Linus Walleij > > Signed-off-by: Dillon Min > > --- > > > +static const struct of_device_id ili9341_of_match[] =3D { > > + { > > + .compatible =3D "st,sf-tc240t-9370-t", > > + .data =3D &ili9341_stm32f429_disco_data, > > + }, > > + { > > + /* porting from tiny/ili9341.c > > + * for original mipi dbi compitable > > + */ > > + .compatible =3D "adafruit,yx240qv29", > > I don't understand this, now there will be 2 drivers that support the > same display? There is no reason to create two drivers to support the same display. To support only-dbi and dbi+dpi panel at drm/panel or drm/tiny both fine with me. > > AFAICT drm/tiny/ili9341.c is just copied into this driver, is the plan > to remove the tiny/ driver? If so I couldn't see this mentioned anywhere. Yes, I'd like to merge the code from drm/tiny/ili9341.c to this driver (to make a single driver to support different bus). I have two purpose to extend the feature drm/tiny/ili9341.c - keep compatible =3D "adafruit,yx240qv29", add bus mode dts bindings (pane= l_bus) to define the interface which host wants to use. such as panel_bus=3D"dbi" or "rgb" or "i80" for this case, i will add dpi code to drm/tiny/ili9341.c. - merge tiny/ili9341.c to this driver,remove drm/tiny/ili9341.c, add new dts compatible string to support other interfaces. just like what i'm doing now. I have no idea about your plan on drm/tiny drivers, actually some of these panels under the diny folder can support both dbi and dbi+dpi (much faster, need more pins). no doubt the requirement to support dpi is always there. What is your preference? Thanks & Regards Dillon > > Noralf. > > > + .data =3D NULL, > > + }, > > +}; > > +MODULE_DEVICE_TABLE(of, ili9341_of_match); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14B2BC6377D for ; Thu, 22 Jul 2021 02:10:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D253F6128A for ; Thu, 22 Jul 2021 02:10:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D253F6128A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fWYOcJwp9dvAgW0gfylHbsnsWAn47v4RCF72ruLiX5I=; b=T/FjPCgybH9vYt yZW4hGuYevDlOsE5ARqMGeI316SqZOPkGIW8uYoPad1mNbey/1LCig4AW8pc1zD/EnpojONSG1w9s IYKe6j67k4UO4/DKXwfl/LYaiGSyQBKlNZOgDw7oHtAXAaFrid43WG2NsKMth8jKuAGOzgIGiTMU2 9K7XBUbzQ2AMhthSKWq+TuJ10I4CeRItYNh0pvAl8FQpD7oiuQGtxcFRCvecM90AHjN56zCVUFnBY 4L/qMJ2ScppOYRwdgMIiLqVhI6MF0hiXJ6mq9euZ3cHnd7IowpE6LEPzm4IHSuqtxImeEcKBKQqS2 cLDMwOULYvLvLtNxXL1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6O7z-00HYKI-Nf; Thu, 22 Jul 2021 02:07:59 +0000 Received: from mail-il1-x129.google.com ([2607:f8b0:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6O7w-00HYJs-3V for linux-arm-kernel@lists.infradead.org; Thu, 22 Jul 2021 02:07:57 +0000 Received: by mail-il1-x129.google.com with SMTP id j5so4059147ilk.3 for ; Wed, 21 Jul 2021 19:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=90T8pVlNu5R4aARTLjIPZ2shWeZ1pN4LEYWIIMIBA/Y=; b=ZrcYlafSzxD0iNHz7hFfuRgsZhERE/FFxN0t89R6+5lbyxC7+FH5iiv/EwOH4RoWLg qvxm3vsrC/5fwcDoUGWRvEBxx+MKGXA6auS8Dr5I8xK1XsiTXuJbW7GKLUlPzTqM4W1C +2CrFCMeknsDB2dF9Ecr6TqMn14CNC88WEKDpWBUxKEp8Ikpmv9jmxS2x+fQIfTgAnlF Z91yHUNCggVbgrcsjthne/UBOvQtsFefHu7S4Vp6UhjPlx2hJH6mbx1YF4xl5AIOlIbm DoklVBDaXv1/Eqh3VxLyksW2y5dGQhnsR1DYubiaFaFPi9btcOoHAJ/xROeJC58fY/6f TCRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=90T8pVlNu5R4aARTLjIPZ2shWeZ1pN4LEYWIIMIBA/Y=; b=h+eEbg1vB1uc+B3czQuBbsgzwilCA/hFnCmPQXuXDmxCo0WhCw/lelHz2xyx4PPbiO LIwFHzGezykOpTG/TAdtPnUC1EP/0ISPrBWenPZ/pZbO5Y31Lk0l8PIq5K6F6Amu5lx2 dtXwzhVb8RBspi7oMD2SuiJfay9TFXIBLWt/IpDdi6e8lrL3EelrcKjl2+mrBqpr1sxV CJm+6m8jXURQfTB+ML8atnbqvxwFmh3yoa082iP/gYQcecRVQfO9XuyFK5IzlolkYHEG tT85I0bLPWjTBtljHc3VkEBoKxdeawKxeHx6Vo/gPkKwdgOGA/JnM0VEqFgJ0H39/Sdm 6dTg== X-Gm-Message-State: AOAM533ZbeFWT2x9rxtoUGuHHseJCSRHQpR/iEzVN0vIhl0k4obkuHn9 fhg6d5V/XryV8Hyv3U4guDCyuGXca/UtM7zWK6w= X-Google-Smtp-Source: ABdhPJxgBytAWSHe5ssnHfJDN1qf7Ebn8LuKIIxs/cyJ1/sfTsYmEVV6WZ09Y2ktwylhbMFQIAmIrxrDCnDM1ssJyPA= X-Received: by 2002:a92:c5c5:: with SMTP id s5mr24509368ilt.271.1626919674933; Wed, 21 Jul 2021 19:07:54 -0700 (PDT) MIME-Version: 1.0 References: <1626853288-31223-1-git-send-email-dillon.minfei@gmail.com> <1626853288-31223-4-git-send-email-dillon.minfei@gmail.com> <8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org> In-Reply-To: <8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org> From: Dillon Min Date: Thu, 22 Jul 2021 10:07:18 +0800 Message-ID: Subject: Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Cc: Thierry Reding , Sam Ravnborg , Dave Airlie , Daniel Vetter , Rob Herring , Linus Walleij , Alexandre TORGUE , Maxime Coquelin , Doug Anderson , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_190756_191534_C51A67B8 X-CRM114-Status: GOOD ( 24.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTm9yYWxmCgpUaGFua3MgZm9yIHlvdXIgdGltZSB0byByZXZpZXcgbXkgcGF0Y2guCgpPbiBU aHUsIDIyIEp1bCAyMDIxIGF0IDAxOjQyLCBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVz Lm9yZz4gd3JvdGU6Cj4KPgo+Cj4gRGVuIDIxLjA3LjIwMjEgMDkuNDEsIHNrcmV2IGRpbGxvbi5t aW5mZWlAZ21haWwuY29tOgo+ID4gRnJvbTogRGlsbG9uIE1pbiA8ZGlsbG9uLm1pbmZlaUBnbWFp bC5jb20+Cj4gPgo+ID4gVGhpcyBkcml2ZXIgY29tYmluZSB0aW55L2lsaTkzNDEuYyBtaXBpX2Ri aV9pbnRlcmZhY2UgZHJpdmVyCj4gPiB3aXRoIG1pcGlfZHBpX2ludGVyZmFjZSBkcml2ZXIsIGNh biBzdXBwb3J0IGlsaTkzNDEgd2l0aCBzZXJpYWwKPiA+IG1vZGUgb3IgcGFyYWxsZWwgcmdiIGlu dGVyZmFjZSBtb2RlIGJ5IHJlZ2lzdGVyIGNvbmZpZ3VyYXRpb24uCj4gPgo+ID4gQ2M6IExpbnVz IFdhbGxlaWogPGxpbnVzLndhbGxlaWpAbGluYXJvLm9yZz4KPiA+IFNpZ25lZC1vZmYtYnk6IERp bGxvbiBNaW4gPGRpbGxvbi5taW5mZWlAZ21haWwuY29tPgo+ID4gLS0tCj4KPiA+ICtzdGF0aWMg Y29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBpbGk5MzQxX29mX21hdGNoW10gPSB7Cj4gPiArICAg ICB7Cj4gPiArICAgICAgICAgICAgIC5jb21wYXRpYmxlID0gInN0LHNmLXRjMjQwdC05MzcwLXQi LAo+ID4gKyAgICAgICAgICAgICAuZGF0YSA9ICZpbGk5MzQxX3N0bTMyZjQyOV9kaXNjb19kYXRh LAo+ID4gKyAgICAgfSwKPiA+ICsgICAgIHsKPiA+ICsgICAgICAgICAgICAgLyogcG9ydGluZyBm cm9tIHRpbnkvaWxpOTM0MS5jCj4gPiArICAgICAgICAgICAgICAqIGZvciBvcmlnaW5hbCBtaXBp IGRiaSBjb21waXRhYmxlCj4gPiArICAgICAgICAgICAgICAqLwo+ID4gKyAgICAgICAgICAgICAu Y29tcGF0aWJsZSA9ICJhZGFmcnVpdCx5eDI0MHF2MjkiLAo+Cj4gSSBkb24ndCB1bmRlcnN0YW5k IHRoaXMsIG5vdyB0aGVyZSB3aWxsIGJlIDIgZHJpdmVycyB0aGF0IHN1cHBvcnQgdGhlCj4gc2Ft ZSBkaXNwbGF5PwoKVGhlcmUgaXMgbm8gcmVhc29uIHRvIGNyZWF0ZSB0d28gZHJpdmVycyB0byBz dXBwb3J0IHRoZSBzYW1lIGRpc3BsYXkuCgpUbyBzdXBwb3J0IG9ubHktZGJpIGFuZCBkYmkrZHBp IHBhbmVsIGF0IGRybS9wYW5lbCBvciBkcm0vdGlueSBib3RoCmZpbmUgd2l0aCBtZS4KCj4KPiBB RkFJQ1QgZHJtL3RpbnkvaWxpOTM0MS5jIGlzIGp1c3QgY29waWVkIGludG8gdGhpcyBkcml2ZXIs IGlzIHRoZSBwbGFuCj4gdG8gcmVtb3ZlIHRoZSB0aW55LyBkcml2ZXI/IElmIHNvIEkgY291bGRu J3Qgc2VlIHRoaXMgbWVudGlvbmVkIGFueXdoZXJlLgoKWWVzLCBJJ2QgbGlrZSB0byBtZXJnZSB0 aGUgY29kZSBmcm9tIGRybS90aW55L2lsaTkzNDEuYyB0byB0aGlzIGRyaXZlcgoodG8gbWFrZSBh IHNpbmdsZSBkcml2ZXIgdG8gc3VwcG9ydCBkaWZmZXJlbnQgYnVzKS4KCkkgaGF2ZSB0d28gcHVy cG9zZSB0byBleHRlbmQgdGhlIGZlYXR1cmUgZHJtL3RpbnkvaWxpOTM0MS5jCgotIGtlZXAgY29t cGF0aWJsZSA9ICJhZGFmcnVpdCx5eDI0MHF2MjkiLCBhZGQgYnVzIG1vZGUgZHRzIGJpbmRpbmdz IChwYW5lbF9idXMpCiAgdG8gZGVmaW5lIHRoZSBpbnRlcmZhY2Ugd2hpY2ggaG9zdCB3YW50cyB0 byB1c2UuIHN1Y2ggYXMKcGFuZWxfYnVzPSJkYmkiIG9yICJyZ2IiCiAgb3IgImk4MCIgZm9yIHRo aXMgY2FzZSwgaSB3aWxsIGFkZCBkcGkgY29kZSB0byBkcm0vdGlueS9pbGk5MzQxLmMuCgotIG1l cmdlIHRpbnkvaWxpOTM0MS5jIHRvIHRoaXMgZHJpdmVyLHJlbW92ZSBkcm0vdGlueS9pbGk5MzQx LmMsIGFkZApuZXcgZHRzIGNvbXBhdGlibGUKICBzdHJpbmcgdG8gc3VwcG9ydCBvdGhlciBpbnRl cmZhY2VzLiBqdXN0IGxpa2Ugd2hhdCBpJ20gZG9pbmcgbm93LgoKSSBoYXZlIG5vIGlkZWEgYWJv dXQgeW91ciBwbGFuIG9uIGRybS90aW55IGRyaXZlcnMsIGFjdHVhbGx5IHNvbWUgb2YKdGhlc2Ug cGFuZWxzIHVuZGVyCnRoZSBkaW55IGZvbGRlciBjYW4gc3VwcG9ydCBib3RoIGRiaSBhbmQgZGJp K2RwaSAobXVjaCBmYXN0ZXIsIG5lZWQKbW9yZSBwaW5zKS4gbm8KZG91YnQgdGhlIHJlcXVpcmVt ZW50IHRvIHN1cHBvcnQgZHBpIGlzIGFsd2F5cyB0aGVyZS4KCldoYXQgaXMgeW91ciBwcmVmZXJl bmNlPwoKVGhhbmtzICYgUmVnYXJkcwpEaWxsb24KCj4KPiBOb3JhbGYuCj4KPiA+ICsgICAgICAg ICAgICAgLmRhdGEgPSBOVUxMLAo+ID4gKyAgICAgfSwKPiA+ICt9Owo+ID4gK01PRFVMRV9ERVZJ Q0VfVEFCTEUob2YsIGlsaTkzNDFfb2ZfbWF0Y2gpOwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D379FC6377A for ; Thu, 22 Jul 2021 02:07:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78D9E611C1 for ; Thu, 22 Jul 2021 02:07:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78D9E611C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6249E6EB19; Thu, 22 Jul 2021 02:07:56 +0000 (UTC) Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 961626EB19 for ; Thu, 22 Jul 2021 02:07:55 +0000 (UTC) Received: by mail-il1-x131.google.com with SMTP id o8so4051373ilf.4 for ; Wed, 21 Jul 2021 19:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=90T8pVlNu5R4aARTLjIPZ2shWeZ1pN4LEYWIIMIBA/Y=; b=ZrcYlafSzxD0iNHz7hFfuRgsZhERE/FFxN0t89R6+5lbyxC7+FH5iiv/EwOH4RoWLg qvxm3vsrC/5fwcDoUGWRvEBxx+MKGXA6auS8Dr5I8xK1XsiTXuJbW7GKLUlPzTqM4W1C +2CrFCMeknsDB2dF9Ecr6TqMn14CNC88WEKDpWBUxKEp8Ikpmv9jmxS2x+fQIfTgAnlF Z91yHUNCggVbgrcsjthne/UBOvQtsFefHu7S4Vp6UhjPlx2hJH6mbx1YF4xl5AIOlIbm DoklVBDaXv1/Eqh3VxLyksW2y5dGQhnsR1DYubiaFaFPi9btcOoHAJ/xROeJC58fY/6f TCRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=90T8pVlNu5R4aARTLjIPZ2shWeZ1pN4LEYWIIMIBA/Y=; b=d13bc1PCVg4itbshHcetFDtNkZ5dq4RTR1GZGcj83bPLX9cYaD9n3BrGctgzSfxg29 eXWfwdY3kZCbloqdjXutCzlYcO93+7WjAe9wyFWCYhnbBJCrzviDQsTLfcX7XgN0m+S5 gi6bPlieFZYTOEiCqvy0Z0NtyQ7NVAdcnqUMEVQa6YAA7cRwRDbGcizYBKk7+kI9FwHw I8iNMaRyTYEEw1jqFORuA09q3lqj2ZLY0+N/ActsYQyxa4zVfPDzPvnShbwVrIHgYvQA tqxvbbo/pYYTjDCwNegBvYtEQHhYvAJtSLMccix/5UeT0AAVXYtr1/QLkM4uqRuIu/mb d2qw== X-Gm-Message-State: AOAM531E04TQsnhegwkduwJ8VZQLWh/FAolfLuQXKUddeQ42J8D8X+Uq eZoyrXL/vRp3UI8JFGbpKlU6a74MkCYSQSHyQbk= X-Google-Smtp-Source: ABdhPJxgBytAWSHe5ssnHfJDN1qf7Ebn8LuKIIxs/cyJ1/sfTsYmEVV6WZ09Y2ktwylhbMFQIAmIrxrDCnDM1ssJyPA= X-Received: by 2002:a92:c5c5:: with SMTP id s5mr24509368ilt.271.1626919674933; Wed, 21 Jul 2021 19:07:54 -0700 (PDT) MIME-Version: 1.0 References: <1626853288-31223-1-git-send-email-dillon.minfei@gmail.com> <1626853288-31223-4-git-send-email-dillon.minfei@gmail.com> <8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org> In-Reply-To: <8e091b9c-764d-d410-559e-3c5e25de2a3c@tronnes.org> From: Dillon Min Date: Thu, 22 Jul 2021 10:07:18 +0800 Message-ID: Subject: Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Maxime Coquelin , Dave Airlie , Linux Kernel Mailing List , Alexandre TORGUE , "open list:DRM PANEL DRIVERS" , Doug Anderson , Rob Herring , Thierry Reding , Sam Ravnborg , linux-stm32@st-md-mailman.stormreply.com, Linux ARM Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Noralf Thanks for your time to review my patch. On Thu, 22 Jul 2021 at 01:42, Noralf Tr=C3=B8nnes wrot= e: > > > > Den 21.07.2021 09.41, skrev dillon.minfei@gmail.com: > > From: Dillon Min > > > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > > with mipi_dpi_interface driver, can support ili9341 with serial > > mode or parallel rgb interface mode by register configuration. > > > > Cc: Linus Walleij > > Signed-off-by: Dillon Min > > --- > > > +static const struct of_device_id ili9341_of_match[] =3D { > > + { > > + .compatible =3D "st,sf-tc240t-9370-t", > > + .data =3D &ili9341_stm32f429_disco_data, > > + }, > > + { > > + /* porting from tiny/ili9341.c > > + * for original mipi dbi compitable > > + */ > > + .compatible =3D "adafruit,yx240qv29", > > I don't understand this, now there will be 2 drivers that support the > same display? There is no reason to create two drivers to support the same display. To support only-dbi and dbi+dpi panel at drm/panel or drm/tiny both fine with me. > > AFAICT drm/tiny/ili9341.c is just copied into this driver, is the plan > to remove the tiny/ driver? If so I couldn't see this mentioned anywhere. Yes, I'd like to merge the code from drm/tiny/ili9341.c to this driver (to make a single driver to support different bus). I have two purpose to extend the feature drm/tiny/ili9341.c - keep compatible =3D "adafruit,yx240qv29", add bus mode dts bindings (pane= l_bus) to define the interface which host wants to use. such as panel_bus=3D"dbi" or "rgb" or "i80" for this case, i will add dpi code to drm/tiny/ili9341.c. - merge tiny/ili9341.c to this driver,remove drm/tiny/ili9341.c, add new dts compatible string to support other interfaces. just like what i'm doing now. I have no idea about your plan on drm/tiny drivers, actually some of these panels under the diny folder can support both dbi and dbi+dpi (much faster, need more pins). no doubt the requirement to support dpi is always there. What is your preference? Thanks & Regards Dillon > > Noralf. > > > + .data =3D NULL, > > + }, > > +}; > > +MODULE_DEVICE_TABLE(of, ili9341_of_match);