From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E48C43217 for ; Mon, 11 Oct 2021 10:01:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CE5360F0F for ; Mon, 11 Oct 2021 10:01:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235717AbhJKKC7 (ORCPT ); Mon, 11 Oct 2021 06:02:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235602AbhJKKC6 (ORCPT ); Mon, 11 Oct 2021 06:02:58 -0400 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 592F5C061570; Mon, 11 Oct 2021 03:00:58 -0700 (PDT) Received: by mail-io1-xd34.google.com with SMTP id 5so19076403iov.9; Mon, 11 Oct 2021 03:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yXcvq1zADtmcg32ryQtdH4a+0FvgZKed0QthCOmoDpI=; b=QAQqV+bDQO33uF6/KpR9PYACxfCcadoANuvPU7QoHKA0od6J0LHRYUxhgY+Ygo5K9B l31yjNV3TWME2U8o3xy8xoTAj9d31NtM7T1tmVgMizsqcAFY/VOIr1LydauRgLj8qjaH 2jMTrlzUf9EFxOq1mReHwa3+yI+/AbAaAkJGPn3dO2k4j75o59XafFv4PRZdUQRyNQXT jjfQjAVyw+jqueCZixlDtbYCJel+1r2Hf7/iUzO6JeDbwlFL58KOi4//2eQpFQgz8tza t2mGtfo0ZFVbqwVNgSWmm/Bxi2Ub9/8/5nZ2aNNWonGCoalVHlAH6pPBAftRKVo1BueJ voNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yXcvq1zADtmcg32ryQtdH4a+0FvgZKed0QthCOmoDpI=; b=sbwrLRTIEA9HtUfWxAwk9d2RkaAOReKW8IV0b+9Epz7/hdOLTz98QCVeZYSsk42TaG VDKSjlICH5uES2UYWFnnilXcpxAqwE1W/T+u3QgrUHpCmgFwn2TEyycT5Q3nvMj/uSXa 1Os8/wjkKMaJei2Dl/jE2ZKg/qBUBL0dV5WlOyXU1NXhexKzV5vNe1XdSgzmfs/S0eUC p/KKZsOACQznBJUySb/ivjdRH4Nrnso19jzQ7XNvWwWrbNn/vz4Sjk/Tur3JSBRdW6S7 Hnqi8v1gLiHiHhTi8TT2n9IqMslnXfD/swykeNHNoWsYzWfq44GYGRgKrEpCrIIx1tO9 N7Vw== X-Gm-Message-State: AOAM531a/44bsAbsGhsOaJBYByi1jR5OCEdU9QdsGROEX2+rrLpktegq tYV9PPuWZrPsTR94NmTdj6zKKrz4VcpyNFKsbpU= X-Google-Smtp-Source: ABdhPJwxaGE2iK30U5/jrs1jVvsUDLIabaQ09onY1Mk3bondvsaQahhYyWt4k5W8cnGvxl3udGcwTpQ+9J3IO1h35kE= X-Received: by 2002:a02:7105:: with SMTP id n5mr1133311jac.64.1633946457732; Mon, 11 Oct 2021 03:00:57 -0700 (PDT) MIME-Version: 1.0 References: <1633689012-14492-1-git-send-email-dillon.minfei@gmail.com> <1633689012-14492-7-git-send-email-dillon.minfei@gmail.com> <290d78b5-b6d4-a115-9556-f2f909f573da@xs4all.nl> In-Reply-To: <290d78b5-b6d4-a115-9556-f2f909f573da@xs4all.nl> From: Dillon Min Date: Mon, 11 Oct 2021 18:00:21 +0800 Message-ID: Subject: Re: [PATCH v3 6/8] media: v4l2-ctrls: Add ARGB color effects control To: Hans Verkuil Cc: Mauro Carvalho Chehab , mchehab+huawei@kernel.org, ezequiel@collabora.com, gnurou@gmail.com, Pi-Hsun Shih , Maxime Coquelin , Alexandre TORGUE , Michael Turquette , Stephen Boyd , Rob Herring , gabriel.fernandez@st.com, gabriel.fernandez@foss.st.com, Patrice CHOTARD , hugues.fruchet@foss.st.com, linux-media , Linux Kernel Mailing List , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans Thanks for the quick reply. On Mon, 11 Oct 2021 at 17:40, Hans Verkuil wrote: > > On 08/10/2021 12:30, dillon.minfei@gmail.com wrote: > > From: Dillon Min > > > > - add V4L2_COLORFX_SET_ARGB color effects control. > > - add V4L2_CID_COLORFX_ARGB for ARGB color setting. > > > > Signed-off-by: Dillon Min > > --- > > v3: according to Hans's suggestion, thanks. > > - remove old stm32 private R2M ioctl > > - add V4L2_CID_COLORFX_ARGB > > - add V4L2_COLORFX_SET_ARGB > > > > Documentation/userspace-api/media/v4l/control.rst | 8 ++++++++ > > drivers/media/v4l2-core/v4l2-ctrls-defs.c | 2 ++ > > include/uapi/linux/v4l2-controls.h | 4 +++- > > 3 files changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/userspace-api/media/v4l/control.rst b/Documentation/userspace-api/media/v4l/control.rst > > index f8d0b923da20..319606a6288f 100644 > > --- a/Documentation/userspace-api/media/v4l/control.rst > > +++ b/Documentation/userspace-api/media/v4l/control.rst > > @@ -242,8 +242,16 @@ Control IDs > > * - ``V4L2_COLORFX_SET_CBCR`` > > - The Cb and Cr chroma components are replaced by fixed coefficients > > determined by ``V4L2_CID_COLORFX_CBCR`` control. > > + * - ``V4L2_COLORFX_SET_ARGB`` > > + - ARGB colors. > > How about: > > - The ARGB components are replaced by the fixed ARGB components > determined by ``V4L2_CID_COLORFX_ARGB`` control. Sure, will be addressed by v4. > > I also wonder if it makes sense to include the alpha channel here. > > Looking at the driver code it appears to me (I might be wrong) that the alpha > channel is never touched (DMA2D_ALPHA_MODE_NO_MODIF), and setting the alpha > channel as part of a color effects control is rather odd as well. Indeed, Alpha channel is not used in current code. I'll remove this item in v4. how about change the code like below: * - ``V4L2_COLORFX_SET_RGB`` - The RGB components are replaced by the fixed RGB components determined by ``V4L2_CID_COLORFX_RGB`` control. ``V4L2_CID_COLORFX_RGB`` ``(integer)`` Determines the Red, Green, and Blue coefficients for ``V4L2_COLORFX_SET_RGB`` color effect. Bits [7:0] of the supplied 32 bit value are interpreted as Blue component, bits [15:8] as Green component, bits [23:16] as Red component, and bits [31:24] must be zero. > > Alpha channel manipulation really is separate from the color and - if needed - should > be done with a separate control. OK, Will use a separate control when adding blend features. Best Regards, Dillon > > Regards, > > Hans > > > > > > > +``V4L2_CID_COLORFX_ARGB`` ``(integer)`` > > + Determines the Alpha, Red, Green, and Blue coefficients for > > + ``V4L2_COLORFX_SET_ARGB`` color effect. > > + Bits [7:0] of the supplied 32 bit value are interpreted as Blue component, > > + bits [15:8] as Green component, bits [23:16] as Red component, and > > + bits [31:24] as Alpha component. > > > > ``V4L2_CID_COLORFX_CBCR`` ``(integer)`` > > Determines the Cb and Cr coefficients for ``V4L2_COLORFX_SET_CBCR`` > > diff --git a/drivers/media/v4l2-core/v4l2-ctrls-defs.c b/drivers/media/v4l2-core/v4l2-ctrls-defs.c > > index 421300e13a41..53be6aadb289 100644 > > --- a/drivers/media/v4l2-core/v4l2-ctrls-defs.c > > +++ b/drivers/media/v4l2-core/v4l2-ctrls-defs.c > > @@ -785,6 +785,7 @@ const char *v4l2_ctrl_get_name(u32 id) > > case V4L2_CID_MIN_BUFFERS_FOR_OUTPUT: return "Min Number of Output Buffers"; > > case V4L2_CID_ALPHA_COMPONENT: return "Alpha Component"; > > case V4L2_CID_COLORFX_CBCR: return "Color Effects, CbCr"; > > + case V4L2_CID_COLORFX_ARGB: return "Color Effects, ARGB"; > > > > /* > > * Codec controls > > @@ -1392,6 +1393,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type, > > *min = *max = *step = *def = 0; > > break; > > case V4L2_CID_BG_COLOR: > > + case V4L2_CID_COLORFX_ARGB: > > *type = V4L2_CTRL_TYPE_INTEGER; > > *step = 1; > > *min = 0; > > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > > index 5532b5f68493..2876c2282a68 100644 > > --- a/include/uapi/linux/v4l2-controls.h > > +++ b/include/uapi/linux/v4l2-controls.h > > @@ -128,6 +128,7 @@ enum v4l2_colorfx { > > V4L2_COLORFX_SOLARIZATION = 13, > > V4L2_COLORFX_ANTIQUE = 14, > > V4L2_COLORFX_SET_CBCR = 15, > > + V4L2_COLORFX_SET_ARGB = 16, > > }; > > #define V4L2_CID_AUTOBRIGHTNESS (V4L2_CID_BASE+32) > > #define V4L2_CID_BAND_STOP_FILTER (V4L2_CID_BASE+33) > > @@ -145,9 +146,10 @@ enum v4l2_colorfx { > > > > #define V4L2_CID_ALPHA_COMPONENT (V4L2_CID_BASE+41) > > #define V4L2_CID_COLORFX_CBCR (V4L2_CID_BASE+42) > > +#define V4L2_CID_COLORFX_ARGB (V4L2_CID_BASE+43) > > > > /* last CID + 1 */ > > -#define V4L2_CID_LASTP1 (V4L2_CID_BASE+43) > > +#define V4L2_CID_LASTP1 (V4L2_CID_BASE+44) > > > > /* USER-class private control IDs */ > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF959C433EF for ; Mon, 11 Oct 2021 10:06:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB1FF60F21 for ; Mon, 11 Oct 2021 10:06:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BB1FF60F21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tD1OvH+MplDm80/OorNgnYW6xoh8BxwMgvFGM9gSgbI=; b=GIsdn0+Fm9OWha PYEDbXFfiqRmyJkdfXwkLNEtLDy8TZaTvZWEoSvMcHv2pvnmB5LIZ8I/Coa8gL6TRSitbYv/7rR2W +4OqbLTRycRm+86KgaIgVlEYYA3kNofnE0r3D3x4tLpqEZQ18mmktdXIOXIdL5FQl1VsL4QT1CpF2 eJXYljzJm8Pd4Eou57byrO4hs/c+ZDZNteS/AqnqjNoGSiTVQf+IIVLLpCt0urQDj5HjW2wEwTKE1 gQe9F3KYgaJ9hRlqcidab7XB27urwlshHKwgiii4Gv0fUuCnwSFsHjvr7K1/R6FM0pLSf7VBJKztU EkVarTr9VHDWloEXdDtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZs9J-008jq7-SY; Mon, 11 Oct 2021 10:03:14 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZs7A-008ipq-BQ for linux-arm-kernel@lists.infradead.org; Mon, 11 Oct 2021 10:01:02 +0000 Received: by mail-io1-xd32.google.com with SMTP id e144so19097264iof.3 for ; Mon, 11 Oct 2021 03:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yXcvq1zADtmcg32ryQtdH4a+0FvgZKed0QthCOmoDpI=; b=QAQqV+bDQO33uF6/KpR9PYACxfCcadoANuvPU7QoHKA0od6J0LHRYUxhgY+Ygo5K9B l31yjNV3TWME2U8o3xy8xoTAj9d31NtM7T1tmVgMizsqcAFY/VOIr1LydauRgLj8qjaH 2jMTrlzUf9EFxOq1mReHwa3+yI+/AbAaAkJGPn3dO2k4j75o59XafFv4PRZdUQRyNQXT jjfQjAVyw+jqueCZixlDtbYCJel+1r2Hf7/iUzO6JeDbwlFL58KOi4//2eQpFQgz8tza t2mGtfo0ZFVbqwVNgSWmm/Bxi2Ub9/8/5nZ2aNNWonGCoalVHlAH6pPBAftRKVo1BueJ voNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yXcvq1zADtmcg32ryQtdH4a+0FvgZKed0QthCOmoDpI=; b=y/VoKKoDeVUQXEnhCHFSuNfRqNwg/Diuec+vNtqRnhyIYkyOTMlelxmsJW/CBONWFI efjunY1HN9qUBTIMJF9dQPHiDSYzZzejQON2NYCQMrKlYZaxR8gU7DAHXpCJJxMLCFd2 HFHjLetAwPSMKM5mpyozqnYTf9DUe6F7+E1T1eVOWVma5tWeiBeI5kxwg7cD970VevSr iBvwL5/4RdQIa+ZfY1Jq19ZwdusLThhowGrkfBVUgyLvXreiJWID0caGQVk9eM7iE/ZZ iQfAmGxADoVUPupwKyfeTYfdTruyu1SE11GFLaMaAtgm+MdZX/TWbXn6sjJgVZmy2ecW 8ERg== X-Gm-Message-State: AOAM532Vl0mbBuo4gc3vWNI6KSkdkHzs9jq8Gft1kfMkromvcQezJGnb 7Ef6zMP+3/2CG1pCYBxSyNguRjys4f6QiUWzOLQ= X-Google-Smtp-Source: ABdhPJwxaGE2iK30U5/jrs1jVvsUDLIabaQ09onY1Mk3bondvsaQahhYyWt4k5W8cnGvxl3udGcwTpQ+9J3IO1h35kE= X-Received: by 2002:a02:7105:: with SMTP id n5mr1133311jac.64.1633946457732; Mon, 11 Oct 2021 03:00:57 -0700 (PDT) MIME-Version: 1.0 References: <1633689012-14492-1-git-send-email-dillon.minfei@gmail.com> <1633689012-14492-7-git-send-email-dillon.minfei@gmail.com> <290d78b5-b6d4-a115-9556-f2f909f573da@xs4all.nl> In-Reply-To: <290d78b5-b6d4-a115-9556-f2f909f573da@xs4all.nl> From: Dillon Min Date: Mon, 11 Oct 2021 18:00:21 +0800 Message-ID: Subject: Re: [PATCH v3 6/8] media: v4l2-ctrls: Add ARGB color effects control To: Hans Verkuil Cc: Mauro Carvalho Chehab , mchehab+huawei@kernel.org, ezequiel@collabora.com, gnurou@gmail.com, Pi-Hsun Shih , Maxime Coquelin , Alexandre TORGUE , Michael Turquette , Stephen Boyd , Rob Herring , gabriel.fernandez@st.com, gabriel.fernandez@foss.st.com, Patrice CHOTARD , hugues.fruchet@foss.st.com, linux-media , Linux Kernel Mailing List , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_030100_520867_40084D5B X-CRM114-Status: GOOD ( 29.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Hans Thanks for the quick reply. On Mon, 11 Oct 2021 at 17:40, Hans Verkuil wrote: > > On 08/10/2021 12:30, dillon.minfei@gmail.com wrote: > > From: Dillon Min > > > > - add V4L2_COLORFX_SET_ARGB color effects control. > > - add V4L2_CID_COLORFX_ARGB for ARGB color setting. > > > > Signed-off-by: Dillon Min > > --- > > v3: according to Hans's suggestion, thanks. > > - remove old stm32 private R2M ioctl > > - add V4L2_CID_COLORFX_ARGB > > - add V4L2_COLORFX_SET_ARGB > > > > Documentation/userspace-api/media/v4l/control.rst | 8 ++++++++ > > drivers/media/v4l2-core/v4l2-ctrls-defs.c | 2 ++ > > include/uapi/linux/v4l2-controls.h | 4 +++- > > 3 files changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/userspace-api/media/v4l/control.rst b/Documentation/userspace-api/media/v4l/control.rst > > index f8d0b923da20..319606a6288f 100644 > > --- a/Documentation/userspace-api/media/v4l/control.rst > > +++ b/Documentation/userspace-api/media/v4l/control.rst > > @@ -242,8 +242,16 @@ Control IDs > > * - ``V4L2_COLORFX_SET_CBCR`` > > - The Cb and Cr chroma components are replaced by fixed coefficients > > determined by ``V4L2_CID_COLORFX_CBCR`` control. > > + * - ``V4L2_COLORFX_SET_ARGB`` > > + - ARGB colors. > > How about: > > - The ARGB components are replaced by the fixed ARGB components > determined by ``V4L2_CID_COLORFX_ARGB`` control. Sure, will be addressed by v4. > > I also wonder if it makes sense to include the alpha channel here. > > Looking at the driver code it appears to me (I might be wrong) that the alpha > channel is never touched (DMA2D_ALPHA_MODE_NO_MODIF), and setting the alpha > channel as part of a color effects control is rather odd as well. Indeed, Alpha channel is not used in current code. I'll remove this item in v4. how about change the code like below: * - ``V4L2_COLORFX_SET_RGB`` - The RGB components are replaced by the fixed RGB components determined by ``V4L2_CID_COLORFX_RGB`` control. ``V4L2_CID_COLORFX_RGB`` ``(integer)`` Determines the Red, Green, and Blue coefficients for ``V4L2_COLORFX_SET_RGB`` color effect. Bits [7:0] of the supplied 32 bit value are interpreted as Blue component, bits [15:8] as Green component, bits [23:16] as Red component, and bits [31:24] must be zero. > > Alpha channel manipulation really is separate from the color and - if needed - should > be done with a separate control. OK, Will use a separate control when adding blend features. Best Regards, Dillon > > Regards, > > Hans > > > > > > > +``V4L2_CID_COLORFX_ARGB`` ``(integer)`` > > + Determines the Alpha, Red, Green, and Blue coefficients for > > + ``V4L2_COLORFX_SET_ARGB`` color effect. > > + Bits [7:0] of the supplied 32 bit value are interpreted as Blue component, > > + bits [15:8] as Green component, bits [23:16] as Red component, and > > + bits [31:24] as Alpha component. > > > > ``V4L2_CID_COLORFX_CBCR`` ``(integer)`` > > Determines the Cb and Cr coefficients for ``V4L2_COLORFX_SET_CBCR`` > > diff --git a/drivers/media/v4l2-core/v4l2-ctrls-defs.c b/drivers/media/v4l2-core/v4l2-ctrls-defs.c > > index 421300e13a41..53be6aadb289 100644 > > --- a/drivers/media/v4l2-core/v4l2-ctrls-defs.c > > +++ b/drivers/media/v4l2-core/v4l2-ctrls-defs.c > > @@ -785,6 +785,7 @@ const char *v4l2_ctrl_get_name(u32 id) > > case V4L2_CID_MIN_BUFFERS_FOR_OUTPUT: return "Min Number of Output Buffers"; > > case V4L2_CID_ALPHA_COMPONENT: return "Alpha Component"; > > case V4L2_CID_COLORFX_CBCR: return "Color Effects, CbCr"; > > + case V4L2_CID_COLORFX_ARGB: return "Color Effects, ARGB"; > > > > /* > > * Codec controls > > @@ -1392,6 +1393,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type, > > *min = *max = *step = *def = 0; > > break; > > case V4L2_CID_BG_COLOR: > > + case V4L2_CID_COLORFX_ARGB: > > *type = V4L2_CTRL_TYPE_INTEGER; > > *step = 1; > > *min = 0; > > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > > index 5532b5f68493..2876c2282a68 100644 > > --- a/include/uapi/linux/v4l2-controls.h > > +++ b/include/uapi/linux/v4l2-controls.h > > @@ -128,6 +128,7 @@ enum v4l2_colorfx { > > V4L2_COLORFX_SOLARIZATION = 13, > > V4L2_COLORFX_ANTIQUE = 14, > > V4L2_COLORFX_SET_CBCR = 15, > > + V4L2_COLORFX_SET_ARGB = 16, > > }; > > #define V4L2_CID_AUTOBRIGHTNESS (V4L2_CID_BASE+32) > > #define V4L2_CID_BAND_STOP_FILTER (V4L2_CID_BASE+33) > > @@ -145,9 +146,10 @@ enum v4l2_colorfx { > > > > #define V4L2_CID_ALPHA_COMPONENT (V4L2_CID_BASE+41) > > #define V4L2_CID_COLORFX_CBCR (V4L2_CID_BASE+42) > > +#define V4L2_CID_COLORFX_ARGB (V4L2_CID_BASE+43) > > > > /* last CID + 1 */ > > -#define V4L2_CID_LASTP1 (V4L2_CID_BASE+43) > > +#define V4L2_CID_LASTP1 (V4L2_CID_BASE+44) > > > > /* USER-class private control IDs */ > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel