From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB7DC433EF for ; Tue, 1 Mar 2022 00:51:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229901AbiCAAwD (ORCPT ); Mon, 28 Feb 2022 19:52:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbiCAAwB (ORCPT ); Mon, 28 Feb 2022 19:52:01 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 242CD10FE4 for ; Mon, 28 Feb 2022 16:51:21 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id m14so24288682lfu.4 for ; Mon, 28 Feb 2022 16:51:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AHMKNwsJmZIv42C56dUYCGLQL894qM+ba23hywWTdn8=; b=CvrUBJC6MSgGF2nfgS8h6+bd3OM57xvy6mAQ5dDJSDF+HjBQendAmIUKlh1i1XlWJT tfNEvm8PWqbbhCmzwhoWSgEEDCByUvTreqcxm/q8nO2R0zzwFAgv1MrBAC9+bpiv7g/F pTxXnGdDTLZNGOFzq0M2d/89Pzhxwk3ItZZu0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AHMKNwsJmZIv42C56dUYCGLQL894qM+ba23hywWTdn8=; b=msQ3Dd3u/d3XfcKsf+n3Hh9TVxURvo3DhRRC5TzyaC7eZaeZEKr4XIe9FuZsaSwTZ4 cVC2R24Zih7PlLD+HJNpMVzNS8cj2CDMpETCmtLpR0zabXjwrnUoLrszNIijp4n0ff2E ig/Am45l3rfyqjqW5pAAhrxm7ck137Sj6ACQazrhVVs8jG7FDR6OkKU2Xn810OZOWDuo kbkMjYV2G+nSpPwVeCfUPNvwr1F/Lc0tQ2w7fWo7ypC/is0gmH+QkUfy93UNKeMy9w7z GMYIkKv8Dj7/+IyOx8WaiB/5of5Ij8NFgNk94ARgmfswYDIBqRuqRuaj4MPZyigjU4yz JWew== X-Gm-Message-State: AOAM532RuO1mNmpa60VlYZWyQFUARyRGf4JgH3JqgSJ7n/pZ15CATwNS S3cg+Rfsz8IRLUQovLvxJ68UWQKST68CbDBoKVXqOg== X-Google-Smtp-Source: ABdhPJx1XgxrxKvShJZnqXdRuXmzpPyv95vdF2irZB/EkJsngmyT6nJoPFnRQo6osF+EKqx9c8UESUZekiL9gRL6td8= X-Received: by 2002:ac2:5b4b:0:b0:43c:795a:25a6 with SMTP id i11-20020ac25b4b000000b0043c795a25a6mr14461839lfp.268.1646095879481; Mon, 28 Feb 2022 16:51:19 -0800 (PST) MIME-Version: 1.0 References: <1645810914-35485-1-git-send-email-jdamato@fastly.com> <1645810914-35485-5-git-send-email-jdamato@fastly.com> <453c24e6-f9b1-0b7d-3144-7b3db1d94944@redhat.com> <87h78jxsrl.fsf@toke.dk> In-Reply-To: <87h78jxsrl.fsf@toke.dk> From: Joe Damato Date: Mon, 28 Feb 2022 16:51:08 -0800 Message-ID: Subject: Re: [net-next v7 4/4] mlx5: add support for page_pool_get_stats To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, kuba@kernel.org, ilias.apalodimas@linaro.org, davem@davemloft.net, hawk@kernel.org, saeed@kernel.org, ttoukan.linux@gmail.com, brouer@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 28, 2022 at 1:17 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Joe Damato writes: > > > On Sun, Feb 27, 2022 at 11:28 PM Jesper Dangaard Brouer > > wrote: > >> > >> > >> > >> On 25/02/2022 18.41, Joe Damato wrote: > >> > +#ifdef CONFIG_PAGE_POOL_STATS > >> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_fast)= }, > >> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_slow)= }, > >> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_slow_= high_order) }, > >> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_empty= ) }, > >> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_refil= l) }, > >> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_waive= ) }, > >> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_rec_c= ached) }, > >> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_rec_c= ache_full) }, > >> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_rec_r= ing) }, > >> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_rec_r= ing_full) }, > >> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_rec_r= eleased_ref) }, > >> > +#endif > >> > >> The naming: "page_pool_rec_xxx". > >> What does the "rec" stand for? > > > > rec stands for recycle. > > > > ethtool strings have a limited size (ETH_GSTRING_LEN - 32 bytes) and > > the full word "recycle" didn't fit for some of the stats once the > > queue number is prepended elsewhere in the driver code. > > > >> Users of ethtool -S stats... will they know "rec" is "recycle" ? > > > > I am open to other names or adding documentation to the driver docs to > > explain the meaning. > > You could shorten the 'page_pool_' prefix to 'ppool_' or even 'pp_' and > gain some characters that way? I had considered this, but I thought that 'pp' was possibly as terse as 're= c'. If you all think these are more clear, I can send a v8 of this series that changes the strings from the above to this instead: rx_pp_alloc_fast rx_pp_alloc_slow rx_pp_alloc_... and rx_pp_recyle_cached rx_pp_recycle_cache_full rx_pp_recycle_... With this name scheme, it looks like all the stat names seem to fit. I have no idea if this is more or less clear to the user though :) I'll leave it up to the mlx5 maintainers; I am happy to do whatever they prefer to get this series in. Thanks, Joe