From: Nikunj Dadhania <nikunj.dadhania@gmail.com>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org,
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
bharata@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd
Date: Thu, 2 Mar 2017 09:44:17 +0530 [thread overview]
Message-ID: <CALAZu3_dXwjN1T=VS3pfzU-rf40dT2a8zWHhKLfor+mnb6eVwQ@mail.gmail.com> (raw)
In-Reply-To: <820beb1e-20e9-9588-f39d-a7f20ee8af4a@twiddle.net>
On 02-Mar-2017 8:07 AM, "Richard Henderson" <rth@twiddle.net> wrote:
On 03/02/2017 02:24 AM, Nikunj A Dadhania wrote:
> +static void float64_madd_set_vxisi(CPUPPCState *env, float64 a, float64
> b,
> + float64 c, unsigned int flags)
> {
> + float64 f = float64_mul(a, b, &env->fp_status);
>
What is the point of this multiply?
Only to compute vxisi as stated in the thread
"If the product of x and y is an Infinity and z is an Infinity of the
opposite sign, vxisi_flag is set to 1."
Let me know if I there is an alternative way to achieve this.
> + /* a*b = ∞ and c = ∞, find ∞ - ∞ case and set VXISI */
> + if (float64_is_infinity(f) && float64_is_infinity(c)) {
> + if ((f ^ c) == 0) {
> + /* Both negative/positive inifinity and substraction*/
> + if (flags & MSUB_FLGS) {
>
I would really prefer you use the float_muladd_* names.
Sure.
+uint64_t helper_##op(CPUPPCState *env, uint64_t arg1, \
> + uint64_t arg2, uint64_t arg3) \
> +{ \
> + if (unlikely((float64_is_infinity(arg1) && float64_is_zero(arg2)) ||
> \
> + (float64_is_zero(arg1) && float64_is_infinity(arg2)))) {
> \
> + /* Multiplication of zero by infinity */ \
> + arg1 = float_invalid_op_excp(env, POWERPC_EXCP_FP_VXIMZ, 1); \
> + } else { \
> + if (unlikely(float64_is_signaling_nan(arg1, &env->fp_status) || \
> + float64_is_signaling_nan(arg2, &env->fp_status) || \
> + float64_is_signaling_nan(arg3, &env->fp_status))) {
> \
> + /* sNaN operation */ \
> + float_invalid_op_excp(env, POWERPC_EXCP_FP_VXSNAN, 1); \
> + } \
> + \
> + float64_madd_set_vxisi(env, arg1, arg2, arg3, madd_flags); \
> + arg1 = float64_muladd(arg1, arg2, arg3, madd_flags, \
> + &env->fp_status); \
> + float_check_status(env); \
>
I know this is the layout of the bulk of the ppc target, but it's
inefficient. Let's do this one correctly, akin to target/tricore:
result = float64_muladd(args...);
flags = get_float_exception_flags(&env->fp_status);
if (flags) {
if (flags & float_flag_invalid) {
// examine inputs to see why we return NaN
}
float_check_status(env);
}
Sure.
Nikunj
next prev parent reply other threads:[~2017-03-02 4:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 15:24 [Qemu-devel] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd Nikunj A Dadhania
2017-03-02 0:29 ` David Gibson
2017-03-02 2:22 ` Richard Henderson
2017-03-02 4:08 ` [Qemu-devel] [Qemu-ppc] " Nikunj Dadhania
2017-03-02 5:03 ` Nikunj A Dadhania
2017-03-02 2:36 ` [Qemu-devel] " Richard Henderson
2017-03-02 4:14 ` Nikunj Dadhania [this message]
2017-03-02 5:04 ` [Qemu-devel] [Qemu-ppc] " Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALAZu3_dXwjN1T=VS3pfzU-rf40dT2a8zWHhKLfor+mnb6eVwQ@mail.gmail.com' \
--to=nikunj.dadhania@gmail.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.