All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Maxim Altshul <maxim.altshul@ti.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Kalle Valo <kvalo@codeaurora.org>,
	Eliad Peller <eliad@wizery.com>, Yaniv Machani <yanivma@ti.com>
Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput
Date: Thu, 4 Aug 2016 23:03:29 -0700	[thread overview]
Message-ID: <CALAqxLU_=1hvpneB+LMe51J5YQh0LdhYo=V5=UwDBAU1Zp-Lbg@mail.gmail.com> (raw)
In-Reply-To: <1470375614.2977.1.camel@sipsolutions.net>

On Thu, Aug 4, 2016 at 10:40 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Thu, 2016-08-04 at 14:31 -0700, John Stultz wrote:
>> On Thu, Aug 4, 2016 at 5:43 AM, Maxim Altshul <maxim.altshul@ti.com>
>> wrote:
>> > - The variable is added to allow the driver an easy access
>> > to it's own hw->priv when the op is invoked.
>> >
>> > - Change wlcore op accordingly.
>> >
>> > Signed-off-by: Maxim Altshul <maxim.altshul@ti.com>
>>
>> These two patches solve the regression I was seeing with pre-v4.8-rc1
>> kernels on HiKey.
>>
>
> Interesting, what was the regression? Was the station pointer there not
> valid?

Yea, a null pointer deference:
https://lkml.org/lkml/2016/7/27/712

thanks
-john

  reply	other threads:[~2016-08-05  6:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 12:43 [PATCH 0/2] get_expected_throughput interface update Maxim Altshul
2016-08-04 12:43 ` [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput Maxim Altshul
2016-08-04 12:43   ` [PATCH 2/2] wlcore: Remove wl pointer from wl_sta structure Maxim Altshul
2016-08-04 21:31     ` John Stultz
2016-08-15  7:56     ` Kalle Valo
2016-08-15  7:56     ` Kalle Valo
2016-08-04 21:31   ` [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput John Stultz
2016-08-05  5:40     ` Johannes Berg
2016-08-05  6:03       ` John Stultz [this message]
2016-08-05 12:22   ` Johannes Berg
2016-08-05 12:24     ` Johannes Berg
2016-08-05 13:25       ` Altshul, Maxim
2016-08-05 15:34         ` Johannes Berg
2016-08-07 13:42           ` Altshul, Maxim
2016-08-08  6:10             ` Johannes Berg
2016-08-08 10:42               ` Altshul, Maxim
2016-08-09  7:58                 ` Johannes Berg
2016-08-10  8:03                   ` Altshul, Maxim
2016-08-15  7:59   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALAqxLU_=1hvpneB+LMe51J5YQh0LdhYo=V5=UwDBAU1Zp-Lbg@mail.gmail.com' \
    --to=john.stultz@linaro.org \
    --cc=eliad@wizery.com \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxim.altshul@ti.com \
    --cc=yanivma@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.