From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754307AbcG2Wkw (ORCPT ); Fri, 29 Jul 2016 18:40:52 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:32917 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754112AbcG2Wkr (ORCPT ); Fri, 29 Jul 2016 18:40:47 -0400 MIME-Version: 1.0 In-Reply-To: <20160724072509.GC9681@localhost> References: <1469073189-9167-1-git-send-email-john.stultz@linaro.org> <1469073189-9167-2-git-send-email-john.stultz@linaro.org> <20160724072509.GC9681@localhost> From: John Stultz Date: Fri, 29 Jul 2016 15:40:46 -0700 Message-ID: Subject: Re: [PATCH 1/7] k3dma: Fix hisi burst clipping To: Vinod Koul Cc: lkml , Andy Green , Zhangfei Gao , Jingoo Han , Krzysztof Kozlowski , Maxime Ripard , Dan Williams , Mark Brown , Andy Green Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 24, 2016 at 12:25 AM, Vinod Koul wrote: > On Wed, Jul 20, 2016 at 08:53:03PM -0700, John Stultz wrote: >> From: Andy Green >> >> Max burst len is a 4-bit field, but at the moment it's clipped with >> a 5-bit constant... reduce it to that which can be expressed > > Maybe we should GENMASK() etc to avoid these errors.. Not sure I follow what you're thinking here... can you clarify a bit? thanks -john