From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932167AbdJWVgI (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Oct 2017 17:36:08 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:43854 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751299AbdJWVgG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2017 17:36:06 -0400
X-Google-Smtp-Source: ABhQp+SPIqiKafszk44vSbl5M+n9a7cVKllJ4LRPGXBw7QtRwF4AtRk6U1D0KnRBOQWkOTFiQmyi7nmmWdPTovtLJ4U=
MIME-Version: 1.0
In-Reply-To: <CALAqxLVzzypXaNqjqdn3cDr89jXQrQrfD7w8JfNhFKc=eJTHrg@mail.gmail.com>
References: <1505937448-13475-1-git-send-email-john.stultz@linaro.org>
 <2B3535C5ECE8B5419E3ECBE3007729090269FF70AC@US01WEMBX2.internal.synopsys.com>
 <410670D7E743164D87FA6160E7907A560113A21CDB@am04wembxa.internal.synopsys.com>
 <CALAqxLXqeY0om1sCc04zywkNCTw2_xKxOSfVZGK=sSmPeoP=ug@mail.gmail.com>
 <410670D7E743164D87FA6160E7907A560113A2C8E9@am04wembxa.internal.synopsys.com>
 <CALAqxLXoSmKuGGROsWqas2pq4iXJ_jawJ+kkM19G3vQ2bNP0Hg@mail.gmail.com>
 <410670D7E743164D87FA6160E7907A560113A2E38F@am04wembxa.internal.synopsys.com>
 <CALAqxLV71UvLtZU=MYwgVmuGU-hV+hs5jFy09AgvihJWQBEkmA@mail.gmail.com>
 <410670D7E743164D87FA6160E7907A560113A2ECC2@am04wembxa.internal.synopsys.com>
 <410670D7E743164D87FA6160E7907A560113A3036D@am04wembxa.internal.synopsys.com>
 <CALAqxLWBrnOwgA3QATMY3NGQgm5GZOXQRSpeDtoo7OA7UwRCJA@mail.gmail.com>
 <410670D7E743164D87FA6160E7907A560113A31032@am04wembxa.internal.synopsys.com>
 <410670D7E743164D87FA6160E7907A560113A31B67@am04wembxa.internal.synopsys.com> <CALAqxLVzzypXaNqjqdn3cDr89jXQrQrfD7w8JfNhFKc=eJTHrg@mail.gmail.com>
From: John Stultz <john.stultz@linaro.org>
Date: Mon, 23 Oct 2017 14:36:04 -0700
Message-ID: <CALAqxLUx5J1=uLexHGCwjjYCpnX6qL+MQ58oxNEqmn1i29LLMw@mail.gmail.com>
Subject: Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey
To: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
Cc: John Youn <John.Youn@synopsys.com>,
        lkml <linux-kernel@vger.kernel.org>, Wei Xu <xuwei5@hisilicon.com>,
        Guodong Xu <guodong.xu@linaro.org>,
        Amit Pundir <amit.pundir@linaro.org>,
        YongQin Liu <yongqin.liu@linaro.org>,
        Douglas Anderson <dianders@chromium.org>,
        Chen Yu <chenyu56@huawei.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 23, 2017 at 1:41 PM, John Stultz <john.stultz@linaro.org> wrote:
> On Mon, Oct 23, 2017 at 2:19 AM, Minas Harutyunyan
> <Minas.Harutyunyan@synopsys.com> wrote:
>> Could you please verify on your setup follow patches:
>> 1. Vardan's patch.
>> 2. Patch for TOUTCAL&USBTRDTIM programming (new version see below).
>> 4. Your patch 2/3 to avoid "Mode Mismatch" interrupts.
>> 5. Your patch 3/3 to set udc state to "not attached".
>> 6. Your patch 1/3, but remove dwc2_hsotg_core_init_disconnected()
>> function call from Host starting brnch, keep *only*
>> dwc2_hsotg_disconnect() to change UDC state to "not attached".
>
> So yes, this set does seem to work ok for me. Though neither Vardan's
> patch or the TOUTCAL/USBTRDTIM patch seem to have much effect either
> way (I need to do more testing just to be sure, but for the use cases
> I've had trouble with they don't seem to do much).
>
> I'm happy to rework my earlier patch #1/3 to remove
> dwc2_hsotg_core_init_disconnected() and resend.

Just resent the set of my changes with the above tweak.

The stack including Vardan's and your fixes that I also tested with
(but to little effect) can be found here:
https://git.linaro.org/people/john.stultz/android-dev.git/log/?id=4302a823816e944a6f548b05049c4e4c006bbadd

thanks
-john