From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753790AbcK1Sje (ORCPT <rfc822;w@1wt.eu>);
        Mon, 28 Nov 2016 13:39:34 -0500
Received: from mail-oi0-f48.google.com ([209.85.218.48]:34429 "EHLO
        mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750971AbcK1Sj0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Nov 2016 13:39:26 -0500
MIME-Version: 1.0
In-Reply-To: <36DF59CE26D8EE47B0655C516E9CE6405E63B123@shsmsx102.ccr.corp.intel.com>
References: <1479531014-25264-1-git-send-email-john.stultz@linaro.org>
 <1479531014-25264-4-git-send-email-john.stultz@linaro.org>
 <20161121081755.GB14231@gmail.com> <36DF59CE26D8EE47B0655C516E9CE6405E63B123@shsmsx102.ccr.corp.intel.com>
From: John Stultz <john.stultz@linaro.org>
Date: Mon, 28 Nov 2016 10:39:24 -0800
Message-ID: <CALAqxLUyrEYfLP+=WNPaa=wGsp_yo78+BauuZEyiMR69QrKcRw@mail.gmail.com>
Subject: Re: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm_trace
 is enabled
To: "Chen, Yu C" <yu.c.chen@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Xunlei Pang <xlpang@redhat.com>, Ingo Molnar <mingo@redhat.com>,
        Len Brown <lenb@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Pavel Machek <pavel@ucw.cz>, Thomas Gleixner <tglx@linutronix.de>,
        Prarit Bhargava <prarit@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 24, 2016 at 1:54 AM, Chen, Yu C <yu.c.chen@intel.com> wrote:
> Hi,
>
>> -----Original Message-----
>> From: Ingo Molnar [mailto:mingo.kernel.org@gmail.com] On Behalf Of Ingo
>> Molnar
>> Sent: Monday, November 21, 2016 4:18 PM
>> To: John Stultz
>> Cc: lkml; Chen, Yu C; Rafael J. Wysocki; Xunlei Pang; Ingo Molnar; Len Brown; H.
>> Peter Anvin; Pavel Machek; Thomas Gleixner; Prarit Bhargava; Richard Cochran
>> Subject: Re: [PATCH 3/4] timekeeping: Ignore the bogus sleep time if pm_trace
>> is enabled
>>
>>
>> * John Stultz <john.stultz@linaro.org> wrote:
>>
>> > +static int pm_trace_notify(struct notifier_block *nb,
>> > +                           unsigned long mode, void *_unused) {
>> > +   switch (mode) {
>> > +   case PM_POST_HIBERNATION:
>> > +   case PM_POST_SUSPEND:
>> > +           if (pm_trace_rtc_abused) {
>> > +                   pm_trace_rtc_abused = false;
>> > +                   pr_warn("Possible incorrect RTC due to pm_trace,"
>> > +                           "please use ntp-date or rdate to reset.\n");
>>
>> Please don't break user-visible strings just to pacify checkpatch!
>>
>> The bogus linebreak above hides a type in the user string:
>>
>>   Possible incorrect RTC due to pm_trace,please use ntp-date or rdate to reset.
>>
>> (There's a missing space after the comma.)
>>
>> Best practice is to preserve the continuous nature of the user string in the code.
>>
>> In addition to that, please quote suggested command names, i.e. something like:
>>
>>   Possible incorrect RTC due to pm_trace, please use 'ntp-date' or 'rdate' to
>> reset it.
> OK, will do.

Just a heads up. I've already made these changes in my tree.

thanks
-john