From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2629AC433DF for ; Thu, 20 Aug 2020 01:53:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D952620885 for ; Thu, 20 Aug 2020 01:53:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qN6Z+7A+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726723AbgHTBxU (ORCPT ); Wed, 19 Aug 2020 21:53:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726435AbgHTBxU (ORCPT ); Wed, 19 Aug 2020 21:53:20 -0400 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 167B5C061757 for ; Wed, 19 Aug 2020 18:53:20 -0700 (PDT) Received: by mail-oi1-x243.google.com with SMTP id b22so702827oic.8 for ; Wed, 19 Aug 2020 18:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=95vglf64Vq/O/1I3tuau6vIlhCDn5C32IVrNU3ul3Rs=; b=qN6Z+7A+Lbqvnw/Y3D/+sTqCsXSHZNFofii9Sv7TAGxZTT4nzYugE0dv9WTjhy2Ach +bhLMdQLy50q5omf+RBQ7ttymA4E2wnLpegiXS6qkD0jOwznXKg6Uhanq75UdpRrSZ66 OM5P1bIQaiyp+S+D5AsSGvF1RLWV0iyMOLjSPXcJJ5W4N8NQvko9tn0H8YwE5EYRDUYh 5bltJlJRMt+4kkGWuQZZd1tFeESB9OagrslJBjw8flAHuV7E+cA49b+f4QZ+Ys+qKJzf yt9Du/YLUFEDZvS0GWAkjnup+G5NgTLBJdMf5qwxqk3iQE1wPRWq6d8GTvx0sLSy1P6D aTtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=95vglf64Vq/O/1I3tuau6vIlhCDn5C32IVrNU3ul3Rs=; b=GoqCUJunZQMUOWgp6fVizbAUg3HTDF2XwhwFi5rd1f5UG3+RZXOyccudBAnFiQvzdk QUOrOkyh/qeBsvWHW71aWcvNn7F1t4m0n7wkFiDh8YKeos0gwFqwPfLKxEag5Stw4FXU OUqckCbxzyptWB5Y5CcDJPlPSA/VR/YJeSoHNgUI5JESvmTT1gzJR9ouLE4Q31mqIhmh FoRBuTpnQMzz96c05+mOFbt24CexIEjHYIZ01xYOcG0oxylxgKUFpUWBbloXCTdZgU2W E1lmxpYjZmUVCGggeDgN+czU9Z43B0hvC2vM0TlfI92WYJfgpAe8twdBHS7uYBfQw3bk Jthg== X-Gm-Message-State: AOAM530b3kXGtU7RaIPTZ6P0Wa+kpQS7TYsMCgBAcvo0dfPrKYQNFTjw DrscGGRJA0rem3RFgc2Eb0ee7uzRjlkjat4pp0+25g== X-Google-Smtp-Source: ABdhPJySRF2+7apSZAyGDFV0x5mhrt3OKJXKRRGDgyzVeBsX16AotO12+Vzd0RVSZAnZmVjb8g7Vq+nZj9NHf4LQsIU= X-Received: by 2002:aca:1014:: with SMTP id 20mr557719oiq.169.1597888399467; Wed, 19 Aug 2020 18:53:19 -0700 (PDT) MIME-Version: 1.0 References: <9fa944021373ec5b82c2c1e118c15d9effe7f964.1597833138.git.mchehab+huawei@kernel.org> In-Reply-To: <9fa944021373ec5b82c2c1e118c15d9effe7f964.1597833138.git.mchehab+huawei@kernel.org> From: John Stultz Date: Wed, 19 Aug 2020 18:53:06 -0700 Message-ID: Subject: Re: [PATCH 25/49] staging: hikey9xx/gpu: do some code cleanups To: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , linuxarm@huawei.com, mauro.chehab@huawei.com, Manivannan Sadhasivam , Daniel Vetter , dri-devel , Xiubin Zhang , Liwei Cai , Chen Feng , driverdevel , lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab wrote: > @@ -376,7 +355,7 @@ static int kirin_drm_platform_resume(struct platform_device *pdev) > } > > static const struct of_device_id kirin_drm_dt_ids[] = { > - { .compatible = "hisilicon,hi3660-dpe", > + { .compatible = "hisilicon,kirin960-dpe", One issue, elsewhere in your patch stack you still refer to the hisilicon,hi3660-dpe compatible string. This should probably be consistent one way or the other. thanks -john From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=BAYES_40,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC94CC433E1 for ; Thu, 20 Aug 2020 01:53:24 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBF49207DA for ; Thu, 20 Aug 2020 01:53:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qN6Z+7A+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBF49207DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 839E9226A2; Thu, 20 Aug 2020 01:53:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id enmnCbocz0HQ; Thu, 20 Aug 2020 01:53:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 8B6B6220C5; Thu, 20 Aug 2020 01:53:22 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 0CF241BF311 for ; Thu, 20 Aug 2020 01:53:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 099468688F for ; Thu, 20 Aug 2020 01:53:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LXD4y9YPVuKJ for ; Thu, 20 Aug 2020 01:53:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 4C043867BD for ; Thu, 20 Aug 2020 01:53:20 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id a24so708702oia.6 for ; Wed, 19 Aug 2020 18:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=95vglf64Vq/O/1I3tuau6vIlhCDn5C32IVrNU3ul3Rs=; b=qN6Z+7A+Lbqvnw/Y3D/+sTqCsXSHZNFofii9Sv7TAGxZTT4nzYugE0dv9WTjhy2Ach +bhLMdQLy50q5omf+RBQ7ttymA4E2wnLpegiXS6qkD0jOwznXKg6Uhanq75UdpRrSZ66 OM5P1bIQaiyp+S+D5AsSGvF1RLWV0iyMOLjSPXcJJ5W4N8NQvko9tn0H8YwE5EYRDUYh 5bltJlJRMt+4kkGWuQZZd1tFeESB9OagrslJBjw8flAHuV7E+cA49b+f4QZ+Ys+qKJzf yt9Du/YLUFEDZvS0GWAkjnup+G5NgTLBJdMf5qwxqk3iQE1wPRWq6d8GTvx0sLSy1P6D aTtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=95vglf64Vq/O/1I3tuau6vIlhCDn5C32IVrNU3ul3Rs=; b=qD3mDFVZPHjwM+/OZ5uurcSGMJgPGNr125rrsRFHat/PuP0KHzrMcrfQQjDrfFx8Wr CLtFJSRzynEGYpM8DSjP6scQDZ4aBsmDSk1tf+5bHgfh8xtNVrqnyjFKeH0GnBC+LmiR JJ61zLlcMFGltI5K0jFGUcP3Ar+Mh2F0fW5t3FBQYNcsjxKK1l/4RK9KA7D7tr++Amog a4kWf8AmtPU2ggvQc0vutb9LSKdzART3WvPaL5DQh5ECbhoJnN2bVFGacKIiRKUjAi5+ sOsKkY8g9oIzWlxDGg27yfHWA6Gu82vTKzTyYKmoSLLqbccOb9DK26pnyz9/DoJ6MoI+ kZ6Q== X-Gm-Message-State: AOAM533sSvVthrBO65QfLnFG9MCGkwWEDcM92F9bmO4kiHqsaefpflh7 XQp9u1O7577OZ4jEfV3103HMxTRpZTPWn72Z8iv1Lw== X-Google-Smtp-Source: ABdhPJySRF2+7apSZAyGDFV0x5mhrt3OKJXKRRGDgyzVeBsX16AotO12+Vzd0RVSZAnZmVjb8g7Vq+nZj9NHf4LQsIU= X-Received: by 2002:aca:1014:: with SMTP id 20mr557719oiq.169.1597888399467; Wed, 19 Aug 2020 18:53:19 -0700 (PDT) MIME-Version: 1.0 References: <9fa944021373ec5b82c2c1e118c15d9effe7f964.1597833138.git.mchehab+huawei@kernel.org> In-Reply-To: <9fa944021373ec5b82c2c1e118c15d9effe7f964.1597833138.git.mchehab+huawei@kernel.org> From: John Stultz Date: Wed, 19 Aug 2020 18:53:06 -0700 Message-ID: Subject: Re: [PATCH 25/49] staging: hikey9xx/gpu: do some code cleanups To: Mauro Carvalho Chehab X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: driverdevel , Liwei Cai , Manivannan Sadhasivam , Greg Kroah-Hartman , linuxarm@huawei.com, dri-devel , Xiubin Zhang , Daniel Vetter , Chen Feng , mauro.chehab@huawei.com, lkml Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab wrote: > @@ -376,7 +355,7 @@ static int kirin_drm_platform_resume(struct platform_device *pdev) > } > > static const struct of_device_id kirin_drm_dt_ids[] = { > - { .compatible = "hisilicon,hi3660-dpe", > + { .compatible = "hisilicon,kirin960-dpe", One issue, elsewhere in your patch stack you still refer to the hisilicon,hi3660-dpe compatible string. This should probably be consistent one way or the other. thanks -john _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB2EFC433E1 for ; Thu, 20 Aug 2020 01:53:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1028207FB for ; Thu, 20 Aug 2020 01:53:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qN6Z+7A+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1028207FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A61F86E88A; Thu, 20 Aug 2020 01:53:21 +0000 (UTC) Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 495B96E88A for ; Thu, 20 Aug 2020 01:53:20 +0000 (UTC) Received: by mail-oi1-x243.google.com with SMTP id u63so718250oie.5 for ; Wed, 19 Aug 2020 18:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=95vglf64Vq/O/1I3tuau6vIlhCDn5C32IVrNU3ul3Rs=; b=qN6Z+7A+Lbqvnw/Y3D/+sTqCsXSHZNFofii9Sv7TAGxZTT4nzYugE0dv9WTjhy2Ach +bhLMdQLy50q5omf+RBQ7ttymA4E2wnLpegiXS6qkD0jOwznXKg6Uhanq75UdpRrSZ66 OM5P1bIQaiyp+S+D5AsSGvF1RLWV0iyMOLjSPXcJJ5W4N8NQvko9tn0H8YwE5EYRDUYh 5bltJlJRMt+4kkGWuQZZd1tFeESB9OagrslJBjw8flAHuV7E+cA49b+f4QZ+Ys+qKJzf yt9Du/YLUFEDZvS0GWAkjnup+G5NgTLBJdMf5qwxqk3iQE1wPRWq6d8GTvx0sLSy1P6D aTtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=95vglf64Vq/O/1I3tuau6vIlhCDn5C32IVrNU3ul3Rs=; b=smOOawLf1A/RmkA2VLkYRcQBjypro2Zrmrv/S2IpTZvFnIuf9oKpFvAXmelfJqIr41 25j6j9pVBkIDs2WI2Za99+NWI9BhQNWIMxgOOld+app61o4zQmHelgktDsPzRschZdX7 KUVoP1Y6/HbE65ZVWBO7uDslaK4Mdj57l5c6VpMwtA+pB2DvmJHZbGfRFKR7URe7BsfD 0K3st/06gi122O20OpcKWuLC3R/zfJ8AjbT0jjC0HAx2eihguE5VNdEfVmH6LZaRUKAP DfFJNvjBSmCradc1IovjhDupBoyDTAnOl/G8N3hmhWNlZr2bDoaWagzOqDBn4RAR0LYu /QCg== X-Gm-Message-State: AOAM5321ZhTQpGftmA87VSR8hhG/DT6q4hWyff3bPYckMXxfcU44QV5Q RYT34vktqi/EACI592Yz3MDvQ/uQoeyO27MpDG2oKA== X-Google-Smtp-Source: ABdhPJySRF2+7apSZAyGDFV0x5mhrt3OKJXKRRGDgyzVeBsX16AotO12+Vzd0RVSZAnZmVjb8g7Vq+nZj9NHf4LQsIU= X-Received: by 2002:aca:1014:: with SMTP id 20mr557719oiq.169.1597888399467; Wed, 19 Aug 2020 18:53:19 -0700 (PDT) MIME-Version: 1.0 References: <9fa944021373ec5b82c2c1e118c15d9effe7f964.1597833138.git.mchehab+huawei@kernel.org> In-Reply-To: <9fa944021373ec5b82c2c1e118c15d9effe7f964.1597833138.git.mchehab+huawei@kernel.org> From: John Stultz Date: Wed, 19 Aug 2020 18:53:06 -0700 Message-ID: Subject: Re: [PATCH 25/49] staging: hikey9xx/gpu: do some code cleanups To: Mauro Carvalho Chehab X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: driverdevel , Liwei Cai , Manivannan Sadhasivam , Greg Kroah-Hartman , linuxarm@huawei.com, dri-devel , Xiubin Zhang , Chen Feng , mauro.chehab@huawei.com, lkml Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab wrote: > @@ -376,7 +355,7 @@ static int kirin_drm_platform_resume(struct platform_device *pdev) > } > > static const struct of_device_id kirin_drm_dt_ids[] = { > - { .compatible = "hisilicon,hi3660-dpe", > + { .compatible = "hisilicon,kirin960-dpe", One issue, elsewhere in your patch stack you still refer to the hisilicon,hi3660-dpe compatible string. This should probably be consistent one way or the other. thanks -john _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel