From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40444C43217 for ; Mon, 29 Nov 2021 18:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0Wyr+Ql8syk8m5fSSRREjxMyRH+FIaaR60Z3POc0fCI=; b=Oj7IwymllIYxdL vLVkTpeFK9FCwOa6TXkKjDoLe+SdotSi3WSMag3QNjzNP9kqAfGbXODtW3RvvCXDKaFvouDC0ADjD Vt35AaEhaHO83c5zDYPgQeTeG/13wyfbn8Aqv47DFuAlNMdTNcE0jdkXG4WnoDa07jbFH8yudKGJU Ct9D9Hs5kmgP6vB5a8uT3+qrWF3LdlEBaUikQVFg3aJkEsJGuY86/3t65uNA3CpmHOxZkygFX3P7h SscikYXuZaBs+bkJ0e9KL6rXGJnZwb+JaBPZUD8Gn7eEodhVa/T284uyzeFRIYqWrNolwgMMcFnyG sK0K3Sxd8kEMu9Rvz2CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrl1u-001hic-9H; Mon, 29 Nov 2021 18:05:30 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrl1h-001heC-1b for linux-mediatek@lists.infradead.org; Mon, 29 Nov 2021 18:05:18 +0000 Received: by mail-lj1-x22b.google.com with SMTP id t11so36071260ljh.6 for ; Mon, 29 Nov 2021 10:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IDi3zvjd6u7ZBVvXAka/LTSyAvUkqeh+L5SnX6c8Zdk=; b=ELtQ57DjVTWJPnvASv4jZtvg9xzVjpRXdLK6WadVUiqQO2Tejx2Y4rP/jZvsvwdaGM wVK5qYNcJTRTVvihhUy6a3XfzO7ShXe3HSKg9CJ9S9TdxAt3X4+ddQNsKXsRbhOEV3Nn NeS7l4DPoqAaH0j+Gm2rrnRobzgyBp+zZRI4nhmfoSItyMTQPe6HJsrb3a8uXIO7pAUp d0pHSCno/fnC3Fp0q+W51eSWigYy/I5qIJhRZa/O1KEhI708OF8jeLET61Dg8b9kw0VH st1/mw7gEQ1NVGLv+ANo/xqXiZgR94N5ykkWzVgrrh3SWq2UdJQ1DTZyuwBI86rq3HIq HE3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IDi3zvjd6u7ZBVvXAka/LTSyAvUkqeh+L5SnX6c8Zdk=; b=Xxyir1Uu5ZaTQ/cAR8whAyUo/lRZ7CTOXEKyO3WUaZF3ChJJL6K/KhnO4kqbQW6DNn /DP9vT102p6MV8c6bAQgv35wf2wxEf61ROu4RvW0Yfvvnwb0SPydmh5Z6eghBoahrJx5 i6b45luhkHTifXWe/2eHj5lS3vKr7a8tNZDxYMlRYcJcTPFnpF5Xl2S1ce6/Jew/Z1AR ObLvNHyOXh/l79Oui1PYakK6T4p63ihwt7XbHk7zkxw4lEjcpLKCxMe7Ezc353GEfUKs Jbq/aoOaGn5czr8H9O1/D1nfKWP4m5jBtfnTyox9h87bYrXZg24B4jmzU+h+na0dMer5 QhvQ== X-Gm-Message-State: AOAM531a8ldBeWtI4ZhFsg3MzYUh7iILqm4pNL5kr6BDr07o51JQAv9p SXg/FE3Imall74WfQs/7SJsMcjbw4gtqDlHMGSHbjw== X-Google-Smtp-Source: ABdhPJz00rJJqhFv+eY/G4mQJbhWwtM/vfpfxJXb8qlKInsjRYgNcLli9eLdqgC5XVztKYKpkdzK0NNalzo7Gw9l8CQ= X-Received: by 2002:a2e:95d3:: with SMTP id y19mr50881703ljh.175.1638209112922; Mon, 29 Nov 2021 10:05:12 -0800 (PST) MIME-Version: 1.0 References: <20211126074904.88388-1-guangming.cao@mediatek.com> In-Reply-To: <20211126074904.88388-1-guangming.cao@mediatek.com> From: John Stultz Date: Mon, 29 Nov 2021 10:05:00 -0800 Message-ID: Subject: Re: [PATCH v4] dma-buf: system_heap: Use 'for_each_sgtable_sg' in pages free flow To: guangming.cao@mediatek.com Cc: greg@kroah.com, Brian.Starkey@arm.com, benjamin.gaignard@linaro.org, christian.koenig@amd.com, dri-devel@lists.freedesktop.org, labbott@redhat.com, linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, lmark@codeaurora.org, matthias.bgg@gmail.com, robin.murphy@arm.com, stable@vger.kernel.org, sumit.semwal@linaro.org, wsd_upstream@mediatek.com, kuan-ying.lee@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_100517_098982_5C6DE374 X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Nov 25, 2021 at 11:48 PM wrote: > > From: Guangming > > For previous version, it uses 'sg_table.nent's to traverse sg_table in pages > free flow. > However, 'sg_table.nents' is reassigned in 'dma_map_sg', it means the number of > created entries in the DMA adderess space. > So, use 'sg_table.nents' in pages free flow will case some pages can't be freed. > > Here we should use sg_table.orig_nents to free pages memory, but use the > sgtable helper 'for each_sgtable_sg'(, instead of the previous rather common > helper 'for_each_sg' which maybe cause memory leak) is much better. > > Fixes: d963ab0f15fb0 ("dma-buf: system_heap: Allocate higher order pages if available") > Signed-off-by: Guangming > Reviewed-by: Robin Murphy > Cc: # 5.11.* Thanks so much for catching this and sending in all the revisions! Reviewed-by: John Stultz _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97AD7C433F5 for ; Mon, 29 Nov 2021 18:05:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 981D26E500; Mon, 29 Nov 2021 18:05:15 +0000 (UTC) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8DB326E500 for ; Mon, 29 Nov 2021 18:05:14 +0000 (UTC) Received: by mail-lj1-x22d.google.com with SMTP id d11so36079049ljg.8 for ; Mon, 29 Nov 2021 10:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IDi3zvjd6u7ZBVvXAka/LTSyAvUkqeh+L5SnX6c8Zdk=; b=ELtQ57DjVTWJPnvASv4jZtvg9xzVjpRXdLK6WadVUiqQO2Tejx2Y4rP/jZvsvwdaGM wVK5qYNcJTRTVvihhUy6a3XfzO7ShXe3HSKg9CJ9S9TdxAt3X4+ddQNsKXsRbhOEV3Nn NeS7l4DPoqAaH0j+Gm2rrnRobzgyBp+zZRI4nhmfoSItyMTQPe6HJsrb3a8uXIO7pAUp d0pHSCno/fnC3Fp0q+W51eSWigYy/I5qIJhRZa/O1KEhI708OF8jeLET61Dg8b9kw0VH st1/mw7gEQ1NVGLv+ANo/xqXiZgR94N5ykkWzVgrrh3SWq2UdJQ1DTZyuwBI86rq3HIq HE3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IDi3zvjd6u7ZBVvXAka/LTSyAvUkqeh+L5SnX6c8Zdk=; b=7vQZYg4ontut9eq5/6C200Kk45lBgdQQ1KfkjLCsHZ0aqdwJZ0Xpsq9DLK14vpRssT kLcI8RQb3YStMEnbXlVwSWGvO2bB/VFTuiWLLxKln9jrSMltNDu0l/82D6RMp2JrSeO6 de3yK5/iLnHhkyxbrvsHZa7N3Znl6tzq3YDc13/qcKBZPvSWlMYNFuMhhmm3TveHXqO/ H8GUWUHMdXKe7ejaU2PDNZRJto+7DxtVI/lVLmM2C9JB411i9QX0t7BmuG5a26xVXfRt El4DGHdEgaMP4+nEJ8B2NgdlN1A+ZuoXXCNYEGd4Yy+1zLUzxIf7hgTwUQjXI5DacWP1 3F2w== X-Gm-Message-State: AOAM531BxmL5Q4n28f/iMK0km4XnsXtJVViTTltJd/qVMCtz3Rg6KSkm TMxPnVsDntTUzd1jgk9omX+cWvK52jzQ3jEauC7c2A== X-Google-Smtp-Source: ABdhPJz00rJJqhFv+eY/G4mQJbhWwtM/vfpfxJXb8qlKInsjRYgNcLli9eLdqgC5XVztKYKpkdzK0NNalzo7Gw9l8CQ= X-Received: by 2002:a2e:95d3:: with SMTP id y19mr50881703ljh.175.1638209112922; Mon, 29 Nov 2021 10:05:12 -0800 (PST) MIME-Version: 1.0 References: <20211126074904.88388-1-guangming.cao@mediatek.com> In-Reply-To: <20211126074904.88388-1-guangming.cao@mediatek.com> From: John Stultz Date: Mon, 29 Nov 2021 10:05:00 -0800 Message-ID: Subject: Re: [PATCH v4] dma-buf: system_heap: Use 'for_each_sgtable_sg' in pages free flow To: guangming.cao@mediatek.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream@mediatek.com, kuan-ying.lee@mediatek.com, greg@kroah.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, christian.koenig@amd.com, linaro-mm-sig@lists.linaro.org, linux-mediatek@lists.infradead.org, lmark@codeaurora.org, benjamin.gaignard@linaro.org, matthias.bgg@gmail.com, stable@vger.kernel.org, labbott@redhat.com, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Nov 25, 2021 at 11:48 PM wrote: > > From: Guangming > > For previous version, it uses 'sg_table.nent's to traverse sg_table in pages > free flow. > However, 'sg_table.nents' is reassigned in 'dma_map_sg', it means the number of > created entries in the DMA adderess space. > So, use 'sg_table.nents' in pages free flow will case some pages can't be freed. > > Here we should use sg_table.orig_nents to free pages memory, but use the > sgtable helper 'for each_sgtable_sg'(, instead of the previous rather common > helper 'for_each_sg' which maybe cause memory leak) is much better. > > Fixes: d963ab0f15fb0 ("dma-buf: system_heap: Allocate higher order pages if available") > Signed-off-by: Guangming > Reviewed-by: Robin Murphy > Cc: # 5.11.* Thanks so much for catching this and sending in all the revisions! Reviewed-by: John Stultz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96C99C433F5 for ; Mon, 29 Nov 2021 18:06:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q4H1H1UM1qUXsQjza3+/fpNrSR23JI6LyZABzOLa8Kw=; b=JnhGiRBJICNxCL XsP9u4wj+U53TSGZQ/JfhE6rqWPvkgUC4m+jiIrhCCBxWBOC58ByDDlPX0MkNjsz9oVb7THFQhfTC a17des3qh4Sgo1RXqZvJFEzPLzuqVOjQbfqIVmY4N8/SfyxrdtzkAEQroT5sqlcyWs6MXP6XraFlG QwDSrWW/d6JcQnK/1bfMEIPMl+c7ZDjBZZhgYNFZzH4D10O2lM/HLtbebBeIuynaFyDDu1nwxEUtK BmNBW51ZgrMgK3Gp/RvFTqJnB7Y1RAnP7HdsvkqPQqX3XzMWBcKvXGSyLtjcUjy6DpP1qh9BM+DKf nlYViSiLt10nEfh25MQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrl1j-001hg4-Mf; Mon, 29 Nov 2021 18:05:19 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrl1g-001heB-1f for linux-arm-kernel@lists.infradead.org; Mon, 29 Nov 2021 18:05:17 +0000 Received: by mail-lj1-x230.google.com with SMTP id l7so36080341lja.2 for ; Mon, 29 Nov 2021 10:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IDi3zvjd6u7ZBVvXAka/LTSyAvUkqeh+L5SnX6c8Zdk=; b=ELtQ57DjVTWJPnvASv4jZtvg9xzVjpRXdLK6WadVUiqQO2Tejx2Y4rP/jZvsvwdaGM wVK5qYNcJTRTVvihhUy6a3XfzO7ShXe3HSKg9CJ9S9TdxAt3X4+ddQNsKXsRbhOEV3Nn NeS7l4DPoqAaH0j+Gm2rrnRobzgyBp+zZRI4nhmfoSItyMTQPe6HJsrb3a8uXIO7pAUp d0pHSCno/fnC3Fp0q+W51eSWigYy/I5qIJhRZa/O1KEhI708OF8jeLET61Dg8b9kw0VH st1/mw7gEQ1NVGLv+ANo/xqXiZgR94N5ykkWzVgrrh3SWq2UdJQ1DTZyuwBI86rq3HIq HE3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IDi3zvjd6u7ZBVvXAka/LTSyAvUkqeh+L5SnX6c8Zdk=; b=TrrMURBMkyLA3wkUXQR8xn/Dp8pIe0mYYQZzBrEqnli8lel6lqxE50CLghkVH1eo23 yUVT2ineOiqcHMchr8WAOK2KnXMaedYTrixG6TaOzVCVSfemDmvHGjxLJabe4V2JMC/Z XHXvcdpkpbPHro3EVWNptH+Xqo0PCvO3/hvTMaxnzPwjb3fegmWkN7lJGIPjfl6eBB5K 09ETDFawjRAQEeZAfK6SQiQakDUP6p0iNND7y4jsV0cejC8QuxhcRGCTPtHMFKMSxU5B W4Vt9bvz+2RaHIbriySb8rrnq6/l74X/pSswQK9iTl4Khv3b1P38WxPh0Gu4G61CX0YX jdsQ== X-Gm-Message-State: AOAM530xoWfHAHaBSk+QBQwO++gkBvxGIuzVm0QK9fzA2HNa3wOj6LmB soeEAHc3O1CtYmGic47hZbTtO+72hfrnNnHTbTx4vg== X-Google-Smtp-Source: ABdhPJz00rJJqhFv+eY/G4mQJbhWwtM/vfpfxJXb8qlKInsjRYgNcLli9eLdqgC5XVztKYKpkdzK0NNalzo7Gw9l8CQ= X-Received: by 2002:a2e:95d3:: with SMTP id y19mr50881703ljh.175.1638209112922; Mon, 29 Nov 2021 10:05:12 -0800 (PST) MIME-Version: 1.0 References: <20211126074904.88388-1-guangming.cao@mediatek.com> In-Reply-To: <20211126074904.88388-1-guangming.cao@mediatek.com> From: John Stultz Date: Mon, 29 Nov 2021 10:05:00 -0800 Message-ID: Subject: Re: [PATCH v4] dma-buf: system_heap: Use 'for_each_sgtable_sg' in pages free flow To: guangming.cao@mediatek.com Cc: greg@kroah.com, Brian.Starkey@arm.com, benjamin.gaignard@linaro.org, christian.koenig@amd.com, dri-devel@lists.freedesktop.org, labbott@redhat.com, linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, lmark@codeaurora.org, matthias.bgg@gmail.com, robin.murphy@arm.com, stable@vger.kernel.org, sumit.semwal@linaro.org, wsd_upstream@mediatek.com, kuan-ying.lee@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_100516_118131_322E23A4 X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 25, 2021 at 11:48 PM wrote: > > From: Guangming > > For previous version, it uses 'sg_table.nent's to traverse sg_table in pages > free flow. > However, 'sg_table.nents' is reassigned in 'dma_map_sg', it means the number of > created entries in the DMA adderess space. > So, use 'sg_table.nents' in pages free flow will case some pages can't be freed. > > Here we should use sg_table.orig_nents to free pages memory, but use the > sgtable helper 'for each_sgtable_sg'(, instead of the previous rather common > helper 'for_each_sg' which maybe cause memory leak) is much better. > > Fixes: d963ab0f15fb0 ("dma-buf: system_heap: Allocate higher order pages if available") > Signed-off-by: Guangming > Reviewed-by: Robin Murphy > Cc: # 5.11.* Thanks so much for catching this and sending in all the revisions! Reviewed-by: John Stultz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC08CC433EF for ; Mon, 29 Nov 2021 22:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233459AbhK2Whw (ORCPT ); Mon, 29 Nov 2021 17:37:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233468AbhK2WhX (ORCPT ); Mon, 29 Nov 2021 17:37:23 -0500 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE3EC127105 for ; Mon, 29 Nov 2021 10:05:14 -0800 (PST) Received: by mail-lj1-x230.google.com with SMTP id k23so36171546lje.1 for ; Mon, 29 Nov 2021 10:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IDi3zvjd6u7ZBVvXAka/LTSyAvUkqeh+L5SnX6c8Zdk=; b=ELtQ57DjVTWJPnvASv4jZtvg9xzVjpRXdLK6WadVUiqQO2Tejx2Y4rP/jZvsvwdaGM wVK5qYNcJTRTVvihhUy6a3XfzO7ShXe3HSKg9CJ9S9TdxAt3X4+ddQNsKXsRbhOEV3Nn NeS7l4DPoqAaH0j+Gm2rrnRobzgyBp+zZRI4nhmfoSItyMTQPe6HJsrb3a8uXIO7pAUp d0pHSCno/fnC3Fp0q+W51eSWigYy/I5qIJhRZa/O1KEhI708OF8jeLET61Dg8b9kw0VH st1/mw7gEQ1NVGLv+ANo/xqXiZgR94N5ykkWzVgrrh3SWq2UdJQ1DTZyuwBI86rq3HIq HE3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IDi3zvjd6u7ZBVvXAka/LTSyAvUkqeh+L5SnX6c8Zdk=; b=s13eEEVnB+C6q0e1we0DNGtuJg7QuJNWoD554uYq+UMw4ScKmhAqIDU3IGhrQKEnTs k19DZqRQBx6AbAWDX1zg73ub9whKJyGlBAtC+4pxBR3jOh/k+vBOVMF1gKo2GGZWCI/q uiNzaMvhV87OBqMmm+1AWjJD4BWrpyPR70QUYrqGOHDi65ctaXfz7txvyuwkjDoi26fp 1UfHcfOyhQqzZ/Cykne76CbWsk72wDupz0pou1j/CyHjwxXOsaTKlihJix/jmqSUQJT3 mOq2Rdhuul7BWnM2pHLXe8wadBGINMfH1R7q+ihsAIGIbOY3vIShuRxkX4rldm3xP/GG iboA== X-Gm-Message-State: AOAM533bgtEsgKXRYVGy5/67Y1oP7BuwJh26GOoeWDkykwIJhvWI+TfN Y+9bOFojE2Pk3YI3nJ30fDaOsJePREEW5bDN8i8rfA== X-Google-Smtp-Source: ABdhPJz00rJJqhFv+eY/G4mQJbhWwtM/vfpfxJXb8qlKInsjRYgNcLli9eLdqgC5XVztKYKpkdzK0NNalzo7Gw9l8CQ= X-Received: by 2002:a2e:95d3:: with SMTP id y19mr50881703ljh.175.1638209112922; Mon, 29 Nov 2021 10:05:12 -0800 (PST) MIME-Version: 1.0 References: <20211126074904.88388-1-guangming.cao@mediatek.com> In-Reply-To: <20211126074904.88388-1-guangming.cao@mediatek.com> From: John Stultz Date: Mon, 29 Nov 2021 10:05:00 -0800 Message-ID: Subject: Re: [PATCH v4] dma-buf: system_heap: Use 'for_each_sgtable_sg' in pages free flow To: guangming.cao@mediatek.com Cc: greg@kroah.com, Brian.Starkey@arm.com, benjamin.gaignard@linaro.org, christian.koenig@amd.com, dri-devel@lists.freedesktop.org, labbott@redhat.com, linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, lmark@codeaurora.org, matthias.bgg@gmail.com, robin.murphy@arm.com, stable@vger.kernel.org, sumit.semwal@linaro.org, wsd_upstream@mediatek.com, kuan-ying.lee@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 25, 2021 at 11:48 PM wrote: > > From: Guangming > > For previous version, it uses 'sg_table.nent's to traverse sg_table in pages > free flow. > However, 'sg_table.nents' is reassigned in 'dma_map_sg', it means the number of > created entries in the DMA adderess space. > So, use 'sg_table.nents' in pages free flow will case some pages can't be freed. > > Here we should use sg_table.orig_nents to free pages memory, but use the > sgtable helper 'for each_sgtable_sg'(, instead of the previous rather common > helper 'for_each_sg' which maybe cause memory leak) is much better. > > Fixes: d963ab0f15fb0 ("dma-buf: system_heap: Allocate higher order pages if available") > Signed-off-by: Guangming > Reviewed-by: Robin Murphy > Cc: # 5.11.* Thanks so much for catching this and sending in all the revisions! Reviewed-by: John Stultz