From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6096DC433DF for ; Wed, 5 Aug 2020 07:44:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C1852245C for ; Wed, 5 Aug 2020 07:44:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O7KCWZiy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726008AbgHEHoi (ORCPT ); Wed, 5 Aug 2020 03:44:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbgHEHof (ORCPT ); Wed, 5 Aug 2020 03:44:35 -0400 Received: from mail-oo1-xc42.google.com (mail-oo1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC34FC06174A for ; Wed, 5 Aug 2020 00:44:34 -0700 (PDT) Received: by mail-oo1-xc42.google.com with SMTP id s190so8569460ooa.13 for ; Wed, 05 Aug 2020 00:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2XB0gKQyc9CsSKqZ7GgGJ8tPycXtrwiQ0rJYnNLbYnE=; b=O7KCWZiyayJrpPKe4Qo2MFaMV++l507OxnySpg4nllQ/4WIyMRp2lmiAvGqQ++lZ/i vurTpoVPRWh2eWqVPdl+snBzEx6FwPldWsWqTBgZM4xOyUZWUxAZjdRAQgCtgP67MK04 ee7GreNHGoW00bOF3cl/JYbZUFiin8xF3OX6uD5776b0ZZdreRjtCydX/Uhays9SI/tB axIiLXzrWS9a6MiU3AOIocYrZgEHqZi5bWdtWeWMCkuKFVa95uev5y5FAL8m4mBOG7+s LFMYnNqvJyhxpqiIzSINRZJQdQ1ASAJHx/N/N+MNsK+WGBTlWFQJ9NeScR/DbhGCCnT0 6c6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2XB0gKQyc9CsSKqZ7GgGJ8tPycXtrwiQ0rJYnNLbYnE=; b=sTSdNDDz6hy6cOqdsgDdrjSjmixX6jd6qC879agrzEwY2XXVot0xep3HmZN6DFNcEk PdUSN/8KlvtYQ71FhE8IiUD1vVB9UkjCEqZhs22a/96VVpcMuEaVITB66ngXzLDtajbs P6h1ddlkrFYIGzLkM87WAQnq9Cwt+az+3sYq/iPVlyQeETghYI4yuxbIrC6WaUOhnK8/ Ml78pgyJBmhD2SRf5mN5YxFRBRZ2aceq/U3jqxxWmAswOXHPKzKPEoYsj0LKKjXefSXZ p7dTDCFcbKoonS7FPX7EF0VQs8Vq68IupzU9TGwWicvvuTZPDfbrdAoOgXmM4qcfenHR 1ZzA== X-Gm-Message-State: AOAM530S41GFum55Icc7VVFd6acvR+GinNJIN5Pbq4pO/1FaFZa0l86/ Akuh5PtKBYNjH9RUuY/eyP3Jt1+x47lMUWAz7mAj8A== X-Google-Smtp-Source: ABdhPJyTnc5GAirwQ3qZDK4WN0lqH19fI2aSlix6R6R+dyBypcI5OYPshiJlUl3SHM0DH8s2OgrXhfwvSl++QvmT16w= X-Received: by 2002:a4a:a648:: with SMTP id j8mr1634862oom.36.1596613472779; Wed, 05 Aug 2020 00:44:32 -0700 (PDT) MIME-Version: 1.0 References: <20200718000637.3632841-1-saravanak@google.com> <20200718000637.3632841-3-saravanak@google.com> In-Reply-To: <20200718000637.3632841-3-saravanak@google.com> From: John Stultz Date: Wed, 5 Aug 2020 00:44:21 -0700 Message-ID: Subject: Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros To: Saravana Kannan Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Matthias Brugger , Andy Gross , Bjorn Andersson , Android Kernel Team , lkml , linux-arm-kernel , linux-mediatek@lists.infradead.org, linux-arm-msm , Hanks Chen , CC Hwang , Loda Chou Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jul 17, 2020 at 5:06 PM Saravana Kannan wrote: > > Switch the driver to use the helper macros. In addition to reducing the > number of lines, this also adds module unload protection (if the driver > is compiled as a module) by switching from module_platform_driver to > builtin_platform_driver. > > Signed-off-by: Saravana Kannan > --- > drivers/irqchip/qcom-pdc.c | 26 +++----------------------- > 1 file changed, 3 insertions(+), 23 deletions(-) > > diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > index 5b624e3295e4..c1c5dfad57cc 100644 > --- a/drivers/irqchip/qcom-pdc.c > +++ b/drivers/irqchip/qcom-pdc.c > @@ -432,28 +432,8 @@ static int qcom_pdc_init(struct device_node *node, struct device_node *parent) > return ret; > } > > -static int qcom_pdc_probe(struct platform_device *pdev) > -{ > - struct device_node *np = pdev->dev.of_node; > - struct device_node *parent = of_irq_find_parent(np); > - > - return qcom_pdc_init(np, parent); > -} > - > -static const struct of_device_id qcom_pdc_match_table[] = { > - { .compatible = "qcom,pdc" }, > - {} > -}; > -MODULE_DEVICE_TABLE(of, qcom_pdc_match_table); > - > -static struct platform_driver qcom_pdc_driver = { > - .probe = qcom_pdc_probe, > - .driver = { > - .name = "qcom-pdc", > - .of_match_table = qcom_pdc_match_table, > - .suppress_bind_attrs = true, > - }, > -}; > -module_platform_driver(qcom_pdc_driver); > +IRQCHIP_PLATFORM_DRIVER_BEGIN(qcom_pdc) > +IRQCHIP_MATCH("qcom,pdc", qcom_pdc_init) > +IRQCHIP_PLATFORM_DRIVER_END(qcom_pdc) > MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Power Domain Controller"); > MODULE_LICENSE("GPL v2"); So this is where I bashfully admit I didn't get a chance to try this patch series out, as I had success with a much older version of Saravana's macro magic. But unfortunately, now that this has landed in mainline, I'm seeing boot regressions on db845c. :( This is in the non-modular case, building the driver in. I managed to bisect it down to this patch, and reverting it avoids the issue. I don't see what is wrong right off, but I really need to get to bed, so I'll dig further tomorrow. Saravana: Apologies for not getting around to testing this beforehand! thanks -john From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D3D0C433DF for ; Wed, 5 Aug 2020 07:44:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B6FC2245C for ; Wed, 5 Aug 2020 07:44:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uRtWE06A"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O7KCWZiy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B6FC2245C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FoFIUdGca5nHjGQbQASQ+2y3qOpYIC8ucrfLdCGOrtA=; b=uRtWE06AHw6iti7xBNWYlAT6z 2BKRQKkjLn2NJhZktGGxeGuTulclAR5QnV4R/sC2Dm0KIi/oC28NI4i+QpwO2aJcDPXx/Qs7PnHEN S2ni4Yatqwr4gEk1xmXj3UJfOzNqJU1u94og0NzfJ9mpZaMAM0r5shT4LgTxMYS+rRFylESK54ZWZ lJObeXf7wOp1CynTZsqv7IYAY4LCQaDq5yURadlqEBIa2d444//9eb8YWJBGoqAN/lStAHHgEh0AR k5lR1xHz7dW1Be+gsN9RuqrG1NKFqtoij03pmDCAH43HJyebNPNtofl1yvf3WBRBSrL1x6d7FA6qy lcsZ5cawA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3E6J-0002zD-Me; Wed, 05 Aug 2020 07:44:39 +0000 Received: from mail-oo1-xc43.google.com ([2607:f8b0:4864:20::c43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3E6F-0002y6-AC for linux-mediatek@lists.infradead.org; Wed, 05 Aug 2020 07:44:36 +0000 Received: by mail-oo1-xc43.google.com with SMTP id x1so6401208oox.6 for ; Wed, 05 Aug 2020 00:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2XB0gKQyc9CsSKqZ7GgGJ8tPycXtrwiQ0rJYnNLbYnE=; b=O7KCWZiyayJrpPKe4Qo2MFaMV++l507OxnySpg4nllQ/4WIyMRp2lmiAvGqQ++lZ/i vurTpoVPRWh2eWqVPdl+snBzEx6FwPldWsWqTBgZM4xOyUZWUxAZjdRAQgCtgP67MK04 ee7GreNHGoW00bOF3cl/JYbZUFiin8xF3OX6uD5776b0ZZdreRjtCydX/Uhays9SI/tB axIiLXzrWS9a6MiU3AOIocYrZgEHqZi5bWdtWeWMCkuKFVa95uev5y5FAL8m4mBOG7+s LFMYnNqvJyhxpqiIzSINRZJQdQ1ASAJHx/N/N+MNsK+WGBTlWFQJ9NeScR/DbhGCCnT0 6c6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2XB0gKQyc9CsSKqZ7GgGJ8tPycXtrwiQ0rJYnNLbYnE=; b=U5yGeH6tP7SoIK5gGDYPyeKOl8/tQIb4npvp8BM6nnS2zZaYoaI4pogTi6HbWZKh/z 05iVfCb4d2gjLmgpESrETx6aQsuAWlFScQgDvJDr8tqqSELCQ/aHsMPy9E8DNirNp1ss sxZrFzORH++kM6UAli8ez13Kt0hz0Qzb5+DHdYC2cFlES0NM5Rm1Au4gS7ik2wHafIxX WlbMVM0Gpxzj8aqKKWaoCwPcJTfjMzd8JDZGbIH6f1F3c/qf3/1pI2hpVKhCBLbsCufp bARylUaZLpNns+qSJYZGIJiJWZ1mB/5ys7SvS/pJkBr0XrBKXMCQBArXtnIaA4prbonX BGEQ== X-Gm-Message-State: AOAM533cELvm2yXat9BJqCC0JbycyMzW0NXDQ4GfRlyV+0Psbgl/0KJp khi/YPSSbinylg11W8FDqg9xo51kgrhdw2VrwgFawQ== X-Google-Smtp-Source: ABdhPJyTnc5GAirwQ3qZDK4WN0lqH19fI2aSlix6R6R+dyBypcI5OYPshiJlUl3SHM0DH8s2OgrXhfwvSl++QvmT16w= X-Received: by 2002:a4a:a648:: with SMTP id j8mr1634862oom.36.1596613472779; Wed, 05 Aug 2020 00:44:32 -0700 (PDT) MIME-Version: 1.0 References: <20200718000637.3632841-1-saravanak@google.com> <20200718000637.3632841-3-saravanak@google.com> In-Reply-To: <20200718000637.3632841-3-saravanak@google.com> From: John Stultz Date: Wed, 5 Aug 2020 00:44:21 -0700 Message-ID: Subject: Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros To: Saravana Kannan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_034435_714166_4F7EB5C8 X-CRM114-Status: GOOD ( 21.69 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: CC Hwang , Jason Cooper , Marc Zyngier , Hanks Chen , Loda Chou , lkml , Bjorn Andersson , Andy Gross , linux-mediatek@lists.infradead.org, linux-arm-msm , Matthias Brugger , Thomas Gleixner , Android Kernel Team , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Jul 17, 2020 at 5:06 PM Saravana Kannan wrote: > > Switch the driver to use the helper macros. In addition to reducing the > number of lines, this also adds module unload protection (if the driver > is compiled as a module) by switching from module_platform_driver to > builtin_platform_driver. > > Signed-off-by: Saravana Kannan > --- > drivers/irqchip/qcom-pdc.c | 26 +++----------------------- > 1 file changed, 3 insertions(+), 23 deletions(-) > > diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > index 5b624e3295e4..c1c5dfad57cc 100644 > --- a/drivers/irqchip/qcom-pdc.c > +++ b/drivers/irqchip/qcom-pdc.c > @@ -432,28 +432,8 @@ static int qcom_pdc_init(struct device_node *node, struct device_node *parent) > return ret; > } > > -static int qcom_pdc_probe(struct platform_device *pdev) > -{ > - struct device_node *np = pdev->dev.of_node; > - struct device_node *parent = of_irq_find_parent(np); > - > - return qcom_pdc_init(np, parent); > -} > - > -static const struct of_device_id qcom_pdc_match_table[] = { > - { .compatible = "qcom,pdc" }, > - {} > -}; > -MODULE_DEVICE_TABLE(of, qcom_pdc_match_table); > - > -static struct platform_driver qcom_pdc_driver = { > - .probe = qcom_pdc_probe, > - .driver = { > - .name = "qcom-pdc", > - .of_match_table = qcom_pdc_match_table, > - .suppress_bind_attrs = true, > - }, > -}; > -module_platform_driver(qcom_pdc_driver); > +IRQCHIP_PLATFORM_DRIVER_BEGIN(qcom_pdc) > +IRQCHIP_MATCH("qcom,pdc", qcom_pdc_init) > +IRQCHIP_PLATFORM_DRIVER_END(qcom_pdc) > MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Power Domain Controller"); > MODULE_LICENSE("GPL v2"); So this is where I bashfully admit I didn't get a chance to try this patch series out, as I had success with a much older version of Saravana's macro magic. But unfortunately, now that this has landed in mainline, I'm seeing boot regressions on db845c. :( This is in the non-modular case, building the driver in. I managed to bisect it down to this patch, and reverting it avoids the issue. I don't see what is wrong right off, but I really need to get to bed, so I'll dig further tomorrow. Saravana: Apologies for not getting around to testing this beforehand! thanks -john _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4238C433E0 for ; Wed, 5 Aug 2020 07:46:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80CC92245C for ; Wed, 5 Aug 2020 07:46:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BaK+zOrW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O7KCWZiy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80CC92245C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gKrDyZ7OL2fyfuYGAGSger40znmE2bYr/6WFIhOwaCQ=; b=BaK+zOrWoK1ysYWo5EKq1qYWG MntY0L/8yegQn9XEPOY5h1d6EX3XKZg7YsKS6iNnm6NU32fgYHBj+5NeH4GaG7gqSKD8Y/5OEpseA adjaOCPngl1NW/+dNOQIVBq8K4dUtADseuCjvVMXzF3C8VfVrqrFMvQpKnZ4zmUO3Te/P+dIDKPub 0OKlXsxRxXfMRTouWTvG7zJoW2GAhzUaoZMHShM8j/Xs2iBX+X5AmFr6bzhg4oLyCobmQ69YRZaul 3vR/HIbPdVln4X0ULTA2HeiuPc4nnbsJ2N7NuBJ+nZfqxXW6PpSTmvlhBgROHavat3UQ535dX6veL FPpEzeY9A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3E6I-0002yj-K5; Wed, 05 Aug 2020 07:44:38 +0000 Received: from mail-oo1-xc44.google.com ([2607:f8b0:4864:20::c44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3E6F-0002y5-AP for linux-arm-kernel@lists.infradead.org; Wed, 05 Aug 2020 07:44:36 +0000 Received: by mail-oo1-xc44.google.com with SMTP id j19so2926448oor.2 for ; Wed, 05 Aug 2020 00:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2XB0gKQyc9CsSKqZ7GgGJ8tPycXtrwiQ0rJYnNLbYnE=; b=O7KCWZiyayJrpPKe4Qo2MFaMV++l507OxnySpg4nllQ/4WIyMRp2lmiAvGqQ++lZ/i vurTpoVPRWh2eWqVPdl+snBzEx6FwPldWsWqTBgZM4xOyUZWUxAZjdRAQgCtgP67MK04 ee7GreNHGoW00bOF3cl/JYbZUFiin8xF3OX6uD5776b0ZZdreRjtCydX/Uhays9SI/tB axIiLXzrWS9a6MiU3AOIocYrZgEHqZi5bWdtWeWMCkuKFVa95uev5y5FAL8m4mBOG7+s LFMYnNqvJyhxpqiIzSINRZJQdQ1ASAJHx/N/N+MNsK+WGBTlWFQJ9NeScR/DbhGCCnT0 6c6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2XB0gKQyc9CsSKqZ7GgGJ8tPycXtrwiQ0rJYnNLbYnE=; b=CSiw0H8+05IaoFJlfkYbw6iqcg0UmiU25dO2TKgHmBTbtDMlaQgeKyAxl2ESt2eCoz KSnQPl+Q630Pwd6+B6dobie2LuGiayVYvtnZQLJBg+uLI2uJYa8hNnXo+cFi4/AGiWIa 3Wn74z7/xNqkfLbdDOiXrtUaslpjgUBQLb4OpizLq88eIPytoak2Jhu520GjqxXbvZUA 1MKf8mHzPXtAEW8EYhU3AwoSic2FoNG0ho371nxqX8qzLLyuvagzcya0/qS6Nz7CJH94 d+Tar9oFT9Pwae5SK614PRXIV/glY8VIa5WwAPmiHVqrXfR2jEnorrTc+jFVCRu7YFaI PyFA== X-Gm-Message-State: AOAM5338LEBt2e06pJhl7/g18+4bnssaUAL0CiEop9s7h2HOe4NfSIRM 60rN14c8FsFQB/xuizGzIXOjanM6rgi8izsvCLcUNw== X-Google-Smtp-Source: ABdhPJyTnc5GAirwQ3qZDK4WN0lqH19fI2aSlix6R6R+dyBypcI5OYPshiJlUl3SHM0DH8s2OgrXhfwvSl++QvmT16w= X-Received: by 2002:a4a:a648:: with SMTP id j8mr1634862oom.36.1596613472779; Wed, 05 Aug 2020 00:44:32 -0700 (PDT) MIME-Version: 1.0 References: <20200718000637.3632841-1-saravanak@google.com> <20200718000637.3632841-3-saravanak@google.com> In-Reply-To: <20200718000637.3632841-3-saravanak@google.com> From: John Stultz Date: Wed, 5 Aug 2020 00:44:21 -0700 Message-ID: Subject: Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros To: Saravana Kannan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_034435_713268_016F36D7 X-CRM114-Status: GOOD ( 23.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: CC Hwang , Jason Cooper , Marc Zyngier , Hanks Chen , Loda Chou , lkml , Bjorn Andersson , Andy Gross , linux-mediatek@lists.infradead.org, linux-arm-msm , Matthias Brugger , Thomas Gleixner , Android Kernel Team , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 17, 2020 at 5:06 PM Saravana Kannan wrote: > > Switch the driver to use the helper macros. In addition to reducing the > number of lines, this also adds module unload protection (if the driver > is compiled as a module) by switching from module_platform_driver to > builtin_platform_driver. > > Signed-off-by: Saravana Kannan > --- > drivers/irqchip/qcom-pdc.c | 26 +++----------------------- > 1 file changed, 3 insertions(+), 23 deletions(-) > > diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > index 5b624e3295e4..c1c5dfad57cc 100644 > --- a/drivers/irqchip/qcom-pdc.c > +++ b/drivers/irqchip/qcom-pdc.c > @@ -432,28 +432,8 @@ static int qcom_pdc_init(struct device_node *node, struct device_node *parent) > return ret; > } > > -static int qcom_pdc_probe(struct platform_device *pdev) > -{ > - struct device_node *np = pdev->dev.of_node; > - struct device_node *parent = of_irq_find_parent(np); > - > - return qcom_pdc_init(np, parent); > -} > - > -static const struct of_device_id qcom_pdc_match_table[] = { > - { .compatible = "qcom,pdc" }, > - {} > -}; > -MODULE_DEVICE_TABLE(of, qcom_pdc_match_table); > - > -static struct platform_driver qcom_pdc_driver = { > - .probe = qcom_pdc_probe, > - .driver = { > - .name = "qcom-pdc", > - .of_match_table = qcom_pdc_match_table, > - .suppress_bind_attrs = true, > - }, > -}; > -module_platform_driver(qcom_pdc_driver); > +IRQCHIP_PLATFORM_DRIVER_BEGIN(qcom_pdc) > +IRQCHIP_MATCH("qcom,pdc", qcom_pdc_init) > +IRQCHIP_PLATFORM_DRIVER_END(qcom_pdc) > MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Power Domain Controller"); > MODULE_LICENSE("GPL v2"); So this is where I bashfully admit I didn't get a chance to try this patch series out, as I had success with a much older version of Saravana's macro magic. But unfortunately, now that this has landed in mainline, I'm seeing boot regressions on db845c. :( This is in the non-modular case, building the driver in. I managed to bisect it down to this patch, and reverting it avoids the issue. I don't see what is wrong right off, but I really need to get to bed, so I'll dig further tomorrow. Saravana: Apologies for not getting around to testing this beforehand! thanks -john _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel