From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E438C48BE5 for ; Fri, 11 Jun 2021 19:16:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22EF6613D3 for ; Fri, 11 Jun 2021 19:16:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230364AbhFKTS2 (ORCPT ); Fri, 11 Jun 2021 15:18:28 -0400 Received: from mail-lf1-f42.google.com ([209.85.167.42]:43929 "EHLO mail-lf1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229685AbhFKTS1 (ORCPT ); Fri, 11 Jun 2021 15:18:27 -0400 Received: by mail-lf1-f42.google.com with SMTP id x24so4442368lfr.10 for ; Fri, 11 Jun 2021 12:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XX1W3URWQ8r7C42PWjWKsvggaK12j8Zhh8tbxVvnO2w=; b=nTb2yspBH9u7uwoFjX8jsvdCFER3T7Bg+mpnOMpkt4egaQm7qPi7JOIsnAKqah/LXZ drWRb1WZk+czg48dmZFpssa0KuRfbWn7mW3UVNp3P5AKH2B3xN15/uWNvDDYh/R/iDqf KZJKULNgY5qxFSwUY/CtclPh7LQYPy11OEBjje2bPI2ycK1Iay5R070vmzOX8iTf5Va8 RnYlsgYc+bIvRwDdB/cjijQcprkz0x1qGD7wE7fcyK9tfWT/kbuIe5LsiRTllfH2Dcmf fg85Tw49uriMJ6UDesjh15oUodZahOpAsnAi1yJJVFjlkBkEoMpSZADCnUiJG+alXrFh n31w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XX1W3URWQ8r7C42PWjWKsvggaK12j8Zhh8tbxVvnO2w=; b=VGY+P7djs6mYbQPAfn1bvAP01aX4GSsw+1ICwvb6cUD62pljxl6RJt2LAJx1CJ2Um+ V+zegXaX15lerq9ftiOBYajt7eYuY5s16kAtEaIL0ubhZkHeQFY32th5fN5xukfjdten JjyQEAexrWmeVLBkFpG6K79ALm+M7ZkiNYb+TTGqDM7jxcVz1CWJ6C4uyiaheHznPn+w q9hX1DmeEqZ2xMSm/FCm4sYlPc2oIYvR1g+WmE3BkyU3sXgw1jG1huaVlQ6jcxS0aHIS XIz5vQaBQKtYX3DRwAFjXfvQpXNJV60WRprSIgjG2Yve+uihKs4XBVIrl6msr10P0ume 3TLg== X-Gm-Message-State: AOAM533g0b07vFcrMlb8T2chLa1MWm2YBROv0UPcUpT4fQ1h6d7LawSO gWKIT7jXrbMEv+BJw6TpagvZ6wQgHofuTqkAvcAta6WUAVg= X-Google-Smtp-Source: ABdhPJzojiGmPxWqA+iJlZvJDBVswkAfdjKbLrU0iZLy3nWfGlyWzCEH7Q2CBe44XskeGNFG3yWJgOHAbCBUTjJOHNU= X-Received: by 2002:a19:c181:: with SMTP id r123mr3490274lff.7.1623438928342; Fri, 11 Jun 2021 12:15:28 -0700 (PDT) MIME-Version: 1.0 References: <20210331105735.3690009-1-dmitry.baryshkov@linaro.org> <20210331105735.3690009-23-dmitry.baryshkov@linaro.org> In-Reply-To: From: John Stultz Date: Fri, 11 Jun 2021 12:15:16 -0700 Message-ID: Subject: Re: [PATCH v4 22/24] drm/msm/dsi: remove temp data from global pll structure To: Dmitry Baryshkov Cc: Rob Clark , Sean Paul , Abhinav Kumar , Jonathan Marek , Michael Turquette , Stephen Boyd , linux-arm-msm , dri-devel , Stephen Boyd , David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:COMMON CLK FRAMEWORK" , Peter Collingbourne , Amit Pundir , Vinod Koul , Bjorn Andersson Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jun 11, 2021 at 2:01 AM Dmitry Baryshkov wrote: > > Hi, > > On Fri, 11 Jun 2021 at 10:07, John Stultz wrote: > > > > On Wed, Mar 31, 2021 at 3:58 AM Dmitry Baryshkov > > wrote: > > > > > > The 7nm, 10nm and 14nm drivers would store interim data used during > > > VCO/PLL rate setting in the global dsi_pll_Nnm structure. Move this data > > > structures to the onstack storage. While we are at it, drop > > > unused/static 'config' data, unused config fields, etc. > > > > > > Signed-off-by: Dmitry Baryshkov > > > Reviewed-by: Abhinav Kumar > > > Tested-by: Stephen Boyd # on sc7180 lazor > > > > Hey Dmitry, > > Just wanted to give you a heads up. Peter Collingbourne reported > > today that his db845c wasn't booting to display for him on his 4k > > monitor. It works fine on a 1080p screen, and while 4k isn't supported > > (yet?), normally the board should fall back to 1080p when connected > > to a 4k monitor. I was able to reproduce this myself and I see the > > errors below[1]. > > It looks like I made a mistake testing these patches with the splash > screen disabled. > Stephen Boyd has proposed a fix few days ago (will be included into > the 5.13). Could you check that it fixes the problem for you? > > https://lore.kernel.org/linux-arm-msm/20210608195519.125561-1-swboyd@chromium.org/ Ah! This does seem to fix it! Thank you so much for pointing it out! thanks -john From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46BB1C48BD1 for ; Fri, 11 Jun 2021 19:15:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EED861364 for ; Fri, 11 Jun 2021 19:15:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EED861364 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 84C236E45C; Fri, 11 Jun 2021 19:15:31 +0000 (UTC) Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16A496E45C for ; Fri, 11 Jun 2021 19:15:30 +0000 (UTC) Received: by mail-lf1-x12b.google.com with SMTP id k40so10064629lfv.7 for ; Fri, 11 Jun 2021 12:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XX1W3URWQ8r7C42PWjWKsvggaK12j8Zhh8tbxVvnO2w=; b=nTb2yspBH9u7uwoFjX8jsvdCFER3T7Bg+mpnOMpkt4egaQm7qPi7JOIsnAKqah/LXZ drWRb1WZk+czg48dmZFpssa0KuRfbWn7mW3UVNp3P5AKH2B3xN15/uWNvDDYh/R/iDqf KZJKULNgY5qxFSwUY/CtclPh7LQYPy11OEBjje2bPI2ycK1Iay5R070vmzOX8iTf5Va8 RnYlsgYc+bIvRwDdB/cjijQcprkz0x1qGD7wE7fcyK9tfWT/kbuIe5LsiRTllfH2Dcmf fg85Tw49uriMJ6UDesjh15oUodZahOpAsnAi1yJJVFjlkBkEoMpSZADCnUiJG+alXrFh n31w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XX1W3URWQ8r7C42PWjWKsvggaK12j8Zhh8tbxVvnO2w=; b=NdzKT6JboloITXdLK2QuZ+1t6R+6XfIf0+2Do4SBHyEncZefIBMkpSb3F6dBL97RPm 35xdxqS3iSd+3piiDXuSptyya6evs4Gm1OHTqRuPBHXhb7t0SddoRKRNGTm821D7dKE2 BVVeUrk3Mj3yWOvh5Ze5V+EaSMqPjhS1aSV2AlOUYbxM34n/mlAwi977yLnIJcVNLdfL ssmPtciGu/tfSfiV5Wwe3/iUHOTAMGs4r4Y3H1w2sTOedMvgl20IYnVm1/iwknZ95XlJ KoDc7O1H2VNycQupUrfJWRvbXLkLhbuJDRocgVcA8aBMMuaRJ/g0W7UODKsJBQQacuNG xkxw== X-Gm-Message-State: AOAM530he74hmX1mmkLQP5fVqDQkQf2kornBqscL6gaRKOFKi3OOKlmR m1D7QyDH+MBwdaHblU/mnsYZIPm48qUdvn5JN/T9Rg== X-Google-Smtp-Source: ABdhPJzojiGmPxWqA+iJlZvJDBVswkAfdjKbLrU0iZLy3nWfGlyWzCEH7Q2CBe44XskeGNFG3yWJgOHAbCBUTjJOHNU= X-Received: by 2002:a19:c181:: with SMTP id r123mr3490274lff.7.1623438928342; Fri, 11 Jun 2021 12:15:28 -0700 (PDT) MIME-Version: 1.0 References: <20210331105735.3690009-1-dmitry.baryshkov@linaro.org> <20210331105735.3690009-23-dmitry.baryshkov@linaro.org> In-Reply-To: From: John Stultz Date: Fri, 11 Jun 2021 12:15:16 -0700 Message-ID: Subject: Re: [PATCH v4 22/24] drm/msm/dsi: remove temp data from global pll structure To: Dmitry Baryshkov Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amit Pundir , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Vinod Koul , Jonathan Marek , Stephen Boyd , linux-arm-msm , Michael Turquette , Abhinav Kumar , Stephen Boyd , David Airlie , dri-devel , Peter Collingbourne , Bjorn Andersson , Sean Paul , "open list:COMMON CLK FRAMEWORK" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 11, 2021 at 2:01 AM Dmitry Baryshkov wrote: > > Hi, > > On Fri, 11 Jun 2021 at 10:07, John Stultz wrote: > > > > On Wed, Mar 31, 2021 at 3:58 AM Dmitry Baryshkov > > wrote: > > > > > > The 7nm, 10nm and 14nm drivers would store interim data used during > > > VCO/PLL rate setting in the global dsi_pll_Nnm structure. Move this data > > > structures to the onstack storage. While we are at it, drop > > > unused/static 'config' data, unused config fields, etc. > > > > > > Signed-off-by: Dmitry Baryshkov > > > Reviewed-by: Abhinav Kumar > > > Tested-by: Stephen Boyd # on sc7180 lazor > > > > Hey Dmitry, > > Just wanted to give you a heads up. Peter Collingbourne reported > > today that his db845c wasn't booting to display for him on his 4k > > monitor. It works fine on a 1080p screen, and while 4k isn't supported > > (yet?), normally the board should fall back to 1080p when connected > > to a 4k monitor. I was able to reproduce this myself and I see the > > errors below[1]. > > It looks like I made a mistake testing these patches with the splash > screen disabled. > Stephen Boyd has proposed a fix few days ago (will be included into > the 5.13). Could you check that it fixes the problem for you? > > https://lore.kernel.org/linux-arm-msm/20210608195519.125561-1-swboyd@chromium.org/ Ah! This does seem to fix it! Thank you so much for pointing it out! thanks -john