From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D86C433DF for ; Tue, 4 Aug 2020 21:24:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1BB220842 for ; Tue, 4 Aug 2020 21:24:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LthmW3Lz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727124AbgHDVY1 (ORCPT ); Tue, 4 Aug 2020 17:24:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726775AbgHDVY0 (ORCPT ); Tue, 4 Aug 2020 17:24:26 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E967C06174A for ; Tue, 4 Aug 2020 14:24:26 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id t7so17876447otp.0 for ; Tue, 04 Aug 2020 14:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=k9/tscxhQqLXMKufpxll8+O44Aoxn3IbN6hHzmHjeyk=; b=LthmW3LzzjhnSTSJ/Gk3/qE3qMtkbshJVZQ8VvPoQUD14fRb8+6ZREaa16vBXOv1B/ iCz3iW+Ld6mgmeMw0916UckRv6jqN1O3aiBgPtqwXE14SpVgCbHxPPjndJ5a0qf9ZuBO 0DMgY2VCRRgo1VuhaAsG3Pq2eLgLRLyQmtbm1paF9aVKd5GPRUp+JagTiJ0ixRjJYWtH vH9TTHge8Lz6YzaqokOI9017/ZYGVovnurHehoFn81WWkRgDL898MDEvu/hvL7nKxE4P ijvjQkL0+o3F4MiCZyH/zbsTqkGpi/VEbJP7wQBQwImsUtMHCzmwfIv6IIvz+tstdU3G 0GdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=k9/tscxhQqLXMKufpxll8+O44Aoxn3IbN6hHzmHjeyk=; b=fi8/vadUNJJY4jzlr/HkD0kCVvyQOnoI0WKRbpcJeaWbL+gt/ikVWE0r+TVMf6y4Ux QGw3PJH4j77TaPG07qayzKQdKGMEsN7JPy+UJyqfZhsYycZCn6HrUSr+J4NasiLtBVgQ AIw85aoo25rWNX4ihHCSaSM9LgaumlL9cBYF15iaV8LeuUzB9IGSQpxJdHlL6LkSk1Wa xKaE4bz6oLij072vp41Ky1Hqycy5ChR7uGBlfTt/Vz3412aWYN05H3RyLl/sMkvypj4C LQxj+EM0ZIMHLrMoiV5h9SUOGMGbYaneg9ncoog+Oo1J4Bsq9dOlTGD9xwir1C+++f7v q7/Q== X-Gm-Message-State: AOAM531pmdJiWLGy3ureh9LXlDOcSwK701Z9v6o9rIp92wY+BO0lOJyU /fgOSXBAyCZYYMemOWSNzM1bAsYbrZ71xRbOLZfSzg== X-Google-Smtp-Source: ABdhPJwrlWMjyO3HV4MDFR4gb4NaCjbwSiumlhalogqG2gqSuAloVI6+obWms7yfcFnZi+bTMkLl8+r5tY36mh/4U4o= X-Received: by 2002:a05:6830:237b:: with SMTP id r27mr45696oth.352.1596576265757; Tue, 04 Aug 2020 14:24:25 -0700 (PDT) MIME-Version: 1.0 References: <20200511110611.3142-1-ricardo.canuelo@collabora.com> <20200511110611.3142-5-ricardo.canuelo@collabora.com> In-Reply-To: From: John Stultz Date: Tue, 4 Aug 2020 14:24:13 -0700 Message-ID: Subject: Re: [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 DT binding To: =?UTF-8?Q?Ricardo_Ca=C3=B1uelo?= Cc: Laurent Pinchart , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven , Wei Xu , Rob Herring , kernel@collabora.com, linux-arm-kernel , Mauro Carvalho Chehab Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Aug 4, 2020 at 1:57 PM John Stultz wrote: > > On Mon, May 11, 2020 at 4:07 AM Ricardo Ca=C3=B1uelo > wrote: > > > > hi3660-hikey960.dts: > > Define a 'ports' node for 'adv7533: adv7533@39' and the > > 'adi,dsi-lanes' property to make it compliant with the adi,adv7533 DT > > binding. > > > > This fills the requirements to meet the binding requirements, > > remote endpoints are not defined. > > > > hi6220-hikey.dts: > > Change property name s/pd-gpio/pd-gpios, gpio properties should be > > plural. This is just a cosmetic change. > > > > Signed-off-by: Ricardo Ca=C3=B1uelo > > As a heads up. > So this change sounds sane, but I just bisected it down as the cause > of a regression on HiKey960 where the adv7511 driver doesn't probe. > > I'll dig a bit more on what is going on (the DRM driver is still out > of tree, so maybe the DTS bits for that are not quite right?), but if > you have any suggestions, I'll give those a try. Yes. It ends up the DRM driver dts changes were being done in the wrong file so it was adding adv7511 bits in the dtsi, which were then being overridden by your tweak. I'll fixup the pending DRM driver dts bits. Apologies for the noise. thanks -john From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E61A0C433DF for ; Tue, 4 Aug 2020 21:25:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9B8D22B42 for ; Tue, 4 Aug 2020 21:25:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oW93oJk5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LthmW3Lz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9B8D22B42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nD/HbpPhUlxR4FlbA0EWqeKTu8IBcQWZphbaYNogzpg=; b=oW93oJk5AVg1CLmAeNMLaEpCi TARbesNudriiVt1FJ37n/zaa62frFuauDFx5+C3tvyJmDCFWMNi5fdxU0ZvnEK+hP5PgBsztj8xvp n0WC7th0zZ4VroFbRyYJJJkseQ6B+v23t68G9+cO3yKg8SN+3Un2GTN18Pzv4E/pqIZoKT//MDhWa mvgsCLjCO2uqSSdOmZ6wjiXQOPNNKT3Xyp0w4yexP+bAwMgG1hubQdu2LLihsKDyXECosgQrGdkke dMvdQYF6OSki2A0JXe7PIqafmuk+E2HYh4vQEkBLrprHCP39hdChPepf/DFdYlhizHeMK0H1MBKin ikAaxngeg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k34QB-0000wi-N9; Tue, 04 Aug 2020 21:24:31 +0000 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k34Q8-0000vZ-3O for linux-arm-kernel@lists.infradead.org; Tue, 04 Aug 2020 21:24:29 +0000 Received: by mail-ot1-x343.google.com with SMTP id x24so7583840otp.3 for ; Tue, 04 Aug 2020 14:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=k9/tscxhQqLXMKufpxll8+O44Aoxn3IbN6hHzmHjeyk=; b=LthmW3LzzjhnSTSJ/Gk3/qE3qMtkbshJVZQ8VvPoQUD14fRb8+6ZREaa16vBXOv1B/ iCz3iW+Ld6mgmeMw0916UckRv6jqN1O3aiBgPtqwXE14SpVgCbHxPPjndJ5a0qf9ZuBO 0DMgY2VCRRgo1VuhaAsG3Pq2eLgLRLyQmtbm1paF9aVKd5GPRUp+JagTiJ0ixRjJYWtH vH9TTHge8Lz6YzaqokOI9017/ZYGVovnurHehoFn81WWkRgDL898MDEvu/hvL7nKxE4P ijvjQkL0+o3F4MiCZyH/zbsTqkGpi/VEbJP7wQBQwImsUtMHCzmwfIv6IIvz+tstdU3G 0GdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=k9/tscxhQqLXMKufpxll8+O44Aoxn3IbN6hHzmHjeyk=; b=SW9U+1BBpwOnh8TlWJV8yGTYM5bPbPbIkeWnyhQIgedyTS/YWtxIzjtvhZj10aKr0P WzT+9miUILU29GrcumUhHoro3b27KhEHyov9omYjJ+LiHwZmRN0lyw6UZY31aj1iM+VG qeXKPceP0m9zG8bJ4oKVJzP8p/uFxMpBkFgvWhefRuswF7a2KBaf9DLh0/3MYZPkhOyH nQ9u2oe8PEQ2ISx/nnXRLRUFHh7scyg6LXz+IUDtoy37rIJTwMAmJxU6//xTo7mJl0eE FOf0K58TTyHWqJiR9WwCC2q4NHJR3MSJCOLQ3xkWdLtAuY9KV7Vx1D7GYd5ChTh9tLMs 57SQ== X-Gm-Message-State: AOAM530196XVFjMTdwS8qgh688M9YXKFU63R3dLyOw7/Z4qxWMjxs2WT s9+EMJlMUnIcfQ1J2YU0TD5m+vM8OZpiLB9HyHqs6g== X-Google-Smtp-Source: ABdhPJwrlWMjyO3HV4MDFR4gb4NaCjbwSiumlhalogqG2gqSuAloVI6+obWms7yfcFnZi+bTMkLl8+r5tY36mh/4U4o= X-Received: by 2002:a05:6830:237b:: with SMTP id r27mr45696oth.352.1596576265757; Tue, 04 Aug 2020 14:24:25 -0700 (PDT) MIME-Version: 1.0 References: <20200511110611.3142-1-ricardo.canuelo@collabora.com> <20200511110611.3142-5-ricardo.canuelo@collabora.com> In-Reply-To: From: John Stultz Date: Tue, 4 Aug 2020 14:24:13 -0700 Message-ID: Subject: Re: [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 DT binding To: =?UTF-8?Q?Ricardo_Ca=C3=B1uelo?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200804_172428_165031_0283756B X-CRM114-Status: GOOD ( 20.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven , Mauro Carvalho Chehab , Wei Xu , Rob Herring , Laurent Pinchart , kernel@collabora.com, linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBdWcgNCwgMjAyMCBhdCAxOjU3IFBNIEpvaG4gU3R1bHR6IDxqb2huLnN0dWx0ekBs aW5hcm8ub3JnPiB3cm90ZToKPgo+IE9uIE1vbiwgTWF5IDExLCAyMDIwIGF0IDQ6MDcgQU0gUmlj YXJkbyBDYcOxdWVsbwo+IDxyaWNhcmRvLmNhbnVlbG9AY29sbGFib3JhLmNvbT4gd3JvdGU6Cj4g Pgo+ID4gaGkzNjYwLWhpa2V5OTYwLmR0czoKPiA+ICAgRGVmaW5lIGEgJ3BvcnRzJyBub2RlIGZv ciAnYWR2NzUzMzogYWR2NzUzM0AzOScgYW5kIHRoZQo+ID4gICAnYWRpLGRzaS1sYW5lcycgcHJv cGVydHkgdG8gbWFrZSBpdCBjb21wbGlhbnQgd2l0aCB0aGUgYWRpLGFkdjc1MzMgRFQKPiA+ICAg YmluZGluZy4KPiA+Cj4gPiAgIFRoaXMgZmlsbHMgdGhlIHJlcXVpcmVtZW50cyB0byBtZWV0IHRo ZSBiaW5kaW5nIHJlcXVpcmVtZW50cywKPiA+ICAgcmVtb3RlIGVuZHBvaW50cyBhcmUgbm90IGRl ZmluZWQuCj4gPgo+ID4gaGk2MjIwLWhpa2V5LmR0czoKPiA+ICAgQ2hhbmdlIHByb3BlcnR5IG5h bWUgcy9wZC1ncGlvL3BkLWdwaW9zLCBncGlvIHByb3BlcnRpZXMgc2hvdWxkIGJlCj4gPiAgIHBs dXJhbC4gVGhpcyBpcyBqdXN0IGEgY29zbWV0aWMgY2hhbmdlLgo+ID4KPiA+IFNpZ25lZC1vZmYt Ynk6IFJpY2FyZG8gQ2HDsXVlbG8gPHJpY2FyZG8uY2FudWVsb0Bjb2xsYWJvcmEuY29tPgo+Cj4g QXMgYSBoZWFkcyB1cC4KPiBTbyB0aGlzIGNoYW5nZSBzb3VuZHMgc2FuZSwgYnV0IEkganVzdCBi aXNlY3RlZCBpdCBkb3duIGFzIHRoZSBjYXVzZQo+IG9mIGEgcmVncmVzc2lvbiBvbiBIaUtleTk2 MCB3aGVyZSB0aGUgYWR2NzUxMSBkcml2ZXIgZG9lc24ndCBwcm9iZS4KPgo+IEknbGwgZGlnIGEg Yml0IG1vcmUgb24gd2hhdCBpcyBnb2luZyBvbiAodGhlIERSTSBkcml2ZXIgaXMgc3RpbGwgb3V0 Cj4gb2YgdHJlZSwgc28gbWF5YmUgdGhlIERUUyBiaXRzIGZvciB0aGF0IGFyZSBub3QgcXVpdGUg cmlnaHQ/KSwgYnV0IGlmCj4geW91IGhhdmUgYW55IHN1Z2dlc3Rpb25zLCBJJ2xsIGdpdmUgdGhv c2UgYSB0cnkuCgpZZXMuIEl0IGVuZHMgdXAgdGhlIERSTSBkcml2ZXIgZHRzIGNoYW5nZXMgd2Vy ZSBiZWluZyBkb25lIGluIHRoZQp3cm9uZyBmaWxlIHNvIGl0IHdhcyBhZGRpbmcgYWR2NzUxMSBi aXRzIGluIHRoZSBkdHNpLCB3aGljaCB3ZXJlIHRoZW4KYmVpbmcgb3ZlcnJpZGRlbiBieSB5b3Vy IHR3ZWFrLiBJJ2xsIGZpeHVwIHRoZSBwZW5kaW5nIERSTSBkcml2ZXIgZHRzCmJpdHMuIEFwb2xv Z2llcyBmb3IgdGhlIG5vaXNlLgoKdGhhbmtzCi1qb2huCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==