Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

From: John Stultz <john.stultz@linaro.org>
To: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
Cc: John Youn <John.Youn@synopsys.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Wei Xu <xuwei5@hisilicon.com>, Guodong Xu <guodong.xu@linaro.org>,
	Amit Pundir <amit.pundir@linaro.org>,
	YongQin Liu <yongqin.liu@linaro.org>,
	Douglas Anderson <dianders@chromium.org>,
	Chen Yu <chenyu56@huawei.com>,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey
Date: Thu, 19 Oct 2017 13:20:49 -0700	[thread overview]
Message-ID: <CALAqxLWBrnOwgA3QATMY3NGQgm5GZOXQRSpeDtoo7OA7UwRCJA@mail.gmail.com> (raw)
In-Reply-To: <410670D7E743164D87FA6160E7907A560113A3036D@am04wembxa.internal.synopsys.com>

On Wed, Oct 18, 2017 at 11:46 PM, Minas Harutyunyan
<Minas.Harutyunyan@synopsys.com> wrote:
> Could you please apply this patch. Please not apply your patch series
> "[PATCH 0/3] dwc2 fixes for edge cases on hikey" to check only below patch.
> If you confirm that this patch fix your issue with "Transaction Error"
> and " ChHltd set, but reason is unknown" I'll submit to LKML as final patch.
> Then can be applied your patch series, without patch 1/3 (changing in
> connector id status change) to correctly set UDC states.
>
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index
> f4ef159b538e..7da22152df68 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -331,6 +331,9 @@ static void dwc2_gusbcfg_init(struct dwc2_hsotg *hsotg)
>          usbcfg = dwc2_readl(hsotg->regs + GUSBCFG);
>          usbcfg &= ~(GUSBCFG_HNPCAP | GUSBCFG_SRPCAP);
>
> +       /* Set HS/FS Timeout Calibration */
> +       usbcfg |= GUSBCFG_TOUTCAL(7);
> +
>          switch (hsotg->hw_params.op_mode) {
>          case GHWCFG2_OP_MODE_HNP_SRP_CAPABLE:
>                  if (hsotg->params.otg_cap ==

So while using this patch and the earlier one from Vardan, I don't see
the "Transaction Error"
and " ChHltd set, but reason is unknown" messages, but I do see:

[  272.290459] dwc2 f72c0000.usb: Mode Mismatch Interrupt: currently
in Host mode
[  272.290476] dwc2 f72c0000.usb: Mode Mismatch Interrupt: currently
in Host mode
[  272.290491] dwc2 f72c0000.usb: Mode Mismatch Interrupt: currently
in Host mode
[  272.290507] dwc2 f72c0000.usb: Mode Mismatch Interrupt: currently
in Host mode
[  272.290522] dwc2 f72c0000.usb: Mode Mismatch Interrupt: currently
in Host mode
[  272.290538] dwc2 f72c0000.usb: Mode Mismatch Interrupt: currently
in Host mode
[  272.290554] dwc2 f72c0000.usb: Mode Mismatch Interrupt: currently
in Host mode
[  272.290570] dwc2 f72c0000.usb: Mode Mismatch Interrupt: currently
in Host mode
[  272.290585] dwc2 f72c0000.usb: Mode Mismatch Interrupt: currently
in Host mode
[  272.290687] dwc2 f72c0000.usb: dwc2_hsotg_ep_stop_xfr: timeout DIEPINT.NAKEFF
[  272.290702] dwc2 f72c0000.usb: Mode Mismatch Interrupt: currently
in Host mode
[  272.290717] dwc2 f72c0000.usb: Mode Mismatch Interrupt: currently
in Host mode

After which the USB eth device stops functioning.

So its not really much functional change from without the patch from
my perspective.

Additionally, I'm still not seeing any disconnect calls when removing
the B plug.

Re-adding my three patches ontop of this change and Vardan's does fix
both the UDC state handling and avoids usb devices from failing when
the board is in host mode and the /dev/usb-ffs/adb/ep0 file is closed
by adbd.

thanks
-john