From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A848C433E0 for ; Tue, 4 Aug 2020 20:57:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E86B2086A for ; Tue, 4 Aug 2020 20:57:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cofNJGqX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728038AbgHDU5d (ORCPT ); Tue, 4 Aug 2020 16:57:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727045AbgHDU5b (ORCPT ); Tue, 4 Aug 2020 16:57:31 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49D4BC06174A for ; Tue, 4 Aug 2020 13:57:31 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id x24so7530044otp.3 for ; Tue, 04 Aug 2020 13:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ew7RpwihRSTCnUgcvw5AbxI8h8NUrdZdMwtakCPnHo4=; b=cofNJGqXeQw6v7cqYxAvPmopvbKtLPmZ6VgOWXWb60MAG6K91VLZyZm0cCEo9zt4/R fi2ILKX8HJazErPrDyZIbZHctMxS05+6Z2EA/Tr/9qTp0ogeG6yNIWGyMeVv8SE0GPXk uzOkZagf7L7ojHM03l5xFit7wCASfbhupERrwm1VIxC1UCBDp56ON1GC7IutwPb/CStM XIGPOdE3A+kjxPilnUOVcwqe9qTWsmYHUKODOPwvOgU6eW4BAb2/kHu7mRc9K/8LOLr7 vi5++r7Bj3eQ4kcF5xoSLz8UnRhjz9vs/Tg1+r79wAGIeFg+CmpgLSOEyGiPx6Upa57j MsXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ew7RpwihRSTCnUgcvw5AbxI8h8NUrdZdMwtakCPnHo4=; b=mcDlhbGedUvjimHHl/2zUY03In87nKIrXuoMV9vk2876io6m/IkSoISBwFoNtX/0B7 GKqwMGJmXRbEqk7QZ1KYn9RHyWyYgI2dN7SFPioIwbOBu2AV6sJxk3Ng/UBDItuY3KS+ eZqw6uQYHE+faoPCrX2A+KwHH9gAh/7XYAkC+sNvEZr0R39ncnF+vH8Jvh74FDkhWIAe Yk/zK2r2jpvl0j6growh7f1R2zHA55PCqvo7a6kDg2DHLfKczpwArTmgKhXuT7tom4qI kWVrVSs8cXwGPnpl/fh3PyKL1Qq29FjzRkLqzyOUSMxsUK8F5xJMAtPChZYItDfj01JO qfvQ== X-Gm-Message-State: AOAM530ii+jwJpxKV9/60t5ijt3UyGwbdPcqmA5OavBaWp/wJy4bh7lb kWjCVmMRdnB60yJC1T1vtjo39qTfeffsdvtrrSvK0g== X-Google-Smtp-Source: ABdhPJwssL95/NKq1hq6qV7chgO3lIiK0ksJVekE+5Kda/WgnbkduHUSAtXrjtJlbKaHlL6MbnqZ39u0lGVEDDu55Fk= X-Received: by 2002:a05:6830:237b:: with SMTP id r27mr18375403oth.352.1596574650640; Tue, 04 Aug 2020 13:57:30 -0700 (PDT) MIME-Version: 1.0 References: <20200511110611.3142-1-ricardo.canuelo@collabora.com> <20200511110611.3142-5-ricardo.canuelo@collabora.com> In-Reply-To: <20200511110611.3142-5-ricardo.canuelo@collabora.com> From: John Stultz Date: Tue, 4 Aug 2020 13:57:18 -0700 Message-ID: Subject: Re: [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 DT binding To: =?UTF-8?Q?Ricardo_Ca=C3=B1uelo?= Cc: Laurent Pinchart , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven , Wei Xu , Rob Herring , kernel@collabora.com, linux-arm-kernel , Mauro Carvalho Chehab Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, May 11, 2020 at 4:07 AM Ricardo Ca=C3=B1uelo wrote: > > hi3660-hikey960.dts: > Define a 'ports' node for 'adv7533: adv7533@39' and the > 'adi,dsi-lanes' property to make it compliant with the adi,adv7533 DT > binding. > > This fills the requirements to meet the binding requirements, > remote endpoints are not defined. > > hi6220-hikey.dts: > Change property name s/pd-gpio/pd-gpios, gpio properties should be > plural. This is just a cosmetic change. > > Signed-off-by: Ricardo Ca=C3=B1uelo As a heads up. So this change sounds sane, but I just bisected it down as the cause of a regression on HiKey960 where the adv7511 driver doesn't probe. I'll dig a bit more on what is going on (the DRM driver is still out of tree, so maybe the DTS bits for that are not quite right?), but if you have any suggestions, I'll give those a try. If anyone is curious, my latest patches for the board is here: https://git.linaro.org/people/john.stultz/android-dev.git/log/?h=3Ddev/hike= y960-mainline-WIP&id=3D4e6cefcc9bc1c13a503fdcb3768b3fd6479d8655 thanks -john From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABA3AC433E3 for ; Tue, 4 Aug 2020 20:59:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 861A52086A for ; Tue, 4 Aug 2020 20:59:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cFrLYqve"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cofNJGqX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 861A52086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yLN+aDWiSZ9SuDVyFAhVeL5pMUkbgveRDOnx1iUA0Lo=; b=cFrLYqveQ4EtPCwueFBuZPssg xK3jHgCwZxnUH4hkIV0S5Iuir8MDWbzxtWzk6jo+25Q7qrNkiF+6WHvH3HP+wzOHqWUZ9gtHipkjL hmJzD98psmqeOVnRbkw0j1EVMVz2ZyeXHB7j9XP2mZgsZSVWw2y2sm9vej924JPan7dOkNGUdKVsY 6qz8ScY0l2LQWkuz0wl0yjgrLA3bOnJRRmBO+J0qLhT80JOkeTtUPRkZ7fy8rKv9jh4gLB6eA3avP DzJgWoCeT+s4eDg++DSr+ELAlcVKCPH7sLE6FUgzh2+auAxPvh1wU4xxUjDX4Nxq+iLzRSU8BL/KE HJPTMctEQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3408-0004aD-SJ; Tue, 04 Aug 2020 20:57:36 +0000 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3406-0004ZA-F1 for linux-arm-kernel@lists.infradead.org; Tue, 04 Aug 2020 20:57:35 +0000 Received: by mail-ot1-x341.google.com with SMTP id c4so6121406otf.12 for ; Tue, 04 Aug 2020 13:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ew7RpwihRSTCnUgcvw5AbxI8h8NUrdZdMwtakCPnHo4=; b=cofNJGqXeQw6v7cqYxAvPmopvbKtLPmZ6VgOWXWb60MAG6K91VLZyZm0cCEo9zt4/R fi2ILKX8HJazErPrDyZIbZHctMxS05+6Z2EA/Tr/9qTp0ogeG6yNIWGyMeVv8SE0GPXk uzOkZagf7L7ojHM03l5xFit7wCASfbhupERrwm1VIxC1UCBDp56ON1GC7IutwPb/CStM XIGPOdE3A+kjxPilnUOVcwqe9qTWsmYHUKODOPwvOgU6eW4BAb2/kHu7mRc9K/8LOLr7 vi5++r7Bj3eQ4kcF5xoSLz8UnRhjz9vs/Tg1+r79wAGIeFg+CmpgLSOEyGiPx6Upa57j MsXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ew7RpwihRSTCnUgcvw5AbxI8h8NUrdZdMwtakCPnHo4=; b=DdCrQR0EWW2tYKJtwNbCsXoBFKtxF78g8td0dUUH1xVjQPkueHsUd+lYEgfQQ2oY7P 1S7Cq2ozaHZoXfQJFe3undrSGX7x6GDZLSw/XzuF+sXJMUNBnHqAmu4O5SwrO5JMgCnE cP28sv1b8eBqojWNQRfGSS5Y7plzEV3Aap3d0R/4whpmsDlTuEQRsMN9AtAj72Jqi7OI DvNcxBwLhoDGn3AM4G6S2fnuYq/SaTYklPu0ic9NAqYyerVrN/+V1rES9SRM8xCYo2cd dfgG9Lfm5M6Ivn3J+Zy1Epky0eB0fcp0DydoBV8Yr2944xwlMLiS4AylctZVLHnOJYeP jO/Q== X-Gm-Message-State: AOAM531u9osxus9VP1qCMjITy7E6KQTrLwqMSlXFyX+gZ3GYRxlSktnu sIyLaHSlNfRuTj4IiNZRmYp+N9UK1eUCRhW4PkjIsw== X-Google-Smtp-Source: ABdhPJwssL95/NKq1hq6qV7chgO3lIiK0ksJVekE+5Kda/WgnbkduHUSAtXrjtJlbKaHlL6MbnqZ39u0lGVEDDu55Fk= X-Received: by 2002:a05:6830:237b:: with SMTP id r27mr18375403oth.352.1596574650640; Tue, 04 Aug 2020 13:57:30 -0700 (PDT) MIME-Version: 1.0 References: <20200511110611.3142-1-ricardo.canuelo@collabora.com> <20200511110611.3142-5-ricardo.canuelo@collabora.com> In-Reply-To: <20200511110611.3142-5-ricardo.canuelo@collabora.com> From: John Stultz Date: Tue, 4 Aug 2020 13:57:18 -0700 Message-ID: Subject: Re: [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 DT binding To: =?UTF-8?Q?Ricardo_Ca=C3=B1uelo?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200804_165734_513468_A78F73F3 X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven , Mauro Carvalho Chehab , Wei Xu , Rob Herring , Laurent Pinchart , kernel@collabora.com, linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXkgMTEsIDIwMjAgYXQgNDowNyBBTSBSaWNhcmRvIENhw7F1ZWxvCjxyaWNhcmRv LmNhbnVlbG9AY29sbGFib3JhLmNvbT4gd3JvdGU6Cj4KPiBoaTM2NjAtaGlrZXk5NjAuZHRzOgo+ ICAgRGVmaW5lIGEgJ3BvcnRzJyBub2RlIGZvciAnYWR2NzUzMzogYWR2NzUzM0AzOScgYW5kIHRo ZQo+ICAgJ2FkaSxkc2ktbGFuZXMnIHByb3BlcnR5IHRvIG1ha2UgaXQgY29tcGxpYW50IHdpdGgg dGhlIGFkaSxhZHY3NTMzIERUCj4gICBiaW5kaW5nLgo+Cj4gICBUaGlzIGZpbGxzIHRoZSByZXF1 aXJlbWVudHMgdG8gbWVldCB0aGUgYmluZGluZyByZXF1aXJlbWVudHMsCj4gICByZW1vdGUgZW5k cG9pbnRzIGFyZSBub3QgZGVmaW5lZC4KPgo+IGhpNjIyMC1oaWtleS5kdHM6Cj4gICBDaGFuZ2Ug cHJvcGVydHkgbmFtZSBzL3BkLWdwaW8vcGQtZ3Bpb3MsIGdwaW8gcHJvcGVydGllcyBzaG91bGQg YmUKPiAgIHBsdXJhbC4gVGhpcyBpcyBqdXN0IGEgY29zbWV0aWMgY2hhbmdlLgo+Cj4gU2lnbmVk LW9mZi1ieTogUmljYXJkbyBDYcOxdWVsbyA8cmljYXJkby5jYW51ZWxvQGNvbGxhYm9yYS5jb20+ CgpBcyBhIGhlYWRzIHVwLgpTbyB0aGlzIGNoYW5nZSBzb3VuZHMgc2FuZSwgYnV0IEkganVzdCBi aXNlY3RlZCBpdCBkb3duIGFzIHRoZSBjYXVzZQpvZiBhIHJlZ3Jlc3Npb24gb24gSGlLZXk5NjAg d2hlcmUgdGhlIGFkdjc1MTEgZHJpdmVyIGRvZXNuJ3QgcHJvYmUuCgpJJ2xsIGRpZyBhIGJpdCBt b3JlIG9uIHdoYXQgaXMgZ29pbmcgb24gKHRoZSBEUk0gZHJpdmVyIGlzIHN0aWxsIG91dApvZiB0 cmVlLCBzbyBtYXliZSB0aGUgRFRTIGJpdHMgZm9yIHRoYXQgYXJlIG5vdCBxdWl0ZSByaWdodD8p LCBidXQgaWYKeW91IGhhdmUgYW55IHN1Z2dlc3Rpb25zLCBJJ2xsIGdpdmUgdGhvc2UgYSB0cnku CgpJZiBhbnlvbmUgaXMgY3VyaW91cywgbXkgbGF0ZXN0IHBhdGNoZXMgZm9yIHRoZSBib2FyZCBp cyBoZXJlOgpodHRwczovL2dpdC5saW5hcm8ub3JnL3Blb3BsZS9qb2huLnN0dWx0ei9hbmRyb2lk LWRldi5naXQvbG9nLz9oPWRldi9oaWtleTk2MC1tYWlubGluZS1XSVAmaWQ9NGU2Y2VmY2M5YmMx YzEzYTUwM2ZkY2IzNzY4YjNmZDY0NzlkODY1NQoKdGhhbmtzCi1qb2huCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==