From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932857AbeDXDDs (ORCPT ); Mon, 23 Apr 2018 23:03:48 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:43916 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932759AbeDXDDq (ORCPT ); Mon, 23 Apr 2018 23:03:46 -0400 X-Google-Smtp-Source: AIpwx48KkDhFk5P8kS7Q4MtjJCJcpMr/3F0t0IeqM+Gr6/5VX7R8AQbSPyR0MkBmMgUoYXGTk1LIaJXhAbDw7uKsbFk= MIME-Version: 1.0 In-Reply-To: References: <2580c734d38041e984215ccc522a4f2d@genki.is> From: John Stultz Date: Mon, 23 Apr 2018 20:03:44 -0700 Message-ID: Subject: Re: [RFC/RFT patch 0/7] timekeeping: Unify clock MONOTONIC and clock BOOTTIME To: Genki Sky Cc: David Herrmann , lkml , Sergey Senozhatsky , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 23, 2018 at 7:45 PM, Genki Sky wrote: > Quoting Genki Sky (2018/04/23 20:40:36 -0400) >> I came across this thread for same reason as [0]: Daemons getting >> killed by systemd on resume (after >WatchdogSec seconds of >> suspending). I'm using master branch of systemd and the kernel. As >> mentioned, systemd uses CLOCK_MONOTONIC, originally expecting it to >> not include suspend time. >> >> Correct me if I'm mistaken, but I don't see the ambiguity of whether >> this patch series breaks systemd. If it's implemented correctly, you'd >> hope it *would* break it! > > This sounded a little weak on re-reading, sorry. So, I just confirmed > that after booting a "git revert -m 1 680014d6d1da", the issue no > longer appears. (I.e., a suspend for >WatchDog sec doesn't result in > any daemon getting killed). > > Let me know if I can help in any way. Yea, this is the sort of thing I was worried about. Thomas: I think reverting this change is needed. thanks -john