From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A6B0C10F11 for ; Wed, 24 Apr 2019 19:25:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52C6020652 for ; Wed, 24 Apr 2019 19:25:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hqyhgSpi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731350AbfDXTZu (ORCPT ); Wed, 24 Apr 2019 15:25:50 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:42982 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbfDXTZt (ORCPT ); Wed, 24 Apr 2019 15:25:49 -0400 Received: by mail-wr1-f68.google.com with SMTP id g3so26708765wrx.9 for ; Wed, 24 Apr 2019 12:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a2LfF+54lAYEDIYuh1kcXf6iTBYgfOjqWNYwzXwMRmQ=; b=hqyhgSpiAgUsPyz1ZyX9vXULHY8xwUjMTz5sjXsLXWiTFjQZj8y92RAVojJzWtXWUE gYUSJA+0XOeJ39h+OCP2QmKRDzn1BUvETUor3WX47WOOMExHlO6l/sXIGQHkGXvN8dSE Vtw8/nN465q10/sQBDyTosM6c8EMMGwe0hWWrg660R1B7+vxcREKYIkC2wBUhY1yz/XI Uqcbgc98QyHz/EEb+SwbqXxw3MPF2nc6OUU7nZueGYiOGcxnfTjB31GFfAcXZozLqIDZ fZN1048AYtRiX2/uFlqrBs5kSxBGIUDslTeHxqNIuHXqtJ7jj7chPYGydgR/X5AbRTIe mSpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a2LfF+54lAYEDIYuh1kcXf6iTBYgfOjqWNYwzXwMRmQ=; b=gbA7qmW3uPlFVruTOCGsie0GoajGKCS56nb0Sz1NEVRZqEbdx/j5ZKTyuRW56//6Y8 9uN8YJu7IYu0VXqpijRzcVPf5PjHYS56l7GEAwgzGHJjnnMk/ZCBz0O1qRuWPuRzcfN8 mhGpf2kfTAhmAXSSx+C9k9Y+u7A3FQ4/rqHDsCqIEQbsG7SbmetYOl8S6OcK6iqlVbs1 gGt3PyClk7Z874dDs1UjQiCFgiqhfOGS1MU0m48AQpx+2tvog9YfffVK96OJwCscUglD x5B8g3rxpGTJgc5dH7b/kDVlDfun03zktqOaaEuckpfapre8VwDUrFgb3M8fWtTHIPM7 zbdw== X-Gm-Message-State: APjAAAW0q77E+jT0f6T/DfuaVlVgk7TKxmR65dKDaf+OhdI0t5caWSaI gabZFK7furnB0Oq20YOsRqmlGEDc/si/Uhr4KKYTiQ== X-Google-Smtp-Source: APXvYqznbn3Slfia7rEN0K5uBFs1V9XeBBnlQpsghjBILJBDXc3J38DuhwUiDRoHSzh8t7jrC+AGF8yT6O1FQ897eec= X-Received: by 2002:adf:cd90:: with SMTP id q16mr1316301wrj.75.1556133947827; Wed, 24 Apr 2019 12:25:47 -0700 (PDT) MIME-Version: 1.0 References: <1556061656-1733-1-git-send-email-john.stultz@linaro.org> <1556061656-1733-12-git-send-email-john.stultz@linaro.org> <20190424165049.GD20110@ravnborg.org> In-Reply-To: <20190424165049.GD20110@ravnborg.org> From: John Stultz Date: Wed, 24 Apr 2019 12:25:36 -0700 Message-ID: Subject: Re: [PATCH 11/25] drm: kirin: Move kirin_crtc, kirin_plane, kirin_format to kirin_drm_drv.h To: Sam Ravnborg Cc: lkml , Xu YiPing , David Airlie , Chen Feng , dri-devel , Xinliang Liu , Xinwei Kong , Rongrong Zou Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 24, 2019 at 9:50 AM Sam Ravnborg wrote: > On Tue, Apr 23, 2019 at 04:20:42PM -0700, John Stultz wrote: > > This struct: > > /* ade-format info: */ > > -struct ade_format { > > - u32 pixel_format; > > - enum ade_fb_format ade_format; > > -}; > > - > > -static const struct ade_format ade_formats[] = { > > +static const struct kirin_format ade_formats[] = { > > /* 16bpp RGB: */ > > { DRM_FORMAT_RGB565, ADE_RGB_565 }, > > { DRM_FORMAT_BGR565, ADE_BGR_565 }, ... > > + > > +/* kirin-format translate table */ > > +struct kirin_format { > > + u32 pixel_format; > > + u32 hw_format; > > +}; > Is renamed. > The member hw_format is renamed and no longer uses an enum. > (The sole user of this enum type). So the enum values are still used, but yes, the type here shifts. > These changes are not included in the changelog - should they be part of > this patch? > And also the change from enum to u32 is not understood. So the intent is to be able to share the kirin_format structure between both the kirin620 support and kirin960, where as the ade_fb_format enum values are tied to the kirin620, the kirin960 has dpe_fb_formats enum which has different values. So the u32 hw_format value is just the generic storage for enumerated format types of either device. So its just a map from generic pixel_format definition -> hardware specific value for that format. I'll try to make that change more clear in the commit message, but if you have ideas for a simpler or cleaner way to do the same, let me know. thanks -john From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Stultz Subject: Re: [PATCH 11/25] drm: kirin: Move kirin_crtc, kirin_plane, kirin_format to kirin_drm_drv.h Date: Wed, 24 Apr 2019 12:25:36 -0700 Message-ID: References: <1556061656-1733-1-git-send-email-john.stultz@linaro.org> <1556061656-1733-12-git-send-email-john.stultz@linaro.org> <20190424165049.GD20110@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 491E78920C for ; Wed, 24 Apr 2019 19:25:49 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id b1so15392107wru.3 for ; Wed, 24 Apr 2019 12:25:49 -0700 (PDT) In-Reply-To: <20190424165049.GD20110@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sam Ravnborg Cc: Xu YiPing , David Airlie , Chen Feng , lkml , dri-devel , Xinliang Liu , Xinwei Kong , Rongrong Zou List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBcHIgMjQsIDIwMTkgYXQgOTo1MCBBTSBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9y Zy5vcmc+IHdyb3RlOgo+IE9uIFR1ZSwgQXByIDIzLCAyMDE5IGF0IDA0OjIwOjQyUE0gLTA3MDAs IEpvaG4gU3R1bHR6IHdyb3RlOgo+Cj4gVGhpcyBzdHJ1Y3Q6Cj4gPiAgLyogYWRlLWZvcm1hdCBp bmZvOiAqLwo+ID4gLXN0cnVjdCBhZGVfZm9ybWF0IHsKPiA+IC0gICAgIHUzMiBwaXhlbF9mb3Jt YXQ7Cj4gPiAtICAgICBlbnVtIGFkZV9mYl9mb3JtYXQgYWRlX2Zvcm1hdDsKPiA+IC19Owo+ID4g LQo+ID4gLXN0YXRpYyBjb25zdCBzdHJ1Y3QgYWRlX2Zvcm1hdCBhZGVfZm9ybWF0c1tdID0gewo+ ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qga2lyaW5fZm9ybWF0IGFkZV9mb3JtYXRzW10gPSB7Cj4g PiAgICAgICAvKiAxNmJwcCBSR0I6ICovCj4gPiAgICAgICB7IERSTV9GT1JNQVRfUkdCNTY1LCBB REVfUkdCXzU2NSB9LAo+ID4gICAgICAgeyBEUk1fRk9STUFUX0JHUjU2NSwgQURFX0JHUl81NjUg fSwKLi4uCj4gPiArCj4gPiArLyoga2lyaW4tZm9ybWF0IHRyYW5zbGF0ZSB0YWJsZSAqLwo+ID4g K3N0cnVjdCBraXJpbl9mb3JtYXQgewo+ID4gKyAgICAgdTMyIHBpeGVsX2Zvcm1hdDsKPiA+ICsg ICAgIHUzMiBod19mb3JtYXQ7Cj4gPiArfTsKPiBJcyByZW5hbWVkLgo+IFRoZSBtZW1iZXIgaHdf Zm9ybWF0IGlzIHJlbmFtZWQgYW5kIG5vIGxvbmdlciB1c2VzIGFuIGVudW0uCj4gKFRoZSBzb2xl IHVzZXIgb2YgdGhpcyBlbnVtIHR5cGUpLgoKU28gdGhlIGVudW0gdmFsdWVzIGFyZSBzdGlsbCB1 c2VkLCBidXQgeWVzLCB0aGUgdHlwZSBoZXJlIHNoaWZ0cy4KCj4gVGhlc2UgY2hhbmdlcyBhcmUg bm90IGluY2x1ZGVkIGluIHRoZSBjaGFuZ2Vsb2cgLSBzaG91bGQgdGhleSBiZSBwYXJ0IG9mCj4g dGhpcyBwYXRjaD8KPiBBbmQgYWxzbyB0aGUgY2hhbmdlIGZyb20gZW51bSB0byB1MzIgaXMgbm90 IHVuZGVyc3Rvb2QuCgpTbyB0aGUgaW50ZW50IGlzIHRvIGJlIGFibGUgdG8gc2hhcmUgdGhlIGtp cmluX2Zvcm1hdCBzdHJ1Y3R1cmUKYmV0d2VlbiBib3RoIHRoZSBraXJpbjYyMCBzdXBwb3J0IGFu ZCBraXJpbjk2MCwgd2hlcmUgYXMgdGhlCmFkZV9mYl9mb3JtYXQgZW51bSB2YWx1ZXMgYXJlIHRp ZWQgdG8gdGhlIGtpcmluNjIwLCB0aGUga2lyaW45NjAgaGFzCmRwZV9mYl9mb3JtYXRzIGVudW0g d2hpY2ggaGFzIGRpZmZlcmVudCB2YWx1ZXMuIFNvIHRoZSB1MzIgaHdfZm9ybWF0CnZhbHVlIGlz IGp1c3QgdGhlIGdlbmVyaWMgc3RvcmFnZSBmb3IgZW51bWVyYXRlZCBmb3JtYXQgdHlwZXMgb2YK ZWl0aGVyIGRldmljZS4gU28gaXRzIGp1c3QgYSBtYXAgZnJvbSBnZW5lcmljIHBpeGVsX2Zvcm1h dCBkZWZpbml0aW9uCi0+IGhhcmR3YXJlIHNwZWNpZmljIHZhbHVlIGZvciB0aGF0IGZvcm1hdC4K CkknbGwgdHJ5IHRvIG1ha2UgdGhhdCBjaGFuZ2UgbW9yZSBjbGVhciBpbiB0aGUgY29tbWl0IG1l c3NhZ2UsIGJ1dCBpZgp5b3UgaGF2ZSBpZGVhcyBmb3IgYSBzaW1wbGVyIG9yIGNsZWFuZXIgd2F5 IHRvIGRvIHRoZSBzYW1lLCBsZXQgbWUKa25vdy4KCnRoYW5rcwotam9obgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=