From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752363AbcJCUQZ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Oct 2016 16:16:25 -0400
Received: from mail-oi0-f48.google.com ([209.85.218.48]:34425 "EHLO
        mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751554AbcJCUQR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Oct 2016 16:16:17 -0400
MIME-Version: 1.0
In-Reply-To: <xa1tint9qjqz.fsf@mina86.com>
References: <205cfce1-d54c-262d-f939-ad9f37b0c52c@huawei.com>
 <878tud4q6x.fsf@linux.intel.com> <261ada71-8a5d-6e89-7fac-6b6ba88218d7@huawei.com>
 <xa1t4m50ugsk.fsf@mina86.com> <xa1ty42bu2kv.fsf@mina86.com>
 <CALAqxLW0scq+WxcEZEojdap_UdN7r0aEV6+KxsZ4H2WFXHVXcQ@mail.gmail.com> <xa1tint9qjqz.fsf@mina86.com>
From: John Stultz <john.stultz@linaro.org>
Date: Mon, 3 Oct 2016 13:16:16 -0700
Message-ID: <CALAqxLWyU3cS4GX3bQvhTio4zgU5jozCJjT0RyKMVeR+TWC+sw@mail.gmail.com>
Subject: Re: BUG: scheduling while atomic in f_fs when gadget remove driver
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Chen Yu <chenyu56@huawei.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Biggo Wang <wangbinghui@hisilicon.com>,
        lkml <linux-kernel@vger.kernel.org>, linux-usb@vger.kernel.org,
        Amit Pundir <amit.pundir@linaro.org>,
        Guodong Xu <guodong.xu@linaro.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u93KGWie004098

On Mon, Oct 3, 2016 at 1:07 PM, Michal Nazarewicz <mina86@mina86.com> wrote:
> On Mon, Oct 03 2016, John Stultz wrote:
>> On Wed, Sep 28, 2016 at 2:38 PM, Michal Nazarewicz <mina86@mina86.com> wrote:
>>> On Wed, Sep 28 2016, Michal Nazarewicz wrote:
>>>> With that done, the only thing which needs a mutex is
>>>> epfile->read_buffer.
>>>
>>> Perhaps this would do:
>>>
>>> ---- >8 -------------------------------------------------- -------------
>>> From 6416a1065203a39328311f6c58083089efe169aa Mon Sep 17 00:00:00 2001
>>> From: Michal Nazarewicz <mina86@mina86.com>
>>> Date: Wed, 28 Sep 2016 23:36:56 +0200
>>> Subject: [RFC] usb: gadget: f_fs: stop sleeping in ffs_func_eps_disable
>>> MIME-Version: 1.0
>>> Content-Type: text/plain; charset=UTF-8
>>> Content-Transfer-Encoding: 8bit
>>>
>>> ffs_func_eps_disable is called from atomic context so it cannot sleep
>>> thus cannot grab a mutex.  Change the handling of epfile->read_buffer
>>> to use non-sleeping synchronisation method.
>>>
>>> Reported-by: Chen Yu <chenyu56@huawei.com>
>>> Signed-off-by: Michał Nazarewicz <mina86@mina86.com>
>>> Fixes: 9353afbbfa7b ("buffer data from ‘oversized’ OUT requests")
>>
>> So the patch here seems to be in some odd encoding?
>
> O_o
> It’s UTF-8.

Yea, I dunno. Simply copied it out of mutt and git am didn't like it.

I think its the "Content-Transfer-Encoding: quoted-printable" main email with
"Content-Transfer-Encoding: 8bit" embedded inside.

Ends up looking like:
Content-Type: text/plain; charset=3DUTF-8

With lots of =3D and =20 values spread about.

>> Can you resend it using git-send-email or in some way other then
>> embedding it inline here? Maybe just point me to a git tree that has
>> it?
>
>         https://github.com/mina86/linux.git f-fs-fix

Thanks so much! I'll fetch that and get testing on my side with it as well!

thanks again!
-john