From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D2A6C433EF for ; Wed, 29 Sep 2021 21:51:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42C18613A6 for ; Wed, 29 Sep 2021 21:51:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344409AbhI2Vxh (ORCPT ); Wed, 29 Sep 2021 17:53:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244341AbhI2Vxg (ORCPT ); Wed, 29 Sep 2021 17:53:36 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 946BAC061768 for ; Wed, 29 Sep 2021 14:51:54 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id u18so16615442lfd.12 for ; Wed, 29 Sep 2021 14:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QyZa3HE5AzTnbENME0c+EUQpZhFABdDt4UxWcwk5TJM=; b=WWSFtRfbtLI608F0Gg2VZAh1FMB0Sw410UJ0duopP3lRsTt2hsmEipXag4AOmfxKDI 7MKAWksjJLNofeIXURHWexv8M+/uA52YQKQkh6xlO2dp3qnuJcucj0QF0wlPnLL7G+CY vm2f8FUQ2HJroOq/HBQmmnTux3c0KCmIJ8SUs4luaUj+t+NA9kCp/3y39C1zf3Qvtwpf LaCbBmt7Fn2L7n4sydcITz+aUSsAAesmTGZv9p/uG9nxPdodqC85lWRJ+Bkcy3x5h7U+ kvlhXXwiSiJTjoKUItoLWB52VKpFPFSnkHXcneT1iPORQErRMM0LTsgEQjrmGpj1t4WQ hDiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QyZa3HE5AzTnbENME0c+EUQpZhFABdDt4UxWcwk5TJM=; b=55NNw2E1tjy/EMfIj7eLHQVMW1ZaAjaCAyyXQw+7OUGlpkOTNNWQG7y/Uu0UQgH9oz kK1OkPAf5uS/sf390KoK5ymTdhMoaQkkAJnfik1wrrBEf5X9p+/XTlueW9nJMybplIcZ h8AwY5UMow/Ns5CZ5TpkvuH83umEZKVi3U34uI+TkUvHBVKXa6ELF497YtkF/C7op+EI 1KAHCoGdvi1pSO7jPGCyHrL5y3yEWp6+nW/iTv9dbnvg2fiobeqan9reTY5wXGhwYGgJ 4b7mUKF/3h/kx3DPYg8G87dhCFuwamWcgCXbt4XGM8vgpQEvHizMBsEhMDweeBDkQGqC MURQ== X-Gm-Message-State: AOAM531Jur244zStBPNMe7E9cIOMJ2q5jhLFJHWnYSiHC8ArqvLxZ+1h U0PLnCMyyBr4EySClxkRG5GzErgekQQoxE5rhtomVQ== X-Google-Smtp-Source: ABdhPJxGvqFYzY22yc3Fsk+wgOe6xikVy1hR2J76T+Qxsjp4YCP2wTkaTdeqY+ydE1oYOitVBr5bbHaK9AS6FwbyCYM= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr2037444lfv.613.1632952312913; Wed, 29 Sep 2021 14:51:52 -0700 (PDT) MIME-Version: 1.0 References: <20210910101218.1632297-1-maxime@cerno.tech> In-Reply-To: From: John Stultz Date: Wed, 29 Sep 2021 14:51:40 -0700 Message-ID: Subject: Re: [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent To: Maxime Ripard Cc: Andrzej Hajda , Sam Ravnborg , Daniel Vetter , David Airlie , Jonas Karlman , Laurent Pinchart , Thierry Reding , Maarten Lankhorst , Thomas Zimmermann , Neil Armstrong , Robert Foss , Jernej Skrabec , Sean Paul , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Kyungmin Park , lkml , Xinliang Liu , Seung-Woo Kim , Tian Tao , Inki Dae , Linux Samsung SOC , linux-arm-msm , Rob Clark , dri-devel , Chen Feng , Xinwei Kong , Joonyoung Shim Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > > The best practice to avoid those issues is to register its functions only after > > > all its dependencies are live. We also shouldn't wait any longer than we should > > > to play nice with the other components that are waiting for us, so in our case > > > that would mean moving the DSI device registration to the bridge probe. > > > > > > I also had a look at all the DSI hosts, and it seems that exynos, kirin and msm > > > would be affected by this and wouldn't probe anymore after those changes. > > > Exynos and kirin seems to be simple enough for a mechanical change (that still > > > requires to be tested), but the changes in msm seemed to be far more important > > > and I wasn't confortable doing them. > > > > > > Hey Maxime, > > Sorry for taking so long to get to this, but now that plumbers is > > over I've had a chance to check it out on kirin > > > > Rob Clark pointed me to his branch with some fixups here: > > https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework > > > > But trying to boot hikey with that, I see the following loop indefinitely: > > [ 4.632132] adv7511 2-0039: supply avdd not found, using dummy regulator > > [ 4.638961] adv7511 2-0039: supply dvdd not found, using dummy regulator > > [ 4.645741] adv7511 2-0039: supply pvdd not found, using dummy regulator > > [ 4.652483] adv7511 2-0039: supply a2vdd not found, using dummy regulator > > [ 4.659342] adv7511 2-0039: supply v3p3 not found, using dummy regulator > > [ 4.666086] adv7511 2-0039: supply v1p2 not found, using dummy regulator > > [ 4.681898] adv7511 2-0039: failed to find dsi host > > I just realized Rob's tree is missing the kirin patch. My apologies! > I'll retest and let you know. Ok, just retested including the kirin patch and unfortunately I'm still seeing the same thing. :( Will dig a bit and let you know when I find more. thanks -john From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF48DC433F5 for ; Wed, 29 Sep 2021 21:51:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 769A560FE8 for ; Wed, 29 Sep 2021 21:51:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 769A560FE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B570E6E28A; Wed, 29 Sep 2021 21:51:55 +0000 (UTC) Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99B6D6EADD for ; Wed, 29 Sep 2021 21:51:54 +0000 (UTC) Received: by mail-lf1-x136.google.com with SMTP id e15so16618841lfr.10 for ; Wed, 29 Sep 2021 14:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QyZa3HE5AzTnbENME0c+EUQpZhFABdDt4UxWcwk5TJM=; b=WWSFtRfbtLI608F0Gg2VZAh1FMB0Sw410UJ0duopP3lRsTt2hsmEipXag4AOmfxKDI 7MKAWksjJLNofeIXURHWexv8M+/uA52YQKQkh6xlO2dp3qnuJcucj0QF0wlPnLL7G+CY vm2f8FUQ2HJroOq/HBQmmnTux3c0KCmIJ8SUs4luaUj+t+NA9kCp/3y39C1zf3Qvtwpf LaCbBmt7Fn2L7n4sydcITz+aUSsAAesmTGZv9p/uG9nxPdodqC85lWRJ+Bkcy3x5h7U+ kvlhXXwiSiJTjoKUItoLWB52VKpFPFSnkHXcneT1iPORQErRMM0LTsgEQjrmGpj1t4WQ hDiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QyZa3HE5AzTnbENME0c+EUQpZhFABdDt4UxWcwk5TJM=; b=kX/nQKp8O5d1ZFsQNLjbxb6F3pHUM0qV+A+cwY5wzsXmdl4mBSyTfDzzg/Ult4f++6 bezdmfL9LLHoF4Ej0oCqbwKm3YWavPRBOdJG4HyW+9LXgR/ghlGl9ViplQBb3vLCeQUx zt5PfU5Jv9aKRH+8QMOdvw/FyB4z85tbRdoWYkQdRlcvVfeTKj5TcgiNM/g4Ib57XM+Q RE48plYvZSPKlVtUAg1zHW8b9mdRY/cuJcOi7a9yfTtF4+JWp34OGkCSOgbQ/AdypNRJ rmmP7ALEmCyBgB7Mty26dZ52HsJ3xlgSwrcQA93jdmA635DbiM0MlR/3CAYW/sbgP3B8 Pa+w== X-Gm-Message-State: AOAM533oC6sepHsQnW4p2dLIJjZyFv1kSQGda6UVzoBL/VTJ6OTf4hgD zsXqErUJb0RfaxAz+2fLw7qso9rHhq16qBBYnm+yGQ== X-Google-Smtp-Source: ABdhPJxGvqFYzY22yc3Fsk+wgOe6xikVy1hR2J76T+Qxsjp4YCP2wTkaTdeqY+ydE1oYOitVBr5bbHaK9AS6FwbyCYM= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr2037444lfv.613.1632952312913; Wed, 29 Sep 2021 14:51:52 -0700 (PDT) MIME-Version: 1.0 References: <20210910101218.1632297-1-maxime@cerno.tech> In-Reply-To: From: John Stultz Date: Wed, 29 Sep 2021 14:51:40 -0700 Message-ID: Subject: Re: [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent To: Maxime Ripard Cc: Andrzej Hajda , Sam Ravnborg , Daniel Vetter , David Airlie , Jonas Karlman , Laurent Pinchart , Thierry Reding , Maarten Lankhorst , Thomas Zimmermann , Neil Armstrong , Robert Foss , Jernej Skrabec , Sean Paul , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Kyungmin Park , lkml , Xinliang Liu , Seung-Woo Kim , Tian Tao , Inki Dae , Linux Samsung SOC , linux-arm-msm , Rob Clark , dri-devel , Chen Feng , Xinwei Kong , Joonyoung Shim Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > > The best practice to avoid those issues is to register its functions only after > > > all its dependencies are live. We also shouldn't wait any longer than we should > > > to play nice with the other components that are waiting for us, so in our case > > > that would mean moving the DSI device registration to the bridge probe. > > > > > > I also had a look at all the DSI hosts, and it seems that exynos, kirin and msm > > > would be affected by this and wouldn't probe anymore after those changes. > > > Exynos and kirin seems to be simple enough for a mechanical change (that still > > > requires to be tested), but the changes in msm seemed to be far more important > > > and I wasn't confortable doing them. > > > > > > Hey Maxime, > > Sorry for taking so long to get to this, but now that plumbers is > > over I've had a chance to check it out on kirin > > > > Rob Clark pointed me to his branch with some fixups here: > > https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework > > > > But trying to boot hikey with that, I see the following loop indefinitely: > > [ 4.632132] adv7511 2-0039: supply avdd not found, using dummy regulator > > [ 4.638961] adv7511 2-0039: supply dvdd not found, using dummy regulator > > [ 4.645741] adv7511 2-0039: supply pvdd not found, using dummy regulator > > [ 4.652483] adv7511 2-0039: supply a2vdd not found, using dummy regulator > > [ 4.659342] adv7511 2-0039: supply v3p3 not found, using dummy regulator > > [ 4.666086] adv7511 2-0039: supply v1p2 not found, using dummy regulator > > [ 4.681898] adv7511 2-0039: failed to find dsi host > > I just realized Rob's tree is missing the kirin patch. My apologies! > I'll retest and let you know. Ok, just retested including the kirin patch and unfortunately I'm still seeing the same thing. :( Will dig a bit and let you know when I find more. thanks -john