From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0711C8300F for ; Tue, 1 Dec 2020 19:49:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EF292151B for ; Tue, 1 Dec 2020 19:49:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="p1A2sApH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404321AbgLATti (ORCPT ); Tue, 1 Dec 2020 14:49:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389343AbgLATth (ORCPT ); Tue, 1 Dec 2020 14:49:37 -0500 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E026C061A48 for ; Tue, 1 Dec 2020 11:48:28 -0800 (PST) Received: by mail-oi1-x243.google.com with SMTP id k26so3105646oiw.0 for ; Tue, 01 Dec 2020 11:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GU/a7gBkkUxdrrdBKj5i93nXRF3uXJBiU207T9STEpA=; b=p1A2sApHdbVLzC8djhvsu1ocumSGH/RrLteefCxvWcVC9II7eb4K+dA9ylmw0GCSil IdK8sStgNrAsQSfi1KnqUFQpef6Os/deuekWk34UB20tBP3kXJIDjxV2YytOg85DFx5S SDlQgS0aW0RcuHkStBqNvfRyhs4d+mTtm7+eIIlSnkzv0nmb2jELrm/kGEd0MjEmKa4H hEilThbEtbrPls3EzqOEG+fxstBvnSbW9ko0Vuk7+Srhu6SWU14iFkZ+cdL9062wd9IO p2BQcSfAIf2prEQ61JJysRhKwGcBcjDviAe8w/Kf6cUJsOKhx/4DrHC9wwr6nIteNECS U8Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GU/a7gBkkUxdrrdBKj5i93nXRF3uXJBiU207T9STEpA=; b=Coqq6KM2iRNMOaxerD/2omRiWksFXlJNWQCcyrOcPDT0XStxEoypH+kOiac8yBnHo4 VoTxWeg+Xidw0p9o20ovQVQIwrS6ZVz0SJVbzEKFvaSutLDr+PqoI+Xyp49uDWxsQ0x6 Iq/3R+2hmkW1nsv6+yCMfdiGZY3bxnHrkbVwNKvcaFEtwf8oX/UJBfcmvCNFaSLgaTOa DZ/MKltO3vfajTh2odvxocWr01aGg+1DVFmHPuQUT3AHpyAejlxoV6zzINaRKc5myMOe V9HRQUP/jIHEjyc8UWwTbLBug5OM6fP0IMz/CenBh7FYXkaGHq3DGah7k8nLIsGWcsP7 Gwlg== X-Gm-Message-State: AOAM531qC3Kc0TvIJpsQtxr2gs+VwcK1eboVivjmvuk0Frm7p6bofcD+ 8ftEGJdHOMfuP3gB3zm8JG7KeBkkdJ18m4HpGR6KJA== X-Google-Smtp-Source: ABdhPJwuOtbu6e0mpTX2ppq4vKVkfl1OODrkYIbcJ3YSTIHDgdruXNvVWsKxJZQMNlznGdTCU8LxdeHczxzz46q0rwM= X-Received: by 2002:aca:c3d6:: with SMTP id t205mr2816644oif.10.1606852107373; Tue, 01 Dec 2020 11:48:27 -0800 (PST) MIME-Version: 1.0 References: <20201201175144.3996569-1-minchan@kernel.org> <20201201175144.3996569-5-minchan@kernel.org> In-Reply-To: <20201201175144.3996569-5-minchan@kernel.org> From: John Stultz Date: Tue, 1 Dec 2020 11:48:15 -0800 Message-ID: Subject: Re: [PATCH v2 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps To: Minchan Kim Cc: Andrew Morton , LKML , linux-mm , Hyesoo Yu , Matthew Wilcox , david@redhat.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, Suren Baghdasaryan , KyongHo Cho , John Dias , Hridya Valsaraju , Sumit Semwal , Brian Starkey , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Christian Koenig , "moderated list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 1, 2020 at 9:51 AM Minchan Kim wrote: Thanks for reworking and resending this! ... > +static int __init chunk_heap_init(void) > +{ > + struct cma *default_cma = dev_get_cma_area(NULL); > + struct dma_heap_export_info exp_info; > + struct chunk_heap *chunk_heap; > + > + if (!default_cma) > + return 0; > + > + chunk_heap = kzalloc(sizeof(*chunk_heap), GFP_KERNEL); > + if (!chunk_heap) > + return -ENOMEM; > + > + chunk_heap->order = CHUNK_HEAP_ORDER; > + chunk_heap->cma = default_cma; > + > + exp_info.name = cma_get_name(default_cma); So, this would create a chunk heap name with the default CMA name, which would be indistinguishable from the heap name used for the plain CMA heap. Probably a good idea to prefix it with "chunk-" so the heap device names are unique? thanks -john From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14310C64E7B for ; Tue, 1 Dec 2020 19:48:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 39653206F9 for ; Tue, 1 Dec 2020 19:48:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="p1A2sApH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39653206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5874D6B0036; Tue, 1 Dec 2020 14:48:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 537BD8D0002; Tue, 1 Dec 2020 14:48:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 425598D0001; Tue, 1 Dec 2020 14:48:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by kanga.kvack.org (Postfix) with ESMTP id 2B4496B0036 for ; Tue, 1 Dec 2020 14:48:29 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D7AD33637 for ; Tue, 1 Dec 2020 19:48:28 +0000 (UTC) X-FDA: 77545750296.12.corn79_3b05afa273ad Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id AF5CF1801EC47 for ; Tue, 1 Dec 2020 19:48:28 +0000 (UTC) X-HE-Tag: corn79_3b05afa273ad X-Filterd-Recvd-Size: 4270 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Dec 2020 19:48:28 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id y74so3051730oia.11 for ; Tue, 01 Dec 2020 11:48:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GU/a7gBkkUxdrrdBKj5i93nXRF3uXJBiU207T9STEpA=; b=p1A2sApHdbVLzC8djhvsu1ocumSGH/RrLteefCxvWcVC9II7eb4K+dA9ylmw0GCSil IdK8sStgNrAsQSfi1KnqUFQpef6Os/deuekWk34UB20tBP3kXJIDjxV2YytOg85DFx5S SDlQgS0aW0RcuHkStBqNvfRyhs4d+mTtm7+eIIlSnkzv0nmb2jELrm/kGEd0MjEmKa4H hEilThbEtbrPls3EzqOEG+fxstBvnSbW9ko0Vuk7+Srhu6SWU14iFkZ+cdL9062wd9IO p2BQcSfAIf2prEQ61JJysRhKwGcBcjDviAe8w/Kf6cUJsOKhx/4DrHC9wwr6nIteNECS U8Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GU/a7gBkkUxdrrdBKj5i93nXRF3uXJBiU207T9STEpA=; b=Uy5foDZxqg5YnTnkjQqORulZPVHGnrHXacSIy+e/u0h0Ifd4zSA2f9dUNOdbo9eiaC RM99/ZRIgJWxSa5f0wfV0yqWCV5vc25moVq0a7q99Vv1kvL490DN0s3mQ0Gfzn6b3Exf ru3RLQWcBHjNrA8QWLE2/tWXh3Nl3ovg2sgDtV5wptjl+j9i0JcYqfHseWcFnmAfDpzL g1HAqlkdvO9B+cb5ZboJDDPT0a3QGcvFSOoFGAS1z7OpVNJ0b4Am+DwMSIyP5/gfMA/Q +ryVIijrgwpmUnl9MSnRza7WvM4KALCcRVVnUAAIeIg2ExuIqwPjeBdm3s4blNEk+R3/ cKXA== X-Gm-Message-State: AOAM5314HqSjagdPq2/bMGS59oK/ZFY74/HyY0cYDGqvRVcy+dduHH7u uSqs4UPcWLk+yyePHlUDAmg3Ls/r9ibaIDO+pU4uhg== X-Google-Smtp-Source: ABdhPJwuOtbu6e0mpTX2ppq4vKVkfl1OODrkYIbcJ3YSTIHDgdruXNvVWsKxJZQMNlznGdTCU8LxdeHczxzz46q0rwM= X-Received: by 2002:aca:c3d6:: with SMTP id t205mr2816644oif.10.1606852107373; Tue, 01 Dec 2020 11:48:27 -0800 (PST) MIME-Version: 1.0 References: <20201201175144.3996569-1-minchan@kernel.org> <20201201175144.3996569-5-minchan@kernel.org> In-Reply-To: <20201201175144.3996569-5-minchan@kernel.org> From: John Stultz Date: Tue, 1 Dec 2020 11:48:15 -0800 Message-ID: Subject: Re: [PATCH v2 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps To: Minchan Kim Cc: Andrew Morton , LKML , linux-mm , Hyesoo Yu , Matthew Wilcox , david@redhat.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, Suren Baghdasaryan , KyongHo Cho , John Dias , Hridya Valsaraju , Sumit Semwal , Brian Starkey , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Christian Koenig , "moderated list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 1, 2020 at 9:51 AM Minchan Kim wrote: Thanks for reworking and resending this! ... > +static int __init chunk_heap_init(void) > +{ > + struct cma *default_cma = dev_get_cma_area(NULL); > + struct dma_heap_export_info exp_info; > + struct chunk_heap *chunk_heap; > + > + if (!default_cma) > + return 0; > + > + chunk_heap = kzalloc(sizeof(*chunk_heap), GFP_KERNEL); > + if (!chunk_heap) > + return -ENOMEM; > + > + chunk_heap->order = CHUNK_HEAP_ORDER; > + chunk_heap->cma = default_cma; > + > + exp_info.name = cma_get_name(default_cma); So, this would create a chunk heap name with the default CMA name, which would be indistinguishable from the heap name used for the plain CMA heap. Probably a good idea to prefix it with "chunk-" so the heap device names are unique? thanks -john