From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754363AbcG2WiO (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Jul 2016 18:38:14 -0400
Received: from mail-oi0-f51.google.com ([209.85.218.51]:34307 "EHLO
	mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754160AbcG2WiD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Jul 2016 18:38:03 -0400
MIME-Version: 1.0
In-Reply-To: <20160724073108.GD9681@localhost>
References: <1469073189-9167-1-git-send-email-john.stultz@linaro.org>
 <1469073189-9167-5-git-send-email-john.stultz@linaro.org> <20160724073108.GD9681@localhost>
From: John Stultz <john.stultz@linaro.org>
Date: Fri, 29 Jul 2016 15:38:01 -0700
Message-ID: <CALAqxLXFv90c94svtfrW56Dh+6bbVJWu6azfbR7v++Bs3OL82w@mail.gmail.com>
Subject: Re: [PATCH 4/7] k3dma: Add cyclic mode for audio
To: Vinod Koul <vinod.koul@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>, Andy Green <andy.green@linaro.org>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Jingoo Han <jg1.han@samsung.com>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Mark Brown <broonie@kernel.org>, Andy Green <andy@warmcat.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jul 24, 2016 at 12:31 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Wed, Jul 20, 2016 at 08:53:06PM -0700, John Stultz wrote:
>
>>       ds = kzalloc(sizeof(*ds) + num * sizeof(ds->desc_hw[0]), GFP_ATOMIC);
>> -     if (!ds) {
>> -             dev_dbg(chan->device->dev, "vchan %p: kzalloc fail\n", &c->vc);
>> +     if (!ds)
>
> This is an unrelated change

Ack. And Its fallen out with recent changes in 4.8-rc


>> +
>> +     ds = kzalloc(sizeof(*ds) + num * sizeof(ds->desc_hw[0]), GFP_ATOMIC);
>
> we should use GFP_NOWAIT. And looks like driver doesn't use GFP_NOWAIT< so
> you may fix that up as well

Done.

>> +     if (!ds)
>> +             return NULL;
>> +
>> +     ds->desc_hw_lli = __virt_to_phys((unsigned long)&ds->desc_hw[0]);
>
> why no dma_map_single(()?
>
> Also __api is internal APIs, driver should not use them. Why not plain
> virt_to_phys()

Right. This is reworked by one of the following patches, but I
reordered things in my tree so those fixes land before we add the
cyclic feature.

I'll resend after the merge-window is over (unless you'd like to see it sooner).

thanks
-john