From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E929EC0044C for ; Mon, 5 Nov 2018 17:49:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A95F320700 for ; Mon, 5 Nov 2018 17:49:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="VfMQlgDK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A95F320700 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387656AbeKFDK0 (ORCPT ); Mon, 5 Nov 2018 22:10:26 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:44798 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387595AbeKFDK0 (ORCPT ); Mon, 5 Nov 2018 22:10:26 -0500 Received: by mail-wr1-f66.google.com with SMTP id j17-v6so5372339wrq.11 for ; Mon, 05 Nov 2018 09:49:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=K6FhVTqVVUuW/ADxHVPs56HcvIicW0s7Z480AD0vQpg=; b=VfMQlgDK1Xqb0qf9C/ar2i16zKqVIEq2XmQ3LffLeJ1emNizQPMCEVG7k7NjQKoJuH JxU6IGSXtllqNhPr8xyLhHvRcGkpYsdGPsIa0iDCfyLqMCSOeXYTNmh0a7RSBVr2Gzgs SwjSXIBaZJDDWg/ascnYjdWcd9KLQUjy5E39c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=K6FhVTqVVUuW/ADxHVPs56HcvIicW0s7Z480AD0vQpg=; b=COuD1gYrYfd/zSNYKXxC0i6YdZh/lkpG8gn7NH0kPwvw/G02FNTFmmVK1KfPpKTOuX osTJCSMZAqbIBS1mlqyZOzrd7qRsFF4KJPMf0hoSsgOrGPewOdMiImoUygQH0IZOtkAn WOGFOFy50YAynH/Jkxn6gGeiy8WF1VliYANFjHYB2yf7JD5sV2FSvvgwDe40SA6tpcZk tqrxXOiAgOcZRaCuLOpwMsZSMeNiLOWVEKde0ffDQu65HAUaKDIrDtX30QNokaO8bog2 nZtiBkSySi/FAI9Y+KdgyXVIXZMDC6WoW5pyKQp6HPGUYHGFRt/1LvDo3AUmY9vQF0hm 7V6w== X-Gm-Message-State: AGRZ1gKSeMjA13IS+PNjHCgxMSJytszemozOgJ67ETuDURRkTq1WPdq4 aRdL/9jtN4sjGpKcErHIvgJ7LtKvVGpv7oLF7vV3qg== X-Google-Smtp-Source: AJdET5eQq0knOziaKk0pw+yGa/C8oKMmqg6Ax5/xPHPpM1zIVd/Nak3s9R+idlQJPU43C4p6GfxKNQ2T/zEqdRGhLDA= X-Received: by 2002:adf:9f0b:: with SMTP id l11-v6mr20511899wrf.206.1541440178262; Mon, 05 Nov 2018 09:49:38 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a1c:4054:0:0:0:0:0 with HTTP; Mon, 5 Nov 2018 09:49:37 -0800 (PST) In-Reply-To: <87o9b3g927.fsf@codeaurora.org> References: <1540490241-32021-1-git-send-email-john.stultz@linaro.org> <87o9b3g927.fsf@codeaurora.org> From: John Stultz Date: Mon, 5 Nov 2018 09:49:37 -0800 Message-ID: Subject: Re: [RFC][PATCH] wlcore: Fixup "Add support for optional wakeirq" To: Kalle Valo Cc: lkml , Tony Lindgren , Eyal Reizer , Anders Roxell , linux-wireless@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Nov 5, 2018 at 1:36 AM, Kalle Valo wrote: > John Stultz writes: > >> After commit 3c83dd577c7f ("wlcore: Add support for optional >> wakeirq") landed upstream, I started seeing the following oops >> on my HiKey board: >> >> [ 1.870279] Unable to handle kernel read from unreadable memory at virtual address 0000000000000010 >> [ 1.870283] Mem abort info: >> [ 1.870287] ESR = 0x96000005 >> [ 1.870292] Exception class = DABT (current EL), IL = 32 bits >> [ 1.870296] SET = 0, FnV = 0 >> [ 1.870299] EA = 0, S1PTW = 0 >> [ 1.870302] Data abort info: >> [ 1.870306] ISV = 0, ISS = 0x00000005 >> [ 1.870309] CM = 0, WnR = 0 >> [ 1.870312] [0000000000000010] user address but active_mm is swapper >> [ 1.870318] Internal error: Oops: 96000005 [#1] PREEMPT SMP >> [ 1.870327] CPU: 0 PID: 5 Comm: kworker/0:0 Not tainted 4.19.0-05129-gb3d1e8e #48 >> [ 1.870331] Hardware name: HiKey Development Board (DT) >> [ 1.870350] Workqueue: events_freezable mmc_rescan >> [ 1.870358] pstate: 60400005 (nZCv daif +PAN -UAO) >> [ 1.870366] pc : wl1271_probe+0x210/0x350 >> [ 1.870371] lr : wl1271_probe+0x210/0x350 >> [ 1.870374] sp : ffffff80080739b0 >> [ 1.870377] x29: ffffff80080739b0 x28: 0000000000000000 >> [ 1.870384] x27: 0000000000000000 x26: 0000000000000000 >> [ 1.870391] x25: 0000000000000036 x24: ffffffc074ecb598 >> [ 1.870398] x23: ffffffc07ffdce78 x22: ffffffc0744ed808 >> [ 1.870404] x21: ffffffc074ecbb98 x20: ffffff8008ff9000 >> [ 1.870411] x19: ffffffc0744ed800 x18: ffffff8008ff9a48 >> [ 1.870418] x17: 0000000000000000 x16: 0000000000000000 >> [ 1.870425] x15: ffffffc074ecb503 x14: ffffffffffffffff >> [ 1.870431] x13: ffffffc074ecb502 x12: 0000000000000030 >> [ 1.870438] x11: 0101010101010101 x10: 0000000000000040 >> [ 1.870444] x9 : ffffffc075400248 x8 : ffffffc075400270 >> [ 1.870451] x7 : 0000000000000000 x6 : 0000000000000000 >> [ 1.870457] x5 : 0000000000000000 x4 : 0000000000000000 >> [ 1.870463] x3 : 0000000000000000 x2 : 0000000000000000 >> [ 1.870469] x1 : 0000000000000028 x0 : 0000000000000000 >> [ 1.870477] Process kworker/0:0 (pid: 5, stack limit = 0x(____ptrval____)) >> [ 1.870480] Call trace: >> [ 1.870485] wl1271_probe+0x210/0x350 >> [ 1.870491] sdio_bus_probe+0x100/0x128 >> [ 1.870500] really_probe+0x1a8/0x2b8 >> [ 1.870506] driver_probe_device+0x58/0x100 >> [ 1.870511] __device_attach_driver+0x94/0xd8 >> [ 1.870517] bus_for_each_drv+0x70/0xc8 >> [ 1.870522] __device_attach+0xe0/0x140 >> [ 1.870527] device_initial_probe+0x10/0x18 >> [ 1.870532] bus_probe_device+0x94/0xa0 >> [ 1.870537] device_add+0x374/0x5b8 >> [ 1.870542] sdio_add_func+0x60/0x88 >> [ 1.870546] mmc_attach_sdio+0x1b0/0x358 >> [ 1.870551] mmc_rescan+0x2cc/0x390 >> [ 1.870558] process_one_work+0x12c/0x320 >> [ 1.870563] worker_thread+0x48/0x458 >> [ 1.870569] kthread+0xf8/0x128 >> [ 1.870575] ret_from_fork+0x10/0x18 >> [ 1.870583] Code: 92400c21 b2760021 a90687a2 97e95bf9 (f9400803) >> [ 1.870587] ---[ end trace 1e15f81d3c139ca9 ]--- >> >> It seems since we don't have a wakeirq value in the dts, the wakeirq >> value in wl1271_probe() is zero, which then causes trouble in >> irqd_get_trigger_type(irq_get_irq_data(wakeirq)). >> >> This patch tries to address this by checking if wakeirq is zero, >> and not trying to add it to the resources if that is the case. >> >> Cc: Tony Lindgren >> Cc: Kalle Valo >> Cc: Eyal Reizer >> Cc: Anders Roxell >> Cc: linux-wireless@vger.kernel.org >> Acked-by: Tony Lindgren >> Signed-off-by: John Stultz > > Any particular reason why you marked this as RFC? I'm asking because I Mostly out of habit. I do that on the first pass submissions. But yea, no objection if it were to be taken. > would like to apply this patch as is and push to 4.20. > > I'll just add: > > Fixes: 3c83dd577c7f ("wlcore: Add support for optional wakeirq") That would be great! thanks -john