From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B32FC433EF for ; Thu, 13 Jan 2022 23:27:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238219AbiAMX1C (ORCPT ); Thu, 13 Jan 2022 18:27:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238190AbiAMX1B (ORCPT ); Thu, 13 Jan 2022 18:27:01 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC66FC061574 for ; Thu, 13 Jan 2022 15:27:00 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id br17so24890128lfb.6 for ; Thu, 13 Jan 2022 15:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Br5WfYiTc37TH3IA3cWwwQvBdeV/BPdpfjqxoTbjUg8=; b=W5TpqtMMfX5D0g3MqtnYghqkOFySoHX8V7Y3CDIEk/QzE1qbCwAEJgPpiJrTJPckV+ 6N2Vqv9WJ3XylOrXOadOYeXgV1y464f5VNQVaG+8o2Glkx36tVcTGtTSSygXE9SjYxv1 RnoyaBK5nCwB6EOFL7/mwCLnckkE1s60MGfxHeQCmCJhhJZOBIv+VRduC1HOrb6bkNsL FVwFtXFQXUD8Gx/cQQ5XhZOwds/VF/zUQ0OARSiZM0Xy9Ppb3w6T0wwLrYPxiySAyUbE 20XLOCa+lmlXMZ8C2ul6MEW+k28ADcena2T1vx5h/MaIhRGddm0bLJivZ074kU2ydzvf 0q+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Br5WfYiTc37TH3IA3cWwwQvBdeV/BPdpfjqxoTbjUg8=; b=my64tfvjeQeRqYr75USgwoerzSpoiKcRItXUPbWgL0F5ixRPaVlbESmhGHaAvmzhlL LRv2ZAfsya7eG1xS5nnIaggYJB0iY8CJ3Ffc6gb8u5ET+8YuBuFieF8zsyNTW+hmDuHI tY4eqgkfZWQV9OggxgNYYQDLGlGpzyewObIakfbzW9k1Vw+CIvsIK7zKq3Ly3qWBOJ/a YosO7ut/bM8IwngQRaFmlQ4tolJb5UIwVvZZQxtccxGgYuc41qkK7l0RcqmYadHg4pfk EDLKypqW/QI01qVEaZ8Xua/D4uq8q3JZUSpva6ssSZGLxD/8e+wBw/+N/yOgIIQeeUPr udWQ== X-Gm-Message-State: AOAM5306xva1VtjSA/H6wRdf0Tf1nxAU9fy9V/+piJFLQk0jCCU0LOL2 rLPWo0zB+xBQJSYUnJ4w43SzUZFuNP48yXzb5Yy9G8yDw5U= X-Google-Smtp-Source: ABdhPJxQ6vukwqgYAso2HtDl4olPJlAPhHEDkugkY9sHGK03iZx+0X4RXJF67ZQjXjdGFfz53L/S+5nppyW0SRY2Ae4= X-Received: by 2002:a2e:9346:: with SMTP id m6mr4880056ljh.130.1642116419137; Thu, 13 Jan 2022 15:26:59 -0800 (PST) MIME-Version: 1.0 References: <20220113123406.11520-1-guangming.cao@mediatek.com> <4f88205c1b344aea8608960e2f85b8f4@intel.com> <24157767-dc29-bbdd-5428-d89ecc6b9606@amd.com> In-Reply-To: <24157767-dc29-bbdd-5428-d89ecc6b9606@amd.com> From: John Stultz Date: Thu, 13 Jan 2022 15:26:47 -0800 Message-ID: Subject: Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: "Ruhl, Michael J" , "guangming.cao@mediatek.com" , "sumit.semwal@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "wsd_upstream@mediatek.com" , "libo.kang@mediatek.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "yf.wang@mediatek.com" , "linaro-mm-sig@lists.linaro.org" , "linux-mediatek@lists.infradead.org" , "lmark@codeaurora.org" , "benjamin.gaignard@linaro.org" , "bo.song@mediatek.com" , "matthias.bgg@gmail.com" , "labbott@redhat.com" , "mingyuan.ma@mediatek.com" , "jianjiao.zeng@mediatek.com" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 13, 2022 at 5:05 AM Christian K=C3=B6nig wrote: > Am 13.01.22 um 14:00 schrieb Ruhl, Michael J: > >> -----Original Message----- > >> From: dri-devel On Behalf Of > >> Ruhl, Michael J > >>> -----Original Message----- > >>> From: dri-devel On Behalf O= f > >>> guangming.cao@mediatek.com > >>> + /* > >>> + * Invalid size check. The "len" should be less than totalram. > >>> + * > >>> + * Without this check, once the invalid size allocation runs on a= process > >>> that > >>> + * can't be killed by OOM flow(such as "gralloc" on Android devic= es), it > >>> will > >>> + * cause a kernel exception, and to make matters worse, we can't = find > >>> who are using > >>> + * so many memory with "dma_buf_debug_show" since the relevant > >>> dma-buf hasn't exported. > >>> + */ > >>> + if (len >> PAGE_SHIFT > totalram_pages()) > >> If your "heap" is from cma, is this still a valid check? > > And thinking a bit further, if I create a heap from something else (say= device memory), > > you will need to be able to figure out the maximum allowable check for = the specific > > heap. > > > > Maybe the heap needs a callback for max size? > > Well we currently maintain a separate allocator and don't use dma-heap, > but yes we have systems with 16GiB device and only 8GiB system memory so > that check here is certainly not correct. Good point. > In general I would rather let the system run into -ENOMEM or -EINVAL > from the allocator instead. Probably the simpler solution is to push the allocation check to the heap driver, rather than doing it at the top level here. For CMA or other contiguous heaps, letting the allocator fail is fast enough. For noncontiguous buffers, like the system heap, the allocation can burn a lot of time and consume a lot of memory (causing other trouble) before a large allocation might naturally fail. thanks -john From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 108C8C433F5 for ; Thu, 13 Jan 2022 23:27:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2182E10E7B7; Thu, 13 Jan 2022 23:27:02 +0000 (UTC) Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by gabe.freedesktop.org (Postfix) with ESMTPS id E009E10E7B7 for ; Thu, 13 Jan 2022 23:27:00 +0000 (UTC) Received: by mail-lf1-x12d.google.com with SMTP id p27so13222378lfa.1 for ; Thu, 13 Jan 2022 15:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Br5WfYiTc37TH3IA3cWwwQvBdeV/BPdpfjqxoTbjUg8=; b=W5TpqtMMfX5D0g3MqtnYghqkOFySoHX8V7Y3CDIEk/QzE1qbCwAEJgPpiJrTJPckV+ 6N2Vqv9WJ3XylOrXOadOYeXgV1y464f5VNQVaG+8o2Glkx36tVcTGtTSSygXE9SjYxv1 RnoyaBK5nCwB6EOFL7/mwCLnckkE1s60MGfxHeQCmCJhhJZOBIv+VRduC1HOrb6bkNsL FVwFtXFQXUD8Gx/cQQ5XhZOwds/VF/zUQ0OARSiZM0Xy9Ppb3w6T0wwLrYPxiySAyUbE 20XLOCa+lmlXMZ8C2ul6MEW+k28ADcena2T1vx5h/MaIhRGddm0bLJivZ074kU2ydzvf 0q+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Br5WfYiTc37TH3IA3cWwwQvBdeV/BPdpfjqxoTbjUg8=; b=KGH8YcKOnD0645iYEDE2l7Zzyxw8fzYfO3bL6WyJh0Q1TXiWKMFk5tXM1q3RNr+B8j RljkI2i0VwlznyXHohAPc8t5oUocaig6dC8Vmr9DIXWeMkQDjGGd8pAS/ycxj22dz/BD jR8SiUEwxCDyLj4sVzpfdPbVl/AYykv/elX0iblzb36qNaPowk5Hl53XFDpABHUBStGk ThR2qkJgcNPBX+5hNfwEqCNHW56FNuWIg/6LaOFgi0objgkZUnoav+liV7ktOm1ctIgN h7F+bnaK8DCcs6AmeJBFdeivuiIDNi92P73sC+DjrHTHwlbXcbCmWpi4M763UrftHbm1 u+yA== X-Gm-Message-State: AOAM533V/x2ZUnsBttMOssArPCnEO2NCtxahQmq/mLuOCZjZEu9MwJ8X H0NaF7ZBgZQXdj0HpdhCklbLu/Dpo35qMRjZMYoauQ== X-Google-Smtp-Source: ABdhPJxQ6vukwqgYAso2HtDl4olPJlAPhHEDkugkY9sHGK03iZx+0X4RXJF67ZQjXjdGFfz53L/S+5nppyW0SRY2Ae4= X-Received: by 2002:a2e:9346:: with SMTP id m6mr4880056ljh.130.1642116419137; Thu, 13 Jan 2022 15:26:59 -0800 (PST) MIME-Version: 1.0 References: <20220113123406.11520-1-guangming.cao@mediatek.com> <4f88205c1b344aea8608960e2f85b8f4@intel.com> <24157767-dc29-bbdd-5428-d89ecc6b9606@amd.com> In-Reply-To: <24157767-dc29-bbdd-5428-d89ecc6b9606@amd.com> From: John Stultz Date: Thu, 13 Jan 2022 15:26:47 -0800 Message-ID: Subject: Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation To: =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "labbott@redhat.com" , "guangming.cao@mediatek.com" , "wsd_upstream@mediatek.com" , "linux-kernel@vger.kernel.org" , "libo.kang@mediatek.com" , "yf.wang@mediatek.com" , "linaro-mm-sig@lists.linaro.org" , "Ruhl, Michael J" , "jianjiao.zeng@mediatek.com" , "linux-mediatek@lists.infradead.org" , "dri-devel@lists.freedesktop.org" , "benjamin.gaignard@linaro.org" , "bo.song@mediatek.com" , "matthias.bgg@gmail.com" , "mingyuan.ma@mediatek.com" , "lmark@codeaurora.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 13, 2022 at 5:05 AM Christian K=C3=B6nig wrote: > Am 13.01.22 um 14:00 schrieb Ruhl, Michael J: > >> -----Original Message----- > >> From: dri-devel On Behalf Of > >> Ruhl, Michael J > >>> -----Original Message----- > >>> From: dri-devel On Behalf O= f > >>> guangming.cao@mediatek.com > >>> + /* > >>> + * Invalid size check. The "len" should be less than totalram. > >>> + * > >>> + * Without this check, once the invalid size allocation runs on a= process > >>> that > >>> + * can't be killed by OOM flow(such as "gralloc" on Android devic= es), it > >>> will > >>> + * cause a kernel exception, and to make matters worse, we can't = find > >>> who are using > >>> + * so many memory with "dma_buf_debug_show" since the relevant > >>> dma-buf hasn't exported. > >>> + */ > >>> + if (len >> PAGE_SHIFT > totalram_pages()) > >> If your "heap" is from cma, is this still a valid check? > > And thinking a bit further, if I create a heap from something else (say= device memory), > > you will need to be able to figure out the maximum allowable check for = the specific > > heap. > > > > Maybe the heap needs a callback for max size? > > Well we currently maintain a separate allocator and don't use dma-heap, > but yes we have systems with 16GiB device and only 8GiB system memory so > that check here is certainly not correct. Good point. > In general I would rather let the system run into -ENOMEM or -EINVAL > from the allocator instead. Probably the simpler solution is to push the allocation check to the heap driver, rather than doing it at the top level here. For CMA or other contiguous heaps, letting the allocator fail is fast enough. For noncontiguous buffers, like the system heap, the allocation can burn a lot of time and consume a lot of memory (causing other trouble) before a large allocation might naturally fail. thanks -john From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92F84C433EF for ; Thu, 13 Jan 2022 23:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zCkq4DgARgD4D/2UuKFVU0tH6II0btQ+4jZxNMaU1kw=; b=nATbDBneMtktX1 eJYAl9POg6UXDaawmCwdfvkgHZK/wM6MUi4FxWmdXOahbWPsRI1cU3+DYv4tb6iXfomkmAUvDIbSq 8qdwMRv+0YmbQyOvz2I0fURST/N2qShw4KLLKDSM0wd6YovjgtchW5xVyxtU/O1IK4fh8Fvs5bBR1 ehPB9+mOIybZx320I5nIZnszw5Pe2+FacsFYGgFcFlBG7kaM6ciHM5r9Z41BbhyU72OeNAOcLuQT8 9umLddplryfVp5X29URxAnR7GuWzI3Cl8YkHbXpCDniR3lFi+pTJ9Q9qVFu7+yvTrK8Y6QOD5+RvV zKRMXfnZ+PeJdYNVnYyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n89Uy-007HU4-QF; Thu, 13 Jan 2022 23:27:16 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n89Um-007HR0-A5 for linux-mediatek@lists.infradead.org; Thu, 13 Jan 2022 23:27:05 +0000 Received: by mail-lf1-x12d.google.com with SMTP id b14so6441535lff.3 for ; Thu, 13 Jan 2022 15:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Br5WfYiTc37TH3IA3cWwwQvBdeV/BPdpfjqxoTbjUg8=; b=W5TpqtMMfX5D0g3MqtnYghqkOFySoHX8V7Y3CDIEk/QzE1qbCwAEJgPpiJrTJPckV+ 6N2Vqv9WJ3XylOrXOadOYeXgV1y464f5VNQVaG+8o2Glkx36tVcTGtTSSygXE9SjYxv1 RnoyaBK5nCwB6EOFL7/mwCLnckkE1s60MGfxHeQCmCJhhJZOBIv+VRduC1HOrb6bkNsL FVwFtXFQXUD8Gx/cQQ5XhZOwds/VF/zUQ0OARSiZM0Xy9Ppb3w6T0wwLrYPxiySAyUbE 20XLOCa+lmlXMZ8C2ul6MEW+k28ADcena2T1vx5h/MaIhRGddm0bLJivZ074kU2ydzvf 0q+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Br5WfYiTc37TH3IA3cWwwQvBdeV/BPdpfjqxoTbjUg8=; b=nka8UROv2DTUY8LdZ+nCJXxacSLSDDfwLTOWGc6mTtvIE1j5mEEtFj5GSOtIpvwNJX GtpgbRDReJ/fPiGo8xFSX/RUCuWh+dBeWlmTi0QPujbkkxmvM6E6WmbousAn6ZAwU5mf yjUAUOiXuI9Tvjv9qapm/J7Vg1tH3azpR6iLF7Q09g3M1jkvQHI3r+rARkMC4qnyv7Nf iRjew8lNLqGdo1bRywhgltXVt0qfkcRsvAWB20wfOnWEI484ZkmJGHC8zAyeFmTuZtgG 4KO7+WDeyGPv4pOQ12ScNpceUPxveN2HEGWe7z216oLPy+Wm3eeZzAe1JGFikPxr9sRj QsKA== X-Gm-Message-State: AOAM533XeVk1op+wPxjHIoSaKNbTDMg4jZ68ECSBnmwtY4Ker3cNP8Fs hRgzebK/EyS+jHvpU7wYrbQ1RN7/ABZEpCktxpVF4w== X-Google-Smtp-Source: ABdhPJxQ6vukwqgYAso2HtDl4olPJlAPhHEDkugkY9sHGK03iZx+0X4RXJF67ZQjXjdGFfz53L/S+5nppyW0SRY2Ae4= X-Received: by 2002:a2e:9346:: with SMTP id m6mr4880056ljh.130.1642116419137; Thu, 13 Jan 2022 15:26:59 -0800 (PST) MIME-Version: 1.0 References: <20220113123406.11520-1-guangming.cao@mediatek.com> <4f88205c1b344aea8608960e2f85b8f4@intel.com> <24157767-dc29-bbdd-5428-d89ecc6b9606@amd.com> In-Reply-To: <24157767-dc29-bbdd-5428-d89ecc6b9606@amd.com> From: John Stultz Date: Thu, 13 Jan 2022 15:26:47 -0800 Message-ID: Subject: Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: "Ruhl, Michael J" , "guangming.cao@mediatek.com" , "sumit.semwal@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "wsd_upstream@mediatek.com" , "libo.kang@mediatek.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "yf.wang@mediatek.com" , "linaro-mm-sig@lists.linaro.org" , "linux-mediatek@lists.infradead.org" , "lmark@codeaurora.org" , "benjamin.gaignard@linaro.org" , "bo.song@mediatek.com" , "matthias.bgg@gmail.com" , "labbott@redhat.com" , "mingyuan.ma@mediatek.com" , "jianjiao.zeng@mediatek.com" , "linux-media@vger.kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_152704_384542_EB975BC8 X-CRM114-Status: GOOD ( 19.39 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKYW4gMTMsIDIwMjIgYXQgNTowNSBBTSBDaHJpc3RpYW4gS8O2bmlnCjxjaHJpc3Rp YW4ua29lbmlnQGFtZC5jb20+IHdyb3RlOgo+IEFtIDEzLjAxLjIyIHVtIDE0OjAwIHNjaHJpZWIg UnVobCwgTWljaGFlbCBKOgo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPj4gRnJv bTogZHJpLWRldmVsIDxkcmktZGV2ZWwtYm91bmNlc0BsaXN0cy5mcmVlZGVza3RvcC5vcmc+IE9u IEJlaGFsZiBPZgo+ID4+IFJ1aGwsIE1pY2hhZWwgSgo+ID4+PiAtLS0tLU9yaWdpbmFsIE1lc3Nh Z2UtLS0tLQo+ID4+PiBGcm9tOiBkcmktZGV2ZWwgPGRyaS1kZXZlbC1ib3VuY2VzQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZz4gT24gQmVoYWxmIE9mCj4gPj4+IGd1YW5nbWluZy5jYW9AbWVkaWF0ZWsu Y29tCj4gPj4+ICsgICAvKgo+ID4+PiArICAgICogSW52YWxpZCBzaXplIGNoZWNrLiBUaGUgImxl biIgc2hvdWxkIGJlIGxlc3MgdGhhbiB0b3RhbHJhbS4KPiA+Pj4gKyAgICAqCj4gPj4+ICsgICAg KiBXaXRob3V0IHRoaXMgY2hlY2ssIG9uY2UgdGhlIGludmFsaWQgc2l6ZSBhbGxvY2F0aW9uIHJ1 bnMgb24gYSBwcm9jZXNzCj4gPj4+IHRoYXQKPiA+Pj4gKyAgICAqIGNhbid0IGJlIGtpbGxlZCBi eSBPT00gZmxvdyhzdWNoIGFzICJncmFsbG9jIiBvbiBBbmRyb2lkIGRldmljZXMpLCBpdAo+ID4+ PiB3aWxsCj4gPj4+ICsgICAgKiBjYXVzZSBhIGtlcm5lbCBleGNlcHRpb24sIGFuZCB0byBtYWtl IG1hdHRlcnMgd29yc2UsIHdlIGNhbid0IGZpbmQKPiA+Pj4gd2hvIGFyZSB1c2luZwo+ID4+PiAr ICAgICogc28gbWFueSBtZW1vcnkgd2l0aCAiZG1hX2J1Zl9kZWJ1Z19zaG93IiBzaW5jZSB0aGUg cmVsZXZhbnQKPiA+Pj4gZG1hLWJ1ZiBoYXNuJ3QgZXhwb3J0ZWQuCj4gPj4+ICsgICAgKi8KPiA+ Pj4gKyAgIGlmIChsZW4gPj4gUEFHRV9TSElGVCA+IHRvdGFscmFtX3BhZ2VzKCkpCj4gPj4gSWYg eW91ciAiaGVhcCIgaXMgZnJvbSBjbWEsIGlzIHRoaXMgc3RpbGwgYSB2YWxpZCBjaGVjaz8KPiA+ IEFuZCB0aGlua2luZyBhIGJpdCBmdXJ0aGVyLCBpZiBJIGNyZWF0ZSBhIGhlYXAgZnJvbSBzb21l dGhpbmcgZWxzZSAoc2F5IGRldmljZSBtZW1vcnkpLAo+ID4geW91IHdpbGwgbmVlZCB0byBiZSBh YmxlIHRvIGZpZ3VyZSBvdXQgdGhlIG1heGltdW0gYWxsb3dhYmxlIGNoZWNrIGZvciB0aGUgc3Bl Y2lmaWMKPiA+IGhlYXAuCj4gPgo+ID4gTWF5YmUgdGhlIGhlYXAgbmVlZHMgYSBjYWxsYmFjayBm b3IgbWF4IHNpemU/Cj4KPiBXZWxsIHdlIGN1cnJlbnRseSBtYWludGFpbiBhIHNlcGFyYXRlIGFs bG9jYXRvciBhbmQgZG9uJ3QgdXNlIGRtYS1oZWFwLAo+IGJ1dCB5ZXMgd2UgaGF2ZSBzeXN0ZW1z IHdpdGggMTZHaUIgZGV2aWNlIGFuZCBvbmx5IDhHaUIgc3lzdGVtIG1lbW9yeSBzbwo+IHRoYXQg Y2hlY2sgaGVyZSBpcyBjZXJ0YWlubHkgbm90IGNvcnJlY3QuCgpHb29kIHBvaW50LgoKPiBJbiBn ZW5lcmFsIEkgd291bGQgcmF0aGVyIGxldCB0aGUgc3lzdGVtIHJ1biBpbnRvIC1FTk9NRU0gb3Ig LUVJTlZBTAo+IGZyb20gdGhlIGFsbG9jYXRvciBpbnN0ZWFkLgoKUHJvYmFibHkgdGhlIHNpbXBs ZXIgc29sdXRpb24gaXMgdG8gcHVzaCB0aGUgYWxsb2NhdGlvbiBjaGVjayB0byB0aGUKaGVhcCBk cml2ZXIsIHJhdGhlciB0aGFuIGRvaW5nIGl0IGF0IHRoZSB0b3AgbGV2ZWwgaGVyZS4KCkZvciBD TUEgb3Igb3RoZXIgY29udGlndW91cyBoZWFwcywgbGV0dGluZyB0aGUgYWxsb2NhdG9yIGZhaWwg aXMgZmFzdAplbm91Z2guIEZvciBub25jb250aWd1b3VzIGJ1ZmZlcnMsIGxpa2UgdGhlIHN5c3Rl bSBoZWFwLCB0aGUKYWxsb2NhdGlvbiBjYW4gYnVybiBhIGxvdCBvZiB0aW1lIGFuZCBjb25zdW1l IGEgbG90IG9mIG1lbW9yeSAoY2F1c2luZwpvdGhlciB0cm91YmxlKSBiZWZvcmUgYSBsYXJnZSBh bGxvY2F0aW9uIG1pZ2h0IG5hdHVyYWxseSBmYWlsLgoKdGhhbmtzCi1qb2huCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1tZWRpYXRlayBtYWls aW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 017DCC433EF for ; Thu, 13 Jan 2022 23:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DSE/eLOCFVZ7WnCfJPaoM8w+FMxUgIjPWOupF6d2rxU=; b=0I5zN3MVH3s3Dm yHtCOowpTbcFWwLVGHwEr12RkYpZ/YxIlNGuufe+hzQ9uRqXJF5TV5e7U9ASOJvZH2iSpajtsmHCX SzILCFJJBZFTyPtxAz0PnZ8LfNbfq8GUbMGgFMCGzO7tt7h6a3445nLSpBoqkyOjUfeIdbTq6chRp DS6VbiY9NzrMAG6Kk5B/RjmEHh5xbW+qL84rV0IvAmeN18Ev+vieuhTSiUQ+mxAtuYln1GW6bpnQw oIwVJ3OBs30ohcfFn8LZRBsI8L75HbNJk2cr1XaBvc9L7ybF0alr7EGZv34TH3RpTfmbpfQ2lTyU8 S47dh3FtZtYvytm2c9Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n89Up-007HSZ-Rx; Thu, 13 Jan 2022 23:27:08 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n89Um-007HR1-9s for linux-arm-kernel@lists.infradead.org; Thu, 13 Jan 2022 23:27:05 +0000 Received: by mail-lf1-x136.google.com with SMTP id x22so24808313lfd.10 for ; Thu, 13 Jan 2022 15:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Br5WfYiTc37TH3IA3cWwwQvBdeV/BPdpfjqxoTbjUg8=; b=W5TpqtMMfX5D0g3MqtnYghqkOFySoHX8V7Y3CDIEk/QzE1qbCwAEJgPpiJrTJPckV+ 6N2Vqv9WJ3XylOrXOadOYeXgV1y464f5VNQVaG+8o2Glkx36tVcTGtTSSygXE9SjYxv1 RnoyaBK5nCwB6EOFL7/mwCLnckkE1s60MGfxHeQCmCJhhJZOBIv+VRduC1HOrb6bkNsL FVwFtXFQXUD8Gx/cQQ5XhZOwds/VF/zUQ0OARSiZM0Xy9Ppb3w6T0wwLrYPxiySAyUbE 20XLOCa+lmlXMZ8C2ul6MEW+k28ADcena2T1vx5h/MaIhRGddm0bLJivZ074kU2ydzvf 0q+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Br5WfYiTc37TH3IA3cWwwQvBdeV/BPdpfjqxoTbjUg8=; b=E1VoXjWDguOCBRJKDDJs2iAeok/RYNEcV561D48r49WERayJHXgZl68kLkbXJlP5OH b5msuN+o2qx0T2e3Lq6fFQQUIkzREfOmqCa8RTBbNxHkoxfilZ2LlK6mg+jciITQjR4H NSpsJvhQqV1zvUlEdmcr35qixBJasJRWfW4XO3FoXaFAzffXb0gqAB0BSA7sHgYvmA4S rXCY1IM95EIBovnVkqOm7kXKgsUTfuYAT0XchAV1ce+yMuuWBxvv6A7bDmUx3ztmEOm4 fXai6HDeC430bosPQpWZDZ+zjzvrCi2daA83mfhqlcb4p/KmWE+DV/WkVORWTCCVcx18 8zlg== X-Gm-Message-State: AOAM530IRymgjVZkpeZMyDJjczIpkidwRrP124xASTTfGne9ExuG9q6K Kj/rAErA0B1fSeCl4WfSR8A3soBc5TnWgxSpzbVvgQ== X-Google-Smtp-Source: ABdhPJxQ6vukwqgYAso2HtDl4olPJlAPhHEDkugkY9sHGK03iZx+0X4RXJF67ZQjXjdGFfz53L/S+5nppyW0SRY2Ae4= X-Received: by 2002:a2e:9346:: with SMTP id m6mr4880056ljh.130.1642116419137; Thu, 13 Jan 2022 15:26:59 -0800 (PST) MIME-Version: 1.0 References: <20220113123406.11520-1-guangming.cao@mediatek.com> <4f88205c1b344aea8608960e2f85b8f4@intel.com> <24157767-dc29-bbdd-5428-d89ecc6b9606@amd.com> In-Reply-To: <24157767-dc29-bbdd-5428-d89ecc6b9606@amd.com> From: John Stultz Date: Thu, 13 Jan 2022 15:26:47 -0800 Message-ID: Subject: Re: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: "Ruhl, Michael J" , "guangming.cao@mediatek.com" , "sumit.semwal@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "wsd_upstream@mediatek.com" , "libo.kang@mediatek.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "yf.wang@mediatek.com" , "linaro-mm-sig@lists.linaro.org" , "linux-mediatek@lists.infradead.org" , "lmark@codeaurora.org" , "benjamin.gaignard@linaro.org" , "bo.song@mediatek.com" , "matthias.bgg@gmail.com" , "labbott@redhat.com" , "mingyuan.ma@mediatek.com" , "jianjiao.zeng@mediatek.com" , "linux-media@vger.kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_152704_384612_14FEADC6 X-CRM114-Status: GOOD ( 20.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKYW4gMTMsIDIwMjIgYXQgNTowNSBBTSBDaHJpc3RpYW4gS8O2bmlnCjxjaHJpc3Rp YW4ua29lbmlnQGFtZC5jb20+IHdyb3RlOgo+IEFtIDEzLjAxLjIyIHVtIDE0OjAwIHNjaHJpZWIg UnVobCwgTWljaGFlbCBKOgo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPj4gRnJv bTogZHJpLWRldmVsIDxkcmktZGV2ZWwtYm91bmNlc0BsaXN0cy5mcmVlZGVza3RvcC5vcmc+IE9u IEJlaGFsZiBPZgo+ID4+IFJ1aGwsIE1pY2hhZWwgSgo+ID4+PiAtLS0tLU9yaWdpbmFsIE1lc3Nh Z2UtLS0tLQo+ID4+PiBGcm9tOiBkcmktZGV2ZWwgPGRyaS1kZXZlbC1ib3VuY2VzQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZz4gT24gQmVoYWxmIE9mCj4gPj4+IGd1YW5nbWluZy5jYW9AbWVkaWF0ZWsu Y29tCj4gPj4+ICsgICAvKgo+ID4+PiArICAgICogSW52YWxpZCBzaXplIGNoZWNrLiBUaGUgImxl biIgc2hvdWxkIGJlIGxlc3MgdGhhbiB0b3RhbHJhbS4KPiA+Pj4gKyAgICAqCj4gPj4+ICsgICAg KiBXaXRob3V0IHRoaXMgY2hlY2ssIG9uY2UgdGhlIGludmFsaWQgc2l6ZSBhbGxvY2F0aW9uIHJ1 bnMgb24gYSBwcm9jZXNzCj4gPj4+IHRoYXQKPiA+Pj4gKyAgICAqIGNhbid0IGJlIGtpbGxlZCBi eSBPT00gZmxvdyhzdWNoIGFzICJncmFsbG9jIiBvbiBBbmRyb2lkIGRldmljZXMpLCBpdAo+ID4+ PiB3aWxsCj4gPj4+ICsgICAgKiBjYXVzZSBhIGtlcm5lbCBleGNlcHRpb24sIGFuZCB0byBtYWtl IG1hdHRlcnMgd29yc2UsIHdlIGNhbid0IGZpbmQKPiA+Pj4gd2hvIGFyZSB1c2luZwo+ID4+PiAr ICAgICogc28gbWFueSBtZW1vcnkgd2l0aCAiZG1hX2J1Zl9kZWJ1Z19zaG93IiBzaW5jZSB0aGUg cmVsZXZhbnQKPiA+Pj4gZG1hLWJ1ZiBoYXNuJ3QgZXhwb3J0ZWQuCj4gPj4+ICsgICAgKi8KPiA+ Pj4gKyAgIGlmIChsZW4gPj4gUEFHRV9TSElGVCA+IHRvdGFscmFtX3BhZ2VzKCkpCj4gPj4gSWYg eW91ciAiaGVhcCIgaXMgZnJvbSBjbWEsIGlzIHRoaXMgc3RpbGwgYSB2YWxpZCBjaGVjaz8KPiA+ IEFuZCB0aGlua2luZyBhIGJpdCBmdXJ0aGVyLCBpZiBJIGNyZWF0ZSBhIGhlYXAgZnJvbSBzb21l dGhpbmcgZWxzZSAoc2F5IGRldmljZSBtZW1vcnkpLAo+ID4geW91IHdpbGwgbmVlZCB0byBiZSBh YmxlIHRvIGZpZ3VyZSBvdXQgdGhlIG1heGltdW0gYWxsb3dhYmxlIGNoZWNrIGZvciB0aGUgc3Bl Y2lmaWMKPiA+IGhlYXAuCj4gPgo+ID4gTWF5YmUgdGhlIGhlYXAgbmVlZHMgYSBjYWxsYmFjayBm b3IgbWF4IHNpemU/Cj4KPiBXZWxsIHdlIGN1cnJlbnRseSBtYWludGFpbiBhIHNlcGFyYXRlIGFs bG9jYXRvciBhbmQgZG9uJ3QgdXNlIGRtYS1oZWFwLAo+IGJ1dCB5ZXMgd2UgaGF2ZSBzeXN0ZW1z IHdpdGggMTZHaUIgZGV2aWNlIGFuZCBvbmx5IDhHaUIgc3lzdGVtIG1lbW9yeSBzbwo+IHRoYXQg Y2hlY2sgaGVyZSBpcyBjZXJ0YWlubHkgbm90IGNvcnJlY3QuCgpHb29kIHBvaW50LgoKPiBJbiBn ZW5lcmFsIEkgd291bGQgcmF0aGVyIGxldCB0aGUgc3lzdGVtIHJ1biBpbnRvIC1FTk9NRU0gb3Ig LUVJTlZBTAo+IGZyb20gdGhlIGFsbG9jYXRvciBpbnN0ZWFkLgoKUHJvYmFibHkgdGhlIHNpbXBs ZXIgc29sdXRpb24gaXMgdG8gcHVzaCB0aGUgYWxsb2NhdGlvbiBjaGVjayB0byB0aGUKaGVhcCBk cml2ZXIsIHJhdGhlciB0aGFuIGRvaW5nIGl0IGF0IHRoZSB0b3AgbGV2ZWwgaGVyZS4KCkZvciBD TUEgb3Igb3RoZXIgY29udGlndW91cyBoZWFwcywgbGV0dGluZyB0aGUgYWxsb2NhdG9yIGZhaWwg aXMgZmFzdAplbm91Z2guIEZvciBub25jb250aWd1b3VzIGJ1ZmZlcnMsIGxpa2UgdGhlIHN5c3Rl bSBoZWFwLCB0aGUKYWxsb2NhdGlvbiBjYW4gYnVybiBhIGxvdCBvZiB0aW1lIGFuZCBjb25zdW1l IGEgbG90IG9mIG1lbW9yeSAoY2F1c2luZwpvdGhlciB0cm91YmxlKSBiZWZvcmUgYSBsYXJnZSBh bGxvY2F0aW9uIG1pZ2h0IG5hdHVyYWxseSBmYWlsLgoKdGhhbmtzCi1qb2huCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==