From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D93BC433F5 for ; Thu, 30 Sep 2021 02:31:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D622613CD for ; Thu, 30 Sep 2021 02:31:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347822AbhI3Ccl (ORCPT ); Wed, 29 Sep 2021 22:32:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347684AbhI3Cck (ORCPT ); Wed, 29 Sep 2021 22:32:40 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 776A3C06176A for ; Wed, 29 Sep 2021 19:30:58 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id y26so18857587lfa.11 for ; Wed, 29 Sep 2021 19:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iQnUr5SY7f8OGO57S3EM4uCQ4piA9YupnmmYWxxVKyY=; b=LjS98cvidJEmDORic59MjQfO2hbiTgxfTPD9/2/BLF9ce//XnLIiWgiIkzSXr/gD2G y5tyf0KeEAoS49e4mYQdczDnBT/f/TJt3SBEcGDu/v6oInWf4J0R3Pzkdp4Zb5mTDBox FhQ1S4a8GrGLYeQg3WevOUEvv1xjquhZ8Oxl9NkWXS2zCJGbooU3psEId6fvcuChc6QX snU5E32PuJ8ewpYQoF4iRr3f0AIodLMCW/1RVwEEXXAjTVMeZ7bsg+LxDsWzfqHkVXyG KRffm+ELFqgSNXDqcF6/R2J0XIvvrxXGr1MkGPHdj1+fZQZesnPo12Y9vbyuZKN7xTYd kmcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iQnUr5SY7f8OGO57S3EM4uCQ4piA9YupnmmYWxxVKyY=; b=m7KzaWD8c2D3eNmxw3tbsec9TsCuKAgJWy1OegNYyfW8fkG3GG9EBkOtmXF5eGnzi0 j6RtA9fuHtUY4mQmt6qV4dThSYLrkX0V7jn4+BAKWx7X8YdBI0BiDbKPs94LKCQ/+hNH o0MPFb8Vm9o+XgOI0gDKcwdMYJC0O9ECzSHp70IbntMKWCRTo3F+AD+ckt6kIqKGpu5U L3/Cscqg2BYDeLL/KEqzpTUops2fc2IDBxx87pCEoqXziyncA0GqZ9rHddIAjpbJnjBC sEq/SUV55k9sK3LZy20wA6t47Pn10nuverUrBAb4cNrshkOn7YU6dE4xSfSr5r5nREu8 0Unw== X-Gm-Message-State: AOAM530Ee8ihxKgXDmSDfsoGQqrDHOpOdiLGFqUrNCRsVvJW1M2A3Qqo +jbhZgugsS/br/aVc5lKsod6Czatt5Uqq+LQuBW+0w== X-Google-Smtp-Source: ABdhPJyTibsWlvwWrbIC7Ms+JKl21H1RF1ZZfVQil46L2bTnFKehzHlQGf3CLV72YRs7O3rCPip69Gu8jOrXs4PLVSM= X-Received: by 2002:a2e:87c4:: with SMTP id v4mr3339415ljj.61.1632969056722; Wed, 29 Sep 2021 19:30:56 -0700 (PDT) MIME-Version: 1.0 References: <20210910101218.1632297-1-maxime@cerno.tech> In-Reply-To: From: John Stultz Date: Wed, 29 Sep 2021 19:30:44 -0700 Message-ID: Subject: Re: [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent To: Rob Clark Cc: Maxime Ripard , Andrzej Hajda , Sam Ravnborg , Daniel Vetter , David Airlie , Jonas Karlman , Laurent Pinchart , Thierry Reding , Maarten Lankhorst , Thomas Zimmermann , Neil Armstrong , Robert Foss , Jernej Skrabec , Sean Paul , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Kyungmin Park , lkml , Xinliang Liu , Seung-Woo Kim , Tian Tao , Inki Dae , Linux Samsung SOC , linux-arm-msm , dri-devel , Chen Feng , Xinwei Kong , Joonyoung Shim Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Sep 29, 2021 at 4:20 PM Rob Clark wrote: > On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: > > > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > > > > The best practice to avoid those issues is to register its functions only after > > > > > all its dependencies are live. We also shouldn't wait any longer than we should > > > > > to play nice with the other components that are waiting for us, so in our case > > > > > that would mean moving the DSI device registration to the bridge probe. > > > > > > > > > > I also had a look at all the DSI hosts, and it seems that exynos, kirin and msm > > > > > would be affected by this and wouldn't probe anymore after those changes. > > > > > Exynos and kirin seems to be simple enough for a mechanical change (that still > > > > > requires to be tested), but the changes in msm seemed to be far more important > > > > > and I wasn't confortable doing them. > > > > > > > > > > > > Hey Maxime, > > > > Sorry for taking so long to get to this, but now that plumbers is > > > > over I've had a chance to check it out on kirin > > > > > > > > Rob Clark pointed me to his branch with some fixups here: > > > > https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework > > > > > > > > But trying to boot hikey with that, I see the following loop indefinitely: > > > > [ 4.632132] adv7511 2-0039: supply avdd not found, using dummy regulator > > > > [ 4.638961] adv7511 2-0039: supply dvdd not found, using dummy regulator > > > > [ 4.645741] adv7511 2-0039: supply pvdd not found, using dummy regulator > > > > [ 4.652483] adv7511 2-0039: supply a2vdd not found, using dummy regulator > > > > [ 4.659342] adv7511 2-0039: supply v3p3 not found, using dummy regulator > > > > [ 4.666086] adv7511 2-0039: supply v1p2 not found, using dummy regulator > > > > [ 4.681898] adv7511 2-0039: failed to find dsi host > > > > > > I just realized Rob's tree is missing the kirin patch. My apologies! > > > I'll retest and let you know. > > > > Ok, just retested including the kirin patch and unfortunately I'm > > still seeing the same thing. :( > > > > Will dig a bit and let you know when I find more. > > Did you have a chance to test it on anything using drm/msm with DSI > panels? That would at least confirm that I didn't miss anything in > the drm/msm patch to swap the dsi-host vs bridge ordering.. Not a dsi panel, but for what it's worth, I did just test the series with the db845c w/ HDMI using the lt9611 bridge. So at least that is looking ok. thanks -john From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A46C433F5 for ; Thu, 30 Sep 2021 02:31:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 332AE6187D for ; Thu, 30 Sep 2021 02:31:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 332AE6187D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 09BDF6EB39; Thu, 30 Sep 2021 02:31:04 +0000 (UTC) Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by gabe.freedesktop.org (Postfix) with ESMTPS id A45CC6EB39 for ; Thu, 30 Sep 2021 02:30:58 +0000 (UTC) Received: by mail-lf1-x12a.google.com with SMTP id x27so18756405lfa.9 for ; Wed, 29 Sep 2021 19:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iQnUr5SY7f8OGO57S3EM4uCQ4piA9YupnmmYWxxVKyY=; b=LjS98cvidJEmDORic59MjQfO2hbiTgxfTPD9/2/BLF9ce//XnLIiWgiIkzSXr/gD2G y5tyf0KeEAoS49e4mYQdczDnBT/f/TJt3SBEcGDu/v6oInWf4J0R3Pzkdp4Zb5mTDBox FhQ1S4a8GrGLYeQg3WevOUEvv1xjquhZ8Oxl9NkWXS2zCJGbooU3psEId6fvcuChc6QX snU5E32PuJ8ewpYQoF4iRr3f0AIodLMCW/1RVwEEXXAjTVMeZ7bsg+LxDsWzfqHkVXyG KRffm+ELFqgSNXDqcF6/R2J0XIvvrxXGr1MkGPHdj1+fZQZesnPo12Y9vbyuZKN7xTYd kmcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iQnUr5SY7f8OGO57S3EM4uCQ4piA9YupnmmYWxxVKyY=; b=MdEb2fLvK5rdZ0wnBNfzQKMPj30hLgrsiEIP9MRrIQOBHYo0GGJUzcssqpUqBzTWbw neo8zm05k/qlHnqG1tsmHQ3aWmXjzFCSyBXNCl9u4lfbEDl+MWxXJUk16vxadSatERVB SzXpygm7ebbBVCHS7Xpfm+mCcE0eDfB/n/J0OBw8bMGYCDJ5+0pOL860tY4Xq/LIejTV iw+skE4RyYqHmEgDd4iS9QEb9xqlcpEvEzh7beHiF5BZpL3WRqlbA/V37OS0mOWcxK4/ Sjcpa93vMitMzRlDG39kQTTt/ygXzP5oyngp5PCjM7NfQz6t2/4oZlJpfZo3ehLTLBM1 t58g== X-Gm-Message-State: AOAM532O6zVL0fUg7gAgvS8DTGNdv97NNMIpYe03CnWt5homzm0nELs0 8SnQ5TQlCyj0+4ZZstZY+Eg5rK4+INE7RTrP4DLKAA== X-Google-Smtp-Source: ABdhPJyTibsWlvwWrbIC7Ms+JKl21H1RF1ZZfVQil46L2bTnFKehzHlQGf3CLV72YRs7O3rCPip69Gu8jOrXs4PLVSM= X-Received: by 2002:a2e:87c4:: with SMTP id v4mr3339415ljj.61.1632969056722; Wed, 29 Sep 2021 19:30:56 -0700 (PDT) MIME-Version: 1.0 References: <20210910101218.1632297-1-maxime@cerno.tech> In-Reply-To: From: John Stultz Date: Wed, 29 Sep 2021 19:30:44 -0700 Message-ID: Subject: Re: [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent To: Rob Clark Cc: Maxime Ripard , Andrzej Hajda , Sam Ravnborg , Daniel Vetter , David Airlie , Jonas Karlman , Laurent Pinchart , Thierry Reding , Maarten Lankhorst , Thomas Zimmermann , Neil Armstrong , Robert Foss , Jernej Skrabec , Sean Paul , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Kyungmin Park , lkml , Xinliang Liu , Seung-Woo Kim , Tian Tao , Inki Dae , Linux Samsung SOC , linux-arm-msm , dri-devel , Chen Feng , Xinwei Kong , Joonyoung Shim Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Sep 29, 2021 at 4:20 PM Rob Clark wrote: > On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: > > > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > > > > The best practice to avoid those issues is to register its functions only after > > > > > all its dependencies are live. We also shouldn't wait any longer than we should > > > > > to play nice with the other components that are waiting for us, so in our case > > > > > that would mean moving the DSI device registration to the bridge probe. > > > > > > > > > > I also had a look at all the DSI hosts, and it seems that exynos, kirin and msm > > > > > would be affected by this and wouldn't probe anymore after those changes. > > > > > Exynos and kirin seems to be simple enough for a mechanical change (that still > > > > > requires to be tested), but the changes in msm seemed to be far more important > > > > > and I wasn't confortable doing them. > > > > > > > > > > > > Hey Maxime, > > > > Sorry for taking so long to get to this, but now that plumbers is > > > > over I've had a chance to check it out on kirin > > > > > > > > Rob Clark pointed me to his branch with some fixups here: > > > > https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework > > > > > > > > But trying to boot hikey with that, I see the following loop indefinitely: > > > > [ 4.632132] adv7511 2-0039: supply avdd not found, using dummy regulator > > > > [ 4.638961] adv7511 2-0039: supply dvdd not found, using dummy regulator > > > > [ 4.645741] adv7511 2-0039: supply pvdd not found, using dummy regulator > > > > [ 4.652483] adv7511 2-0039: supply a2vdd not found, using dummy regulator > > > > [ 4.659342] adv7511 2-0039: supply v3p3 not found, using dummy regulator > > > > [ 4.666086] adv7511 2-0039: supply v1p2 not found, using dummy regulator > > > > [ 4.681898] adv7511 2-0039: failed to find dsi host > > > > > > I just realized Rob's tree is missing the kirin patch. My apologies! > > > I'll retest and let you know. > > > > Ok, just retested including the kirin patch and unfortunately I'm > > still seeing the same thing. :( > > > > Will dig a bit and let you know when I find more. > > Did you have a chance to test it on anything using drm/msm with DSI > panels? That would at least confirm that I didn't miss anything in > the drm/msm patch to swap the dsi-host vs bridge ordering.. Not a dsi panel, but for what it's worth, I did just test the series with the db845c w/ HDMI using the lt9611 bridge. So at least that is looking ok. thanks -john